131528 2014-04-10 22:04:28 -0700 [Mac] Prevent crash when exiting fullscreen mode 2014-04-11 09:52:15 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham benjamin bfulgham jer.noble oldest_to_newest 999782 0 bfulgham 2014-04-10 22:04:28 -0700 It is possible to cause a crash in WebKit if you enter full screen mode, exit full screen mode, and close the main view quickly enough. The crash is due to an animation thread attempting to interact with a deallocated window. When we decide to rapidly terminate a window, we need to tell any existing animation controllers to stop animating, and clear their window references. 999784 1 229107 bfulgham 2014-04-10 22:06:58 -0700 Created attachment 229107 Patch 999785 2 bfulgham 2014-04-10 22:07:20 -0700 <rdar://problem/13967272> 999800 3 229107 jer.noble 2014-04-10 22:44:52 -0700 Comment on attachment 229107 Patch Nice! r=me. 999894 4 229138 bfulgham 2014-04-11 09:13:51 -0700 Created attachment 229138 I think this resolves the 'real' problem 999896 5 bfulgham 2014-04-11 09:15:58 -0700 It was bothering me that we were entering the WKFullScreenWindowController::close method with _fullScreenState != ExitingFullScreen, but _scaleAnimation still non-nil and running an animation. I think the actual fix need to be done 'finishedExitFullScreenAnimation', where we clean up the _fadeAnimation, but don't touch the _scaleAnimation. I still like the initial fix to protect us against leaving a running animation when the window is going away, but I think the 'real' fix is this second patch. 999897 6 229138 bfulgham 2014-04-11 09:16:58 -0700 Comment on attachment 229138 I think this resolves the 'real' problem Updated patch that makes sure we never are in a state where '_fullScreenState != ExitingFullScreen' while we have a running animation. 999909 7 229138 jer.noble 2014-04-11 09:51:27 -0700 Comment on attachment 229138 I think this resolves the 'real' problem re-r=me. 999910 8 bfulgham 2014-04-11 09:52:15 -0700 Committed r167130: <http://trac.webkit.org/changeset/167130> 229107 2014-04-10 22:06:58 -0700 2014-04-11 09:13:49 -0700 Patch bug-131528-20140410220637.patch text/plain 1433 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzExMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTEwICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFByZXZlbnQgY3Jh c2ggd2hlbiBleGl0aW5nIGZ1bGxzY3JlZW4gbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRv d0NvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIg Y2xvc2VdKTogSWYgd2UgYXJlIGRvaW5nIGFuIGltbWVkaWF0ZQorICAgICAgICBjbG9zZSBvZiB0 aGUgdmlldywgd2UgbmVlZCB0byBzdG9wIGFuaW1hdGlvbnMgc28gd2UgYXZvaWQgYW55CisgICAg ICAgIGZpbmFsIHRpbWVyIGV2ZW50cyBmcm9tIGludGVyYWN0aW5nIHdpdGggaW52YWxpZCB3aW5k b3cgaGFuZGxlcy4KKwogMjAxNC0wNC0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFw cGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IHRoZSBkZWJ1ZyBib3RzIGFmdGVyIHIxNjcx MDIKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93 Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFj L1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE2NzEwMSkKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5t bQkod29ya2luZyBjb3B5KQpAQCAtNDQyLDYgKzQ0MiwxMSBAQCAtICh2b2lkKWNsb3NlCiAgICAg aWYgKF9mdWxsU2NyZWVuU3RhdGUgPT0gRXhpdGluZ0Z1bGxTY3JlZW4pCiAgICAgICAgIFtzZWxm IGZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246WUVTXTsKIAorICAgIFtfc2NhbGVBbmlt YXRpb24gc3RvcEFuaW1hdGlvbl07CisgICAgW19zY2FsZUFuaW1hdGlvbiBzZXRXaW5kb3c6bmls XTsKKyAgICBbX2ZhZGVBbmltYXRpb24gc3RvcEFuaW1hdGlvbl07CisgICAgW19mYWRlQW5pbWF0 aW9uIHNldFdpbmRvdzpuaWxdOworCiAgICAgX3dlYlZpZXcgPSBuaWw7CiAKICAgICBbc3VwZXIg Y2xvc2VdOwo= 229138 2014-04-11 09:13:51 -0700 2014-04-11 09:51:27 -0700 I think this resolves the 'real' problem bug-131528-20140411091330.patch text/plain 1967 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzEyOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTExICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFByZXZlbnQgY3Jh c2ggd2hlbiBleGl0aW5nIGZ1bGxzY3JlZW4gbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRv d0NvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIg ZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjpdKToKKyAgICAgICAgQ2xlYW4gdXAgdGhl IF9zY2FsZUFuaW1hdGlvbiBjb250cm9sbGVyLCBub3QganVzdCB0aGUgX2ZhZGVBbmltYXRpb24g Y29udHJvbGxlci4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBjbG9z ZV0pOiBJZiB3ZSBhcmUgZG9pbmcgYW4gaW1tZWRpYXRlCisgICAgICAgIGNsb3NlIG9mIHRoZSB2 aWV3LCB3ZSBuZWVkIHRvIHN0b3AgYW5pbWF0aW9ucyBzbyB3ZSBhdm9pZCBhbnkKKyAgICAgICAg ZmluYWwgdGltZXIgZXZlbnRzIGZyb20gaW50ZXJhY3Rpbmcgd2l0aCBpbnZhbGlkIHdpbmRvdyBo YW5kbGVzLgorCiAyMDE0LTA0LTExICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KIAogICAgICAgICB3azItZ3RrIGRvZXMgbm90IGRpc3BsYXkgYW55dGhpbmcKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJv bGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVs bFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0JKHJldmlzaW9uIDE2NzEwMSkKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQkod29y a2luZyBjb3B5KQpAQCAtMzg5LDYgKzM4OSwxMCBAQCAtICh2b2lkKWZpbmlzaGVkRXhpdEZ1bGxT Y3JlZW5BbmltYXRpb246CiAgICAgW1tzZWxmIHdpbmRvd10gb3JkZXJPdXQ6c2VsZl07CiAgICAg W1tzZWxmIHdpbmRvd10gc2V0RnJhbWU6TlNaZXJvUmVjdCBkaXNwbGF5OllFU107CiAKKyAgICBb X3NjYWxlQW5pbWF0aW9uIHN0b3BBbmltYXRpb25dOworICAgIFtfc2NhbGVBbmltYXRpb24gc2V0 V2luZG93Om5pbF07CisgICAgX3NjYWxlQW5pbWF0aW9uID0gbnVsbHB0cjsKKwogICAgIFtfZmFk ZUFuaW1hdGlvbiBzdG9wQW5pbWF0aW9uXTsKICAgICBbX2ZhZGVBbmltYXRpb24gc2V0V2luZG93 Om5pbF07CiAgICAgX2ZhZGVBbmltYXRpb24gPSBudWxscHRyOwpAQCAtNDQyLDYgKzQ0NiwxMSBA QCAtICh2b2lkKWNsb3NlCiAgICAgaWYgKF9mdWxsU2NyZWVuU3RhdGUgPT0gRXhpdGluZ0Z1bGxT Y3JlZW4pCiAgICAgICAgIFtzZWxmIGZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246WUVT XTsKIAorICAgIFtfc2NhbGVBbmltYXRpb24gc3RvcEFuaW1hdGlvbl07CisgICAgW19zY2FsZUFu aW1hdGlvbiBzZXRXaW5kb3c6bmlsXTsKKyAgICBbX2ZhZGVBbmltYXRpb24gc3RvcEFuaW1hdGlv bl07CisgICAgW19mYWRlQW5pbWF0aW9uIHNldFdpbmRvdzpuaWxdOworCiAgICAgX3dlYlZpZXcg PSBuaWw7CiAKICAgICBbc3VwZXIgY2xvc2VdOwo=