131524 2014-04-10 19:44:15 -0700 [WK2] Dispatch to main thread's run loop to handle cookie requests. 2014-04-13 12:47:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 131595 1 jer.noble jer.noble beidson oldest_to_newest 999754 0 jer.noble 2014-04-10 19:44:15 -0700 [WK2] Dispatch to a global concurrent queue to handle cookie requests. 999770 1 229102 jer.noble 2014-04-10 20:50:37 -0700 Created attachment 229102 Patch 999949 2 beidson 2014-04-11 11:34:53 -0700 Concerned about thread safety issues. Discussed with Jer (in person) some potential solutions. 999995 3 229156 jer.noble 2014-04-11 13:16:43 -0700 Created attachment 229156 Patch 1000040 4 229156 beidson 2014-04-11 14:43:59 -0700 Comment on attachment 229156 Patch <3 it 1000062 5 229156 ggaren 2014-04-11 15:30:27 -0700 Comment on attachment 229156 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229156&action=review > Source/WebKit2/ChangeLog:3 > + [WK2] Dispatch to a global concurrent queue to handle cookie requests. Title needs some updatin'. 1000067 6 jer.noble 2014-04-11 15:37:03 -0700 Committed r167164: <http://trac.webkit.org/changeset/167164> 229102 2014-04-10 20:50:37 -0700 2014-04-11 13:16:40 -0700 Patch bug-131524-20140410205016.patch text/plain 1836 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzRiMmFkYzE3MDBjMTE0 OTFlZDY3N2M0Y2FmYTYzMDFkNjgzYWE5OC4uZDYwZGI1NGM5ZTlhMjkyMDRlMWM5NWU5ZmI2NzU5 NzJjNTA5Y2YyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE0LTA0LTEwICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtXSzJdIERpc3BhdGNoIHRv IGEgZ2xvYmFsIGNvbmN1cnJlbnQgcXVldWUgdG8gaGFuZGxlIGNvb2tpZSByZXF1ZXN0cy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTUyNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdXNpbmcg c3luY2hyb25vdXMgbmV0d29yayBBUElzIGZyb20gdGhlIG1haW4gdGhyZWFkIChlLmcuLCAtW05T SW1hZ2UKKyAgICAgICAgaW5pdFdpdGhDb250ZW50c09mVVJMOl0pIG91ciBjb29raWUgc2hpbSB3 b3VsZCBhdHRlbXB0IHRvIGRpc3BhdGhfYXN5bmMKKyAgICAgICAgdG8gdGhlIG1haW4gdGhyZWFk IHRvIGhhbmRsZSB0aGUgY29va2llIHJlcXVlc3QsIGFuZCBibG9jayBhZ2FpbnN0IHRoZSBvcmln aW5hbAorICAgICAgICByZXF1ZXN0LiBJbnN0ZWFkLCBkaXNwYXRjaCB0byBhIGdsb2JhbCBjb25j dXJyZW50IHF1ZXVlLCBhdm9pZGluZyB0aGUgZGVhZGxvY2suCisKKyAgICAgICAgKiBTaGFyZWQv bWFjL0Nvb2tpZVN0b3JhZ2VTaGltLm1tOgorICAgICAgICAoLVtXS05TVVJMU2Vzc2lvbkxvY2Fs IF9nZXRDb29raWVIZWFkZXJzRm9yVGFzazpjb21wbGV0aW9uSGFuZGxlcjpdKToKKworMjAxNC0w NC0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKwogICAgICAgICBbaU9TXVtX SzJdIFZpZGVvcyBzaG91bGQgYW5pbWF0ZSBpbnRvIGFuZCBvdXQgb2YgZnVsbHNjcmVlbi4KICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTQ5NwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL0Nvb2tpZVN0b3JhZ2VTaGltLm1t IGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9Db29raWVTdG9yYWdlU2hpbS5tbQppbmRleCA0 NDE0NTM5NTYwMjhjNjg2YzMxYzg3YzYwOWI0ZWQxMzFiNTQ0NzIxLi41MDhiN2E0ZWE5ZWM1NTYw MmM3ZDU0ZmUyNmZkMjRkZTNlN2U3NjZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvbWFjL0Nvb2tpZVN0b3JhZ2VTaGltLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9t YWMvQ29va2llU3RvcmFnZVNoaW0ubW0KQEAgLTEyMCw3ICsxMjAsNyBAQCB2b2lkIENvb2tpZVN0 b3JhZ2VTaGltOjppbml0aWFsaXplKCkKICAgICBpZiAoIWNvbXBsZXRpb25IYW5kbGVyKQogICAg ICAgICByZXR1cm47CiAKLSAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1 ZSgpLCBeeworICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9nbG9iYWxfcXVldWUoRElT UEFUQ0hfUVVFVUVfUFJJT1JJVFlfREVGQVVMVCwgMCksIF57CiAgICAgICAgIGNvbXBsZXRpb25I YW5kbGVyKFdlYktpdDo6d2ViS2l0Q29va2llU3RvcmFnZUNvcHlSZXF1ZXN0SGVhZGVyRmllbGRz Rm9yVVJMKG51bGxwdHIsIChDRlVSTFJlZilbW3Rhc2sgY3VycmVudFJlcXVlc3RdIFVSTF0pKTsK ICAgICB9KTsKIH0K 229156 2014-04-11 13:16:43 -0700 2014-04-11 15:30:27 -0700 Patch bug-131524-20140411131625.patch text/plain 2309 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzRiMmFkYzE3MDBjMTE0 OTFlZDY3N2M0Y2FmYTYzMDFkNjgzYWE5OC4uMzE2MjBkMGYxNWRhNDcxMGQxMmM0Zjk1NzI0ODBk YjZkMDUzYmFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTA0LTEwICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtXSzJdIERpc3BhdGNoIHRv IGEgZ2xvYmFsIGNvbmN1cnJlbnQgcXVldWUgdG8gaGFuZGxlIGNvb2tpZSByZXF1ZXN0cy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTUyNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdXNpbmcg c3luY2hyb25vdXMgbmV0d29yayBBUElzIGZyb20gdGhlIG1haW4gdGhyZWFkIChlLmcuLCAtW05T SW1hZ2UKKyAgICAgICAgaW5pdFdpdGhDb250ZW50c09mVVJMOl0pIG91ciBjb29raWUgc2hpbSB3 b3VsZCBhdHRlbXB0IHRvIGRpc3BhdGhfYXN5bmMKKyAgICAgICAgdG8gdGhlIG1haW4gdGhyZWFk IHRvIGhhbmRsZSB0aGUgY29va2llIHJlcXVlc3QsIGFuZCBibG9jayBhZ2FpbnN0IHRoZSBvcmln aW5hbAorICAgICAgICByZXF1ZXN0LiBDRk5ldHdvcmsgaXMgc3RpbGwgc2VydmljaW5nIHRoZSBy dW4gbG9vcCBob3dldmVyLCBzbyByYXRoZXIgdGhhbgorICAgICAgICBkaXNwYXRjaF9hc3luYyB0 byB0aGUgbWFpbiBxdWV1ZSwgdXNlIHRoZSBSdW5Mb29wIHRvIGRpc3BhdGNoIHRvIHRoZSBtYWlu IHRocmVhZC4KKworICAgICAgICAqIFNoYXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW06Cisg ICAgICAgICgtW1dLTlNVUkxTZXNzaW9uTG9jYWwgX2dldENvb2tpZUhlYWRlcnNGb3JUYXNrOmNv bXBsZXRpb25IYW5kbGVyOl0pOgorCisyMDE0LTA0LTEwICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgorCiAgICAgICAgIFtpT1NdW1dLMl0gVmlkZW9zIHNob3VsZCBhbmltYXRlIGlu dG8gYW5kIG91dCBvZiBmdWxsc2NyZWVuLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNDk3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFj L0Nvb2tpZVN0b3JhZ2VTaGltLm1tCmluZGV4IDQ0MTQ1Mzk1NjAyOGM2ODZjMzFjODdjNjA5YjRl ZDEzMWI1NDQ3MjEuLmJiNmFmYTk0Zjk2MzM1MDJmODdmNzJjMWUzM2I1MGYzN2FjNTEzMWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvQ29va2llU3RvcmFnZVNoaW0ubW0K KysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9Db29raWVTdG9yYWdlU2hpbS5tbQpAQCAt MzksNiArMzksNyBAQAogI2luY2x1ZGUgPGRsZmNuLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJl YWQuaD4KICNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CisjaW5jbHVkZSA8d3RmL1J1bkxvb3Au aD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAogdHlwZWRlZiBjb25zdCBzdHJ1 Y3QgX0NGVVJMUmVxdWVzdCogQ0ZVUkxSZXF1ZXN0UmVmOwpAQCAtMTIwLDggKzEyMSw5IEBAIHZv aWQgQ29va2llU3RvcmFnZVNoaW06OmluaXRpYWxpemUoKQogICAgIGlmICghY29tcGxldGlvbkhh bmRsZXIpCiAgICAgICAgIHJldHVybjsKIAotICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dl dF9tYWluX3F1ZXVlKCksIF57Ci0gICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFdlYktpdDo6d2Vi S2l0Q29va2llU3RvcmFnZUNvcHlSZXF1ZXN0SGVhZGVyRmllbGRzRm9yVVJMKG51bGxwdHIsIChD RlVSTFJlZilbW3Rhc2sgY3VycmVudFJlcXVlc3RdIFVSTF0pKTsKKyAgICBSZXRhaW5QdHI8TlNV UkxTZXNzaW9uVGFzaz4gc3Ryb25nVGFzayA9IHRhc2s7CisgICAgUnVuTG9vcDo6bWFpbigpLmRp c3BhdGNoKFtzdHJvbmdUYXNrLCBjb21wbGV0aW9uSGFuZGxlcl17CisgICAgICAgIGNvbXBsZXRp b25IYW5kbGVyKFdlYktpdDo6d2ViS2l0Q29va2llU3RvcmFnZUNvcHlSZXF1ZXN0SGVhZGVyRmll bGRzRm9yVVJMKG51bGxwdHIsIChDRlVSTFJlZilbW3N0cm9uZ1Rhc2sgY3VycmVudFJlcXVlc3Rd IFVSTF0pKTsKICAgICB9KTsKIH0KICNlbmRpZgo=