131520 2014-04-10 17:56:54 -0700 Add user default for FTL JIT 2014-05-01 13:59:23 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 1 barraclough barraclough fpizlo oldest_to_newest 999727 0 barraclough 2014-04-10 17:56:54 -0700 . 999728 1 229095 barraclough 2014-04-10 17:59:27 -0700 Created attachment 229095 Fix 999735 2 229095 benjamin 2014-04-10 18:10:10 -0700 Comment on attachment 229095 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=229095&action=review Could you remove the environment variable thingy? Did you perf test this?? > Source/WebKit2/Shared/WebProcessCreationParameters.h:141 > + Extra whitespace here! > Source/WebKit2/UIProcess/mac/WebContextMac.mm:101 > + ditto. > Source/WebKit2/UIProcess/mac/WebContextMac.mm:171 > + ditto. 999737 3 barraclough 2014-04-10 18:16:17 -0700 Transmitting file data ..... Committed revision 167102. D'oh, forgot review comments. :-( 999738 4 barraclough 2014-04-10 18:18:21 -0700 whitespace fixed in. Transmitting file data ... Committed revision 167103. 1005834 5 fpizlo 2014-05-01 13:49:28 -0700 This just cost me a day of debugging. If JSC decides to turn off the FTL JIT, then it shouldn't be possible for WK2 to turn it on. I don't think that flipping JSC's Options directly is an appropriate way to do this. I will roll it out with MarkH's rubber stamp. 1005837 6 fpizlo 2014-05-01 13:59:23 -0700 Rolled out in r168120. We need to find a way of doing this that still allows JSC to disable the FTL JIT regardless of external settings. 229095 2014-04-10 17:59:27 -0700 2014-04-10 18:10:09 -0700 Fix 131520.1.patch text/plain 5825 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzEwMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA0LTEwICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgdXNlciBk ZWZhdWx0IGZvciBGVEwgSklUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzE1MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNoYXJlZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6V2ViUHJvY2Vzc0Ny ZWF0aW9uUGFyYW1ldGVycyk6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NDcmVhdGlvblBh cmFtZXRlcnM6OmVuY29kZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NDcmVhdGlvblBh cmFtZXRlcnM6OmRlY29kZSk6CisgICAgICAgICogU2hhcmVkL1dlYlByb2Nlc3NDcmVhdGlvblBh cmFtZXRlcnMuaDoKKyAgICAgICAgICAgIC0gcGFzcyBzZXR0aW5nIHRvIFdlYkNvbnRlbnQgcHJv Y2Vzcy4KKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNYWMubW06CisgICAgICAg IChXZWJLaXQ6OnJlZ2lzdGVyVXNlckRlZmF1bHRzSWZOZWVkZWQpOgorICAgICAgICAoV2ViS2l0 OjpXZWJDb250ZXh0OjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKToKKyAgICAgICAgICAg IC0gcmVhZCB1c2VyIGRlZmF1bHQuCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9j ZXNzQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlh bGl6ZVdlYlByb2Nlc3MpOgorICAgICAgICAgICAgLSBzZXQgSlNDOjpPcHRpb24uCisKIDIwMTQt MDQtMTAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2Fd IE5vdGlmeSB0aGUgZm9ybSBkZWxlZ2F0ZSB3aGVuIHRoZSBjdXN0b20gYnV0dG9uIGluIHRoZSBm b3JtIGFjY2Vzc29yeSB2aWV3IGlzIHRhcHBlZApJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVk L1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcAkocmV2aXNpb24g MTY3MDg4KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByb2Nlc3NDcmVhdGlvblBhcmFt ZXRlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw3IEBAIFdlYlByb2Nlc3NDcmVh dGlvblBhcmFtZXRlcnM6OldlYlByb2Nlc3MKICAgICAsIHNob3VsZEZvcmNlU2NyZWVuRm9udFN1 YnN0aXR1dGlvbihmYWxzZSkKICAgICAsIHNob3VsZEVuYWJsZUtlcm5pbmdBbmRMaWdhdHVyZXNC eURlZmF1bHQoZmFsc2UpCiAgICAgLCBzaG91bGRFbmFibGVKSVQoZmFsc2UpCisgICAgLCBzaG91 bGRFbmFibGVGVExKSVQoZmFsc2UpCiAjZW5kaWYKICNpZiBFTkFCTEUoTkVUV09SS19QUk9DRVNT KQogICAgICwgdXNlc05ldHdvcmtQcm9jZXNzKGZhbHNlKQpAQCAtMTExLDYgKzExMiw3IEBAIHZv aWQgV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6ZW5jb2QKICAgICBlbmNvZGVyIDw8IHNo b3VsZEZvcmNlU2NyZWVuRm9udFN1YnN0aXR1dGlvbjsKICAgICBlbmNvZGVyIDw8IHNob3VsZEVu YWJsZUtlcm5pbmdBbmRMaWdhdHVyZXNCeURlZmF1bHQ7CiAgICAgZW5jb2RlciA8PCBzaG91bGRF bmFibGVKSVQ7CisgICAgZW5jb2RlciA8PCBzaG91bGRFbmFibGVGVExKSVQ7CiAgICAgZW5jb2Rl ciA8PCAhIWJ1bmRsZVBhcmFtZXRlckRhdGE7CiAgICAgaWYgKGJ1bmRsZVBhcmFtZXRlckRhdGEp CiAgICAgICAgIGVuY29kZXIgPDwgYnVuZGxlUGFyYW1ldGVyRGF0YS0+ZGF0YVJlZmVyZW5jZSgp OwpAQCAtMjM5LDcgKzI0MSw5IEBAIGJvb2wgV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6 ZGVjb2QKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICghZGVjb2Rlci5kZWNvZGUocGFy YW1ldGVycy5zaG91bGRFbmFibGVKSVQpKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0KKyAgICBp ZiAoIWRlY29kZXIuZGVjb2RlKHBhcmFtZXRlcnMuc2hvdWxkRW5hYmxlRlRMSklUKSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgIAogICAgIGJvb2wgaGFzQnVuZGxlUGFyYW1ldGVyRGF0YTsK ICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGhhc0J1bmRsZVBhcmFtZXRlckRhdGEpKQogICAgICAg ICByZXR1cm4gZmFsc2U7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJvY2Vzc0Ny ZWF0aW9uUGFyYW1ldGVycy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9X ZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgJKHJldmlzaW9uIDE2NzA4OCkKKysrIFNvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgJKHdvcmtpbmcg Y29weSkKQEAgLTEzNyw3ICsxMzcsOCBAQCBzdHJ1Y3QgV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1l dGVycyB7CiAgICAgYm9vbCBzaG91bGRGb3JjZVNjcmVlbkZvbnRTdWJzdGl0dXRpb247CiAgICAg Ym9vbCBzaG91bGRFbmFibGVLZXJuaW5nQW5kTGlnYXR1cmVzQnlEZWZhdWx0OwogICAgIGJvb2wg c2hvdWxkRW5hYmxlSklUOwotCisgICAgYm9vbCBzaG91bGRFbmFibGVGVExKSVQ7CisgICAgCiAg ICAgUmVmUHRyPEFQSTo6RGF0YT4gYnVuZGxlUGFyYW1ldGVyRGF0YTsKIAogI2VuZGlmIC8vIFBM QVRGT1JNKENPQ09BKQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250 ZXh0TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2Vi Q29udGV4dE1hYy5tbQkocmV2aXNpb24gMTY3MDg4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL21hYy9XZWJDb250ZXh0TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02OCw2ICs2OCw3IEBA IE5TU3RyaW5nICpXZWJLaXRMb2NhbENhY2hlRGVmYXVsdHNLZXkgPSAKIE5TU3RyaW5nICpXZWJT dG9yYWdlRGlyZWN0b3J5RGVmYXVsdHNLZXkgPSBAIldlYktpdExvY2FsU3RvcmFnZURhdGFiYXNl UGF0aFByZWZlcmVuY2VLZXkiOwogTlNTdHJpbmcgKldlYktpdEtlcm5pbmdBbmRMaWdhdHVyZXNF bmFibGVkQnlEZWZhdWx0RGVmYXVsdHNLZXkgPSBAIldlYktpdEtlcm5pbmdBbmRMaWdhdHVyZXNF bmFibGVkQnlEZWZhdWx0IjsKIE5TU3RyaW5nICpXZWJLaXRKU0NKSVRFbmFibGVkRGVmYXVsdHNL ZXkgPSBAIldlYktpdEpTQ0pJVEVuYWJsZWREZWZhdWx0c0tleSI7CitOU1N0cmluZyAqV2ViS2l0 SlNDRlRMSklURW5hYmxlZERlZmF1bHRzS2V5ID0gQCJXZWJLaXRKU0NGVExKSVRFbmFibGVkRGVm YXVsdHNLZXkiOwogCiAjaWYgIVBMQVRGT1JNKElPUykKIHN0YXRpYyBOU1N0cmluZyAqV2ViS2l0 QXBwbGljYXRpb25EaWRDaGFuZ2VBY2Nlc3NpYmlsaXR5RW5oYW5jZWRVc2VySW50ZXJmYWNlTm90 aWZpY2F0aW9uID0gQCJOU0FwcGxpY2F0aW9uRGlkQ2hhbmdlQWNjZXNzaWJpbGl0eUVuaGFuY2Vk VXNlckludGVyZmFjZU5vdGlmaWNhdGlvbiI7CkBAIC05Niw3ICs5Nyw4IEBAIHN0YXRpYyB2b2lk IHJlZ2lzdGVyVXNlckRlZmF1bHRzSWZOZWVkZWQKICAgICBOU011dGFibGVEaWN0aW9uYXJ5ICpy ZWdpc3RyYXRpb25EaWN0aW9uYXJ5ID0gW05TTXV0YWJsZURpY3Rpb25hcnkgZGljdGlvbmFyeV07 CiAgICAgCiAgICAgW3JlZ2lzdHJhdGlvbkRpY3Rpb25hcnkgc2V0T2JqZWN0OltOU051bWJlciBu dW1iZXJXaXRoQm9vbDpZRVNdIGZvcktleTpXZWJLaXRKU0NKSVRFbmFibGVkRGVmYXVsdHNLZXld OwotCisgICAgW3JlZ2lzdHJhdGlvbkRpY3Rpb25hcnkgc2V0T2JqZWN0OltOU051bWJlciBudW1i ZXJXaXRoQm9vbDpZRVNdIGZvcktleTpXZWJLaXRKU0NGVExKSVRFbmFibGVkRGVmYXVsdHNLZXld OworICAgIAogI2lmIFBMQVRGT1JNKElPUykgfHwgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMDkwCiAgICAgW3JlZ2lzdHJhdGlvbkRpY3Rpb25hcnkgc2V0T2JqZWN0OltOU051 bWJlciBudW1iZXJXaXRoQm9vbDpZRVNdIGZvcktleTpXZWJLaXRLZXJuaW5nQW5kTGlnYXR1cmVz RW5hYmxlZEJ5RGVmYXVsdERlZmF1bHRzS2V5XTsKICNlbmRpZgpAQCAtMTY1LDcgKzE2Nyw4IEBA IHZvaWQgV2ViQ29udGV4dDo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHIKICNlbmRpZgogICAgIHBh cmFtZXRlcnMuc2hvdWxkRW5hYmxlS2VybmluZ0FuZExpZ2F0dXJlc0J5RGVmYXVsdCA9IFtbTlNV c2VyRGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIGJvb2xGb3JLZXk6V2ViS2l0S2Vybmlu Z0FuZExpZ2F0dXJlc0VuYWJsZWRCeURlZmF1bHREZWZhdWx0c0tleV07CiAgICAgcGFyYW1ldGVy cy5zaG91bGRFbmFibGVKSVQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRz XSBib29sRm9yS2V5OldlYktpdEpTQ0pJVEVuYWJsZWREZWZhdWx0c0tleV07Ci0KKyAgICBwYXJh bWV0ZXJzLnNob3VsZEVuYWJsZUZUTEpJVCA9IFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2Vy RGVmYXVsdHNdIGJvb2xGb3JLZXk6V2ViS2l0SlNDRlRMSklURW5hYmxlZERlZmF1bHRzS2V5XTsK KyAgICAKICNpZiBIQVZFKEhPU1RFRF9DT1JFX0FOSU1BVElPTikKICNpZiAhUExBVEZPUk0oSU9T KQogICAgIG1hY2hfcG9ydF90IHJlbmRlclNlcnZlclBvcnQgPSBbW0NBUmVtb3RlTGF5ZXJTZXJ2 ZXIgc2hhcmVkU2VydmVyXSBzZXJ2ZXJQb3J0XTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCShyZXZpc2lvbiAxNjcwODgp CisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQko d29ya2luZyBjb3B5KQpAQCAtMTg1LDYgKzE4NSw5IEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZv cm1Jbml0aWFsaXplV2ViUHIKICAgICBpZiAoIUpTQzo6T3B0aW9uczo6dXNlSklUV2FzT3ZlcnJp ZGRlbigpKQogICAgICAgICBKU0M6Ok9wdGlvbnM6OnVzZUpJVCgpID0gcGFyYW1ldGVycy5zaG91 bGRFbmFibGVKSVQ7CiAKKyAgICBpZiAoIUpTQzo6T3B0aW9uczo6dXNlRlRMSklUV2FzT3ZlcnJp ZGRlbigpKQorICAgICAgICBKU0M6Ok9wdGlvbnM6OnVzZUZUTEpJVCgpID0gcGFyYW1ldGVycy5z aG91bGRFbmFibGVGVExKSVQ7CisKICAgICBzZXRFbmhhbmNlZEFjY2Vzc2liaWxpdHkocGFyYW1l dGVycy5hY2Nlc3NpYmlsaXR5RW5oYW5jZWRVc2VySW50ZXJmYWNlRW5hYmxlZCk7CiAKICNpZiBV U0UoQVBQS0lUKQo=