131514 2014-04-10 16:36:47 -0700 [Win] Clean up some 64-bit Warnings from Visual Studio Static Analyzer 2014-04-10 18:02:47 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham benjamin bfulgham cmarcelo commit-queue webkit-bug-importer oldest_to_newest 999686 0 bfulgham 2014-04-10 16:36:47 -0700 This patch makes a couple of changes needed for 64-bit support on Windows: 1. Set our Microsoft build settings against Vista for 64-bit. 2. Silence a warning about MEMORY_BASIC_INFORMATION being uninitialized. 3. Silence a warning about deprecated GetTickCount() use 999687 1 229089 bfulgham 2014-04-10 16:38:57 -0700 Created attachment 229089 Patch 999692 2 229089 commit-queue 2014-04-10 16:56:34 -0700 Comment on attachment 229089 Patch Rejecting attachment 229089 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 229089, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WTF/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5120716332597248 999699 3 webkit-bug-importer 2014-04-10 16:59:39 -0700 <rdar://problem/16585906> 999731 4 bfulgham 2014-04-10 18:02:47 -0700 Committed r167101: <http://trac.webkit.org/changeset/167101> 229089 2014-04-10 16:38:57 -0700 2014-04-10 16:56:34 -0700 Patch bug-131514-20140410163836.patch text/plain 4256 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjcwOTYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDE0LTA0LTEwICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIENsZWFuIHVwIHNvbWUgNjQtYml0IHdh cm5pbmdzIGZyb20gVmlzdWFsIFN0dWRpbyBhbmFseXplcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXVEYudmN4cHJvai9XVEYudmN4cHJvajogVXNl IGNvcnJlY3QgcGxhdGZvcm0gc2V0dGluZ3MgZm9yCisgICAgICAgIDY0LWJpdCBidWlsZC4KKyAg ICAgICAgKiBjb25maWcuaDogRGl0dG8uCisgICAgICAgICogd3RmL0N1cnJlbnRUaW1lLmNwcDoK KyAgICAgICAgKFdURjo6aGlnaFJlc1VwVGltZSk6IFJlc29sdmUgd2FybmluZyBhYm91dCBkZXBy ZWNhdGVkIEFQSS4KKyAgICAgICAgKiB3dGYvU3RhY2tCb3VuZHMuY3BwOgorICAgICAgICAoV1RG OjpTdGFja0JvdW5kczo6aW5pdGlhbGl6ZSk6IFNpbGVuY2Ugd2FybmluZyBhYm91dAorICAgICAg ICBhbiB1bmluaXRpYWxpemVkIHZhcmlhYmxlLgorCisyMDE0LTA0LTEwICBCcmVudCBGdWxnaGFt ICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlv biAoT09QUyEpLgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXVEYudmN4cHJvai9XVEYu dmN4cHJvajoKKyAgICAgICAgKiBjb25maWcuaDoKKyAgICAgICAgKiB3dGYvQ3VycmVudFRpbWUu Y3BwOgorICAgICAgICAoV1RGOjpoaWdoUmVzVXBUaW1lKToKKyAgICAgICAgKiB3dGYvU3RhY2tC b3VuZHMuY3BwOgorICAgICAgICAoV1RGOjpTdGFja0JvdW5kczo6aW5pdGlhbGl6ZSk6CisKIDIw MTQtMDQtMDkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBS b2xsZWQgYmFjayBpbiByMTY2OTcyLgpJbmRleDogU291cmNlL1dURi9jb25maWcuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV1RGL2NvbmZpZy5oCShyZXZpc2lvbiAxNjcwOTUpCisrKyBTb3VyY2Uv V1RGL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxMiArMjksMjAgQEAKICNpZiBPUyhX SU5ET1dTKQogCiAjaWZuZGVmIF9XSU4zMl9XSU5OVAorI2lmIGRlZmluZWQoX01fWDY0KSB8fCBk ZWZpbmVkKF9feDg2XzY0X18pIAorI2RlZmluZSBfV0lOMzJfV0lOTlQgMHg2MDAKKyNlbHNlCiAj ZGVmaW5lIF9XSU4zMl9XSU5OVCAweDA1MDIKICNlbmRpZgorI2VuZGlmCiAKICNpZm5kZWYgV0lO VkVSCisjaWYgZGVmaW5lZChfTV9YNjQpIHx8IGRlZmluZWQoX194ODZfNjRfXykgCisjZGVmaW5l IFdJTlZFUiAweDA2MDAKKyNlbHNlCiAjZGVmaW5lIFdJTlZFUiAweDA1MDIKICNlbmRpZgorI2Vu ZGlmCiAKICNpZiAhQ09NUElMRVIoTVNWQzdfT1JfTE9XRVIpICYmICFPUyhXSU5DRSkKIC8vIFdl IG5lZWQgdG8gZGVmaW5lIHRoaXMgYmVmb3JlIHRoZSBmaXJzdCAjaW5jbHVkZSBvZiBzdGRsaWIu aCBvciBpdCB3b24ndCBjb250YWluIHJhbmRfcy4KSW5kZXg6IFNvdXJjZS9XVEYvV1RGLnZjeHBy b2ovV1RGLnZjeHByb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi9XVEYudmN4cHJvai9XVEYu dmN4cHJvagkocmV2aXNpb24gMTY3MDk1KQorKysgU291cmNlL1dURi9XVEYudmN4cHJvai9XVEYu dmN4cHJvagkod29ya2luZyBjb3B5KQpAQCAtNDc5LDcgKzQ3OSw2IEBACiAgICAgICA8L0Jyb3dz ZUluZm9ybWF0aW9uRmlsZT4KICAgICAgIDxTdHJpbmdQb29saW5nPgogICAgICAgPC9TdHJpbmdQ b29saW5nPgotICAgICAgPFByZXByb2Nlc3NvckRlZmluaXRpb25zPldJTjMyO19MSUI7JShQcmVw cm9jZXNzb3JEZWZpbml0aW9ucyk8L1ByZXByb2Nlc3NvckRlZmluaXRpb25zPgogICAgIDwvQ2xD b21waWxlPgogICAgIDxMaW5rPgogICAgICAgPFN1YlN5c3RlbT5XaW5kb3dzPC9TdWJTeXN0ZW0+ CkBAIC01MTgsNyArNTE3LDYgQEAKICAgICAgIDwvQnJvd3NlSW5mb3JtYXRpb25GaWxlPgogICAg ICAgPFN0cmluZ1Bvb2xpbmc+CiAgICAgICA8L1N0cmluZ1Bvb2xpbmc+Ci0gICAgICA8UHJlcHJv Y2Vzc29yRGVmaW5pdGlvbnM+V0lOMzI7X0xJQjslKFByZXByb2Nlc3NvckRlZmluaXRpb25zKTwv UHJlcHJvY2Vzc29yRGVmaW5pdGlvbnM+CiAgICAgPC9DbENvbXBpbGU+CiAgICAgPExpbms+CiAg ICAgICA8U3ViU3lzdGVtPldpbmRvd3M8L1N1YlN5c3RlbT4KQEAgLTYzNSw3ICs2MzMsNiBAQAog ICAgICAgPC9Ccm93c2VJbmZvcm1hdGlvbkZpbGU+CiAgICAgICA8U3RyaW5nUG9vbGluZz4KICAg ICAgIDwvU3RyaW5nUG9vbGluZz4KLSAgICAgIDxQcmVwcm9jZXNzb3JEZWZpbml0aW9ucz5XSU4z MjtfTElCOyUoUHJlcHJvY2Vzc29yRGVmaW5pdGlvbnMpPC9QcmVwcm9jZXNzb3JEZWZpbml0aW9u cz4KICAgICA8L0NsQ29tcGlsZT4KICAgICA8TGluaz4KICAgICAgIDxTdWJTeXN0ZW0+V2luZG93 czwvU3ViU3lzdGVtPgpAQCAtNjcyLDcgKzY2OSw2IEBACiAgICAgICA8L0Jyb3dzZUluZm9ybWF0 aW9uRmlsZT4KICAgICAgIDxTdHJpbmdQb29saW5nPgogICAgICAgPC9TdHJpbmdQb29saW5nPgot ICAgICAgPFByZXByb2Nlc3NvckRlZmluaXRpb25zPldJTjMyO19MSUI7JShQcmVwcm9jZXNzb3JE ZWZpbml0aW9ucyk8L1ByZXByb2Nlc3NvckRlZmluaXRpb25zPgogICAgIDwvQ2xDb21waWxlPgog ICAgIDxMaW5rPgogICAgICAgPFN1YlN5c3RlbT5XaW5kb3dzPC9TdWJTeXN0ZW0+CkluZGV4OiBT b3VyY2UvV1RGL3d0Zi9DdXJyZW50VGltZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93 dGYvQ3VycmVudFRpbWUuY3BwCShyZXZpc2lvbiAxNjcwOTUpCisrKyBTb3VyY2UvV1RGL3d0Zi9D dXJyZW50VGltZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNiw3ICsxMDYsMTEgQEAgc3RhdGlj IGRvdWJsZSBoaWdoUmVzVXBUaW1lKCkKIAogICAgIExBUkdFX0lOVEVHRVIgcXBjOwogICAgIFF1 ZXJ5UGVyZm9ybWFuY2VDb3VudGVyKCZxcGMpOworI2lmIGRlZmluZWQoX01fSVg4NikgfHwgZGVm aW5lZChfX2kzODZfXykKICAgICBEV09SRCB0aWNrQ291bnQgPSBHZXRUaWNrQ291bnQoKTsKKyNl bHNlCisgICAgVUxPTkdMT05HIHRpY2tDb3VudCA9IEdldFRpY2tDb3VudDY0KCk7CisjZW5kaWYK IAogICAgIGlmIChpbml0ZWQpIHsKICAgICAgICAgX19pbnQ2NCBxcGNFbGFwc2VkID0gKChxcGMu UXVhZFBhcnQgLSBxcGNMYXN0LlF1YWRQYXJ0KSAqIDEwMDApIC8gcXBjRnJlcXVlbmN5LlF1YWRQ YXJ0OwpJbmRleDogU291cmNlL1dURi93dGYvU3RhY2tCb3VuZHMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcAkocmV2aXNpb24gMTY3MDk1KQorKysgU291 cmNlL1dURi93dGYvU3RhY2tCb3VuZHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTksNyArMTE5 LDcgQEAgdm9pZCBTdGFja0JvdW5kczo6aW5pdGlhbGl6ZSgpCiAKIHZvaWQgU3RhY2tCb3VuZHM6 OmluaXRpYWxpemUoKQogewotICAgIE1FTU9SWV9CQVNJQ19JTkZPUk1BVElPTiBzdGFja09yaWdp bjsKKyAgICBNRU1PUllfQkFTSUNfSU5GT1JNQVRJT04gc3RhY2tPcmlnaW4gPSB7IDAgfTsKICAg ICBWaXJ0dWFsUXVlcnkoJnN0YWNrT3JpZ2luLCAmc3RhY2tPcmlnaW4sIHNpemVvZihzdGFja09y aWdpbikpOwogICAgIC8vIHN0YWNrT3JpZ2luLkFsbG9jYXRpb25CYXNlIHBvaW50cyB0byB0aGUg cmVzZXJ2ZWQgc3RhY2sgbWVtb3J5IGJhc2UgYWRkcmVzcy4KIAo=