131509 2014-04-10 15:16:41 -0700 [iOS WebKit2] Disable the find overlay for now 2014-04-10 17:51:18 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 131519 1 thorton thorton adele alice.barraclough commit-queue sam webkit-bug-importer oldest_to_newest 999664 0 thorton 2014-04-10 15:16:41 -0700 We don't need the grey overlay nor the holes here. 999673 1 229083 thorton 2014-04-10 15:42:18 -0700 Created attachment 229083 patch 999713 2 thorton 2014-04-10 17:32:02 -0700 http://trac.webkit.org/changeset/167097 999714 3 webkit-bug-importer 2014-04-10 17:32:31 -0700 <rdar://problem/16586295> 999720 4 commit-queue 2014-04-10 17:48:10 -0700 Re-opened since this is blocked by bug 131519 229083 2014-04-10 15:42:18 -0700 2014-04-10 15:43:55 -0700 patch findoverlay.diff text/plain 6027 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MGY3ZDI1Li44Y2QwMTk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTQtMDQtMTAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW2lPUyBXZWJLaXQyXSBEaXNhYmxlIHRoZSBmaW5kIG92ZXJsYXkgZm9yIG5vdwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxNTA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQv V2ViUHJlZmVyZW5jZXNTdG9yZS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9GaW5k Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZpbmRDb250cm9sbGVyOjpGaW5kQ29u dHJvbGxlcik6CisgICAgICAgIChXZWJLaXQ6OkZpbmRDb250cm9sbGVyOjpoaWRlRmluZE92ZXJs YXkpOgorICAgICAgICAoV2ViS2l0OjpGaW5kQ29udHJvbGxlcjo6aGlkZUZpbmRVSSk6CisgICAg ICAgIChXZWJLaXQ6OkZpbmRDb250cm9sbGVyOjpzZXRTaG91bGRTaG93T3ZlcmxheSk6CisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmg6CisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjp1 cGRhdGVQcmVmZXJlbmNlcyk6CisgICAgICAgIEFkZCBhIHNldHRpbmcgYWxsb3dpbmcgdXMgdG8g dHVybiBvZmYgdGhlIGZpbmQtaW4tcGFnZSBvdmVybGF5IG9uIGlPUy4KKwogMjAxNC0wNC0xMCAg U2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkIEdUSyBidWlsZCBmaXggYWZ0ZXIgcjE2NzA3NC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oCmluZGV4IDc3NGM1MjcuLjRiY2YxMjggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmgKKysrIGIvU291 cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzU3RvcmUuaApAQCAtNzUsNiArNzUsNyBA QCBuYW1lc3BhY2UgV2ViS2l0IHsKICNkZWZpbmUgREVGQVVMVF9NRURJQV9QTEFZQkFDS19BTExP V1NfSU5MSU5FIGZhbHNlCiAjZGVmaW5lIERFRkFVTFRfTUVESUFfUExBWUJBQ0tfUkVRVUlSRVNf VVNFUl9HRVNUVVJFIHRydWUKICNkZWZpbmUgREVGQVVMVF9URU1QT1JBUllfVElMRV9DT0hPUlRf UkVURU5USU9OX0VOQUJMRUQgZmFsc2UKKyNkZWZpbmUgREVGQVVMVF9GSU5EX0lOX1BBR0VfT1ZF UkxBWV9FTkFCTEVEIGZhbHNlCiAjZWxzZQogI2RlZmluZSBERUZBVUxUX0ZSQU1FX0ZMQVRURU5J TkdfRU5BQkxFRCBmYWxzZQogI2RlZmluZSBERUZBVUxUX1NIT1VMRF9QUklOVF9CQUNLR1JPVU5E UyBmYWxzZQpAQCAtODYsNiArODcsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKICNkZWZpbmUgREVG QVVMVF9NRURJQV9QTEFZQkFDS19BTExPV1NfSU5MSU5FIHRydWUKICNkZWZpbmUgREVGQVVMVF9N RURJQV9QTEFZQkFDS19SRVFVSVJFU19VU0VSX0dFU1RVUkUgZmFsc2UKICNkZWZpbmUgREVGQVVM VF9URU1QT1JBUllfVElMRV9DT0hPUlRfUkVURU5USU9OX0VOQUJMRUQgdHJ1ZQorI2RlZmluZSBE RUZBVUxUX0ZJTkRfSU5fUEFHRV9PVkVSTEFZX0VOQUJMRUQgdHJ1ZQogI2VuZGlmCiAKICNpZiBQ TEFURk9STShJT1MpICYmICFQTEFURk9STShJT1NfU0lNVUxBVE9SKQpAQCAtMjI1LDYgKzIyNyw3 IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogICAgIG1hY3JvKFBhc3N3b3JkRWNob0VuYWJsZWQsIHBh c3N3b3JkRWNob0VuYWJsZWQsIEJvb2wsIGJvb2wsIERFRkFVTFRfUEFTU1dPUkRfRUNIT19FTkFC TEVEKSBcCiAgICAgbWFjcm8oSW1hZ2VDb250cm9sc0VuYWJsZWQsIGltYWdlQ29udHJvbHNFbmFi bGVkLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAgIG1hY3JvKEVuYWJsZUluaGVyaXRVUklRdWVy eUNvbXBvbmVudCwgZW5hYmxlSW5oZXJpdFVSSVF1ZXJ5Q29tcG9uZW50LCBCb29sLCBib29sLCBm YWxzZSkgXAorICAgIG1hY3JvKEZpbmRJblBhZ2VPdmVybGF5RW5hYmxlZCwgZmluZEluUGFnZU92 ZXJsYXlFbmFibGVkLCBCb29sLCBib29sLCBERUZBVUxUX0ZJTkRfSU5fUEFHRV9PVkVSTEFZX0VO QUJMRUQpIFwKIAogI2RlZmluZSBGT1JfRUFDSF9XRUJLSVRfRE9VQkxFX1BSRUZFUkVOQ0UobWFj cm8pIFwKICAgICBtYWNybyhQREZTY2FsZUZhY3RvciwgcGRmU2NhbGVGYWN0b3IsIERvdWJsZSwg ZG91YmxlLCAwKSBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvRmluZENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0ZpbmRDb250cm9sbGVyLmNwcAppbmRleCBiMDZjNjkwLi5jY2IwOGY3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHAKQEAg LTU4LDYgKzU4LDcgQEAgRmluZENvbnRyb2xsZXI6OkZpbmRDb250cm9sbGVyKFdlYlBhZ2UqIHdl YlBhZ2UpCiAgICAgOiBtX3dlYlBhZ2Uod2ViUGFnZSkKICAgICAsIG1fZmluZFBhZ2VPdmVybGF5 KDApCiAgICAgLCBtX2lzU2hvd2luZ0ZpbmRJbmRpY2F0b3IoZmFsc2UpCisgICAgLCBtX3Nob3Vs ZFNob3dPdmVybGF5KHRydWUpCiB7CiB9CiAKQEAgLTI2OCwxOSArMjY5LDI2IEBAIHZvaWQgRmlu ZENvbnRyb2xsZXI6OnNlbGVjdEZpbmRNYXRjaCh1aW50MzJfdCBtYXRjaEluZGV4KQogICAgIGZy YW1lLT5zZWxlY3Rpb24oKS5zZXRTZWxlY3Rpb24oVmlzaWJsZVNlbGVjdGlvbihtX2ZpbmRNYXRj aGVzW21hdGNoSW5kZXhdLmdldCgpKSk7CiB9CiAKK3ZvaWQgRmluZENvbnRyb2xsZXI6OmhpZGVG aW5kT3ZlcmxheSgpCit7CisgICAgaWYgKCFtX2ZpbmRQYWdlT3ZlcmxheSkKKyAgICAgICAgcmV0 dXJuOworCisgICAgbV93ZWJQYWdlLT51bmluc3RhbGxQYWdlT3ZlcmxheShtX2ZpbmRQYWdlT3Zl cmxheSwgUGFnZU92ZXJsYXk6OkZhZGVNb2RlOjpGYWRlKTsKK30KKwogdm9pZCBGaW5kQ29udHJv bGxlcjo6aGlkZUZpbmRVSSgpCiB7CiAgICAgbV9maW5kTWF0Y2hlcy5jbGVhcigpOwotICAgIGlm IChtX2ZpbmRQYWdlT3ZlcmxheSkKLSAgICAgICAgbV93ZWJQYWdlLT51bmluc3RhbGxQYWdlT3Zl cmxheShtX2ZpbmRQYWdlT3ZlcmxheSwgUGFnZU92ZXJsYXk6OkZhZGVNb2RlOjpGYWRlKTsKIAog ICAgIFBsdWdpblZpZXcqIHBsdWdpblZpZXcgPSBwbHVnaW5WaWV3Rm9yRnJhbWUobV93ZWJQYWdl LT5tYWluRnJhbWUoKSk7Ci0gICAgCisKICAgICBpZiAocGx1Z2luVmlldykKICAgICAgICAgcGx1 Z2luVmlldy0+ZmluZFN0cmluZyhlbXB0eVN0cmluZygpLCAwLCAwKTsKICAgICBlbHNlCiAgICAg ICAgIG1fd2ViUGFnZS0+Y29yZVBhZ2UoKS0+dW5tYXJrQWxsVGV4dE1hdGNoZXMoKTsKLSAgICAK KworICAgIGhpZGVGaW5kT3ZlcmxheSgpOwogICAgIGhpZGVGaW5kSW5kaWNhdG9yKCk7CiB9CiAK QEAgLTQ0Myw0ICs0NTEsMTUgQEAgYm9vbCBGaW5kQ29udHJvbGxlcjo6bW91c2VFdmVudChQYWdl T3ZlcmxheSosIGNvbnN0IFdlYk1vdXNlRXZlbnQmIG1vdXNlRXZlbnQpCiAgICAgcmV0dXJuIGZh bHNlOwogfQogCit2b2lkIEZpbmRDb250cm9sbGVyOjpzZXRTaG91bGRTaG93T3ZlcmxheShib29s IHNob3VsZFNob3dPdmVybGF5KQoreworICAgIGlmIChtX3Nob3VsZFNob3dPdmVybGF5ID09IHNo b3VsZFNob3dPdmVybGF5KQorICAgICAgICByZXR1cm47CisKKyAgICBtX3Nob3VsZFNob3dPdmVy bGF5ID0gc2hvdWxkU2hvd092ZXJsYXk7CisKKyAgICBpZiAoaXNTaG93aW5nT3ZlcmxheSgpICYm ICFtX3Nob3VsZFNob3dPdmVybGF5KQorICAgICAgICBoaWRlRmluZE92ZXJsYXkoKTsKK30KKwog fSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9GaW5kQ29udHJvbGxlci5oCmluZGV4IGFmMGMwYTEuLjhlYWFlNTIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5oCkBA IC0zNSw4ICszNSw4IEBACiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7Ci0gICAgY2xhc3MgRnJhbWU7Ci0gICAgY2xhc3MgUmFuZ2U7CitjbGFzcyBGcmFtZTsK K2NsYXNzIFJhbmdlOwogfQogCiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAgLTU0LDEzICs1NCwxNSBA QCBwdWJsaWM6CiAgICAgdm9pZCBmaW5kU3RyaW5nTWF0Y2hlcyhjb25zdCBTdHJpbmcmLCBGaW5k T3B0aW9ucywgdW5zaWduZWQgbWF4TWF0Y2hDb3VudCk7CiAgICAgdm9pZCBnZXRJbWFnZUZvckZp bmRNYXRjaCh1aW50MzJfdCBtYXRjaEluZGV4KTsKICAgICB2b2lkIHNlbGVjdEZpbmRNYXRjaCh1 aW50MzJfdCBtYXRjaEluZGV4KTsKLSAgICB2b2lkIGhpZGVGaW5kVUkoKTsKICAgICB2b2lkIGNv dW50U3RyaW5nTWF0Y2hlcyhjb25zdCBTdHJpbmcmLCBGaW5kT3B0aW9ucywgdW5zaWduZWQgbWF4 TWF0Y2hDb3VudCk7Ci0gICAgCisKKyAgICB2b2lkIGhpZGVGaW5kVUkoKTsKKyAgICB2b2lkIGhp ZGVGaW5kT3ZlcmxheSgpOwogICAgIHZvaWQgaGlkZUZpbmRJbmRpY2F0b3IoKTsKICAgICB2b2lk IHNob3dGaW5kSW5kaWNhdG9ySW5TZWxlY3Rpb24oKTsKIAogICAgIGJvb2wgaXNTaG93aW5nT3Zl cmxheSgpIGNvbnN0IHsgcmV0dXJuIG1faXNTaG93aW5nRmluZEluZGljYXRvciAmJiBtX2ZpbmRQ YWdlT3ZlcmxheTsgfQorICAgIHZvaWQgc2V0U2hvdWxkU2hvd092ZXJsYXkoYm9vbCk7CiAKICAg ICB2b2lkIGRldmljZVNjYWxlRmFjdG9yRGlkQ2hhbmdlKCk7CiAKQEAgLTg2LDYgKzg4LDggQEAg cHJpdmF0ZToKICAgICBib29sIG1faXNTaG93aW5nRmluZEluZGljYXRvcjsKICAgICBXZWJDb3Jl OjpJbnRSZWN0IG1fZmluZEluZGljYXRvclJlY3Q7CiAgICAgVmVjdG9yPFJlZlB0cjxXZWJDb3Jl OjpSYW5nZT4+IG1fZmluZE1hdGNoZXM7CisKKyAgICBib29sIG1fc2hvdWxkU2hvd092ZXJsYXk7 CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCBkNDU4MzRlLi4zZDgxYzcxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCkBAIC0yNjM5LDYgKzI2 MzksOCBAQCB2b2lkIFdlYlBhZ2U6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZlcmVu Y2VzU3RvcmUmIHN0b3JlKQogICAgICAgICBtX2RyYXdpbmdBcmVhLT51cGRhdGVQcmVmZXJlbmNl cyhzdG9yZSk7CiAKICAgICBtX3BhZ2VPdmVybGF5Q29udHJvbGxlci5kaWRDaGFuZ2VQcmVmZXJl bmNlcygpOworCisgICAgbV9maW5kQ29udHJvbGxlci5zZXRTaG91bGRTaG93T3ZlcmxheShzdG9y ZS5nZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6OmZpbmRJblBhZ2VPdmVybGF5 RW5hYmxlZEtleSgpKSk7CiB9CiAKICNpZiBQTEFURk9STShDT0NPQSkK