131503 2014-04-10 12:00:32 -0700 Radio buttons are using the wrong sizes and margins 2022-10-05 15:40:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin webkit-unassigned ahmad.saleem792 webkit-bug-importer webkit oldest_to_newest 999598 0 bdakin 2014-04-10 12:00:32 -0700 This is a regression caused by http://trac.webkit.org/changeset/166514 In making checkboxes and radio buttons share code, I accidentally used checkbox metrics in two spots for radio buttons as well. Miraculously, this does not seem to have effected the rendering is any obvious way, but we should still fix it. 999670 1 229082 bdakin 2014-04-10 15:29:58 -0700 Created attachment 229082 Patch 999674 2 229082 jer.noble 2014-04-10 15:49:50 -0700 Comment on attachment 229082 Patch Because I can't not have a nit, I'd move the "const int* controlMargins" line down below the zoomedSize.setWidth and zoomedSize.setHeight lines. But r=me. :) 1903573 3 ahmad.saleem792 2022-10-05 15:39:55 -0700 This seems to landed and not backed out: https://github.com/WebKit/WebKit/commit/35462e5d6da95e2a904486feba09884d4bb9cc8e Marking as "RESOLVED FIXED". Thanks! 1903574 4 webkit-bug-importer 2022-10-05 15:40:19 -0700 <rdar://problem/100827126> 229082 2014-04-10 15:29:58 -0700 2014-04-10 15:49:50 -0700 Patch for-review.txt text/plain 1850 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NzA5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTEwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSYWRpbyBidXR0b25zIGFyZSB1c2lu ZyB0aGUgd3Jvbmcgc2l6ZXMgYW5kIG1hcmdpbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTUwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSByZWdyZXNzaW9uIHRoYXQgSSBjYXVzZWQg cmVjZW50bHkgd2hlbiBJIGNvbWJpbmVkIHJhZGlvIGJ1dHRvbiBhbmQgCisgICAgICAgIGNoZWNr Ym94IGNvZGUuIAorICAgICAgICAqIHBsYXRmb3JtL21hYy9UaGVtZU1hYy5tbToKKyAgICAgICAg KFdlYkNvcmU6OnBhaW50VG9nZ2xlQnV0dG9uKToKKwogMjAxNC0wNC0wOCAgSm9uIEhvbmV5Y3V0 dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIEFzc2VydGlvbiBmYWlsdXJlIGlu IFdlYkNvcmU6OkZsZXhCb3hJdGVyYXRvcjo6bmV4dCgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1RoZW1lTWFjLm1tCShyZXZpc2lvbiAxNjcwNzMpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTM5NCwxMCArMzk0 LDExIEBAIHN0YXRpYyB2b2lkIHBhaW50VG9nZ2xlQnV0dG9uKENvbnRyb2xQYXIKICAgICBHcmFw aGljc0NvbnRleHRTdGF0ZVNhdmVyIHN0YXRlU2F2ZXIoKmNvbnRleHQpOwogCiAgICAgTlNDb250 cm9sU2l6ZSBjb250cm9sU2l6ZSA9IFt0b2dnbGVCdXR0b25DZWxsIGNvbnRyb2xTaXplXTsKLSAg ICBJbnRTaXplIHpvb21lZFNpemUgPSBjaGVja2JveFNpemVzKClbY29udHJvbFNpemVdOworICAg IEludFNpemUgem9vbWVkU2l6ZSA9IGJ1dHRvblR5cGUgPT0gQ2hlY2tib3hQYXJ0ID8gY2hlY2ti b3hTaXplcygpW2NvbnRyb2xTaXplXSA6IHJhZGlvU2l6ZXMoKVtjb250cm9sU2l6ZV07CisgICAg Y29uc3QgaW50KiBjb250cm9sTWFyZ2lucyA9IGJ1dHRvblR5cGUgPT0gQ2hlY2tib3hQYXJ0ID8g Y2hlY2tib3hNYXJnaW5zKGNvbnRyb2xTaXplKSA6IHJhZGlvTWFyZ2lucyhjb250cm9sU2l6ZSk7 CiAgICAgem9vbWVkU2l6ZS5zZXRXaWR0aCh6b29tZWRTaXplLndpZHRoKCkgKiB6b29tRmFjdG9y KTsKICAgICB6b29tZWRTaXplLnNldEhlaWdodCh6b29tZWRTaXplLmhlaWdodCgpICogem9vbUZh Y3Rvcik7Ci0gICAgSW50UmVjdCBpbmZsYXRlZFJlY3QgPSBpbmZsYXRlUmVjdCh6b29tZWRSZWN0 LCB6b29tZWRTaXplLCBjaGVja2JveE1hcmdpbnMoY29udHJvbFNpemUpLCB6b29tRmFjdG9yKTsK KyAgICBJbnRSZWN0IGluZmxhdGVkUmVjdCA9IGluZmxhdGVSZWN0KHpvb21lZFJlY3QsIHpvb21l ZFNpemUsIGNvbnRyb2xNYXJnaW5zLCB6b29tRmFjdG9yKTsKICAgICAKICAgICBpZiAoem9vbUZh Y3RvciAhPSAxLjBmKSB7CiAgICAgICAgIGluZmxhdGVkUmVjdC5zZXRXaWR0aChpbmZsYXRlZFJl Y3Qud2lkdGgoKSAvIHpvb21GYWN0b3IpOwo=