13147 2007-03-21 13:04:17 -0700 RenderTableCell::sortBorderStyles does not meet qsort's contract 2010-09-22 03:16:41 -0700 1 1 1 Unclassified WebKit CSS 523.x (Safari 3) All OS X 10.4 RESOLVED DUPLICATE 39966 P2 Normal --- 1 phanna hyatt steveblock oldest_to_newest 17928 0 phanna 2007-03-21 13:04:17 -0700 When sorting CollapsedBorderStyles with qsort, the comparator function (compareBorderStylesForQSort) does not honor the requirement that cmp(a, b) == cmp(b, a). This does not appear for the qsort implementation on the Mac but if you use a bubblesort instead of qsort, the problem appears. The issue is that two borders differ only by color and so compareBorders() returns the first parameter each time it is called. This means that calling compareBorders(a, b) != compareBorders(b, a) and thus compareBorderStylesForQSort(a, b) != compareBorderStylesForQSort(b, a) and so an infinite loop can occur because the sorting algorithm will constantly swap the two values. 17921 1 13748 hyatt 2007-03-21 14:00:46 -0700 Created attachment 13748 Patch to use a stable sort instead. This patch switching border style comparison to use a stable sort instead. 17667 2 phanna 2007-03-22 10:08:05 -0700 stable_sort will work but it is not the correct solution. A better solution is to fix the comparison function so that a < b => b > a. 282872 3 steveblock 2010-09-22 03:16:41 -0700 It looks to me like this is fixed with http://trac.webkit.org/changeset/67862 (https://bugs.webkit.org/show_bug.cgi?id=39966) as compareBorders() now returns 0 in the case when borders differ only in colour. > if (border1.precedence() == border2.precedence()) > return 0; *** This bug has been marked as a duplicate of bug 39966 *** 13748 2007-03-21 14:00:46 -0700 2010-06-10 14:30:07 -0700 Patch to use a stable sort instead. patch.txt text/plain 1370 hyatt SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRl cmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCShyZXZpc2lvbiAyMDI2OCkKKysrIHJlbmRlcmluZy9S ZW5kZXJUYWJsZUNlbGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02ODksMjIgKzY4OSwxNiBAQCB2 b2lkIFJlbmRlclRhYmxlQ2VsbDo6Y29sbGVjdEJvcmRlclN0eWxlCiAgICAgYWRkQm9yZGVyU3R5 bGUoYm9yZGVyU3R5bGVzLCBjb2xsYXBzZWRCb3R0b21Cb3JkZXIoKSk7CiB9CiAKLXN0YXRpYyBp bnQgY29tcGFyZUJvcmRlclN0eWxlc0ZvclFTb3J0KGNvbnN0IHZvaWQqIHBhLCBjb25zdCB2b2lk KiBwYikKK3N0YXRpYyBpbmxpbmUgYm9vbCBjb21wYXJlQm9yZGVyU3R5bGVzRm9yU29ydChjb25z dCBDb2xsYXBzZWRCb3JkZXJWYWx1ZSYgYSwgY29uc3QgQ29sbGFwc2VkQm9yZGVyVmFsdWUmIGIp CiB7Ci0gICAgY29uc3QgQ29sbGFwc2VkQm9yZGVyVmFsdWUqIGEgPSBzdGF0aWNfY2FzdDxjb25z dCBDb2xsYXBzZWRCb3JkZXJWYWx1ZSo+KHBhKTsKLSAgICBjb25zdCBDb2xsYXBzZWRCb3JkZXJW YWx1ZSogYiA9IHN0YXRpY19jYXN0PGNvbnN0IENvbGxhcHNlZEJvcmRlclZhbHVlKj4ocGIpOwot ICAgIGlmICgqYSA9PSAqYikKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgQ29sbGFwc2VkQm9yZGVy VmFsdWUgYm9yZGVyV2l0aEhpZ2hlclByZWNlZGVuY2UgPSBjb21wYXJlQm9yZGVycygqYSwgKmIp OwotICAgIGlmICgqYSA9PSBib3JkZXJXaXRoSGlnaGVyUHJlY2VkZW5jZSkKLSAgICAgICAgcmV0 dXJuIDE7Ci0gICAgcmV0dXJuIC0xOworICAgIGlmIChhID09IGIpCisgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICByZXR1cm4gY29tcGFyZUJvcmRlcnMoYSwgYikgPT0gYTsKIH0KIAogdm9pZCBS ZW5kZXJUYWJsZUNlbGw6OnNvcnRCb3JkZXJTdHlsZXMoQ29sbGFwc2VkQm9yZGVyU3R5bGVzJiBi b3JkZXJTdHlsZXMpCiB7Ci0gICAgcXNvcnQoYm9yZGVyU3R5bGVzLmRhdGEoKSwgYm9yZGVyU3R5 bGVzLnNpemUoKSwgc2l6ZW9mKENvbGxhcHNlZEJvcmRlclZhbHVlKSwKLSAgICAgICAgY29tcGFy ZUJvcmRlclN0eWxlc0ZvclFTb3J0KTsKKyAgICBzdGQ6OnN0YWJsZV9zb3J0KGJvcmRlclN0eWxl cy5iZWdpbigpLCBib3JkZXJTdHlsZXMuZW5kKCksIGNvbXBhcmVCb3JkZXJTdHlsZXNGb3JTb3J0 KTsKIH0KIAogdm9pZCBSZW5kZXJUYWJsZUNlbGw6OnBhaW50Q29sbGFwc2VkQm9yZGVyKEdyYXBo aWNzQ29udGV4dCogZ3JhcGhpY3NDb250ZXh0LCBpbnQgdHgsIGludCB0eSwgaW50IHcsIGludCBo KQo=