131468 2014-04-09 17:38:46 -0700 Subpixel rendering: RenderLayer's size is set using enclosingRect() which can result in cruft. 2014-04-20 22:22:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 999367 0 zalan 2014-04-09 17:38:46 -0700 when background color is present on a non-simple-container. 1002432 1 229775 zalan 2014-04-20 16:22:44 -0700 Created attachment 229775 Patch 1002443 2 229775 darin 2014-04-20 20:15:37 -0700 Comment on attachment 229775 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229775&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:715 > + * GraphicsLayer: device pixel positioned. Positioned is floored, size is ceiled. I think this is a typo. “Position is floored”, is what you want. Also, it should be either “ceil’d” or “ceilinged”. It seems to me that combining “position is floored” with “size is ceilinged” could result in incorrect behavior. If the position was 0.95 and the size was 0.1, then the floored position would be 0, the ceillinged size would be 1, and the right would be 1, but the right of the original would be 1.05. 1002450 3 zalan 2014-04-20 20:44:31 -0700 (In reply to comment #2) > (From update of attachment 229775 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=229775&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:715 > > + * GraphicsLayer: device pixel positioned. Positioned is floored, size is ceiled. > > I think this is a typo. “Position is floored”, is what you want. Also, it should be either “ceil’d” or “ceilinged”. Thanks, indeed! (I was just following the 'ceiled' term introduced for LayoutUnit rounding functions by the original subpixel code, but I agree that I should use proper English terms in comments.) > It seems to me that combining “position is floored” with “size is ceilinged” could result in incorrect behavior. If the position was 0.95 and the size was 0.1, then the floored position would be 0, the ceillinged size would be 1, and the right would be 1, but the right of the original would be 1.05. I need to fix these comments! We call floor on minX, minY corner, while ceil on the maxX, maxY, so your example results (0, 0) (2, 2) on a 1x display while (0.5, 0.5) (1.5, 1.5) on a retina display. 1002475 4 zalan 2014-04-20 22:22:12 -0700 Committed r167582: <http://trac.webkit.org/changeset/167582> 229775 2014-04-20 16:22:44 -0700 2014-04-20 20:15:37 -0700 Patch bug-131468-20140420162222.patch text/plain 6993 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI5NDg4NDEzOWYyOGY4 NDMwZWNmZTlkMGY4ZGEzZTQ1NTA5YjAwNi4uMmNkYjZjYmFmZDRjYzI0ODhmNGI5YzVjYTkzOGVm OTM1MzFhOWQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBSZW5kZXJMYXllcidzIHNpemUgaXMgc2V0IHVzaW5nIGVuY2xvc2luZ1JlY3QoKSB3aGljaCBj YW4gcmVzdWx0IGluIGNydWZ0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMxNDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTGF5ZXJzIG1hcmtlZCBvcGFxdWUgbWF5IG5vdCBwYWludCBlZGdlIHBpeGVs cywgd2hlbiBSZW5kZXJMYXllciBib3VuZHMgYXJlIG5vbi1pbnRlZ3JhbCBhbmQgCisgICAgICAg IGdldCBkZXZpY2UgcGl4ZWwgc25hcHBlZC4KKyAgICAgICAgRm9yIGRldGFpbHMgc2VlIHRoaXM6 IGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3IxNTk0NjMKKworICAgICAgICBUZXN0OiBjb21wb3Np dGluZy9oaWRwaS1ub24tc2ltcGxlLWNvbXBvc2l0aW5nLWxheWVyLXdpdGgtZnJhY3Rpb25hbC1z aXplLWFuZC1iYWNrZ3JvdW5kLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRh dGVHcmFwaGljc0xheWVyR2VvbWV0cnkpOgorCiAyMDE0LTA0LTE5ICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIExhdGNoZWQgc2Nyb2xsaW5nIG1heSBpbnRl cmFjdCBiYWRseSB3aXRoIGN1c3RvbSBwcm9ncmFtbWF0aWMgc2Nyb2xsaW5nCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IDg1NTEzOGQx NzEzYTEzOTc4ZThlMWFkYjIxYTE1Y2E4ZmI5Nzg5NjQuLmZiMmUzOWUxMTBlZjdjZGI1ZDRjNTJk NTI2ZDFlNjA3NDI3MWE1NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckJhY2tpbmcuY3BwCkBAIC03MTIsNyArNzEyLDcgQEAgdm9pZCBSZW5kZXJMYXllckJh Y2tpbmc6OnVwZGF0ZUdyYXBoaWNzTGF5ZXJHZW9tZXRyeSgpCiAgICAgfQogCiAgICAgLyoKLSAg ICAqIEdyYXBoaWNzTGF5ZXI6IGRldmljZSBwaXhlbCBwb3NpdGlvbmVkLiBGbG9vcmVkLCBlbmNs b3NpbmcgcmVjdC4KKyAgICAqIEdyYXBoaWNzTGF5ZXI6IGRldmljZSBwaXhlbCBwb3NpdGlvbmVk LiBQb3NpdGlvbmVkIGlzIGZsb29yZWQsIHNpemUgaXMgY2VpbGVkLgogICAgICogUmVuZGVyTGF5 ZXI6IHN1YnBpeGVsIHBvc2l0aW9uZWQuCiAgICAgKiBPZmZzZXQgZnJvbSByZW5kZXJlciAoR3Jh cGhpY3NMYXllciA8LT4gUmVuZGVyTGF5ZXI6OnJlbmRlcmVyKCkpOiBzdWJwaXhlbCBiYXNlZCBv ZmZzZXQuCiAgICAgKgpAQCAtNzMwLDcgKzczMCw3IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5n Ojp1cGRhdGVHcmFwaGljc0xheWVyR2VvbWV0cnkoKQogICAgICoKICAgICAqIGxvY2FsQ29tcG9z aXRpbmdCb3VuZHM6IHRoaXMgUmVuZGVyTGF5ZXIgcmVsYXRpdmUgdG8gaXRzIHJlbmRlcmVyKCku CiAgICAgKiByZWxhdGl2ZUNvbXBvc2l0aW5nQm91bmRzOiB0aGlzIFJlbmRlckxheWVyIHJlbGF0 aXZlIHRvIGl0cyBwYXJlbnQgY29tcG9zaXRpbmcgbGF5ZXIuCi0gICAgKiBlbmNsb3NpbmdSZWxh dGl2ZUNvbXBvc2l0aW5nQm91bmRzOiB0aGlzIFJlbmRlckxheWVyIHJlbGF0aXZlIHRvIGl0cyBw YXJlbnQgYnV0IGZsb29yZWQgdG8gZGV2aWNlIHBpeGVsIHBvc2l0aW9uLgorICAgICogZW5jbG9z aW5nUmVsYXRpdmVDb21wb3NpdGluZ0JvdW5kczogdGhpcyBSZW5kZXJMYXllciByZWxhdGl2ZSB0 byBpdHMgcGFyZW50IGJ1dCBpdHMgcG9zaXRpb24gZmxvb3JlZCB0byBkZXZpY2UgcGl4ZWxzLgog ICAgICogcmVuZGVyZXJPZmZzZXRGcm9tR3JhcGhpY3NMYXllcjogUmVuZGVyTGF5ZXI6OnJlbmRl cmVyKCkncyBvZmZzZXQgZnJvbSBpdHMgZW5jbG9zaW5nIEdyYXBoaWNzTGF5ZXIuCiAgICAgKiBk ZXZpY2VQaXhlbE9mZnNldEZyb21SZW5kZXJlcjogcmVuZGVyZXJPZmZzZXRGcm9tR3JhcGhpY3NM YXllcidzIGRldmljZSBwaXhlbCBwYXJ0LiAoNi45cHggLT4gNi41cHggaW4gY2FzZSBvZiAyeCBk aXNwbGF5KQogICAgICogZGV2aWNlUGl4ZWxGcmFjdGlvbkZyb21SZW5kZXJlcjogcmVuZGVyZXJP ZmZzZXRGcm9tR3JhcGhpY3NMYXllcidzIGZyYWN0aW9uYWwgcGFydCAoNi45cHggLT4gMC40cHgg aW4gY2FzZSBvZiAyeCBkaXNwbGF5KQpAQCAtODIzLDcgKzgyMyw3IEBAIHZvaWQgUmVuZGVyTGF5 ZXJCYWNraW5nOjp1cGRhdGVHcmFwaGljc0xheWVyR2VvbWV0cnkoKQogICAgIGlmICghbV9pc01h aW5GcmFtZVJlbmRlclZpZXdMYXllcikgewogICAgICAgICAvLyBGb3Igbm9uLXJvb3QgbGF5ZXJz LCBiYWNrZ3JvdW5kIGlzIGFsd2F5cyBwYWludGVkIGJ5IHRoZSBwcmltYXJ5IGdyYXBoaWNzIGxh eWVyLgogICAgICAgICBBU1NFUlQoIW1fYmFja2dyb3VuZExheWVyKTsKLSAgICAgICAgYm9vbCBo YWRTdWJwaXhlbFJvdW5kaW5nID0gIW1fZGV2aWNlUGl4ZWxGcmFjdGlvbkZyb21SZW5kZXJlci5p c1plcm8oKTsKKyAgICAgICAgYm9vbCBoYWRTdWJwaXhlbFJvdW5kaW5nID0gZW5jbG9zaW5nUmVs YXRpdmVDb21wb3NpdGluZ0JvdW5kcyAhPSByZWxhdGl2ZUNvbXBvc2l0aW5nQm91bmRzOwogICAg ICAgICBtX2dyYXBoaWNzTGF5ZXItPnNldENvbnRlbnRzT3BhcXVlKCFoYWRTdWJwaXhlbFJvdW5k aW5nICYmIG1fb3duaW5nTGF5ZXIuYmFja2dyb3VuZElzS25vd25Ub0JlT3BhcXVlSW5SZWN0KGxv Y2FsQ29tcG9zaXRpbmdCb3VuZHMpKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhZWYyNGM2MjU1MzU3NjYy YzQzOWQzNTU1Y2NhZjRiODJhNzQ5ODA5Li5mYWVkZmFmMGZlM2ZkNGMzZDg4YmYxY2UxZmU1NjIz ZGZiM2M5MDZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDQtMjAgIFphbGFuIEJ1anRh cyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBTdWJwaXhlbCByZW5kZXJpbmc6IFJlbmRl ckxheWVyJ3Mgc2l6ZSBpcyBzZXQgdXNpbmcgZW5jbG9zaW5nUmVjdCgpIHdoaWNoIGNhbiByZXN1 bHQgaW4gY3J1ZnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzE0NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBMYXllcnMgbWFya2VkIG9wYXF1ZSBtYXkgbm90IHBhaW50IGVkZ2UgcGl4ZWxzLCB3aGVu IFJlbmRlckxheWVyIGJvdW5kcyBhcmUgbm9uLWludGVncmFsIGFuZCAKKyAgICAgICAgZ2V0IGRl dmljZSBwaXhlbCBzbmFwcGVkLgorICAgICAgICBGb3IgZGV0YWlscyBzZWUgdGhpczogaHR0cHM6 Ly90cmFjLndlYmtpdC5vcmcvcjE1OTQ2MworCisgICAgICAgICogY29tcG9zaXRpbmcvaGlkcGkt bm9uLXNpbXBsZS1jb21wb3NpdGluZy1sYXllci13aXRoLWZyYWN0aW9uYWwtc2l6ZS1hbmQtYmFj a2dyb3VuZC1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBjb21wb3NpdGluZy9oaWRw aS1ub24tc2ltcGxlLWNvbXBvc2l0aW5nLWxheWVyLXdpdGgtZnJhY3Rpb25hbC1zaXplLWFuZC1i YWNrZ3JvdW5kLmh0bWw6IEFkZGVkLgorCiAyMDE0LTA0LTE5ICBDaHJpcyBGbGVpemFjaCAgPGNm bGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IGdyaWQgcm93cyBhcmUgbm90IHJlY29n bml6ZWQgZG8gdG8gbGFjayBvZiBleHBsaWNpdCByb2xlPSJyb3ciLCByb2xlPSJncmlkY2VsbCIK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2hpZHBpLW5vbi1zaW1wbGUtY29t cG9zaXRpbmctbGF5ZXItd2l0aC1mcmFjdGlvbmFsLXNpemUtYW5kLWJhY2tncm91bmQtZXhwZWN0 ZWQuaHRtbCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2hpZHBpLW5vbi1zaW1wbGUtY29tcG9z aXRpbmctbGF5ZXItd2l0aC1mcmFjdGlvbmFsLXNpemUtYW5kLWJhY2tncm91bmQtZXhwZWN0ZWQu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi4wZDU1MDA5Nzc4MDg2ODA2YzYwZTZjMDZiYzA5NGUzNzVhOTg3OGQ3 Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvaGlkcGktbm9uLXNp bXBsZS1jb21wb3NpdGluZy1sYXllci13aXRoLWZyYWN0aW9uYWwtc2l6ZS1hbmQtYmFja2dyb3Vu ZC1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMzUgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ Cis8aGVhZD4KKzx0aXRsZT5UaGlzIHRlc3RzIHRoYXQgYSBub24gc2ltcGxlIHJlbmRlciBiYWNr aW5nIGxheWVyIHdpdGggZnJhY3Rpb25hbCBDU1MgcGl4ZWwgc2l6ZSBwYWludHMgdGhlIGJhY2tn cm91bmQgd2l0aCBubyBjcnVmdC48L3RpdGxlPgorPGhlYWQ+Cis8c3R5bGU+CisgIGRpdiB7Cisg ICAgYmFja2dyb3VuZDogZ3JlZW47IAorICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICBib3Jk ZXI6IDAuNXB4IHNvbGlkIHJlZDsKKyAgfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPHAg aWQ9ImNvbnRhaW5lciI+PC9wPgorPHNjcmlwdD4KKyAgdmFyIGNvbnRhaW5lciA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjb250YWluZXIiKTsKKyAgYWRqdXN0bWVudCA9IDAuMTsKKyAgdyA9 IDI7IGggPSAyOworICBmb3IgKGkgPSAwOyBpIDwgMzA7ICsraSkgeworICAgIGFkanVzdG1lbnQg Kz0gMC4xOworICAgIGZvciAoaiA9IDA7IGogPCA0MDsgKytqKSB7CisgICAgICB2YXIgZSA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworICAgICAgZS5zdHlsZS50b3AgPSAoKHcgKyAy KSAqIGkgKyBqICogYWRqdXN0bWVudCkgKyAicHgiOworICAgICAgZS5zdHlsZS5sZWZ0ID0gKCh3 ICsgMikgKiBqICsgaSAqIGFkanVzdG1lbnQpICsgInB4IjsKKyAgICAgIGUuc3R5bGUud2lkdGgg PSB3ICsgInB4IjsKKyAgICAgIGUuc3R5bGUuaGVpZ2h0ID0gaCArICJweCI7CisgICAgICBjb250 YWluZXIuYXBwZW5kQ2hpbGQoZSk7CisgICAgICB3ICs9IDAuMDE7CisgICAgICBoICs9IDAuMDE7 CisgICAgfQorICB9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2NvbXBvc2l0aW5nL2hpZHBpLW5vbi1zaW1wbGUtY29tcG9zaXRpbmctbGF5ZXIt d2l0aC1mcmFjdGlvbmFsLXNpemUtYW5kLWJhY2tncm91bmQuaHRtbCBiL0xheW91dFRlc3RzL2Nv bXBvc2l0aW5nL2hpZHBpLW5vbi1zaW1wbGUtY29tcG9zaXRpbmctbGF5ZXItd2l0aC1mcmFjdGlv bmFsLXNpemUtYW5kLWJhY2tncm91bmQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40MGI0NjAyYzE5ZmY3MmFi YmM2NzZiODQ1MjVjZWEzMWZiODhjOWYwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv Y29tcG9zaXRpbmcvaGlkcGktbm9uLXNpbXBsZS1jb21wb3NpdGluZy1sYXllci13aXRoLWZyYWN0 aW9uYWwtc2l6ZS1hbmQtYmFja2dyb3VuZC5odG1sCkBAIC0wLDAgKzEsMzYgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5UaGlzIHRlc3RzIHRoYXQgYSBub24gc2lt cGxlIHJlbmRlciBiYWNraW5nIGxheWVyIHdpdGggZnJhY3Rpb25hbCBDU1MgcGl4ZWwgc2l6ZSBw YWludHMgdGhlIGJhY2tncm91bmQgd2l0aCBubyBjcnVmdC48L3RpdGxlPgorPGhlYWQ+Cis8c3R5 bGU+CisgIGRpdiB7CisgICAgYmFja2dyb3VuZDogZ3JlZW47IAorICAgIHBvc2l0aW9uOiBhYnNv bHV0ZTsKKyAgICBib3JkZXI6IDAuNXB4IHNvbGlkIHJlZDsKKyAgICAtd2Via2l0LXRyYW5zZm9y bTogdHJhbnNsYXRlWigwKTsKKyAgfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9 ImNvbnRhaW5lciI+PC9wPgorPHNjcmlwdD4KKyAgdmFyIGNvbnRhaW5lciA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJjb250YWluZXIiKTsKKyAgYWRqdXN0bWVudCA9IDAuMTsKKyAgdyA9IDI7 IGggPSAyOworICBmb3IgKGkgPSAwOyBpIDwgMzA7ICsraSkgeworICAgIGFkanVzdG1lbnQgKz0g MC4xOworICAgIGZvciAoaiA9IDA7IGogPCA0MDsgKytqKSB7CisgICAgICB2YXIgZSA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworICAgICAgZS5zdHlsZS50b3AgPSAoKHcgKyAyKSAq IGkgKyBqICogYWRqdXN0bWVudCkgKyAicHgiOworICAgICAgZS5zdHlsZS5sZWZ0ID0gKCh3ICsg MikgKiBqICsgaSAqIGFkanVzdG1lbnQpICsgInB4IjsKKyAgICAgIGUuc3R5bGUud2lkdGggPSB3 ICsgInB4IjsKKyAgICAgIGUuc3R5bGUuaGVpZ2h0ID0gaCArICJweCI7CisgICAgICBjb250YWlu ZXIuYXBwZW5kQ2hpbGQoZSk7CisgICAgICB3ICs9IDAuMDE7CisgICAgICBoICs9IDAuMDE7Cisg ICAgfQorICB9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K