131467 2014-04-09 17:37:33 -0700 REGRESSION (r165908): ~QuickLookHandle() tries to dereference a null ResourceHandle 2014-04-09 17:49:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aestes aestes oldest_to_newest 999366 0 aestes 2014-04-09 17:37:33 -0700 REGRESSION (r165908): ~QuickLookHandle() tries to dereference a null ResourceHandle 999371 1 229006 aestes 2014-04-09 17:44:20 -0700 Created attachment 229006 Patch 999372 2 aestes 2014-04-09 17:49:17 -0700 Committed r167055: <http://trac.webkit.org/changeset/167055> 229006 2014-04-09 17:44:20 -0700 2014-04-09 17:45:42 -0700 Patch bug-131467-20140409174359.patch text/plain 6154 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjYyZGFlNDNiNzFhYjAz Yzk3MmM4ZjU3NGU3NDI3ZjhkZTNlYThlNy4uNzk2YzcyZTdmN2E2MjE2NWY3NTIxNTJkODdiNTA1 YjRkYTM5YjczOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA0LTA5ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTY1OTA4 KTogflF1aWNrTG9va0hhbmRsZSgpIHRyaWVzIHRvIGRlcmVmZXJlbmNlIGEgbnVsbCBSZXNvdXJj ZUhhbmRsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMxNDY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UXVpY2tMb29rSGFuZGxlIHN0b3JlZCBhIFJlc291cmNlSGFuZGxlIHBvaW50ZXIgaW4gb3JkZXIg dG8gbGF0ZXIKKyAgICAgICAgcmV0cml2ZSB0aGUgVVJMIG9mIGl0cyBmaXJzdFJlcXVlc3QoKSwg YnV0IGFmdGVyIHIxNjU5MDggd2Ugbm8gbG9uZ2VyCisgICAgICAgIGFsd2F5cyBoYXZlIGEgUmVz b3VyY2VIYW5kbGUuIFNpbmNlIGZpcnN0UmVxdWVzdCgpJ3MgVVJMIGlzIHRoZSBvbmx5CisgICAg ICAgIHRoaW5nIHdlIG5lZWQgZnJvbSBSZXNvdXJjZUhhbmRsZSwgc3RvcmUgaXQgZGlyZWN0bHkg cmF0aGVyIHRoYW4gYQorICAgICAgICBSZXNvdXJjZUhhbmRsZSBwb2ludGVyLiBJbiB0aGUgY2Fz ZSB3aGVyZSB3ZSBjcmVhdGUgYSBRdWlja0xvb2tIYW5kbGUKKyAgICAgICAgZnJvbSBhIFJlc291 cmNlTG9hZGVyIHJhdGhlciB0aGFuIGEgUmVzb3VyY2VIYW5kbGUsIHBhc3MgdGhlIGxvYWRlcidz CisgICAgICAgIG9yaWdpbmFsUmVxdWVzdCgpLCB3aGljaCByZXByZXNlbnRzIHRoZSBzYW1lIHJl cXVlc3QgYXMgZmlyc3RSZXF1ZXN0KCkKKyAgICAgICAgKGkuZS4gdGhlIHJlcXVlc3QgYWZ0ZXIg d2lsbFNlbmRSZXF1ZXN0KCkgYnV0IGJlZm9yZSByZWRpcmVjdHMpLgorCisgICAgICAgICogcGxh dGZvcm0vbmV0d29yay9pb3MvUXVpY2tMb29rLmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9pb3MvUXVpY2tMb29rLm1tOgorICAgICAgICAoV2ViQ29yZTo6UXVpY2tMb29rSGFuZGxlOjpR dWlja0xvb2tIYW5kbGUpOgorICAgICAgICAoV2ViQ29yZTo6UXVpY2tMb29rSGFuZGxlOjpjcmVh dGUpOgorICAgICAgICAoV2ViQ29yZTo6UXVpY2tMb29rSGFuZGxlOjpkaWRGYWlsKToKKyAgICAg ICAgKFdlYkNvcmU6OlF1aWNrTG9va0hhbmRsZTo6flF1aWNrTG9va0hhbmRsZSk6CisKIDIwMTQt MDQtMDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSFRNTENv bGxlY3Rpb246OnVwZGF0ZU5hbWVkRWxlbWVudENhY2ggaXRlcmF0ZXMgb3ZlciBpdGVtcyB0d2lj ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9pb3MvUXVpY2tM b29rLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2suaApp bmRleCA0YzNmOTA4MTYwNjhkMjViMTJhYWRmZmVjYzA2YThhZWM0ZjUyNDMzLi4xYzNjNDczZWUz NjBiZjlkNTBkYmUzNWQ5MWI1OWRjMDJmYjQwNmM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2suaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2suaApAQCAtMTA2LDEyICsxMDYsOSBAQCBwdWJs aWM6CiAjZW5kaWYKIAogcHJpdmF0ZToKLSAgICBRdWlja0xvb2tIYW5kbGUoUmVzb3VyY2VIYW5k bGUqLCBOU1VSTENvbm5lY3Rpb24gKiwgTlNVUkxSZXNwb25zZSAqLCBpZCBkZWxlZ2F0ZSk7Ci0j aWYgVVNFKENGTkVUV09SSykKLSAgICBRdWlja0xvb2tIYW5kbGUoUmVzb3VyY2VIYW5kbGUqLCBD RlVSTFJlc3BvbnNlUmVmKTsKLSNlbmRpZgorICAgIFF1aWNrTG9va0hhbmRsZShOU1VSTCAqLCBO U1VSTENvbm5lY3Rpb24gKiwgTlNVUkxSZXNwb25zZSAqLCBpZCBkZWxlZ2F0ZSk7CiAKLSAgICBS ZXNvdXJjZUhhbmRsZSogbV9oYW5kbGU7CisgICAgUmV0YWluUHRyPE5TVVJMPiBtX2ZpcnN0UmVx dWVzdFVSTDsKICAgICBSZXRhaW5QdHI8aWQ+IG1fY29udmVydGVyOwogICAgIFJldGFpblB0cjxp ZD4gbV9kZWxlZ2F0ZTsKICAgICBib29sIG1fZmluaXNoZWRMb2FkaW5nRGF0YUludG9Db252ZXJ0 ZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlj a0xvb2subW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2su bW0KaW5kZXggNGQ0YWI3NTkyODk0YThiZTIzNTM1Zjk1Y2RjY2I3MWQxZjQ4Zjc4MC4uZjFjMzBm ODFjZDg2Y2E0NmM5ZDBmMmQ1Nzg0OWFhNDMyYjY2YmIwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9pb3MvUXVpY2tMb29rLm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvaW9zL1F1aWNrTG9vay5tbQpAQCAtMzQwLDggKzM0MCw4IEBA IHN0YXRpYyBOU1N0cmluZyAqY3JlYXRlVGVtcG9yYXJ5RmlsZUZvclF1aWNrTG9vayhOU1N0cmlu ZyAqZmlsZU5hbWUpCiB9CiAKIAotUXVpY2tMb29rSGFuZGxlOjpRdWlja0xvb2tIYW5kbGUoUmVz b3VyY2VIYW5kbGUqIGhhbmRsZSwgTlNVUkxDb25uZWN0aW9uICpjb25uZWN0aW9uLCBOU1VSTFJl c3BvbnNlICpuc1Jlc3BvbnNlLCBpZCBkZWxlZ2F0ZSkKLSAgICA6IG1faGFuZGxlKGhhbmRsZSkK K1F1aWNrTG9va0hhbmRsZTo6UXVpY2tMb29rSGFuZGxlKE5TVVJMICpmaXJzdFJlcXVlc3RVUkws IE5TVVJMQ29ubmVjdGlvbiAqY29ubmVjdGlvbiwgTlNVUkxSZXNwb25zZSAqbnNSZXNwb25zZSwg aWQgZGVsZWdhdGUpCisgICAgOiBtX2ZpcnN0UmVxdWVzdFVSTChmaXJzdFJlcXVlc3RVUkwpCiAg ICAgLCBtX2NvbnZlcnRlcihhZG9wdE5TKFtbUUxQcmV2aWV3Q29udmVydGVyQ2xhc3MoKSBhbGxv Y10gaW5pdFdpdGhDb25uZWN0aW9uOmNvbm5lY3Rpb24gZGVsZWdhdGU6ZGVsZWdhdGUgcmVzcG9u c2U6bnNSZXNwb25zZSBvcHRpb25zOm5pbF0pKQogICAgICwgbV9kZWxlZ2F0ZShhZG9wdE5TKFtk ZWxlZ2F0ZSByZXRhaW5dKSkKICAgICAsIG1fZmluaXNoZWRMb2FkaW5nRGF0YUludG9Db252ZXJ0 ZXIoZmFsc2UpCkBAIC0zNzAsNyArMzcwLDcgQEAgUXVpY2tMb29rSGFuZGxlOjpRdWlja0xvb2tI YW5kbGUoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSwgTlNVUkxDb25uZWN0aW9uICpjb25uZWMKIFBh c3NPd25QdHI8UXVpY2tMb29rSGFuZGxlPiBRdWlja0xvb2tIYW5kbGU6OmNyZWF0ZShSZXNvdXJj ZUhhbmRsZSogaGFuZGxlLCBOU1VSTENvbm5lY3Rpb24gKmNvbm5lY3Rpb24sIE5TVVJMUmVzcG9u c2UgKm5zUmVzcG9uc2UsIGlkIGRlbGVnYXRlKQogewogICAgIGlmIChoYW5kbGUtPmZpcnN0UmVx dWVzdCgpLmlzTWFpblJlc291cmNlUmVxdWVzdCgpICYmIFtXZWJDb3JlOjpRTFByZXZpZXdHZXRT dXBwb3J0ZWRNSU1FVHlwZXNTZXQoKSBjb250YWluc09iamVjdDpbbnNSZXNwb25zZSBNSU1FVHlw ZV1dKQotICAgICAgICByZXR1cm4gYWRvcHRQdHIobmV3IFF1aWNrTG9va0hhbmRsZShoYW5kbGUs IGNvbm5lY3Rpb24sIG5zUmVzcG9uc2UsIGRlbGVnYXRlKSk7CisgICAgICAgIHJldHVybiBhZG9w dFB0cihuZXcgUXVpY2tMb29rSGFuZGxlKFtoYW5kbGUtPmZpcnN0UmVxdWVzdCgpLm5zVVJMUmVx dWVzdChEb05vdFVwZGF0ZUhUVFBCb2R5KSBVUkxdLCBjb25uZWN0aW9uLCBuc1Jlc3BvbnNlLCBk ZWxlZ2F0ZSkpOwogCiAgICAgcmV0dXJuIG51bGxwdHI7CiB9CkBAIC0zODEsNyArMzgxLDcgQEAg UGFzc093blB0cjxRdWlja0xvb2tIYW5kbGU+IFF1aWNrTG9va0hhbmRsZTo6Y3JlYXRlKFJlc291 cmNlSGFuZGxlKiBoYW5kbGUsIFN5bmMKICAgICBpZiAoaGFuZGxlLT5maXJzdFJlcXVlc3QoKS5p c01haW5SZXNvdXJjZVJlcXVlc3QoKSAmJiBbV2ViQ29yZTo6UUxQcmV2aWV3R2V0U3VwcG9ydGVk TUlNRVR5cGVzU2V0KCkgY29udGFpbnNPYmplY3Q6KE5TU3RyaW5nICopQ0ZVUkxSZXNwb25zZUdl dE1JTUVUeXBlKGNmUmVzcG9uc2UpXSkgewogICAgICAgICBOU1VSTFJlc3BvbnNlICpuc1Jlc3Bv bnNlID0gW05TVVJMUmVzcG9uc2UgX3Jlc3BvbnNlV2l0aENGVVJMUmVzcG9uc2U6Y2ZSZXNwb25z ZV07CiAgICAgICAgIFdlYlF1aWNrTG9va0hhbmRsZUFzRGVsZWdhdGUgKmRlbGVnYXRlID0gW1tb V2ViUXVpY2tMb29rSGFuZGxlQXNEZWxlZ2F0ZSBhbGxvY10gaW5pdFdpdGhDb25uZWN0aW9uRGVs ZWdhdGU6Y29ubmVjdGlvbkRlbGVnYXRlXSBhdXRvcmVsZWFzZV07Ci0gICAgICAgIHJldHVybiBh ZG9wdFB0cihuZXcgUXVpY2tMb29rSGFuZGxlKGhhbmRsZSwgbmlsLCBuc1Jlc3BvbnNlLCBkZWxl Z2F0ZSkpOworICAgICAgICByZXR1cm4gYWRvcHRQdHIobmV3IFF1aWNrTG9va0hhbmRsZShbaGFu ZGxlLT5maXJzdFJlcXVlc3QoKS5uc1VSTFJlcXVlc3QoRG9Ob3RVcGRhdGVIVFRQQm9keSkgVVJM XSwgbmlsLCBuc1Jlc3BvbnNlLCBkZWxlZ2F0ZSkpOwogICAgIH0KIAogICAgIHJldHVybiBudWxs cHRyOwpAQCAtMzk2LDcgKzM5Niw3IEBAIENGVVJMUmVzcG9uc2VSZWYgUXVpY2tMb29rSGFuZGxl OjpjZlJlc3BvbnNlKCkKIFBhc3NPd25QdHI8UXVpY2tMb29rSGFuZGxlPiBRdWlja0xvb2tIYW5k bGU6OmNyZWF0ZShSZXNvdXJjZUxvYWRlciogbG9hZGVyLCBOU1VSTFJlc3BvbnNlICpyZXNwb25z ZSwgaWQgZGVsZWdhdGUpCiB7CiAgICAgaWYgKGxvYWRlci0+cmVxdWVzdCgpLmlzTWFpblJlc291 cmNlUmVxdWVzdCgpICYmIFtXZWJDb3JlOjpRTFByZXZpZXdHZXRTdXBwb3J0ZWRNSU1FVHlwZXNT ZXQoKSBjb250YWluc09iamVjdDpbcmVzcG9uc2UgTUlNRVR5cGVdXSkKLSAgICAgICAgcmV0dXJu IGFkb3B0UHRyKG5ldyBRdWlja0xvb2tIYW5kbGUoTlVMTCwgbmlsLCByZXNwb25zZSwgZGVsZWdh dGUpKTsKKyAgICAgICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBRdWlja0xvb2tIYW5kbGUoW2xvYWRl ci0+b3JpZ2luYWxSZXF1ZXN0KCkubnNVUkxSZXF1ZXN0KERvTm90VXBkYXRlSFRUUEJvZHkpIFVS TF0sIG5pbCwgcmVzcG9uc2UsIGRlbGVnYXRlKSk7CiAKICAgICByZXR1cm4gbnVsbHB0cjsKIH0K QEAgLTQ1NCw3ICs0NTQsNyBAQCB2b2lkIFF1aWNrTG9va0hhbmRsZTo6ZGlkRmFpbCgpCiAgICAg TE9HKE5ldHdvcmssICJRdWlja0xvb2tIYW5kbGU6OmRpZEZhaWwoKSIpOwogICAgIG1fcXVpY2ts b29rRmlsZUhhbmRsZSA9IG51bGxwdHI7CiAgICAgLy8gcmVtb3ZlUUxQcmV2aWV3Q29udmVydGVy Rm9yVVJMIGRlbGV0ZXMgdGhlIHRlbXBvcmFyeSBmaWxlIGNyZWF0ZWQuCi0gICAgcmVtb3ZlUUxQ cmV2aWV3Q29udmVydGVyRm9yVVJMKFttX2hhbmRsZS0+Zmlyc3RSZXF1ZXN0KCkubnNVUkxSZXF1 ZXN0KERvTm90VXBkYXRlSFRUUEJvZHkpIFVSTF0pOworICAgIHJlbW92ZVFMUHJldmlld0NvbnZl cnRlckZvclVSTChtX2ZpcnN0UmVxdWVzdFVSTC5nZXQoKSk7CiAgICAgW21fY29udmVydGVyLmdl dCgpIGZpbmlzaENvbnZlcnRpbmddOwogICAgIG1fY29udmVydGVyID0gbnVsbHB0cjsKIH0KQEAg LTQ2NCw3ICs0NjQsNyBAQCBRdWlja0xvb2tIYW5kbGU6On5RdWlja0xvb2tIYW5kbGUoKQogICAg IExPRyhOZXR3b3JrLCAiUXVpY2tMb29rSGFuZGxlOjp+UXVpY2tMb29rSGFuZGxlKCkiKTsKICAg ICBpZiAobV9xdWlja2xvb2tGaWxlSGFuZGxlKSB7CiAgICAgICAgIG1fcXVpY2tsb29rRmlsZUhh bmRsZSA9IG51bGxwdHI7Ci0gICAgICAgIHJlbW92ZVFMUHJldmlld0NvbnZlcnRlckZvclVSTChb bV9oYW5kbGUtPmZpcnN0UmVxdWVzdCgpLm5zVVJMUmVxdWVzdChEb05vdFVwZGF0ZUhUVFBCb2R5 KSBVUkxdKTsKKyAgICAgICAgcmVtb3ZlUUxQcmV2aWV3Q29udmVydGVyRm9yVVJMKG1fZmlyc3RS ZXF1ZXN0VVJMLmdldCgpKTsKICAgICB9CiAgICAgbV9jb252ZXJ0ZXIgPSBudWxscHRyOwogCg==