131451 2014-04-09 14:09:21 -0700 Don't offer "contact" actions in telephone number menus 2014-04-09 14:32:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 999283 0 beidson 2014-04-09 14:09:21 -0700 Don't offer "contact" actions in telephone number menus <rdar://problem/16556907> 999284 1 228981 beidson 2014-04-09 14:11:05 -0700 Created attachment 228981 Patch v1 999286 2 228981 thorton 2014-04-09 14:14:24 -0700 Comment on attachment 228981 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review > Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:674 > + if ([[actionObject actionUTI] rangeOfString:@"com.apple.contact."].location == 0) hasPrefix? > Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:678 > + if ([actionObject isKindOfClass:[getDDSeparatorActionClass() class]]) Isn't it already a Class? Why +class? Same above. 999287 3 228981 thorton 2014-04-09 14:14:42 -0700 Comment on attachment 228981 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review > Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:78 > +@property (readonly) NSString * actionUTI; I think the star should touch the name (to the right). 999290 4 228981 thorton 2014-04-09 14:15:35 -0700 Comment on attachment 228981 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review >> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:78 >> +@property (readonly) NSString * actionUTI; > > I think the star should touch the name (to the right). Also I think this should be empty and the property should be on a (Details) category? or WKDetails or something I don't remember. 999297 5 beidson 2014-04-09 14:32:21 -0700 http://trac.webkit.org/changeset/167034 228981 2014-04-09 14:11:05 -0700 2014-04-09 14:15:35 -0700 Patch v1 patch text/plain 2735 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlN2YyMDJlLi5hOTkxOTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDQtMDkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIERvbid0IG9mZmVyICJjb250YWN0IiBhY3Rpb25zIGluIHRlbGVwaG9uZSBudW1iZXIgbWVu dXMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2NTU2OTA3PiBhbmQgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTQ1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XZWJQYWdlUHJveHlNYWMu bW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2hvd1RlbGVwaG9uZU51bWJlck1l bnUpOiBTa2lwIGFjdGlvbnMgdGhhdCBoYXZlIHRvIGRvIHdpdGggY29udGFjdHMsCisgICAgICAg ICAgYW5kIHNraXAgc2VwYXJhdG9ycyB0b28hCisKIDIwMTQtMDQtMDggIERhbiBCZXJuc3RlaW4g IDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIEFkZCBXS0Zvcm1EZWxlZ2F0ZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJQYWdlUHJveHlNYWMu bW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYlBhZ2VQcm94eU1hYy5tbQppbmRl eCA2NTg2OGIwLi5kNzAxMWRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dlYlBhZ2VQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFj L1dlYlBhZ2VQcm94eU1hYy5tbQpAQCAtNjMsNiArNjMsOCBAQCBAZW5kCiAKIFNPRlRfTElOS19Q UklWQVRFX0ZSQU1FV09SS19PUFRJT05BTChEYXRhRGV0ZWN0b3JzKQogU09GVF9MSU5LX0NMQVNT KERhdGFEZXRlY3RvcnMsIEREQWN0aW9uc01hbmFnZXIpCitTT0ZUX0xJTktfQ0xBU1MoRGF0YURl dGVjdG9ycywgRERBY3Rpb24pCitTT0ZUX0xJTktfQ0xBU1MoRGF0YURldGVjdG9ycywgRERTZXBh cmF0b3JBY3Rpb24pCiBTT0ZUX0xJTktfQ09OU1RBTlQoRGF0YURldGVjdG9ycywgRERCaW5kZXJQ aG9uZU51bWJlcktleSwgQ0ZTdHJpbmdSZWYpCiAKIHR5cGVkZWYgdm9pZCogRERBY3Rpb25Db250 ZXh0OwpAQCAtNzIsNiArNzQsMTMgQEAgKyAoRERBY3Rpb25zTWFuYWdlciAqKSBzaGFyZWRNYW5h Z2VyOwogLSAoTlNBcnJheSAqKSBtZW51SXRlbXNGb3JWYWx1ZTooTlNTdHJpbmcgKil2YWx1ZSB0 eXBlOihDRlN0cmluZ1JlZil0eXBlIHNlcnZpY2U6KE5TU3RyaW5nICopc2VydmljZSBjb250ZXh0 OihEREFjdGlvbkNvbnRleHQgKiljb250ZXh0OwogQGVuZAogCitAaW50ZXJmYWNlIEREQWN0aW9u IDogTlNPYmplY3QKK0Bwcm9wZXJ0eSAocmVhZG9ubHkpIE5TU3RyaW5nICogYWN0aW9uVVRJOwor QGVuZAorCitAaW50ZXJmYWNlIEREU2VwYXJhdG9yQWN0aW9uIDogRERBY3Rpb24KK0BlbmQKKwog I2RlZmluZSBNRVNTQUdFX0NIRUNLKGFzc2VydGlvbikgTUVTU0FHRV9DSEVDS19CQVNFKGFzc2Vy dGlvbiwgcHJvY2VzcygpLmNvbm5lY3Rpb24oKSkKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7 CkBAIC02NTMsNiArNjYyLDIyIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzaG93VGVsZXBob25lTnVt YmVyTWVudShjb25zdCBTdHJpbmcmIHRlbGVwaG9uZU51bWJlciwgY29uc3QKIAogICAgIFZlY3Rv cjxXZWJDb250ZXh0TWVudUl0ZW1EYXRhPiBpdGVtczsKICAgICBmb3IgKE5TTWVudUl0ZW0gKml0 ZW0gaW4gbWVudUl0ZW1zKSB7CisgICAgICAgIE5TRGljdGlvbmFyeSAqcmVwcmVzZW50ZWRPYmpl Y3QgPSBbaXRlbSByZXByZXNlbnRlZE9iamVjdF07CisgICAgICAgIGlmICghW3JlcHJlc2VudGVk T2JqZWN0IGlzS2luZE9mQ2xhc3M6W05TRGljdGlvbmFyeSBjbGFzc11dKQorICAgICAgICAgICAg Y29udGludWU7CisKKyAgICAgICAgRERBY3Rpb24gKmFjdGlvbk9iamVjdCA9IFtyZXByZXNlbnRl ZE9iamVjdCBvYmplY3RGb3JLZXk6QCJEREFjdGlvbiJdOworICAgICAgICBpZiAoIVthY3Rpb25P YmplY3QgaXNLaW5kT2ZDbGFzczpbZ2V0RERBY3Rpb25DbGFzcygpIGNsYXNzXV0pCisgICAgICAg ICAgICBjb250aW51ZTsKKworICAgICAgICAvLyBTa2lwIG1lbnUgaXRlbXMgd2hvc2UgYWN0aW9u cyBoYXZlIGFueXRoaW5nIHRvIGRvIHdpdGggY29udGFjdHMuCisgICAgICAgIGlmIChbW2FjdGlv bk9iamVjdCBhY3Rpb25VVEldIHJhbmdlT2ZTdHJpbmc6QCJjb20uYXBwbGUuY29udGFjdC4iXS5s b2NhdGlvbiA9PSAwKQorICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgLy8gU2tpcCBz ZXBlcmF0b3IgaXRlbXMuCisgICAgICAgIGlmIChbYWN0aW9uT2JqZWN0IGlzS2luZE9mQ2xhc3M6 W2dldEREU2VwYXJhdG9yQWN0aW9uQ2xhc3MoKSBjbGFzc11dKQorICAgICAgICAgICAgY29udGlu dWU7CisKICAgICAgICAgUmV0YWluUHRyPE5TTWVudUl0ZW0+IHJldGFpbmVkSXRlbSA9IGl0ZW07 CiAgICAgICAgIHN0ZDo6ZnVuY3Rpb248dm9pZCgpPiBoYW5kbGVyID0gW3JldGFpbmVkSXRlbV0o KSB7CiAgICAgICAgICAgICBOU01lbnVJdGVtICppdGVtID0gcmV0YWluZWRJdGVtLmdldCgpOwo=