131431 2014-04-08 23:02:24 -0700 nil should only be used for objects 2014-04-08 23:31:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 conrad_shultz conrad_shultz aboxhall apinheiro cfleizach commit-queue dmazzoni eric.carlson glenn jcraig jdiggs jer.noble mario philipj samuel_white sergio webkit-bug-importer oldest_to_newest 999089 0 conrad_shultz 2014-04-08 23:02:24 -0700 -[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:] should always return a BOOL. 999098 1 conrad_shultz 2014-04-08 23:09:35 -0700 Noticed there's a misuse of nil in -[WebViewFullScreenController setMediaElement:] too. 999100 2 228944 conrad_shultz 2014-04-08 23:14:02 -0700 Created attachment 228944 Patch 999103 3 228944 cfleizach 2014-04-08 23:18:34 -0700 Comment on attachment 228944 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147 > + [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr]; nullptr should probably be nil since this is an ObjC call 999104 4 mrowe 2014-04-08 23:19:46 -0700 (In reply to comment #3) > (From update of attachment 228944 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review > > > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147 > > + [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr]; > > nullptr should probably be nil since this is an ObjC call The context: parameter is a void* though, so nullptr is correct. 999109 5 228944 commit-queue 2014-04-08 23:31:51 -0700 Comment on attachment 228944 Patch Clearing flags on attachment: 228944 Committed r167003: <http://trac.webkit.org/changeset/167003> 999110 6 commit-queue 2014-04-08 23:31:55 -0700 All reviewed patches have been landed. Closing bug. 228944 2014-04-08 23:14:02 -0700 2014-04-08 23:31:51 -0700 Patch bug-131431-20140408231341.patch text/plain 2355 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2OTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI0OWRmMjFjZGQyZGY1 ZjYyZDI4ODIyMmEyZDYzZWFkZmRmOWI0Ni4uMmM2YzMzMzEzNWMxNWVmYjM3NTMyMTg5YmQwNWIy ZjU3ZTU4OGRiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA0LTA4ICBDb25y YWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CisKKyAgICAgICAgbmlsIHNob3Vs ZCBvbmx5IGJlIHVzZWQgZm9yIG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMTQzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJNYWMubW06CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyIGFjY2Vzc2liaWxpdHlJc0F0dHJpYnV0ZVNldHRhYmxlOl0pOgorICAgICAgICBuaWwgLT4g Tk8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxl ci5tbToKKyAgICAgICAgKC1bV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlciBzZXRNZWRpYUVs ZW1lbnQ6XSk6CisgICAgICAgIG5pbCAtPiAwOyBjaGFuZ2UgYSBOVUxMIHRvIG51bGxwdHIgd2hp bGUgd2UncmUgaGVyZS4KKwogMjAxNC0wNC0wOCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hA YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBpT1MgKHJlZHV4 KS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vz c2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0KaW5kZXggMDExOTAxODli N2Q1MzIxY2MyZTJkYzUxZTc5NDY1MDY4M2NjOGYwZC4uNDBlOWJiMzI1MWQzODgwMGRlOTBhYTI4 NzI1NmY4ZDliN2E5M2NmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0KKysrIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMu bW0KQEAgLTI5NjgsNyArMjk2OCw3IEBAIHN0YXRpYyBOU1N0cmluZyogcm9sZVZhbHVlVG9OU1N0 cmluZyhBY2Nlc3NpYmlsaXR5Um9sZSB2YWx1ZSkKIC0gKEJPT0wpYWNjZXNzaWJpbGl0eUlzQXR0 cmlidXRlU2V0dGFibGU6KE5TU3RyaW5nKilhdHRyaWJ1dGVOYW1lCiB7CiAgICAgaWYgKCFbc2Vs ZiB1cGRhdGVPYmplY3RCYWNraW5nU3RvcmVdKQotICAgICAgICByZXR1cm4gbmlsOworICAgICAg ICByZXR1cm4gTk87CiAgICAgCiAgICAgaWYgKFthdHRyaWJ1dGVOYW1lIGlzRXF1YWxUb1N0cmlu ZzogQCJBWFNlbGVjdGVkVGV4dE1hcmtlclJhbmdlIl0pCiAgICAgICAgIHJldHVybiBZRVM7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVu Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxz Y3JlZW5Db250cm9sbGVyLm1tCmluZGV4IGRhNzdjMDZkYmZkZDU3NDQzOGY2Zjc3NmYxODUzZWJi OWMwODVmZWIuLjE5NjYzZTJiYjI5NzQ3YTYxMzAwNGE2M2M0MjAwOThiMTkwYzA1NDkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5Db250 cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxz Y3JlZW5Db250cm9sbGVyLm1tCkBAIC0xNDQsNyArMTQ0LDcgQEAgU09GVF9MSU5LX0NMQVNTKEFW Rm91bmRhdGlvbiwgQVZQbGF5ZXJMYXllcikKICAgICAgICAgICAgIFtzZWxmIHNldHVwVmlkZW9P dmVybGF5OmxheWVyXTsKICAgICAgICAgICAgIFtsYXllciBzZXRQbGF5ZXI6cGxheWVyXTsKIAot ICAgICAgICAgICAgW3BsYXllciBhZGRPYnNlcnZlcjpzZWxmIGZvcktleVBhdGg6QCJyYXRlIiBv cHRpb25zOm5pbCBjb250ZXh0Ok5VTExdOworICAgICAgICAgICAgW3BsYXllciBhZGRPYnNlcnZl cjpzZWxmIGZvcktleVBhdGg6QCJyYXRlIiBvcHRpb25zOjAgY29udGV4dDpudWxscHRyXTsKICAg ICAgICAgfQogICAgIH0KIH0K