131427 2014-04-08 22:27:37 -0700 [EFL] Change font path for DumpRenderTree and WebKitTestRunner 2014-04-09 00:22:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi bunhere commit-queue gyuyoung.kim gyuyoung.kim lucas.de.marchi mrobinson rakuco sergio oldest_to_newest 999067 0 ryuan.choi 2014-04-08 22:27:37 -0700 Since r166973, WebKit/Gtk changed font directory. 999068 1 228935 ryuan.choi 2014-04-08 22:29:41 -0700 Created attachment 228935 Patch 999069 2 228935 gyuyoung.kim 2014-04-08 22:33:54 -0700 Comment on attachment 228935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review > Tools/DumpRenderTree/PlatformEfl.cmake:80 > +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts" I think this change occurred because GTK port is deleting their wk1 port. However, we decide to keep wk1 port. It looks that now is time to have EFL own font directory path. 999097 3 ryuan.choi 2014-04-08 23:07:34 -0700 (In reply to comment #2) > (From update of attachment 228935 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review > > > Tools/DumpRenderTree/PlatformEfl.cmake:80 > > +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts" > > I think this change occurred because GTK port is deleting their wk1 port. However, we decide to keep wk1 port. It looks that now is time to have EFL own font directory path. Yes, after removed GtKLauncher, fonts are just moved to WebKitTestRunner/gtk/fonts. I don't think that it is good to copy them to efl specific folder. And we don't have good fonts for efl port yet. One solution is moving fonts to better place but I don't have idea. 999099 4 228935 mrobinson 2014-04-08 23:12:17 -0700 Comment on attachment 228935 Patch Sorry about the breakage! I had no idea that EFL used our fonts directory. 999105 5 228935 gyuyoung.kim 2014-04-08 23:19:48 -0700 Comment on attachment 228935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review > Tools/DumpRenderTree/PlatformEfl.cmake:78 > # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory BTW, I think we can delete this FIXME: comment. Bug 81475 was closed. >>> Tools/DumpRenderTree/PlatformEfl.cmake:80 >>> +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts" >> >> I think this change occurred because GTK port is deleting their wk1 port. However, we decide to keep wk1 port. It looks that now is time to have EFL own font directory path. > > Yes, after removed GtKLauncher, fonts are just moved to WebKitTestRunner/gtk/fonts. > I don't think that it is good to copy them to efl specific folder. > And we don't have good fonts for efl port yet. > > One solution is moving fonts to better place but I don't have idea. I think we need to add a comment. For example, "FIXME: EFL port needs to have own test font and font configure instead of gtk test font in future" > Tools/WebKitTestRunner/PlatformEfl.cmake:79 > # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory ditto. 999106 6 gyuyoung.kim 2014-04-08 23:22:00 -0700 (In reply to comment #4) > (From update of attachment 228935 [details]) > Sorry about the breakage! I had no idea that EFL used our fonts directory. I wish EFL port has own test font in future. So, I would like to land this patch with a comment. 999113 7 ryuan.choi 2014-04-08 23:35:19 -0700 (In reply to comment #5) > (From update of attachment 228935 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228935&action=review > > > Tools/DumpRenderTree/PlatformEfl.cmake:78 > > # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory > > BTW, I think we can delete this FIXME: comment. Bug 81475 was closed. > Oh, right but without fixing "hardcode the directory". :( Bug 81475 just fixed the issues about jhbuild. I will remove url only and follow it in the another bug. > >>> Tools/DumpRenderTree/PlatformEfl.cmake:80 > >>> +add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/WebKitTestRunner/gtk/fonts" > >> > >> I think this change occurred because GTK port is deleting their wk1 port. However, we decide to keep wk1 port. It looks that now is time to have EFL own font directory path. > > > > Yes, after removed GtKLauncher, fonts are just moved to WebKitTestRunner/gtk/fonts. > > I don't think that it is good to copy them to efl specific folder. > > And we don't have good fonts for efl port yet. > > > > One solution is moving fonts to better place but I don't have idea. > > I think we need to add a comment. For example, > > "FIXME: EFL port needs to have own test font and font configure instead of gtk test font in future" > > > Tools/WebKitTestRunner/PlatformEfl.cmake:79 > > # FIXME: DOWNLOADED_FONTS_DIR should not hardcode the directory > > ditto. OK, I will. 999115 8 228946 ryuan.choi 2014-04-08 23:39:30 -0700 Created attachment 228946 Patch 999120 9 228946 commit-queue 2014-04-09 00:22:42 -0700 Comment on attachment 228946 Patch Clearing flags on attachment: 228946 Committed r167004: <http://trac.webkit.org/changeset/167004> 999121 10 commit-queue 2014-04-09 00:22:49 -0700 All reviewed patches have been landed. Closing bug. 228935 2014-04-08 22:29:41 -0700 2014-04-08 23:39:20 -0700 Patch bug-131427-20140409142920.patch text/plain 2170 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2OTk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2U5ODU5YzNiNmU1NDQ5YzBmMTM0NjZkZmI5NmJiZTIw MzdiYTMyYi4uNWZlMDMxMDA1MTM5ZDQ2MmExNTE0Yzc2M2ZmNzAwM2M1YzNhMjdkNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA0LTA4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBDaGFuZ2UgZm9udCBwYXRoIGZvciBEdW1wUmVuZGVyVHJlZSBhbmQgV2Vi S2l0VGVzdFJ1bm5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMxNDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2luY2UgcjE2Njk3MywgZm9udCBwYXRoIHdhcyBjaGFuZ2VkLgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvUGxhdGZvcm1FZmwuY21ha2U6CisgICAgICAgICogV2ViS2l0VGVzdFJ1 bm5lci9QbGF0Zm9ybUVmbC5jbWFrZToKKwogMjAxNC0wNC0wOCAgR2VvZmZyZXkgR2FyZW4gIDxn Z2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQtanNjIGJ1aWxkCmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDQ0MmZlOTgxYzhiMmU4NWU0Y2M1 NzgwODUyMWJhNmIxMjIzOTI0NzEuLjM1MjJmNmFiZjVkZjk4NmJlYzkzMTAzYWMzMmE1MjU1YjAw NmJlM2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtl CisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC03Nyw1ICs3 Nyw1IEBAIGVuZGlmICgpCiAKICMgRklYTUU6IERPV05MT0FERURfRk9OVFNfRElSIHNob3VsZCBu b3QgaGFyZGNvZGUgdGhlIGRpcmVjdG9yeQogIyBzdHJ1Y3R1cmUuIFNlZSA8aHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDc1Pi4KLWFkZF9kZWZpbml0aW9ucygtREZP TlRTX0NPTkZfRElSPSIke1RPT0xTX0RJUn0vRHVtcFJlbmRlclRyZWUvZ3RrL2ZvbnRzIgorYWRk X2RlZmluaXRpb25zKC1ERk9OVFNfQ09ORl9ESVI9IiR7VE9PTFNfRElSfS9XZWJLaXRUZXN0UnVu bmVyL2d0ay9mb250cyIKICAgICAgICAgICAgICAgICAtRERPV05MT0FERURfRk9OVFNfRElSPSIk e0NNQUtFX1NPVVJDRV9ESVJ9L1dlYktpdEJ1aWxkL0RlcGVuZGVuY2llcy9Tb3VyY2Uvd2Via2l0 Z3RrLXRlc3QtZm9udHMiKQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0 Zm9ybUVmbC5jbWFrZSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1FZmwuY21ha2UK aW5kZXggYjZmMWRmYzc4MWVjMjdkYjRjZGU5ZWUxYjk5NjE3ZjVlOGY5Y2EwMy4uNDE1ZTcwYjE5 N2RmMDQ1YTMwOTc0OTA5OWQwNTkyYTllYjFjNmM1ZSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9QbGF0Zm9ybUVmbC5jbWFrZQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L1BsYXRmb3JtRWZsLmNtYWtlCkBAIC03OCw3ICs3OCw3IEBAIGxpc3QoQVBQRU5EIFdlYktpdFRl c3RSdW5uZXJJbmplY3RlZEJ1bmRsZV9TT1VSQ0VTCiAKICMgRklYTUU6IERPV05MT0FERURfRk9O VFNfRElSIHNob3VsZCBub3QgaGFyZGNvZGUgdGhlIGRpcmVjdG9yeQogIyBzdHJ1Y3R1cmUuIFNl ZSA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDc1Pi4KLWFkZF9k ZWZpbml0aW9ucygtREZPTlRTX0NPTkZfRElSPSIke1RPT0xTX0RJUn0vRHVtcFJlbmRlclRyZWUv Z3RrL2ZvbnRzIgorYWRkX2RlZmluaXRpb25zKC1ERk9OVFNfQ09ORl9ESVI9IiR7VE9PTFNfRElS fS9XZWJLaXRUZXN0UnVubmVyL2d0ay9mb250cyIKICAgICAgICAgICAgICAgICAtRERPV05MT0FE RURfRk9OVFNfRElSPSIke0NNQUtFX1NPVVJDRV9ESVJ9L1dlYktpdEJ1aWxkL0RlcGVuZGVuY2ll cy9Tb3VyY2Uvd2Via2l0Z3RrLXRlc3QtZm9udHMiKQogCiBpZiAoRU5BQkxFX0FDQ0VTU0lCSUxJ VFkpCg== 228946 2014-04-08 23:39:30 -0700 2014-04-09 00:22:42 -0700 Patch bug-131427-20140409153908.patch text/plain 2628 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MDAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2U5ODU5YzNiNmU1NDQ5YzBmMTM0NjZkZmI5NmJiZTIw MzdiYTMyYi4uNWZlMDMxMDA1MTM5ZDQ2MmExNTE0Yzc2M2ZmNzAwM2M1YzNhMjdkNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA0LTA4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBDaGFuZ2UgZm9udCBwYXRoIGZvciBEdW1wUmVuZGVyVHJlZSBhbmQgV2Vi S2l0VGVzdFJ1bm5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMxNDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2luY2UgcjE2Njk3MywgZm9udCBwYXRoIHdhcyBjaGFuZ2VkLgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvUGxhdGZvcm1FZmwuY21ha2U6CisgICAgICAgICogV2ViS2l0VGVzdFJ1 bm5lci9QbGF0Zm9ybUVmbC5jbWFrZToKKwogMjAxNC0wNC0wOCAgR2VvZmZyZXkgR2FyZW4gIDxn Z2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQtanNjIGJ1aWxkCmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDQ0MmZlOTgxYzhiMmU4NWU0Y2M1 NzgwODUyMWJhNmIxMjIzOTI0NzEuLmYzNzczOThhYTVlZTdjNzQ1ZjQ5MGI0NzVlODViNjE4Nzc0 ZWZkYWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtl CisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC03NSw3ICs3 NSw3IEBAIGlmIChFTkFCTEVfQUNDRVNTSUJJTElUWSkKICAgICApCiBlbmRpZiAoKQogCi0jIEZJ WE1FOiBET1dOTE9BREVEX0ZPTlRTX0RJUiBzaG91bGQgbm90IGhhcmRjb2RlIHRoZSBkaXJlY3Rv cnkKLSMgc3RydWN0dXJlLiBTZWUgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MTQ3NT4uCi1hZGRfZGVmaW5pdGlvbnMoLURGT05UU19DT05GX0RJUj0iJHtUT09MU19E SVJ9L0R1bXBSZW5kZXJUcmVlL2d0ay9mb250cyIKKyMgRklYTUU6IEVGTCBwb3J0IG5lZWRzIHRv IGhhdmUgb3duIHRlc3QgZm9udCBhbmQgZm9udCBjb25maWd1cmUgaW5zdGVhZCBvZiBndGsgdGVz dCBmb250IGluIGZ1dHVyZQorIyBGSVhNRTogRE9XTkxPQURFRF9GT05UU19ESVIgc2hvdWxkIG5v dCBoYXJkY29kZSB0aGUgZGlyZWN0b3J5IHN0cnVjdHVyZS4KK2FkZF9kZWZpbml0aW9ucygtREZP TlRTX0NPTkZfRElSPSIke1RPT0xTX0RJUn0vV2ViS2l0VGVzdFJ1bm5lci9ndGsvZm9udHMiCiAg ICAgICAgICAgICAgICAgLURET1dOTE9BREVEX0ZPTlRTX0RJUj0iJHtDTUFLRV9TT1VSQ0VfRElS fS9XZWJLaXRCdWlsZC9EZXBlbmRlbmNpZXMvU291cmNlL3dlYmtpdGd0ay10ZXN0LWZvbnRzIikK ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1FZmwuY21ha2UgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGI2ZjFkZmM3ODFl YzI3ZGI0Y2RlOWVlMWI5OTYxN2Y1ZThmOWNhMDMuLjJiOGY4NTFjMzZhMzJkNzE1Y2Q4NDQyOGIz N2M3NDlkMzc3NGRjYWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZv cm1FZmwuY21ha2UKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybUVmbC5jbWFr ZQpAQCAtNzYsOSArNzYsOSBAQCBsaXN0KEFQUEVORCBXZWJLaXRUZXN0UnVubmVySW5qZWN0ZWRC dW5kbGVfU09VUkNFUwogICAgICR7V0VCS0lUX1RFU1RSVU5ORVJfSU5KRUNURURCVU5ETEVfRElS fS9lZmwvVGVzdFJ1bm5lckVmbC5jcHAKICkKIAotIyBGSVhNRTogRE9XTkxPQURFRF9GT05UU19E SVIgc2hvdWxkIG5vdCBoYXJkY29kZSB0aGUgZGlyZWN0b3J5Ci0jIHN0cnVjdHVyZS4gU2VlIDxo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE0NzU+LgotYWRkX2RlZmlu aXRpb25zKC1ERk9OVFNfQ09ORl9ESVI9IiR7VE9PTFNfRElSfS9EdW1wUmVuZGVyVHJlZS9ndGsv Zm9udHMiCisjIEZJWE1FOiBFRkwgcG9ydCBuZWVkcyB0byBoYXZlIG93biB0ZXN0IGZvbnQgYW5k IGZvbnQgY29uZmlndXJlIGluc3RlYWQgb2YgZ3RrIHRlc3QgZm9udCBpbiBmdXR1cmUKKyMgRklY TUU6IERPV05MT0FERURfRk9OVFNfRElSIHNob3VsZCBub3QgaGFyZGNvZGUgdGhlIGRpcmVjdG9y eSBzdHJ1Y3R1cmUuCithZGRfZGVmaW5pdGlvbnMoLURGT05UU19DT05GX0RJUj0iJHtUT09MU19E SVJ9L1dlYktpdFRlc3RSdW5uZXIvZ3RrL2ZvbnRzIgogICAgICAgICAgICAgICAgIC1ERE9XTkxP QURFRF9GT05UU19ESVI9IiR7Q01BS0VfU09VUkNFX0RJUn0vV2ViS2l0QnVpbGQvRGVwZW5kZW5j aWVzL1NvdXJjZS93ZWJraXRndGstdGVzdC1mb250cyIpCiAKIGlmIChFTkFCTEVfQUNDRVNTSUJJ TElUWSkK