131411 2014-04-08 17:45:31 -0700 Remove "System Font" from char width calculations 2014-04-10 12:17:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 131479 1 mmaxfield mmaxfield commit-queue dino jonlee simon.fraser thorton webkit-bug-importer oldest_to_newest 998921 0 mmaxfield 2014-04-08 17:45:31 -0700 Remove "System Font" from whitelisted DRT fonts and char width calculations 998932 1 228922 mmaxfield 2014-04-08 17:50:13 -0700 Created attachment 228922 Patch 998933 2 mmaxfield 2014-04-08 17:51:51 -0700 <rdar://problem/16281488> 999318 3 228922 commit-queue 2014-04-09 15:03:40 -0700 Comment on attachment 228922 Patch Rejecting attachment 228922 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 228922, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5926285901561856 999339 4 mmaxfield 2014-04-09 15:55:36 -0700 http://trac.webkit.org/changeset/167046 999444 5 ap 2014-04-09 23:29:52 -0700 This change caused 300+ failures on Mountain Lion WK1 tester: <http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r167064%20(5110)/results.html>. Rolling out. 999563 6 mmaxfield 2014-04-10 10:18:55 -0700 And yet EWS is all green? I am very surprised by this. 999580 7 thorton 2014-04-10 11:02:04 -0700 (In reply to comment #6) > And yet EWS is all green? I am very surprised by this. EWS uses Mountain Lion. 999583 8 mmaxfield 2014-04-10 11:30:40 -0700 I have figured out what happened. There are two ways that the system font gets whitelisted in DRT, and this patch removes one and http://trac.webkit.org/changeset/167043 removes the other. This patch looks like the culprit because it was committed last. In my testing I hadn't tested the two patches on top of each other; only one after the other. 999603 9 229064 mmaxfield 2014-04-10 12:04:56 -0700 Created attachment 229064 Patch 999610 10 229064 commit-queue 2014-04-10 12:17:21 -0700 Comment on attachment 229064 Patch Clearing flags on attachment: 229064 Committed r167082: <http://trac.webkit.org/changeset/167082> 999611 11 commit-queue 2014-04-10 12:17:24 -0700 All reviewed patches have been landed. Closing bug. 228922 2014-04-08 17:50:13 -0700 2014-04-10 12:04:53 -0700 Patch bug-131411-20140408174952.patch text/plain 2722 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2OTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUwZWEyM2MzODQ5OThm NjNmMzljY2M1NjYyNzg4MjAzM2UxOGIzZC4uZDNlNDcwMzMyOWM2NWI0MzBlNjJmZTU0M2Y4OTUx ODAzOGU2ZjQ4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTA4ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlICJT eXN0ZW0gRm9udCIgZnJvbSB3aGl0ZWxpc3RlZCBEUlQgZm9udHMgYW5kIGNoYXIgd2lkdGggY2Fs Y3VsYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzE0MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvRm9udC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250OjpoYXNWYWxpZEF2ZXJhZ2VDaGFy V2lkdGgpOgorCiAyMDE0LTA0LTA4ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgZXhwb3NlZFJlY3QgZnJvbSBUaWxlQ29udHJvbGxlcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcAppbmRleCBmODhiOGIxYTVhYTI3NGYx YmJmMTYzMGNlZThlZmJjMmE5MGUwNWRhLi5mMjc2ZjEzODdjODk1NDhkYTdmNDJjZWJhZmJhN2M3 MWIwMmQ4YTllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9G b250LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcApA QCAtNDg0LDcgKzQ4NCw3IEBAIGJvb2wgRm9udDo6aGFzVmFsaWRBdmVyYWdlQ2hhcldpZHRoKCkg Y29uc3QKICAgICAvLyBJbnRlcm5hbCBmb250cyBvbiBPUyBYIGFsc28gaGF2ZSBhbiBpbnZhbGlk IGVudHJ5IGluIHRoZSB0YWJsZSBmb3IgYXZnQ2hhcldpZHRoLgogICAgIC8vIFRoZXkgYXJlIGhp ZGRlbiBieSBoYXZpbmcgYSBuYW1lIHRoYXQgYmVnaW5zIHdpdGggYSBwZXJpb2QsIHNvIHNpbXBs eSBzZWFyY2gKICAgICAvLyBmb3IgdGhhdCBoZXJlIHJhdGhlciB0aGFuIHRyeSB0byBrZWVwIHRo ZSBsaXN0IHVwIHRvIGRhdGUuCi0gICAgaWYgKGZhbWlseS5zdGFydHNXaXRoKCcuJykgfHwgZmFt aWx5ID09ICJTeXN0ZW0gRm9udCIpCisgICAgaWYgKGZhbWlseS5zdGFydHNXaXRoKCcuJykpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIHN0YXRpYyBIYXNoU2V0PEF0b21pY1N0cmluZz4q IGZvbnRGYW1pbGllc1dpdGhJbnZhbGlkQ2hhcldpZHRoTWFwID0gMDsKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MTFmYjVjZDQ3ODIxZDczMmYy MGM2NGVmN2I2ZDQxM2YyYjlkNTgxLi43NzkwZDUwM2FiMzZmMzAwY2UwODg5NTg0ZmQ2ZTQyMjc5 OTc0NjE1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDQtMDggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZp ZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgIlN5c3RlbSBGb250IiBmcm9tIHdoaXRl bGlzdGVkIERSVCBmb250cyBhbmQgY2hhciB3aWR0aCBjYWxjdWxhdGlvbnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTQxMQorCisgICAgICAgIENv dmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMv RHVtcFJlbmRlclRyZWUubW06CisgICAgICAgIChhbGxvd2VkRm9udEZhbWlseVNldCk6CisKIDIw MTQtMDQtMDggIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBYUEMgc2Vy dmljZXMgbGF1bmNoZWQgYnkgU2FmYXJpIGhhdmUgd3JvbmcgRFlMRF9GUkFNRVdPUktfUEFUSCBz ZXQgd2hlbiBsYXVuY2hlZCB2aWEgcnVuLXNhZmFyaSAvIGRlYnVnLXNhZmFyaQpkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCmluZGV4IDQzZGM4MjgwOTRmMDEyMzM0 NDg5MTVkMTM2YzdmOGRmNGM4YmNlN2EuLjY0NWJkYjBlYmJjMzEwZTg0YjViOGVlNjRlMTYwM2Fl NmY1ZTcwMWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVy VHJlZS5tbQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0K QEAgLTM5Nyw3ICszOTcsNiBAQCBzdGF0aWMgTlNTZXQgKmFsbG93ZWRGb250RmFtaWx5U2V0KCkK ICAgICAgICAgQCJTVEthaXRpIiwKICAgICAgICAgQCJTVFNvbmciLAogICAgICAgICBAIlN5bWJv bCIsCi0gICAgICAgIEAiU3lzdGVtIEZvbnQiLAogICAgICAgICBAIlRhaG9tYSIsCiAgICAgICAg IEAiVGhvbmJ1cmkiLAogICAgICAgICBAIlRpbWVzIE5ldyBSb21hbiIsCg== 229064 2014-04-10 12:04:56 -0700 2014-04-10 12:17:21 -0700 Patch bug-131411-20140410120434.patch text/plain 1520 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWNiMTcyMWNmYjYzMDli ZmE4MDMxOWNjOTg5ZGU4ZTE3ZGU1Mzg1ZC4uNGJkYTlkMjRjNzJkMmRmY2Y4MWRjYWY4NzA1MTQ3 MjQzNzJiMGJlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTEwICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlICJT eXN0ZW0gRm9udCIgZnJvbSBjaGFyYWN0ZXIgd2lkdGggY2FsY3VsYXRpb25zCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzE0MTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5n IHRlc3RzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZvbnQ6Omhhc1ZhbGlkQXZlcmFnZUNoYXJXaWR0aCk6CisKIDIwMTQtMDQtMTAg IFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBb R1N0cmVhbWVyXSBObyBDT1JTIHN1cHBvcnQgZm9yIG1lZGlhIGVsZW1lbnRzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCmluZGV4IGY4OGI4YjFhNWFhMjc0ZjFiYmYx NjMwY2VlOGVmYmMyYTkwZTA1ZGEuLmYyNzZmMTM4N2M4OTU0OGRhN2Y0MmNlYmFmYmE3YzcxYjAy ZDhhOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwCkBAIC00 ODQsNyArNDg0LDcgQEAgYm9vbCBGb250OjpoYXNWYWxpZEF2ZXJhZ2VDaGFyV2lkdGgoKSBjb25z dAogICAgIC8vIEludGVybmFsIGZvbnRzIG9uIE9TIFggYWxzbyBoYXZlIGFuIGludmFsaWQgZW50 cnkgaW4gdGhlIHRhYmxlIGZvciBhdmdDaGFyV2lkdGguCiAgICAgLy8gVGhleSBhcmUgaGlkZGVu IGJ5IGhhdmluZyBhIG5hbWUgdGhhdCBiZWdpbnMgd2l0aCBhIHBlcmlvZCwgc28gc2ltcGx5IHNl YXJjaAogICAgIC8vIGZvciB0aGF0IGhlcmUgcmF0aGVyIHRoYW4gdHJ5IHRvIGtlZXAgdGhlIGxp c3QgdXAgdG8gZGF0ZS4KLSAgICBpZiAoZmFtaWx5LnN0YXJ0c1dpdGgoJy4nKSB8fCBmYW1pbHkg PT0gIlN5c3RlbSBGb250IikKKyAgICBpZiAoZmFtaWx5LnN0YXJ0c1dpdGgoJy4nKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCiAgICAgc3RhdGljIEhhc2hTZXQ8QXRvbWljU3RyaW5nPiogZm9u dEZhbWlsaWVzV2l0aEludmFsaWRDaGFyV2lkdGhNYXAgPSAwOwo=