131409 2014-04-08 17:30:30 -0700 REGRESSION(r166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing 2014-05-31 11:50:59 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P1 Critical --- 1 rniwa rniwa andersca dbates joepeck kling mitz oldest_to_newest 998908 0 rniwa 2014-04-08 17:30:30 -0700 Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 VM Regions Near 0: --> __TEXT 00000001054f6000-00000001054f8000 [ 8K] r-x/rwx SM=COW /Volumes/VOLUME/*/WebKit2.framework/Versions/A/XPCServices/com.apple.WebKit.WebContent.Development.xpc/Contents/MacOS/com.apple.WebKit.WebContent.Development Application Specific Information: Bundle controller class: BrowserBundleController Process Model: Multiple Web Processes Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit2 0x0000000108509579 WebKit::WebEditorClient::textFieldDidEndEditing(WebCore::Element*) + 79 1 com.apple.WebCore 0x000000010903e1a1 WebCore::FrameLoader::stopLoading(WebCore::UnloadEventPolicy) + 161 2 com.apple.WebCore 0x00000001090dff7c WebCore::FrameLoader::detachFromParent() + 76 3 com.apple.WebKit2 0x0000000108519df0 WebKit::WebPage::close() + 598 4 com.apple.WebKit2 0x0000000108661b43 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection*, IPC::MessageDecoder&) + 4647 5 com.apple.WebKit2 0x00000001085bc145 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection*, IPC::MessageDecoder&) + 125 6 com.apple.WebKit2 0x0000000108694b2c WebKit::WebProcess::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) + 28 7 com.apple.WebKit2 0x000000010857afae IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 94 8 com.apple.WebKit2 0x000000010857d01a IPC::Connection::dispatchOneMessage() + 106 9 com.apple.JavaScriptCore 0x0000000108ded8e2 WTF::RunLoop::performWork() + 850 10 com.apple.JavaScriptCore 0x0000000108dede12 WTF::RunLoop::performWork(void*) + 34 11 com.apple.CoreFoundation 0x00007fff8bf11731 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 12 com.apple.CoreFoundation 0x00007fff8bf02ea2 __CFRunLoopDoSources0 + 242 13 com.apple.CoreFoundation 0x00007fff8bf0262f __CFRunLoopRun + 831 14 com.apple.CoreFoundation 0x00007fff8bf020b5 CFRunLoopRunSpecific + 309 15 com.apple.HIToolbox 0x00007fff90f2fa0d RunCurrentEventLoopInMode + 226 16 com.apple.HIToolbox 0x00007fff90f2f7b7 ReceiveNextEventCommon + 479 17 com.apple.HIToolbox 0x00007fff90f2f5bc _BlockUntilNextEventMatchingListInModeWithFilter + 65 18 com.apple.AppKit 0x00007fff91a4c3de _DPSNextEvent + 1434 19 com.apple.AppKit 0x00007fff91a4ba2b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 20 com.apple.AppKit 0x00007fff91a3fb2c -[NSApplication run] + 553 21 com.apple.AppKit 0x00007fff91a2a913 NSApplicationMain + 940 22 com.apple.XPCService 0x00007fff85f1cc0f _xpc_main + 385 23 libxpc.dylib 0x00007fff8c846bde xpc_main + 399 24 com.apple.WebKit.WebContent.Development 0x00000001054f76a0 0x1054f6000 + 5792 25 libdyld.dylib 0x00007fff8e2135fd start + 1 998910 1 228918 rniwa 2014-04-08 17:33:13 -0700 Created attachment 228918 Fixes the bug 998912 2 228918 joepeck 2014-04-08 17:36:07 -0700 Comment on attachment 228918 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=228918&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:889 > + m_formClient = std::make_ptr<API::InjectedBundle::FormClient>(); What is make_ptr? Did you mean make_unique? 998915 3 rniwa 2014-04-08 17:39:33 -0700 Landed in r166985, and fixed the typo in r166986. 1012750 4 dbates 2014-05-31 11:50:59 -0700 Closing bug as Resolved Fixed since the patch landed per comment #3. If the patch didn't resolve this bug then please reopen/file a new bug as appropriate. 228918 2014-04-08 17:33:13 -0700 2014-04-08 17:36:13 -0700 Fixes the bug fix131409 text/plain 1396 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Njk3NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTA4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ociAxNjY4OTAp OiBDcmFzaCBpbnNpZGUgV2ViS2l0OjpXZWJFZGl0b3JDbGllbnQ6OnRleHRGaWVsZERpZEVuZEVk aXRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MTQwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENy ZWF0ZSBhbiBlbXB0eSBBUEk6OkluamVjdGVkQnVuZGxlOjpGb3JtQ2xpZW50IHRvIGF2b2lkIGNy YXNoaW5nIGluc2lkZQorICAgICAgICBtX21haW5GcmFtZS0+Y29yZUZyYW1lKCktPmxvYWRlcigp LmRldGFjaEZyb21QYXJlbnQoKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Y2xvc2UpOgorCiAyMDE0LTA0LTA4 ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFVuaWZ5 IGFuZCBmYWN0b3Igb3V0IHBhZ2Ugb3ZlcmxheSBpbXBsZW1lbnRhdGlvbnMKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDE2 Njk3NSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtODg2LDcgKzg4Niw3IEBACiAgICAgbV9jb250ZXh0TWVudUNsaWVu dC5pbml0aWFsaXplKDApOwogI2VuZGlmCiAgICAgbV9lZGl0b3JDbGllbnQuaW5pdGlhbGl6ZSgw KTsKLSAgICBtX2Zvcm1DbGllbnQgPSBzdGQ6OnVuaXF1ZV9wdHI8QVBJOjpJbmplY3RlZEJ1bmRs ZTo6Rm9ybUNsaWVudD4oKTsKKyAgICBtX2Zvcm1DbGllbnQgPSBzdGQ6Om1ha2VfcHRyPEFQSTo6 SW5qZWN0ZWRCdW5kbGU6OkZvcm1DbGllbnQ+KCk7CiAgICAgbV9sb2FkZXJDbGllbnQuaW5pdGlh bGl6ZSgwKTsKICAgICBtX3BvbGljeUNsaWVudC5pbml0aWFsaXplKDApOwogICAgIG1fcmVzb3Vy Y2VMb2FkQ2xpZW50LmluaXRpYWxpemUoMCk7Cg==