131398 2014-04-08 14:58:34 -0700 Web Inspector: Address stale FIXMEs concerning console in JSContext inspection 2014-04-08 15:46:39 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 998807 0 joepeck 2014-04-08 14:58:34 -0700 There were a number of FIXMEs regarding "console" support in JSContext inspection. Address them. 998809 1 228897 joepeck 2014-04-08 15:00:52 -0700 Created attachment 228897 [PATCH] Proposed Fix 998832 2 228897 commit-queue 2014-04-08 15:46:37 -0700 Comment on attachment 228897 [PATCH] Proposed Fix Clearing flags on attachment: 228897 Committed r166971: <http://trac.webkit.org/changeset/166971> 998833 3 commit-queue 2014-04-08 15:46:39 -0700 All reviewed patches have been landed. Closing bug. 228897 2014-04-08 15:00:52 -0700 2014-04-08 15:46:37 -0700 [PATCH] Proposed Fix fixme.patch text/plain 5443 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGM0NTIwZjguLjRmYjZmZTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA0LTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkcmVz cyBzdGFsZSBGSVhNRXMgY29uY2VybmluZyBjb25zb2xlIGluIEpTQ29udGV4dCBpbnNwZWN0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEzOTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3Bl Y3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qczoKKyAgICAgICAgVGhlIGNvbnNvbGUgb2JqZWN0 IGNhbiBiZSBkZWxldGVkIGZyb20gYSBwYWdlIG9yIEpTQ29udGV4dCwKKyAgICAgICAgc28ga2Vl cCBjb2RlIHRoYXQgZXhwZWN0cyB0aGF0IGl0IGNvdWxkIGhhdmUgYmVlbiBkZWxldGVkCisgICAg ICAgIHRvIGJlIHJlc2lsaWVudCBpbiB0aG9zZSBjYXNlcy4KKworICAgICAgICAqIGluc3BlY3Rv ci9KU0dsb2JhbE9iamVjdFNjcmlwdERlYnVnU2VydmVyLmg6CisgICAgICAgICogaW5zcGVjdG9y L2FnZW50cy9KU0dsb2JhbE9iamVjdERlYnVnZ2VyQWdlbnQuaDoKKyAgICAgICAgKiBpbnNwZWN0 b3IvYWdlbnRzL0pTR2xvYmFsT2JqZWN0UnVudGltZUFnZW50Lmg6CisgICAgICAgIENoYW5nZSB0 aGUgRklYTUVzIHRvIE5PVEVzIHRoYXQgZXhwbGFpbiB3aHkgdGhlc2UgZnVuY3Rpb25zCisgICAg ICAgIGhhdmUgZW1wdHkgaW1wbGVtZW50YXRpb25zIGZvciBKU0NvbnRleHQgaW5zcGVjdGlvbi4K KwogMjAxNC0wNC0wOCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIGZpeCBhIGdvb2Z5IGFzc2VydGlvbiB0byBmaXggZGVidWcuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNl LmpzIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJj ZS5qcwppbmRleCBkNjE4OWVlLi5kYjMzMWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKQEAgLTIwOSw3ICsy MDksNiBAQCBJbmplY3RlZFNjcmlwdC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBhcmdzQXJy YXkgPSBJbmplY3RlZFNjcmlwdEhvc3QuZXZhbHVhdGUoIigiICsgYXJncyArICIpIik7CiAgICAg ICAgIHZhciByZXN1bHQgPSB0aGlzW21ldGhvZE5hbWVdLmFwcGx5KHRoaXMsIGFyZ3NBcnJheSk7 CiAgICAgICAgIGlmICh0eXBlb2YgcmVzdWx0ID09PSAidW5kZWZpbmVkIikgewotICAgICAgICAg ICAgLy8gRklYTUU6IEpTIENvbnRleHQgaW5zcGVjdGlvbiBjdXJyZW50bHkgZG9lcyBub3QgaGF2 ZSBhIGdsb2JhbC5jb25zb2xlIG9iamVjdC4KICAgICAgICAgICAgIGlmIChpbnNwZWN0ZWRHbG9i YWxPYmplY3QuY29uc29sZSkKICAgICAgICAgICAgICAgICBpbnNwZWN0ZWRHbG9iYWxPYmplY3Qu Y29uc29sZS5lcnJvcigiV2ViIEluc3BlY3RvciBlcnJvcjogSW5qZWN0ZWRTY3JpcHQuJXMgcmV0 dXJucyB1bmRlZmluZWQiLCBtZXRob2ROYW1lKTsKICAgICAgICAgICAgIHJlc3VsdCA9IG51bGw7 CkBAIC01NTcsNyArNTU2LDYgQEAgSW5qZWN0ZWRTY3JpcHQucHJvdG90eXBlID0gewogICAgICAg ICAvLyBXaGVuIG5vdCBldmFsdWF0aW5nIG9uIGEgY2FsbCBmcmFtZSB3ZSB1c2UgYSAnd2l0aCcg c3RhdGVtZW50IHRvIGFsbG93IHZhciBhbmQgZnVuY3Rpb24gc3RhdGVtZW50cyB0byBsZWFrCiAg ICAgICAgIC8vIGludG8gdGhlIGdsb2JhbCBzY29wZS4gVGhpcyBhbGxvdyB0aGVtIHRvIHN0aWNr IGFyb3VuZCBiZXR3ZWVuIGV2YWx1YXRpb25zLgogCi0gICAgICAgIC8vIEZJWE1FOiBKUyBDb250 ZXh0IGluc3BlY3Rpb24gY3VycmVudGx5IGRvZXMgbm90IGhhdmUgYSBnbG9iYWwuY29uc29sZSBv YmplY3QuCiAgICAgICAgIHRyeSB7CiAgICAgICAgICAgICBpZiAoY29tbWFuZExpbmVBUEkpIHsK ICAgICAgICAgICAgICAgICBpZiAoaW5zcGVjdGVkR2xvYmFsT2JqZWN0LmNvbnNvbGUpCkBAIC02 NzIsNyArNjcwLDYgQEAgSW5qZWN0ZWRTY3JpcHQucHJvdG90eXBlID0gewogICAgICAgICBkZWxl dGUgdGhpcy5fbW9kdWxlc1tuYW1lXTsKICAgICAgICAgdmFyIG1vZHVsZUZ1bmN0aW9uID0gSW5q ZWN0ZWRTY3JpcHRIb3N0LmV2YWx1YXRlKCIoIiArIHNvdXJjZSArICIpIik7CiAgICAgICAgIGlm ICh0eXBlb2YgbW9kdWxlRnVuY3Rpb24gIT09ICJmdW5jdGlvbiIpIHsKLSAgICAgICAgICAgIC8v IEZJWE1FOiBKUyBDb250ZXh0IGluc3BlY3Rpb24gY3VycmVudGx5IGRvZXMgbm90IGhhdmUgYSBn bG9iYWwuY29uc29sZSBvYmplY3QuCiAgICAgICAgICAgICBpZiAoaW5zcGVjdGVkR2xvYmFsT2Jq ZWN0LmNvbnNvbGUpCiAgICAgICAgICAgICAgICAgaW5zcGVjdGVkR2xvYmFsT2JqZWN0LmNvbnNv bGUuZXJyb3IoIldlYiBJbnNwZWN0b3IgZXJyb3I6IEEgZnVuY3Rpb24gd2FzIGV4cGVjdGVkIGZv ciBtb2R1bGUgJXMgZXZhbHVhdGlvbiIsIG5hbWUpOwogICAgICAgICAgICAgcmV0dXJuIG51bGw7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2Jq ZWN0U2NyaXB0RGVidWdTZXJ2ZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv SlNHbG9iYWxPYmplY3RTY3JpcHREZWJ1Z1NlcnZlci5oCmluZGV4IGNhMGMyNDcuLmQzMDllNTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmpl Y3RTY3JpcHREZWJ1Z1NlcnZlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvSlNHbG9iYWxPYmplY3RTY3JpcHREZWJ1Z1NlcnZlci5oCkBAIC01Myw3ICs1Myw5IEBAIHBy aXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHJ1bkV2ZW50TG9vcFdoaWxlUGF1c2VkKCkgb3ZlcnJp ZGU7CiAgICAgdmlydHVhbCBib29sIGlzQ29udGVudFNjcmlwdChKU0M6OkV4ZWNTdGF0ZSopIGNv bnN0IG92ZXJyaWRlIHsgcmV0dXJuIGZhbHNlOyB9CiAKLSAgICAvLyBGSVhNRTogSmF2YVNjcmlw dCBpbnNwZWN0aW9uIGhhcyBubyBDb25zb2xlIHlldC4KKyAgICAvLyBOT1RFOiBDdXJyZW50bHkg YWxsIGV4Y2VwdGlvbnMgYXJlIHJlcG9ydGVkIGF0IHRoZSBBUEkgYm91bmRhcnkgdGhyb3VnaCBy ZXBvcnRBUElFeGNlcHRpb24uCisgICAgLy8gVW50aWwgYSB0aW1lIGNvbWVzIHdoZXJlIGFuIGV4 Y2VwdGlvbiBjYW4gYmUgY2F1c2VkIG91dHNpZGUgb2YgdGhlIEFQSSAoZS5nLiBzZXRUaW1lb3V0 CisgICAgLy8gb3Igc29tZSBvdGhlciBhc3luYyBvcGVyYXRpb24gaW4gYSBwdXJlIEpTQ29udGV4 dCkgd2UgY2FuIGlnbm9yZSBleGNlcHRpb25zIHJlcG9ydGVkIGhlcmUuCiAgICAgdmlydHVhbCB2 b2lkIHJlcG9ydEV4Y2VwdGlvbihKU0M6OkV4ZWNTdGF0ZSosIEpTQzo6SlNWYWx1ZSkgY29uc3Qg b3ZlcnJpZGUgeyB9CiAKICAgICBMaXN0ZW5lclNldCBtX2xpc3RlbmVyczsKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0pTR2xvYmFsT2JqZWN0RGVi dWdnZXJBZ2VudC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSlNH bG9iYWxPYmplY3REZWJ1Z2dlckFnZW50LmgKaW5kZXggMTcwYWQ1My4uMjdlZTZhYyAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSlNHbG9iYWxPYmpl Y3REZWJ1Z2dlckFnZW50LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9h Z2VudHMvSlNHbG9iYWxPYmplY3REZWJ1Z2dlckFnZW50LmgKQEAgLTUwLDcgKzUwLDggQEAgcHVi bGljOgogCiAgICAgdmlydHVhbCB2b2lkIGJyZWFrcG9pbnRBY3Rpb25Mb2coSlNDOjpFeGVjU3Rh dGUqLCBjb25zdCBTdHJpbmcmKSBvdmVycmlkZTsKIAotICAgIC8vIEZJWE1FOiBKYXZhU2NyaXB0 IGluc3BlY3RvciBkb2VzIG5vdCB5ZXQgaGF2ZSBhIGNvbnNvbGUgb2JqZWN0IHRvIG11dGUuCisg ICAgLy8gTk9URTogSmF2YVNjcmlwdCBpbnNwZWN0b3IgZG9lcyBub3QgeWV0IG5lZWQgdG8gbXV0 ZSBhIGNvbnNvbGUgYmVjYXVzZSBubyBtZXNzYWdlcworICAgIC8vIGFyZSBzZW50IHRvIHRoZSBj b25zb2xlIG91dHNpZGUgb2YgdGhlIEFQSSBib3VuZGFyeSBvciBjb25zb2xlIG9iamVjdC4KICAg ICB2aXJ0dWFsIHZvaWQgbXV0ZUNvbnNvbGUoKSBvdmVycmlkZSB7IH0KICAgICB2aXJ0dWFsIHZv aWQgdW5tdXRlQ29uc29sZSgpIG92ZXJyaWRlIHsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2VudC5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSlNHbG9iYWxPYmplY3RS dW50aW1lQWdlbnQuaAppbmRleCBkODdmZDJhLi4wZTcyZTA5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2Vu dC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0pTR2xvYmFs T2JqZWN0UnVudGltZUFnZW50LmgKQEAgLTQ3LDcgKzQ3LDggQEAgcHVibGljOgogICAgIHZpcnR1 YWwgSlNDOjpWTSYgZ2xvYmFsVk0oKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIEluamVjdGVkU2Ny aXB0IGluamVjdGVkU2NyaXB0Rm9yRXZhbChFcnJvclN0cmluZyosIGNvbnN0IGludCogZXhlY3V0 aW9uQ29udGV4dElkKSBvdmVycmlkZTsKIAotICAgIC8vIEZJWE1FOiBKYXZhU2NyaXB0IGluc3Bl Y3RvciBkb2VzIG5vdCB5ZXQgaGF2ZSBhIGNvbnNvbGUgb2JqZWN0IHRvIG11dGUuCisgICAgLy8g Tk9URTogSmF2YVNjcmlwdCBpbnNwZWN0b3IgZG9lcyBub3QgeWV0IG5lZWQgdG8gbXV0ZSBhIGNv bnNvbGUgYmVjYXVzZSBubyBtZXNzYWdlcworICAgIC8vIGFyZSBzZW50IHRvIHRoZSBjb25zb2xl IG91dHNpZGUgb2YgdGhlIEFQSSBib3VuZGFyeSBvciBjb25zb2xlIG9iamVjdC4KICAgICB2aXJ0 dWFsIHZvaWQgbXV0ZUNvbnNvbGUoKSBvdmVycmlkZSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgdW5t dXRlQ29uc29sZSgpIG92ZXJyaWRlIHsgfQogCg==