131374 2014-04-08 10:56:11 -0700 [Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element 2014-04-08 11:05:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 998653 0 mitz 2014-04-08 10:56:11 -0700 [Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element 998654 1 228856 mitz 2014-04-08 11:01:55 -0700 Created attachment 228856 Add -[WKWebProcessPlugInNodeHandle isTextField] 998656 2 228856 andersca 2014-04-08 11:03:21 -0700 Comment on attachment 228856 Add -[WKWebProcessPlugInNodeHandle isTextField] View in context: https://bugs.webkit.org/attachment.cgi?id=228856&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:45 > +@property (nonatomic, readonly, getter=isTextField) BOOL textField; I think we should follow the pattern from JSValue here and make this a method named isTextField instead of a property. 998657 3 mitz 2014-04-08 11:05:46 -0700 (In reply to comment #2) > (From update of attachment 228856 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228856&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:45 > > +@property (nonatomic, readonly, getter=isTextField) BOOL textField; > > I think we should follow the pattern from JSValue here and make this a method named isTextField instead of a property. Done. Committed <http://trac.webkti.org/r166936>. 228856 2014-04-08 11:01:55 -0700 2014-04-08 11:03:20 -0700 Add -[WKWebProcessPlugInNodeHandle isTextField] bug-131374-20140408110134.patch text/plain 4112 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjkzNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA0LTA4ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBZGQgYSB3YXkgdG8g dGVsbCB3aGV0aGVyIGEgV0tXZWJQcm9jZXNzUGx1Z0luTm9kZUhhbmRsZSBpcyBhIHRleHQtdHlw ZSBIVE1MIGlucHV0IGVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMTM3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQ cm9jZXNzUGx1Z0luTm9kZUhhbmRsZS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbk5vZGVIYW5kbGUubW06CisgICAgICAg ICgtW1dLV2ViUHJvY2Vzc1BsdWdJbk5vZGVIYW5kbGUgaXNUZXh0RmllbGRdKTogQWRkZWQgdGhp cyBnZXR0ZXIuIENhbGxzCisgICAgICAgIEluamVjdGVkQnVuZGxlTm9kZUhhbmRsZTo6aXNUZXh0 RmllbGQuCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRC dW5kbGVOb2RlSGFuZGxlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGVOb2Rl SGFuZGxlOjppc1RleHRGaWVsZCk6IEFkZGVkLiBVc2VzCisgICAgICAgIFdlYkNvcmU6OkhUTUxJ bnB1dEVsZW1lbnQ6OmlzVGV4dCwgd2hpY2ggaXMgY29uc2lzdGVudCB3aXRoIHdoYXQKKyAgICAg ICAgV2ViQ2hyb21lQ2xpZW50Ojpmb2N1c2VkRWxlbWVudENoYW5nZWQgdXNlcyB0byBkZWNpZGUg d2hldGhlciB0byBjYWxsIGRpZEZvY3VzVGV4dEZpZWxkLgorICAgICAgICAqIFdlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxlTm9kZUhhbmRsZS5oOgorCiAyMDE0LTA0 LTA4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBB ZGQgYSBfY2VydGlmaWNhdGVDaGFpbiBwcm9wZXJ0eSB0byBXS1dlYlByb2Nlc3NQbHVnSW5GcmFt ZQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29j b2EvV0tXZWJQcm9jZXNzUGx1Z0luTm9kZUhhbmRsZS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1Bs dWdJbk5vZGVIYW5kbGUuaAkocmV2aXNpb24gMTY2OTI5KQorKysgU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luTm9kZUhh bmRsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0Miw3IEBAIFdLX0FQSV9DTEFTUwogQHBy b3BlcnR5IChub25hdG9taWMpIEJPT0wgSFRNTElucHV0RWxlbWVudElzQXV0b0ZpbGxlZDsKIEBw cm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgQk9PTCBIVE1MSW5wdXRFbGVtZW50SXNVc2Vy RWRpdGVkOwogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBCT09MIEhUTUxUZXh0QXJl YUVsZW1lbnRJc1VzZXJFZGl0ZWQ7CitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGdl dHRlcj1pc1RleHRGaWVsZCkgQk9PTCB0ZXh0RmllbGQ7CiBAcHJvcGVydHkgKG5vbmF0b21pYywg cmVhZG9ubHkpIFdLV2ViUHJvY2Vzc1BsdWdJbk5vZGVIYW5kbGUgKkhUTUxUYWJsZUNlbGxFbGVt ZW50Q2VsbEFib3ZlOwogCiBAZW5kCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0lu amVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dlYlByb2Nlc3NQbHVnSW5Ob2RlSGFuZGxlLm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ L0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJbk5vZGVIYW5kbGUubW0JKHJldmlzaW9uIDE2NjkyOSkK KysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dL V2ViUHJvY2Vzc1BsdWdJbk5vZGVIYW5kbGUubW0JKHdvcmtpbmcgY29weSkKQEAgLTg4LDYgKzg4 LDExIEBAIC0gKEJPT0wpSFRNTFRleHRBcmVhRWxlbWVudElzVXNlckVkaXRlZAogICAgIHJldHVy biBfbm9kZUhhbmRsZS0+aHRtbFRleHRBcmVhRWxlbWVudExhc3RDaGFuZ2VXYXNVc2VyRWRpdCgp OwogfQogCistIChCT09MKWlzVGV4dEZpZWxkCit7CisgICAgcmV0dXJuIF9ub2RlSGFuZGxlLT5p c1RleHRGaWVsZCgpOworfQorCiAtIChXS1dlYlByb2Nlc3NQbHVnSW5Ob2RlSGFuZGxlICopSFRN TFRhYmxlQ2VsbEVsZW1lbnRDZWxsQWJvdmUKIHsKICAgICBhdXRvIG5vZGVIYW5kbGUgPSBfbm9k ZUhhbmRsZS0+aHRtbFRhYmxlQ2VsbEVsZW1lbnRDZWxsQWJvdmUoKTsKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxlTm9kZUhh bmRsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlLmNwcAkocmV2aXNpb24gMTY2OTI5 KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0 ZWRCdW5kbGVOb2RlSGFuZGxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE1LDYgKzIxNSwxMSBA QCBib29sIEluamVjdGVkQnVuZGxlTm9kZUhhbmRsZTo6aHRtbFRleHRBCiAgICAgcmV0dXJuIHRv SFRNTFRleHRBcmVhRWxlbWVudChtX25vZGUuZ2V0KCkpLT5sYXN0Q2hhbmdlV2FzVXNlckVkaXQo KTsKIH0KIAorYm9vbCBJbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGU6OmlzVGV4dEZpZWxkKCkgY29u c3QKK3sKKyAgICByZXR1cm4gaXNIVE1MSW5wdXRFbGVtZW50KG1fbm9kZS5nZXQoKSkgJiYgdG9I VE1MSW5wdXRFbGVtZW50KG1fbm9kZS5nZXQoKSktPmlzVGV4dCgpOworfQorCiBQYXNzUmVmUHRy PEluamVjdGVkQnVuZGxlTm9kZUhhbmRsZT4gSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlOjpodG1s VGFibGVDZWxsRWxlbWVudENlbGxBYm92ZSgpCiB7CiAgICAgaWYgKCFtX25vZGUtPmhhc1RhZ05h bWUodGRUYWcpKQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs ZS9ET00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFu ZGxlLmgJKHJldmlzaW9uIDE2NjkyOSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxlTm9kZUhhbmRsZS5oCSh3b3JraW5nIGNvcHkp CkBAIC02Niw2ICs2Niw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldEhUTUxJbnB1dEVsZW1lbnRB dXRvZmlsbGVkKGJvb2wpOwogICAgIGJvb2wgaHRtbElucHV0RWxlbWVudExhc3RDaGFuZ2VXYXNV c2VyRWRpdCgpOwogICAgIGJvb2wgaHRtbFRleHRBcmVhRWxlbWVudExhc3RDaGFuZ2VXYXNVc2Vy RWRpdCgpOworICAgIGJvb2wgaXNUZXh0RmllbGQoKSBjb25zdDsKICAgICAKICAgICBQYXNzUmVm UHRyPEluamVjdGVkQnVuZGxlTm9kZUhhbmRsZT4gaHRtbFRhYmxlQ2VsbEVsZW1lbnRDZWxsQWJv dmUoKTsKIAo=