131372 2014-04-08 10:45:01 -0700 Refactor to make JSMainThreadExecState's constructor and destructor private 2014-04-08 12:13:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 998643 0 mark.lam 2014-04-08 10:45:01 -0700 This is in preparation for subsequent patches to ensure that we don't exit the VM with an exception still pending. 998648 1 228854 mark.lam 2014-04-08 10:48:49 -0700 Created attachment 228854 the patch. 998650 2 228854 mhahnenberg 2014-04-08 10:52:58 -0700 Comment on attachment 228854 the patch. r=me 998694 3 mark.lam 2014-04-08 12:13:58 -0700 Thanks. Landed in r166943: <http://trac.webkit.org/r166943>. 228854 2014-04-08 10:48:49 -0700 2014-04-08 10:52:57 -0700 the patch. bug-131372.patch text/plain 2783 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjkzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTA4ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZWZhY3RvciB0byBtYWtlIEpTTWFp blRocmVhZEV4ZWNTdGF0ZSdzIGNvbnN0cnVjdG9yIGFuZCBkZXN0cnVjdG9yIHByaXZhdGUuCisg ICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzEzNzI+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBpbiBwcmVwYXJhdGlvbiBmb3Ig c3Vic2VxdWVudCBwYXRjaGVzIHRvIGVuc3VyZSB0aGF0IHdlIGRvbid0CisgICAgICAgIGV4aXQg dGhlIFZNIHdpdGggYW4gZXhjZXB0aW9uIHN0aWxsIHBlbmRpbmcuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIHJlcXVpcmVkLiAgVGhpcyBpcyBvbmx5IGEgcmVmYWN0b3Igb2YgZXhpc3RpbmcgYmVo YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdFRhc2suY3Bw OgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTTWFpblRocmVhZEV4ZWNTdGF0ZS5oOgorICAgICAg ICAoV2ViQ29yZTo6SlNNYWluVGhyZWFkRXhlY1N0YXRlOjpydW5UYXNrKToKKwogMjAxNC0wNC0w OCAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0BvdXRsb29rLmNvbT4KIAogICAgICAgICBbV2lu Q2Fpcm9dIENvbXBpbGUgZXJyb3IgaW4gVGV4dHVyZU1hcHBlci5oCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdFRhc2suY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NR2xvYmFsT2JqZWN0VGFzay5jcHAJKHJl dmlzaW9uIDE2Njg4NikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NR2xvYmFs T2JqZWN0VGFzay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDEwICs2MCw5IEBAIHB1YmxpYzoK IAogICAgICAgICAvLyBXaGVuIG9uIHRoZSBtYWluIHRocmVhZCAoZS5nLiB0aGUgZG9jdW1lbnQn cyB0aHJlYWQpLCB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSB0bwogICAgICAgICAvLyBwdXNoIHRoZSBj dXJyZW50IEV4ZWNTdGF0ZSBvbiB0byB0aGUgSlNNYWluVGhyZWFkRXhlY1N0YXRlIHN0YWNrLgot ICAgICAgICBpZiAoY29udGV4dC0+aXNEb2N1bWVudCgpKSB7Ci0gICAgICAgICAgICBKU01haW5U aHJlYWRFeGVjU3RhdGUgY3VycmVudFN0YXRlKGV4ZWMpOwotICAgICAgICAgICAgbV90YXNrLT5y dW4oZXhlYyk7Ci0gICAgICAgIH0gZWxzZQorICAgICAgICBpZiAoY29udGV4dC0+aXNEb2N1bWVu dCgpKQorICAgICAgICAgICAgSlNNYWluVGhyZWFkRXhlY1N0YXRlOjpydW5UYXNrKGV4ZWMsICpt X3Rhc2suZ2V0KCkpOworICAgICAgICBlbHNlCiAgICAgICAgICAgICBtX3Rhc2stPnJ1bihleGVj KTsKICAgICB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTWFpblRocmVh ZEV4ZWNTdGF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT TWFpblRocmVhZEV4ZWNTdGF0ZS5oCShyZXZpc2lvbiAxNjY4ODYpCisrKyBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU01haW5UaHJlYWRFeGVjU3RhdGUuaAkod29ya2luZyBjb3B5KQpAQCAt MjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSAiSlNET01CaW5kaW5nLmgiCiAjaW5jbHVkZSA8cnVu dGltZS9Db21wbGV0aW9uLmg+CisjaW5jbHVkZSA8cnVudGltZS9NaWNyb3Rhc2suaD4KICNpbmNs dWRlIDx3dGYvTWFpblRocmVhZC5oPgogCiAjaWYgUExBVEZPUk0oSU9TKQpAQCAtNjIsOCArNjMs MTUgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gSlNDOjpldmFsdWF0ZShleGVjLCBzb3VyY2Us IHRoaXNWYWx1ZSwgZXhjZXB0aW9uKTsKICAgICB9OwogCisgICAgc3RhdGljIHZvaWQgcnVuVGFz ayhKU0M6OkV4ZWNTdGF0ZSogZXhlYywgSlNDOjpNaWNyb3Rhc2smIHRhc2spCisgICAgeworICAg ICAgICBKU01haW5UaHJlYWRFeGVjU3RhdGUgY3VycmVudFN0YXRlKGV4ZWMpOworICAgICAgICB0 YXNrLnJ1bihleGVjKTsKKyAgICB9CisKICAgICBzdGF0aWMgSW5zcGVjdG9ySW5zdHJ1bWVudGF0 aW9uQ29va2llIGluc3RydW1lbnRGdW5jdGlvbkNhbGwoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCos IEpTQzo6Q2FsbFR5cGUsIGNvbnN0IEpTQzo6Q2FsbERhdGEmKTsKIAorcHJpdmF0ZToKICAgICBl eHBsaWNpdCBKU01haW5UaHJlYWRFeGVjU3RhdGUoSlNDOjpFeGVjU3RhdGUqIGV4ZWMpCiAgICAg ICAgIDogbV9wcmV2aW91c1N0YXRlKHNfbWFpblRocmVhZFN0YXRlKQogICAgIHsKQEAgLTgzLDcg KzkxLDYgQEAgcHVibGljOgogICAgICAgICAgICAgZGlkTGVhdmVTY3JpcHRDb250ZXh0KCk7CiAg ICAgfQogCi1wcml2YXRlOgogICAgIHN0YXRpYyBKU0M6OkV4ZWNTdGF0ZSogc19tYWluVGhyZWFk U3RhdGU7CiAgICAgSlNDOjpFeGVjU3RhdGUqIG1fcHJldmlvdXNTdGF0ZTsKIAo=