131360 2014-04-08 08:26:52 -0700 [WinCairo] Compile error in TextureMapper.h 2014-04-08 09:40:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 131276 1 peavo webkit-unassigned achristensen bfulgham cmarcelo commit-queue kondapallykalyan luiz noam ossy oldest_to_newest 998570 0 peavo 2014-04-08 08:26:52 -0700 I'm getting this compile error, when compiling WinCairo: "error C2259: 'WebCore::TextureMapper' : cannot instantiate abstract class" The TextureMapper class has pure virtual methods, and cannot be instantiated. 998576 1 228839 peavo 2014-04-08 08:32:33 -0700 Created attachment 228839 Patch 998584 2 bfulgham 2014-04-08 08:59:15 -0700 This looks fine, but I'll wait for the EFL EWS bot to run before approving. 998587 3 bfulgham 2014-04-08 09:08:45 -0700 Caused by Bug 131276. 998590 4 228839 bfulgham 2014-04-08 09:10:40 -0700 Comment on attachment 228839 Patch r=me. Let's keep an eye on EFL to make sure nothing breaks there. GTK already looks good. 998594 5 peavo 2014-04-08 09:16:46 -0700 (In reply to comment #4) > (From update of attachment 228839 [details]) > r=me. Let's keep an eye on EFL to make sure nothing breaks there. GTK already looks good. Thanks :) 998611 6 228839 commit-queue 2014-04-08 09:40:30 -0700 Comment on attachment 228839 Patch Clearing flags on attachment: 228839 Committed r166931: <http://trac.webkit.org/changeset/166931> 998612 7 commit-queue 2014-04-08 09:40:34 -0700 All reviewed patches have been landed. Closing bug. 228839 2014-04-08 08:32:33 -0700 2014-04-08 09:40:30 -0700 Patch bug-131360-20140408173205.patch text/plain 1296 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjkyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTA4ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvciBpbiBUZXh0dXJlTWFwcGVyLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTM2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBUZXh0dXJlTWFwcGVyIGNsYXNzIGhhcyBwdXJlIHZp cnR1YWwgbWV0aG9kcywgYW5kIGNhbm5vdCBiZSBpbnN0YW50aWF0ZWQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlci5oOgorICAgICAgICAoV2ViQ29y ZTo6VGV4dHVyZU1hcHBlcjo6cGxhdGZvcm1DcmVhdGVBY2NlbGVyYXRlZCk6CisKIDIwMTQtMDQt MDggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBTdWJwaXhlbCBy ZW5kZXJpbmc6IFBhaW50IHRoZSBmaWx0ZXIgZWZmZWN0IHJlc3VsdCBpbWFnZSBvbiBkZXZpY2Ug cGl4ZWwgcG9zaXRpb24uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvVGV4dHVyZU1hcHBlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyLmgJKHJldmlzaW9uIDE2NjkyNikKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyLmgJ KHdvcmtpbmcgY29weSkKQEAgLTE3Nyw3ICsxNzcsNyBAQCBwcml2YXRlOgogI2Vsc2UKICAgICBz dGF0aWMgc3RkOjp1bmlxdWVfcHRyPFRleHR1cmVNYXBwZXI+IHBsYXRmb3JtQ3JlYXRlQWNjZWxl cmF0ZWQoKQogICAgIHsKLSAgICAgICAgcmV0dXJuIHN0ZDo6bWFrZV91bmlxdWU8VGV4dHVyZU1h cHBlcj4oKTsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQogI2VuZGlmCiAgICAgSW50 ZXJwb2xhdGlvblF1YWxpdHkgbV9pbnRlcnBvbGF0aW9uUXVhbGl0eTsK