131344 2014-04-07 20:52:00 -0700 Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences 2014-04-08 09:02:05 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 131258 1 bfulgham bfulgham bfulgham calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 998409 0 bfulgham 2014-04-07 20:52:00 -0700 The caption user preferences can be configured so that captions are always displayed. When this happens, we need to make sure that the JS API for 'webkitClosedCaptionsVisible' correctly reflects the state of this setting. If captions are being displayed on the page, 'webkitClosedCaptionsVisible' must indicate true. Likewise, if captions are hidden it should return false. Bug 131258 dealt with the state of 'webkitClosedCaptionsVisible' when changes were made to the user preferences. However, an edge condition at initial load of a webpage was not properly handled. This bug corrects that additional case. 998410 1 bfulgham 2014-04-07 20:52:21 -0700 <rdar://problem/15745400> 998412 2 228799 bfulgham 2014-04-07 20:56:04 -0700 Created attachment 228799 Patch 998585 3 bfulgham 2014-04-08 09:02:05 -0700 Committed r166927: <http://trac.webkit.org/changeset/166927> 228799 2014-04-07 20:56:04 -0700 2014-04-08 08:01:29 -0700 Patch bug-131344-20140407205543.patch text/plain 1691 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjkwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTA3ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEtlZXAgJ3dlYmtpdENsb3Nl ZENhcHRpb25zVmlzaWJsZScgQVBJIGluIHN5bmMgd2l0aCBjYXB0aW9ucyBkaXNwbGF5IHByZWZl cmVuY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzEzNDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFF bGVtZW50Ojpjb25maWd1cmVUZXh0VHJhY2tHcm91cCkgSWYgd2UgZGVjaWRlIHRoYXQgY2FwdGlv bnMgc2hvdWxkCisgICAgICAgIGJlIGFjdGl2ZSAoZHVlIHRvIHVzZXIgcHJlZmVyZW5jZXMpIG1h a2Ugc3VyZSB0aGUgJ3dlYmtpdENsb3NlZENhcHRpb25zVmlzaWJsZScgc3RhdGUKKyAgICAgICAg aXMgdHVybmVkIG9uLgorCiAyMDE0LTA0LTA3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25A aWdhbGlhLmNvbT4KIAogICAgICAgICBmYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtZGVjb3JhdGlv bi90ZXh0LWRlY29yYXRpb24tdGhpY2tuZXNzLmh0bWwgZmFpbHMgb24gR1RLCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHJldmlzaW9uIDE2Njg4OCkKKysr IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTM2NzAsOSArMzY3MCwxNSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmNvbmZpZ3VyZVRl eHRUcmFjCiAgICAgICAgIH0KICAgICB9CiAKLSAgICBpZiAodHJhY2tUb0VuYWJsZSkKKyAgICBp ZiAodHJhY2tUb0VuYWJsZSkgewogICAgICAgICB0cmFja1RvRW5hYmxlLT5zZXRNb2RlKFRleHRU cmFjazo6c2hvd2luZ0tleXdvcmQoKSk7CiAKKyAgICAgICAgLy8gSWYgdXNlciBwcmVmZXJlbmNl cyBpbmRpY2F0ZSB3ZSBzaG91bGQgYWx3YXlzIGRpc3BsYXkgY2FwdGlvbnMsIG1ha2Ugc3VyZSB3 ZSByZWZsZWN0IHRoZQorICAgICAgICAvLyBwcm9wZXIgc3RhdHVzIHZpYSB0aGUgd2Via2l0Q2xv c2VkQ2FwdGlvbnNWaXNpYmxlIEFQSSBjYWxsOgorICAgICAgICBpZiAoIXdlYmtpdENsb3NlZENh cHRpb25zVmlzaWJsZSgpICYmIGNsb3NlZENhcHRpb25zVmlzaWJsZSgpICYmIGRpc3BsYXlNb2Rl ID09IENhcHRpb25Vc2VyUHJlZmVyZW5jZXM6OkFsd2F5c09uKQorICAgICAgICAgICAgbV93ZWJr aXRMZWdhY3lDbG9zZWRDYXB0aW9uT3ZlcnJpZGUgPSB0cnVlOworICAgIH0KKwogICAgIG1fcHJv Y2Vzc2luZ1ByZWZlcmVuY2VDaGFuZ2UgPSBmYWxzZTsKIH0KIAo=