131327 2014-04-07 17:00:42 -0700 webkit-patch upload scrapes incorrect bug id when provided with non-head git hash 2024-03-26 17:17:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 burg webkit-unassigned ahmad.saleem792 bburg bfan2 gsnedders llango.u-szeged ossy oldest_to_newest 998296 0 burg 2014-04-07 17:00:42 -0700 I have two commits ahead of master, [burg@burg183 webkit-trunk]# git log --oneline -3 311dc75 fix for 131318 f1b1dbf fix for 131324 origin/master f4b81a7 Make Mac only parts of TelephoneNumberOverlayController PLATFORM(MAC). and do `webkit-patch upload -g f1b1dbf`. It then uploads f1b1dbf to bug 131318. It should have scraped 131324. 1011961 1 232129 jberta.u-szeged 2014-05-27 07:43:03 -0700 Created attachment 232129 Patch 1013516 2 232540 jberta.u-szeged 2014-06-05 05:50:57 -0700 Created attachment 232540 WIP Patch 2024053 3 ahmad.saleem792 2024-03-26 17:17:14 -0700 @Sam & @Brianna - is this still applicable? 232129 2014-05-27 07:43:03 -0700 2014-06-05 05:50:57 -0700 Patch bug-131327-20140527164239.patch text/plain 883 jberta.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MDQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWExY2VmOWI2NzA1YjZjYzRjZjA2ODVhMzllZDgwMmVh MWVlZWFjMC4uMDMzMjEyZGM1ZmRkMzkyNzQxYzJmNTc3MDRmYjgwODliMTFhOTUzNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE0LTA1LTE5ICBKb3pzZWYgQmVydGEgIDxqYmVydGEudS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggdXBsb2FkIHNjcmFwZXMgaW5jb3Jy ZWN0IGJ1ZyBpZCB3aGVuIHByb3ZpZGVkIHdpdGggbm9uLWhlYWQgZ2l0IGhhc2gKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTMyNworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RpbmcsIHBsZWFzZSBp Z25vcmUgdGhpcy4KKworICAgICAgICAqIFNjcmlwdHMvdGVzdC50eHQ6IEFkZGVkLgorCiAyMDE0 LTA1LTE5ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5j b20+CiAKICAgICAgICAgcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIHNob3VsZCBzb3J0IHRoZSBs aXN0IG9mIGZhaWxpbmcgc3RyZXNzIHRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3Rl c3QudHh0IGIvVG9vbHMvU2NyaXB0cy90ZXN0LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lNjlkZTI5YmIyZDFk NjQzNGI4YjI5YWU3NzVhZDhjMmU0OGM1MzkxCg== 232540 2014-06-05 05:50:57 -0700 2014-06-05 05:50:57 -0700 WIP Patch patch2.diff text/plain 2772 jberta.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoZWNr b3V0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hlY2tvdXQu cHkKaW5kZXggZjIzNTMzNC4uMGE1ZTVmMSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY2hlY2tvdXQvY2hlY2tvdXQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY2hlY2tvdXQvY2hlY2tvdXQucHkKQEAgLTI3LDYgKzI3LDcgQEAKICMgT0Yg VEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNI IERBTUFHRS4KIAogaW1wb3J0IFN0cmluZ0lPCitpbXBvcnQgcmUKIAogZnJvbSB3ZWJraXRweS5j b21tb24uY29uZmlnIGltcG9ydCB1cmxzCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5jaGVja291dC5j aGFuZ2Vsb2cgaW1wb3J0IENoYW5nZUxvZywgcGFyc2VfYnVnX2lkX2Zyb21fY2hhbmdlbG9nCkBA IC0xNTIsNiArMTUzLDI0IEBAIGNsYXNzIENoZWNrb3V0KG9iamVjdCk6CiAgICAgICAgIGV4Y2Vw dCBTY3JpcHRFcnJvciwgZToKICAgICAgICAgICAgIHBhc3MgIyBXZSBtaWdodCBub3QgaGF2ZSBD aGFuZ2VMb2dzLgogCisgICAgIyBGSVhNRTogSWYgdGhlIGNvbW1pdF9tZXNzYWdlX2Zvcl90aGlz X2NvbW1pdCBjb3VsZCBnZXQgdGhlIGFwcHJvcHJpYXRlIGNvbW1pdCBtZXNzYWdlIGZyb20gY29t bWl0LWxvZy1lZGl0b3IsIHRoZXNlIGZ1bmN0aW9ucyB3b3VsZG4ndCBiZSBuZWNlc3NhcnkuCisg ICAgZGVmIHJlbW92ZV9kaWZmX3JlbGF0ZWRfdGhpbmdzKHNlbGYsIGRpZmYpOgorICAgICAgICBh ZGRlZF9saW5lX3JlZ2V4ID0gcmUuY29tcGlsZSgnXlwrKD8hXCt8WzAtOV0pJykKKyAgICAgICAg YWRkZWRfbGluZV9ncm91cCA9IHJlLmNvbXBpbGUoJyhcKyAqKSguKiknKQorICAgICAgICBkaWZm X2hlYWRlcl9yZW1vdmVkID0gZmlsdGVyKGxhbWJkYSB4OiBhZGRlZF9saW5lX3JlZ2V4Lm1hdGNo KHgpLCBkaWZmLnNwbGl0bGluZXMoKSkKKyAgICAgICAgbGluZV9zdGFydGVyX3JlbW92ZWQgPSBb YWRkZWRfbGluZV9ncm91cC5tYXRjaCh4KS5ncm91cCgyKSBmb3IgeCBpbiBkaWZmX2hlYWRlcl9y ZW1vdmVkXQorICAgICAgICByZXR1cm4gbGluZV9zdGFydGVyX3JlbW92ZWQKKworICAgIGRlZiBi dWdfaWRfZm9yX2NvbW1pdChzZWxmLCBnaXRfY29tbWl0LCBjaGFuZ2VkX2ZpbGVzPU5vbmUpOgor ICAgICAgICBpZiBzZWxmLl9zY20uZGlzcGxheV9uYW1lKCkgIT0gImdpdCI6CisgICAgICAgICAg ICBzZWxmLmJ1Z19pZF9mb3JfdGhpc19jb21taXQoZ2l0X2NvbW1pdCwgY2hhbmdlZF9maWxlcykK KworICAgICAgICBjaGFuZ2Vsb2dzID0gZmlsdGVyKGxhbWJkYSB4OiByZS5tYXRjaChyIi4qQ2hh bmdlTG9nIiwgeCksIGNoYW5nZWRfZmlsZXMpCisgICAgICAgIGNoYW5nZWxvZ19kaWZmcyA9IHNl bGYuX3NjbS5jcmVhdGVfcGF0Y2goZ2l0X2NvbW1pdCwgY2hhbmdlbG9ncykuc3BsaXQociJkaWZm IC0tZ2l0IikKKyAgICAgICAgY2hhbmdlbG9nX2NvbnRlbnRzID0gW3NlbGYucmVtb3ZlX2RpZmZf cmVsYXRlZF90aGluZ3MoZGlmZikgZm9yIGRpZmYgaW4gY2hhbmdlbG9nX2RpZmZzXQorICAgICAg ICBtZXNzYWdlID0gQ29tbWl0TWVzc2FnZShbY2hhbmdlbG9nX2NvbnRlbnRzW3hdW3ldIGZvciB4 IGluIHJhbmdlKDEsIGxlbihjaGFuZ2Vsb2dfY29udGVudHMpKSBmb3IgeSBpbiByYW5nZSgwLCBs ZW4oY2hhbmdlbG9nX2NvbnRlbnRzW3hdKSldKS5tZXNzYWdlKCkKKyAgICAgICAgcmV0dXJuIHBh cnNlX2J1Z19pZF9mcm9tX2NoYW5nZWxvZyhtZXNzYWdlKQorCiAgICAgZGVmIGFwcGx5X3BhdGNo KHNlbGYsIHBhdGNoKToKICAgICAgICAgIyBJdCdzIHBvc3NpYmxlIHRoYXQgdGhlIHBhdGNoIHdh cyBub3QgbWFkZSBmcm9tIHRoZSByb290IGRpcmVjdG9yeS4KICAgICAgICAgIyBXZSBzaG91bGQg ZGV0ZWN0IGFuZCBoYW5kbGUgdGhhdCBjYXNlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL3VwbG9hZC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9jb21tYW5kcy91cGxvYWQucHkKaW5kZXggNjlkYzRmNy4uNzA4MzlkOCAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3VwbG9hZC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkLnB5CkBAIC0xOTYsNyAr MTk2LDcgQEAgY2xhc3MgQWJzdHJhY3RQYXRjaFVwbG9hZGluZ0NvbW1hbmQoQWJzdHJhY3RTZXF1 ZW5jZWRDb21tYW5kKToKICAgICAgICAgaWYgbm90IGJ1Z19pZDoKICAgICAgICAgICAgIGNoYW5n ZWRfZmlsZXMgPSBzZWxmLl90b29sLnNjbSgpLmNoYW5nZWRfZmlsZXMob3B0aW9ucy5naXRfY29t bWl0KQogICAgICAgICAgICAgc3RhdGVbImNoYW5nZWRfZmlsZXMiXSA9IGNoYW5nZWRfZmlsZXMK LSAgICAgICAgICAgIGJ1Z19pZCA9IHRvb2wuY2hlY2tvdXQoKS5idWdfaWRfZm9yX3RoaXNfY29t bWl0KG9wdGlvbnMuZ2l0X2NvbW1pdCwgY2hhbmdlZF9maWxlcykKKyAgICAgICAgICAgIGJ1Z19p ZCA9IHRvb2wuY2hlY2tvdXQoKS5idWdfaWRfZm9yX2NvbW1pdChvcHRpb25zLmdpdF9jb21taXQs IGNoYW5nZWRfZmlsZXMpCiAgICAgICAgIHJldHVybiBidWdfaWQKIAogICAgIGRlZiBfcHJlcGFy ZV9zdGF0ZShzZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToK