131323 2014-04-07 16:04:28 -0700 REGRESSION (r163194-r163227): Garbage tiles in overflow of RTL page with background image 2022-10-25 13:22:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin ahmad.saleem792 bdakin commit-queue esprehn+autocc glenn kondapallykalyan mitz simon.fraser thorton oldest_to_newest 998271 0 bdakin 2014-04-07 16:04:28 -0700 RTL pages with margin tiles (repeating background image) have garbage pixels. <rdar://problem/16402013> 998276 1 228768 bdakin 2014-04-07 16:17:16 -0700 Created attachment 228768 Patch 998632 2 228768 ap 2014-04-08 10:22:08 -0700 Comment on attachment 228768 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228768&action=review > Source/WebCore/ChangeLog:7 > + REGRESSION (r163194-r163227): Garbage tiles in overflow of RTL page with > + background image > + https://bugs.webkit.org/show_bug.cgi?id=131323 > + -and corresponding- > + <rdar://problem/16402013> This can't be tested, can it? 1908204 3 ahmad.saleem792 2022-10-25 13:22:05 -0700 Landed and didn't backed out - https://github.com/WebKit/WebKit/commit/9cab94a05940e230853f6089309a0e8e9776de38 Marking this as "RESOLVED FIXED". 228768 2014-04-07 16:17:16 -0700 2014-04-08 10:22:08 -0700 Patch for-review.txt text/plain 4569 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Njg5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDE0LTA0LTA3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTYzMTk0LXIx NjMyMjcpOiBHYXJiYWdlIHRpbGVzIGluIG92ZXJmbG93IG9mIFJUTCBwYWdlIHdpdGggCisgICAg ICAgIGJhY2tncm91bmQgaW1hZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzMTMyMworICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xNjQwMjAxMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZXR1cm5pbmcgdGhlIFRpbGVkQmFja2luZzo6Ym91bmRzKCkg Zm9yIHRoZSAKKyAgICAgICAgRnJhbWVWaWV3OjpleHRlbmRlZEJhY2tncm91bmRSZWN0Rm9yUGFp bnRpbmcoKSBpbiBjb252ZW5pZW50IGZvciBsdHIgcGFnZXMsIGJ1dCBpdCAKKyAgICAgICAgaXMg c2ltcGx5IGluY29ycmVjdCBpbiBydGwuIFRoZXJlIGlzIG5vIGVhc3kgd2F5IHRvIG1hcCB0aGUg cmVjdCBpbnRvIHRoZSByaWdodCAKKyAgICAgICAgY29vcmRpbmF0ZSBzcGFjZSwgc28gdGhpcyBw YXRjaCByZS13b3JrcyB0aGUgY29kZSB0byB1c2UgY29tcHV0YXRpb25zIGluIAorICAgICAgICBS ZW5kZXJWaWV3IHRvIGdldCB0aGUgcmlnaHQgcmVjdC4KKworICAgICAgICBDYWxsIFJlbmRlclZp ZXc6OnVuZXh0ZW5kZWRCYWNrZ3JvdW5kUmVjdCgpIGFuZCBleHBhbmQgYW5kIG1vdmUgaXQgYmFz ZWQgb24gdGhlIAorICAgICAgICBUaWxlZEJhY2tpbmfigJlzIG1hcmdpbnMuCisgICAgICAgICog cGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpleHRlbmRl ZEJhY2tncm91bmRSZWN0Rm9yUGFpbnRpbmcpOgorCisgICAgICAgIFRoZSBsb2dpYyB0aGF0IHVz ZWQgdG8gYmUgaW4gYmFja2dyb3VuZFJlY3QoKSBoYXMgYmVlbiBtb3ZlZCB0byAKKyAgICAgICAg dW5leHRlbmRlZEJhY2tncm91bmRSZWN0KCkuIAorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJW aWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZXc6OnVuZXh0ZW5kZWRCYWNrZ3Jv dW5kUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWV3OjpiYWNrZ3JvdW5kUmVjdCk6 CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcuaDoKKwogMjAxNC0wNC0wNyAgSHlvd29u IEtpbSAgPGh3MTAwOC5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgTW92ZSB0byB1c2luZyBz dGQ6OnVuaXF1ZV9wdHIgZm9yIG9wZW5nbCwgdGV4bWFwLCB0cmFuc2Zvcm1zIGFuZCBlZmwgaW4g V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAJKHJldmlzaW9uIDE2Njg3NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjU3NSw4ICsyNTc1LDE4IEBAIEludFJlY3QgRnJhbWVWaWV3 OjpleHRlbmRlZEJhY2tncm91bmRSZWMKICAgICBUaWxlZEJhY2tpbmcqIHRpbGVkQmFja2luZyA9 IHRoaXMtPnRpbGVkQmFja2luZygpOwogICAgIGlmICghdGlsZWRCYWNraW5nKQogICAgICAgICBy ZXR1cm4gSW50UmVjdCgpOwotCi0gICAgcmV0dXJuIHRpbGVkQmFja2luZy0+Ym91bmRzKCk7Cisg ICAgCisgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9IHRoaXMtPnJlbmRlclZpZXcoKTsKKyAg ICBpZiAoIXJlbmRlclZpZXcpCisgICAgICAgIHJldHVybiBJbnRSZWN0KCk7CisgICAgCisgICAg TGF5b3V0UmVjdCBleHRlbmRlZFJlY3QgPSByZW5kZXJWaWV3LT51bmV4dGVuZGVkQmFja2dyb3Vu ZFJlY3QocmVuZGVyVmlldyk7CisgICAgaWYgKCF0aWxlZEJhY2tpbmctPmhhc01hcmdpbnMoKSkK KyAgICAgICAgcmV0dXJuIHBpeGVsU25hcHBlZEludFJlY3QoZXh0ZW5kZWRSZWN0KTsKKyAgICAK KyAgICBleHRlbmRlZFJlY3QubW92ZUJ5KExheW91dFBvaW50KC10aWxlZEJhY2tpbmctPmxlZnRN YXJnaW5XaWR0aCgpLCAtdGlsZWRCYWNraW5nLT50b3BNYXJnaW5IZWlnaHQoKSkpOworICAgIGV4 dGVuZGVkUmVjdC5leHBhbmQoTGF5b3V0U2l6ZSh0aWxlZEJhY2tpbmctPmxlZnRNYXJnaW5XaWR0 aCgpICsgdGlsZWRCYWNraW5nLT5yaWdodE1hcmdpbldpZHRoKCksIHRpbGVkQmFja2luZy0+dG9w TWFyZ2luSGVpZ2h0KCkgKyB0aWxlZEJhY2tpbmctPmJvdHRvbU1hcmdpbkhlaWdodCgpKSk7Cisg ICAgcmV0dXJuIHBpeGVsU25hcHBlZEludFJlY3QoZXh0ZW5kZWRSZWN0KTsKIH0KIAogYm9vbCBG cmFtZVZpZXc6OnNob3VsZFVwZGF0ZVdoaWxlT2Zmc2NyZWVuKCkgY29uc3QKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAJKHJldmlzaW9uIDE2Njg3NSkKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAt OTYwLDExICs5NjAsMTEgQEAgYm9vbCBSZW5kZXJWaWV3Ojpyb290QmFja2dyb3VuZElzRW50aXJl bAogCiAgICAgcmV0dXJuIHJvb3RPYmplY3QtPnJlbmRlcmVyRm9yUm9vdEJhY2tncm91bmQoKS5o YXNFbnRpcmVseUZpeGVkQmFja2dyb3VuZCgpOwogfQotCi1MYXlvdXRSZWN0IFJlbmRlclZpZXc6 OmJhY2tncm91bmRSZWN0KFJlbmRlckJveCogYmFja2dyb3VuZFJlbmRlcmVyKSBjb25zdAorICAg IAorTGF5b3V0UmVjdCBSZW5kZXJWaWV3Ojp1bmV4dGVuZGVkQmFja2dyb3VuZFJlY3QoUmVuZGVy Qm94KiBiYWNrZ3JvdW5kUmVuZGVyZXIpIGNvbnN0CiB7CiAgICAgaWYgKCFoYXNDb2x1bW5zKCkp Ci0gICAgICAgIHJldHVybiBmcmFtZVZpZXcoKS5oYXNFeHRlbmRlZEJhY2tncm91bmRSZWN0Rm9y UGFpbnRpbmcoKSA/IGZyYW1lVmlldygpLmV4dGVuZGVkQmFja2dyb3VuZFJlY3RGb3JQYWludGlu ZygpIDogdW5zY2FsZWREb2N1bWVudFJlY3QoKTsKKyAgICAgICAgcmV0dXJuIHVuc2NhbGVkRG9j dW1lbnRSZWN0KCk7CiAKICAgICBDb2x1bW5JbmZvKiBjb2x1bW5JbmZvID0gdGhpcy0+Y29sdW1u SW5mbygpOwogICAgIExheW91dFJlY3QgYmFja2dyb3VuZFJlY3QoMCwgMCwgY29sdW1uSW5mby0+ ZGVzaXJlZENvbHVtbldpZHRoKCksIGNvbHVtbkluZm8tPmNvbHVtbkhlaWdodCgpICogY29sdW1u SW5mby0+Y29sdW1uQ291bnQoKSk7CkBAIC05NzQsNiArOTc0LDE0IEBAIExheW91dFJlY3QgUmVu ZGVyVmlldzo6YmFja2dyb3VuZFJlY3QoUmUKIAogICAgIHJldHVybiBiYWNrZ3JvdW5kUmVjdDsK IH0KKyAgICAKK0xheW91dFJlY3QgUmVuZGVyVmlldzo6YmFja2dyb3VuZFJlY3QoUmVuZGVyQm94 KiBiYWNrZ3JvdW5kUmVuZGVyZXIpIGNvbnN0Cit7CisgICAgaWYgKCFoYXNDb2x1bW5zKCkgJiYg ZnJhbWVWaWV3KCkuaGFzRXh0ZW5kZWRCYWNrZ3JvdW5kUmVjdEZvclBhaW50aW5nKCkpCisgICAg ICAgIHJldHVybiBmcmFtZVZpZXcoKS5leHRlbmRlZEJhY2tncm91bmRSZWN0Rm9yUGFpbnRpbmco KTsKKworICAgIHJldHVybiB1bmV4dGVuZGVkQmFja2dyb3VuZFJlY3QoYmFja2dyb3VuZFJlbmRl cmVyKTsKK30KIAogSW50UmVjdCBSZW5kZXJWaWV3Ojpkb2N1bWVudFJlY3QoKSBjb25zdAogewpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oCShyZXZpc2lvbiAxNjY4NzUp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oCSh3b3JraW5nIGNvcHkp CkBAIC0xNzYsNiArMTc2LDcgQEAgcHVibGljOgogICAgIGJvb2wgdXNlc0NvbXBvc2l0aW5nKCkg Y29uc3Q7CiAKICAgICBJbnRSZWN0IHVuc2NhbGVkRG9jdW1lbnRSZWN0KCkgY29uc3Q7CisgICAg TGF5b3V0UmVjdCB1bmV4dGVuZGVkQmFja2dyb3VuZFJlY3QoUmVuZGVyQm94KiBiYWNrZ3JvdW5k UmVuZGVyZXIpIGNvbnN0OwogICAgIExheW91dFJlY3QgYmFja2dyb3VuZFJlY3QoUmVuZGVyQm94 KiBiYWNrZ3JvdW5kUmVuZGVyZXIpIGNvbnN0OwogCiAgICAgSW50UmVjdCBkb2N1bWVudFJlY3Qo KSBjb25zdDsK