131321 2014-04-07 16:01:35 -0700 Web Inspector: Hang in debuggable application after receiving WIRPermissionDenied 2014-04-07 16:45:48 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck mrowe timothy webkit-bug-importer oldest_to_newest 998266 0 joepeck 2014-04-07 16:01:35 -0700 Hang seen in application after receiving WIRPermissionDenied message: XPC Connection Queue ... 1000 _xpc_connection_call_event_handler + 58 (libxpc.dylib + 40329) [0x7fff88676d89] 1-1000 1000 Inspector::RemoteInspectorXPCConnection::handleEvent(void*) + 156 (JavaScriptCore + 4603324) [0x10e334dbc] 1-1000 1000 Inspector::RemoteInspector::xpcConnectionReceivedMessage(Inspector::RemoteInspectorXPCConnection*, NSString*, NSDictionary*) + 72 (JavaScriptCore + 4587976) [0x10e3311c8] 1-1000 1000 Inspector::RemoteInspector::stop() + 29 (JavaScriptCore + 4587437) [0x10e330fad] 1-1000 1000 std::__1::mutex::lock() + 9 (libc++.1.dylib + 248623) [0x7fff8f33fb2f] 1-1000 1000 __psynch_mutexwait + 10 (libsystem_kernel.dylib + 90754) [0x7fff95b3f282] 1-1000 *1000 psynch_mtxcontinue + 0 (pthread + 18499) [0xffffff7f80ed2843] 1-1000 Note RemoteInspector::xpcConnectionReceivedMessage took the mutex that Inspector::RemoteInspector::stop is waiting for. It already has the mutex. This is the only place stop() is called (other then the RemoteInspector API). Since stop() takes the lock, we can just move xpcConnectionReceivedMessage's lock after the disjoint branch that calls stop(). 998268 1 webkit-bug-importer 2014-04-07 16:02:21 -0700 <rdar://problem/16545910> 998270 2 228767 joepeck 2014-04-07 16:03:48 -0700 Created attachment 228767 [PATCH] Proposed Fix 998284 3 228767 commit-queue 2014-04-07 16:45:45 -0700 Comment on attachment 228767 [PATCH] Proposed Fix Clearing flags on attachment: 228767 Committed r166891: <http://trac.webkit.org/changeset/166891> 998285 4 commit-queue 2014-04-07 16:45:48 -0700 All reviewed patches have been landed. Closing bug. 228767 2014-04-07 16:03:48 -0700 2014-04-07 16:45:45 -0700 [PATCH] Proposed Fix proposed.patch text/plain 1758 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk0NDk4MGUuLmVjZTlhNGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGFuZyBp biBkZWJ1Z2dhYmxlIGFwcGxpY2F0aW9uIGFmdGVyIHJlY2VpdmluZyBXSVJQZXJtaXNzaW9uRGVu aWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEz MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tOgorICAgICAgICAoSW5zcGVjdG9yOjpS ZW1vdGVJbnNwZWN0b3I6OnhwY0Nvbm5lY3Rpb25SZWNlaXZlZE1lc3NhZ2UpOgorICAgICAgICBB dm9pZCBhdHRlbXB0aW5nIHRvIHRha2UgdGhlIHNhbWUgbG9jayB0d2ljZS4gTW92ZSB0aGUgcmVj ZWl2ZWQgbWVzc2FnZQorICAgICAgICBsb2NrIGdyYWIgYWZ0ZXIgdGhlIFdJUlBlcm1pc3Npb25E ZW5pZWQgYnJhbmNoLCB3aGljaCB0YWtlcyB0aGUgbG9jaworICAgICAgICBpbnNpZGUgUmVtb3Rl SW5zcGVjdG9yOjpzdG9wLgorCiAyMDE0LTA0LTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byBkaXNhYmxlIHNvbWUgb2YgdGhl IEZUTCdzIG1vcmUgaW50ZXJlc3RpbmcgZmVhdHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbSBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3Rvci5tbQppbmRleCA5 MzZhNDQ5Li4yNThhZTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IubW0KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLm1tCkBAIC0yMzksMTMgKzIzOSwxMyBA QCB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6c2V0dXBYUENDb25uZWN0aW9uSWZOZWVkZWQoKQogCiB2 b2lkIFJlbW90ZUluc3BlY3Rvcjo6eHBjQ29ubmVjdGlvblJlY2VpdmVkTWVzc2FnZShSZW1vdGVJ bnNwZWN0b3JYUENDb25uZWN0aW9uKiwgTlNTdHJpbmcgKm1lc3NhZ2VOYW1lLCBOU0RpY3Rpb25h cnkgKnVzZXJJbmZvKQogewotICAgIHN0ZDo6bG9ja19ndWFyZDxzdGQ6Om11dGV4PiBsb2NrKG1f bXV0ZXgpOwotCiAgICAgaWYgKFttZXNzYWdlTmFtZSBpc0VxdWFsVG9TdHJpbmc6V0lSUGVybWlz c2lvbkRlbmllZF0pIHsKICAgICAgICAgc3RvcCgpOwogICAgICAgICByZXR1cm47CiAgICAgfQog CisgICAgc3RkOjpsb2NrX2d1YXJkPHN0ZDo6bXV0ZXg+IGxvY2sobV9tdXRleCk7CisKICAgICBp ZiAoW21lc3NhZ2VOYW1lIGlzRXF1YWxUb1N0cmluZzpXSVJTb2NrZXREYXRhTWVzc2FnZV0pCiAg ICAgICAgIHJlY2VpdmVkRGF0YU1lc3NhZ2UodXNlckluZm8pOwogICAgIGVsc2UgaWYgKFttZXNz YWdlTmFtZSBpc0VxdWFsVG9TdHJpbmc6V0lSU29ja2V0U2V0dXBNZXNzYWdlXSkK