131316 2014-04-07 15:18:21 -0700 [WK2][iOS] Consecutive videos in full screen display only black 2014-04-08 11:24:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim philipj sergio oldest_to_newest 998253 0 jer.noble 2014-04-07 15:18:21 -0700 [WK2][iOS] Consecutive videos in full screen display only black 998256 1 228762 jer.noble 2014-04-07 15:27:08 -0700 Created attachment 228762 Patch 998279 2 228762 eric.carlson 2014-04-07 16:23:35 -0700 Comment on attachment 228762 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228762&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:537 > + if (m_videoFullscreenLayer) > + [m_videoLayer removeFromSuperlayer]; This needs a #if PLATFORM(IOS) guard. 998329 3 228783 jer.noble 2014-04-07 17:42:13 -0700 Created attachment 228783 Patch for landing 998668 4 jer.noble 2014-04-08 11:23:24 -0700 Committed r166939: <http://trac.webkit.org/changeset/166939> 228762 2014-04-07 15:27:08 -0700 2014-04-08 11:24:01 -0700 Patch bug-131316-20140407152701.patch text/plain 3050 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RmOTdiNWJhNjVkM2Y2 NjQyMGVlZDc1Y2E1NmVkMzcwMThkZTZiMC4uYjZkOGMyMzViNTgzN2QwODQwZDVkNzM4N2I5YTYz MjViNDRhYTU5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTA3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW2lPU10gQ29uc2Vj dXRpdmUgdmlkZW9zIGluIGZ1bGwgc2NyZWVuIGRpc3BsYXkgb25seSBibGFjaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMzE2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSBNZWRpYVBs YXllcidzIGZ1bGwgc2NyZWVuIGF0dHJpYnV0ZXMgd2hlbmV2ZXIgdGhlIHVuZGVybHlpbmcgZW5n aW5lIGNoYW5nZXMsCisgICAgICAgIG5vdCBqdXN0IHdoZW4gdGhlIGVuZ2luZSBpcyBpbml0aWFs bHkgY3JlYXRlZC4gQWxzbywgY2xlYXIgdGhlIHZpZGVvTGF5ZXIgb3V0IG9mIHRoZQorICAgICAg ICBmdWxsc2NyZWVuIGxheWVyIHdoZW4gZGVzdHJveWluZyB0aGUgdmlkZW9MYXllci4KKworICAg ICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1M TWVkaWFFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5t bToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6 OmRlc3Ryb3lWaWRlb0xheWVyKToKKwogMjAxNC0wNC0wNyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNo b2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gVHVybiBvbiBFTkFCTEVfTUVESUFfQ09O VFJPTFNfU0NSSVBUCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRl eCA4MjA2ZWJlOTUyZjEyN2U4ZjczNmNhOTZiM2U3NWM0YzRhYjk1OWFhLi40NDI1Y2EwZmI1NDIz NjAzOWRkMTJmMzZjNmRiY2I3ZmIwMzkzZWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHAKQEAgLTQyMDksNiArNDIwOSwxNCBAQCB2b2lkIEhUTUxNZWRpYUVsZW1l bnQ6Om1lZGlhUGxheWVyRW5naW5lVXBkYXRlZChNZWRpYVBsYXllciopCiAjaWYgRU5BQkxFKE1F RElBX1NPVVJDRSkKICAgICBtX2Ryb3BwZWRWaWRlb0ZyYW1lcyA9IDA7CiAjZW5kaWYKKworI2lm IFBMQVRGT1JNKElPUykKKyAgICBpZiAoIW1fcGxheWVyKQorICAgICAgICByZXR1cm47CisgICAg bV9wbGF5ZXItPnNldFZpZGVvRnVsbHNjcmVlbkZyYW1lKG1fdmlkZW9GdWxsc2NyZWVuRnJhbWUp OworICAgIG1fcGxheWVyLT5zZXRWaWRlb0Z1bGxzY3JlZW5HcmF2aXR5KG1fdmlkZW9GdWxsc2Ny ZWVuR3Jhdml0eSk7CisgICAgbV9wbGF5ZXItPnNldFZpZGVvRnVsbHNjcmVlbkxheWVyKG1fdmlk ZW9GdWxsc2NyZWVuTGF5ZXIuZ2V0KCkpOworI2VuZGlmCiB9CiAKIHZvaWQgSFRNTE1lZGlhRWxl bWVudDo6bWVkaWFQbGF5ZXJGaXJzdFZpZGVvRnJhbWVBdmFpbGFibGUoTWVkaWFQbGF5ZXIqKQpA QCAtNTQ4NCwxMiArNTQ5Miw2IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6Y3JlYXRlTWVkaWFQ bGF5ZXIoKQogICAgICAgICBlbnF1ZXVlUGxheWJhY2tUYXJnZXRBdmFpbGFiaWxpdHlDaGFuZ2Vk RXZlbnQoKTsgLy8gRW5zdXJlIHRoZSBldmVudCBsaXN0ZW5lciBnZXRzIGF0IGxlYXN0IG9uZSBl dmVudC4KICAgICB9CiAjZW5kaWYKLSAgICAKLSNpZiBQTEFURk9STShJT1MpCi0gICAgbV9wbGF5 ZXItPnNldFZpZGVvRnVsbHNjcmVlbkZyYW1lKG1fdmlkZW9GdWxsc2NyZWVuRnJhbWUpOwotICAg IG1fcGxheWVyLT5zZXRWaWRlb0Z1bGxzY3JlZW5HcmF2aXR5KG1fdmlkZW9GdWxsc2NyZWVuR3Jh dml0eSk7Ci0gICAgbV9wbGF5ZXItPnNldFZpZGVvRnVsbHNjcmVlbkxheWVyKG1fdmlkZW9GdWxs c2NyZWVuTGF5ZXIuZ2V0KCkpOwotI2VuZGlmCiB9CiAKICNpZiBFTkFCTEUoV0VCX0FVRElPKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbk9iakMubW0KaW5kZXggZGJiM2MwMWJmMWJmZjc4MmNjNmRiM2JiZDU0ODg5 YmM0NmRmYmYzZC4uNjNjODg5YjhiYWY5Njc1NmIyZDBiYjNkYmFkZTZhZjBmN2U5YTNiYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDLm1tCkBAIC01MzMsNiArNTMzLDkgQEAgdm9pZCBNZWRpYVBsYXll clByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpkZXN0cm95VmlkZW9MYXllcigpCiAKICAgICBbbV92 aWRlb0xheWVyLmdldCgpIHNldFBsYXllcjpuaWxdOwogCisgICAgaWYgKG1fdmlkZW9GdWxsc2Ny ZWVuTGF5ZXIpCisgICAgICAgIFttX3ZpZGVvTGF5ZXIgcmVtb3ZlRnJvbVN1cGVybGF5ZXJdOwor CiAgICAgbV92aWRlb0xheWVyID0gMDsKIH0KIAo= 228783 2014-04-07 17:42:13 -0700 2014-04-07 17:42:13 -0700 Patch for landing bug-131316-20140407174206.patch text/plain 3078 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2ODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RmOTdiNWJhNjVkM2Y2 NjQyMGVlZDc1Y2E1NmVkMzcwMThkZTZiMC4uYjZkOGMyMzViNTgzN2QwODQwZDVkNzM4N2I5YTYz MjViNDRhYTU5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTA3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdW2lPU10gQ29uc2Vj dXRpdmUgdmlkZW9zIGluIGZ1bGwgc2NyZWVuIGRpc3BsYXkgb25seSBibGFjaworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMzE2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSBNZWRpYVBs YXllcidzIGZ1bGwgc2NyZWVuIGF0dHJpYnV0ZXMgd2hlbmV2ZXIgdGhlIHVuZGVybHlpbmcgZW5n aW5lIGNoYW5nZXMsCisgICAgICAgIG5vdCBqdXN0IHdoZW4gdGhlIGVuZ2luZSBpcyBpbml0aWFs bHkgY3JlYXRlZC4gQWxzbywgY2xlYXIgdGhlIHZpZGVvTGF5ZXIgb3V0IG9mIHRoZQorICAgICAg ICBmdWxsc2NyZWVuIGxheWVyIHdoZW4gZGVzdHJveWluZyB0aGUgdmlkZW9MYXllci4KKworICAg ICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1M TWVkaWFFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5t bToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6 OmRlc3Ryb3lWaWRlb0xheWVyKToKKwogMjAxNC0wNC0wNyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNo b2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gVHVybiBvbiBFTkFCTEVfTUVESUFfQ09O VFJPTFNfU0NSSVBUCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRl eCA4MjA2ZWJlOTUyZjEyN2U4ZjczNmNhOTZiM2U3NWM0YzRhYjk1OWFhLi40NDI1Y2EwZmI1NDIz NjAzOWRkMTJmMzZjNmRiY2I3ZmIwMzkzZWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHAKQEAgLTQyMDksNiArNDIwOSwxNCBAQCB2b2lkIEhUTUxNZWRpYUVsZW1l bnQ6Om1lZGlhUGxheWVyRW5naW5lVXBkYXRlZChNZWRpYVBsYXllciopCiAjaWYgRU5BQkxFKE1F RElBX1NPVVJDRSkKICAgICBtX2Ryb3BwZWRWaWRlb0ZyYW1lcyA9IDA7CiAjZW5kaWYKKworI2lm IFBMQVRGT1JNKElPUykKKyAgICBpZiAoIW1fcGxheWVyKQorICAgICAgICByZXR1cm47CisgICAg bV9wbGF5ZXItPnNldFZpZGVvRnVsbHNjcmVlbkZyYW1lKG1fdmlkZW9GdWxsc2NyZWVuRnJhbWUp OworICAgIG1fcGxheWVyLT5zZXRWaWRlb0Z1bGxzY3JlZW5HcmF2aXR5KG1fdmlkZW9GdWxsc2Ny ZWVuR3Jhdml0eSk7CisgICAgbV9wbGF5ZXItPnNldFZpZGVvRnVsbHNjcmVlbkxheWVyKG1fdmlk ZW9GdWxsc2NyZWVuTGF5ZXIuZ2V0KCkpOworI2VuZGlmCiB9CiAKIHZvaWQgSFRNTE1lZGlhRWxl bWVudDo6bWVkaWFQbGF5ZXJGaXJzdFZpZGVvRnJhbWVBdmFpbGFibGUoTWVkaWFQbGF5ZXIqKQpA QCAtNTQ4NCwxMiArNTQ5Miw2IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6Y3JlYXRlTWVkaWFQ bGF5ZXIoKQogICAgICAgICBlbnF1ZXVlUGxheWJhY2tUYXJnZXRBdmFpbGFiaWxpdHlDaGFuZ2Vk RXZlbnQoKTsgLy8gRW5zdXJlIHRoZSBldmVudCBsaXN0ZW5lciBnZXRzIGF0IGxlYXN0IG9uZSBl dmVudC4KICAgICB9CiAjZW5kaWYKLSAgICAKLSNpZiBQTEFURk9STShJT1MpCi0gICAgbV9wbGF5 ZXItPnNldFZpZGVvRnVsbHNjcmVlbkZyYW1lKG1fdmlkZW9GdWxsc2NyZWVuRnJhbWUpOwotICAg IG1fcGxheWVyLT5zZXRWaWRlb0Z1bGxzY3JlZW5HcmF2aXR5KG1fdmlkZW9GdWxsc2NyZWVuR3Jh dml0eSk7Ci0gICAgbV9wbGF5ZXItPnNldFZpZGVvRnVsbHNjcmVlbkxheWVyKG1fdmlkZW9GdWxs c2NyZWVuTGF5ZXIuZ2V0KCkpOwotI2VuZGlmCiB9CiAKICNpZiBFTkFCTEUoV0VCX0FVRElPKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0 ZUFWRm91bmRhdGlvbk9iakMubW0KaW5kZXggZGJiM2MwMWJmMWJmZjc4MmNjNmRiM2JiZDU0ODg5 YmM0NmRmYmYzZC4uMGMzMzc5MmJhMmRhOWVmYzAzODhjMDA5NDMzNjdhOTJkYjA1N2QxMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDLm1tCkBAIC01MzMsNiArNTMzLDExIEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6ZGVzdHJveVZpZGVvTGF5ZXIoKQogCiAgICAgW21f dmlkZW9MYXllci5nZXQoKSBzZXRQbGF5ZXI6bmlsXTsKIAorI2lmIFBMQVRGT1JNKElPUykKKyAg ICBpZiAobV92aWRlb0Z1bGxzY3JlZW5MYXllcikKKyAgICAgICAgW21fdmlkZW9MYXllciByZW1v dmVGcm9tU3VwZXJsYXllcl07CisjZW5kaWYKKwogICAgIG1fdmlkZW9MYXllciA9IDA7CiB9CiAK