131305 2014-04-07 10:37:42 -0700 [CSS Shapes] Simplify the parsing of width arguments for Inset shapes 2014-04-07 21:47:35 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zoltan zoltan commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 998177 0 zoltan 2014-04-07 10:37:42 -0700 This code introduces some helper functions for setting the size arguments of inset shapes. This change also modifies the code to be the same as in Blink, so it helps us to keep the shapes code similar. 998180 1 228745 zoltan 2014-04-07 10:41:22 -0700 Created attachment 228745 Patch 998414 2 228745 kling 2014-04-07 21:15:51 -0700 Comment on attachment 228745 Patch Okay! 998419 3 228745 commit-queue 2014-04-07 21:47:31 -0700 Comment on attachment 228745 Patch Clearing flags on attachment: 228745 Committed r166909: <http://trac.webkit.org/changeset/166909> 998420 4 commit-queue 2014-04-07 21:47:35 -0700 All reviewed patches have been landed. Closing bug. 228745 2014-04-07 10:41:22 -0700 2014-04-07 21:47:31 -0700 Patch simplifywidthparsing.patch text/plain 4205 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZGY5N2I1Li45ZGUyNDc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTQtMDQtMDcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIFNpbXBsaWZ5IHRoZSBwYXJzaW5nIG9mIHdpZHRoIGFyZ3VtZW50 cyBmb3IgSW5zZXQgc2hhcGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzEzMDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGNvZGUgaW50cm9kdWNlcyBzb21lIGhlbHBlciBmdW5jdGlvbnMgZm9y IHNldHRpbmcgdGhlIHNpemUgYXJndW1lbnRzIG9mIGluc2V0IHNoYXBlcy4gVGhpcyBjaGFuZ2UK KyAgICAgICAgYWxzbyBtb2RpZmllcyB0aGUgY29kZSB0byBiZSB0aGUgc2FtZSBhcyBpbiBCbGlu aywgc28gaXQgaGVscHMgdXMgdG8ga2VlcCB0aGUgc2hhcGVzIGNvZGUgc2ltaWxhci4KKworICAg ICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGNzcy9D U1NCYXNpY1NoYXBlcy5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTQmFzaWNTaGFwZUluc2V0Ojp1 cGRhdGVTaGFwZVNpemU0VmFsdWVzKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU0Jhc2ljU2hhcGVJ bnNldDo6dXBkYXRlU2hhcGVTaXplMVZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU0Jhc2lj U2hhcGVJbnNldDo6dXBkYXRlU2hhcGVTaXplMlZhbHVlcyk6CisgICAgICAgIChXZWJDb3JlOjpD U1NCYXNpY1NoYXBlSW5zZXQ6OnVwZGF0ZVNoYXBlU2l6ZTNWYWx1ZXMpOgorICAgICAgICAqIGNz cy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUJhc2lj U2hhcGVJbnNldCk6CisKIDIwMTQtMDQtMDcgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1 bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFR1cm4gb24gRU5BQkxFX01FRElBX0NPTlRST0xTX1ND UklQVApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Jhc2ljU2hhcGVzLmggYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTQmFzaWNTaGFwZXMuaAppbmRleCBjOTIxMGNmLi5mZmYyMDQ0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQmFzaWNTaGFwZXMuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTQmFzaWNTaGFwZXMuaApAQCAtODEsNiArODEsMjkgQEAgcHVi bGljOgogICAgIHZvaWQgc2V0Qm90dG9tKFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IGJv dHRvbSkgeyBtX2JvdHRvbSA9IGJvdHRvbTsgfQogICAgIHZvaWQgc2V0TGVmdChQYXNzUmVmUHRy PENTU1ByaW1pdGl2ZVZhbHVlPiBsZWZ0KSB7IG1fbGVmdCA9IGxlZnQ7IH0KIAorICAgIHZvaWQg dXBkYXRlU2hhcGVTaXplNFZhbHVlcyhDU1NQcmltaXRpdmVWYWx1ZSogdG9wLCBDU1NQcmltaXRp dmVWYWx1ZSogcmlnaHQsIENTU1ByaW1pdGl2ZVZhbHVlKiBib3R0b20sIENTU1ByaW1pdGl2ZVZh bHVlKiBsZWZ0KQorICAgIHsKKyAgICAgICAgc2V0VG9wKHRvcCk7CisgICAgICAgIHNldFJpZ2h0 KHJpZ2h0KTsKKyAgICAgICAgc2V0Qm90dG9tKGJvdHRvbSk7CisgICAgICAgIHNldExlZnQobGVm dCk7CisgICAgfQorCisgICAgdm9pZCB1cGRhdGVTaGFwZVNpemUxVmFsdWUoQ1NTUHJpbWl0aXZl VmFsdWUqIHZhbHVlMSkKKyAgICB7CisgICAgICAgIHVwZGF0ZVNoYXBlU2l6ZTRWYWx1ZXModmFs dWUxLCB2YWx1ZTEsIHZhbHVlMSwgdmFsdWUxKTsKKyAgICB9CisKKyAgICB2b2lkIHVwZGF0ZVNo YXBlU2l6ZTJWYWx1ZXMoQ1NTUHJpbWl0aXZlVmFsdWUqIHZhbHVlMSwgIENTU1ByaW1pdGl2ZVZh bHVlKiB2YWx1ZTIpCisgICAgeworICAgICAgICB1cGRhdGVTaGFwZVNpemU0VmFsdWVzKHZhbHVl MSwgdmFsdWUyLCB2YWx1ZTEsIHZhbHVlMik7CisgICAgfQorCisgICAgdm9pZCB1cGRhdGVTaGFw ZVNpemUzVmFsdWVzKENTU1ByaW1pdGl2ZVZhbHVlKiB2YWx1ZTEsIENTU1ByaW1pdGl2ZVZhbHVl KiB2YWx1ZTIsICBDU1NQcmltaXRpdmVWYWx1ZSogdmFsdWUzKQorICAgIHsKKyAgICAgICAgdXBk YXRlU2hhcGVTaXplNFZhbHVlcyh2YWx1ZTEsIHZhbHVlMiwgdmFsdWUzLCB2YWx1ZTIpOworICAg IH0KKwogICAgIHZvaWQgc2V0VG9wTGVmdFJhZGl1cyhQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZh bHVlPiByYWRpdXMpIHsgbV90b3BMZWZ0UmFkaXVzID0gcmFkaXVzOyB9CiAgICAgdm9pZCBzZXRU b3BSaWdodFJhZGl1cyhQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiByYWRpdXMpIHsgbV90 b3BSaWdodFJhZGl1cyA9IHJhZGl1czsgfQogICAgIHZvaWQgc2V0Qm90dG9tUmlnaHRSYWRpdXMo UGFzc1JlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gcmFkaXVzKSB7IG1fYm90dG9tUmlnaHRSYWRp dXMgPSByYWRpdXM7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggZTg4ZmIzOS4uOGNm ZjM5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTU0MjgsMzEgKzU0MjgsMTkgQEAg UGFzc1JlZlB0cjxDU1NCYXNpY1NoYXBlPiBDU1NQYXJzZXI6OnBhcnNlQmFzaWNTaGFwZUluc2V0 KENTU1BhcnNlclZhbHVlTGlzdCogYXIKIAogICAgIHN3aXRjaCAod2lkdGhBcmd1bWVudHMuc2l6 ZSgpKSB7CiAgICAgY2FzZSAxOiB7Ci0gICAgICAgIHNoYXBlLT5zZXRUb3Aod2lkdGhBcmd1bWVu dHNbMF0pOwotICAgICAgICBzaGFwZS0+c2V0UmlnaHQod2lkdGhBcmd1bWVudHNbMF0pOwotICAg ICAgICBzaGFwZS0+c2V0Qm90dG9tKHdpZHRoQXJndW1lbnRzWzBdKTsKLSAgICAgICAgc2hhcGUt PnNldExlZnQod2lkdGhBcmd1bWVudHNbMF0pOworICAgICAgICBzaGFwZS0+dXBkYXRlU2hhcGVT aXplMVZhbHVlKHdpZHRoQXJndW1lbnRzWzBdLmdldCgpKTsKICAgICAgICAgYnJlYWs7CiAgICAg fQogICAgIGNhc2UgMjogewotICAgICAgICBzaGFwZS0+c2V0VG9wKHdpZHRoQXJndW1lbnRzWzBd KTsKLSAgICAgICAgc2hhcGUtPnNldFJpZ2h0KHdpZHRoQXJndW1lbnRzWzFdKTsKLSAgICAgICAg c2hhcGUtPnNldEJvdHRvbSh3aWR0aEFyZ3VtZW50c1swXSk7Ci0gICAgICAgIHNoYXBlLT5zZXRM ZWZ0KHdpZHRoQXJndW1lbnRzWzFdKTsKKyAgICAgICAgc2hhcGUtPnVwZGF0ZVNoYXBlU2l6ZTJW YWx1ZXMod2lkdGhBcmd1bWVudHNbMF0uZ2V0KCksIHdpZHRoQXJndW1lbnRzWzFdLmdldCgpKTsK ICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICBjYXNlIDM6IHsKLSAgICAgICAgc2hhcGUt PnNldFRvcCh3aWR0aEFyZ3VtZW50c1swXSk7Ci0gICAgICAgIHNoYXBlLT5zZXRSaWdodCh3aWR0 aEFyZ3VtZW50c1sxXSk7Ci0gICAgICAgIHNoYXBlLT5zZXRCb3R0b20od2lkdGhBcmd1bWVudHNb Ml0pOwotICAgICAgICBzaGFwZS0+c2V0TGVmdCh3aWR0aEFyZ3VtZW50c1sxXSk7CisgICAgICAg IHNoYXBlLT51cGRhdGVTaGFwZVNpemUzVmFsdWVzKHdpZHRoQXJndW1lbnRzWzBdLmdldCgpLCB3 aWR0aEFyZ3VtZW50c1sxXS5nZXQoKSwgd2lkdGhBcmd1bWVudHNbMl0uZ2V0KCkpOwogICAgICAg ICBicmVhazsKICAgICB9CiAgICAgY2FzZSA0OiB7Ci0gICAgICAgIHNoYXBlLT5zZXRUb3Aod2lk dGhBcmd1bWVudHNbMF0pOwotICAgICAgICBzaGFwZS0+c2V0UmlnaHQod2lkdGhBcmd1bWVudHNb MV0pOwotICAgICAgICBzaGFwZS0+c2V0Qm90dG9tKHdpZHRoQXJndW1lbnRzWzJdKTsKLSAgICAg ICAgc2hhcGUtPnNldExlZnQod2lkdGhBcmd1bWVudHNbM10pOworICAgICAgICBzaGFwZS0+dXBk YXRlU2hhcGVTaXplNFZhbHVlcyh3aWR0aEFyZ3VtZW50c1swXS5nZXQoKSwgd2lkdGhBcmd1bWVu dHNbMV0uZ2V0KCksIHdpZHRoQXJndW1lbnRzWzJdLmdldCgpLCB3aWR0aEFyZ3VtZW50c1szXS5n ZXQoKSk7CiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBkZWZhdWx0Ogo=