<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>131294</bug_id>
          
          <creation_ts>2014-04-07 00:49:05 -0700</creation_ts>
          <short_desc>[AX][GTK] No new lines in some AX tests output</short_desc>
          <delta_ts>2014-04-09 08:06:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sergio Villar Senin">svillar</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>cfleizach</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>jcraig</cc>
    
    <cc>jdiggs</cc>
    
    <cc>mario</cc>
    
    <cc>mrobinson</cc>
    
    <cc>samuel_white</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>998096</commentid>
    <comment_count>0</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2014-04-07 00:49:05 -0700</bug_when>
    <thetext>Several tests fail:
accessibility/adjacent-continuations-cause-assertion-failure.html
accessibility/deleting-iframe-destroys-axcache.html
accessibility/div-within-anchors-causes-crash.html
accessibility/lists.html

This is the kind of errors bots are observing:
-AXRole: AXWebArea
- AXRole: AXSection AXValue: y
- AXRole: AXSection AXValue: End of test
+AXRole: AXWebArea AXValue: x&lt;\n&gt;y&lt;\n&gt;z&lt;\n&gt;End of test&lt;\n&gt;Make sure that a debug assert is not triggered when constructing the accessibility tree for this page.&lt;\n&gt;&lt;\n&gt;On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.&lt;\n&gt;&lt;\n&gt;&lt;\n&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998097</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-04-07 00:49:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/16537388&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998098</commentid>
    <comment_count>2</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2014-04-07 00:58:43 -0700</bug_when>
    <thetext>Actually the failures is not only about the &quot;&lt;/n&gt;&quot; thing, but it seems that some roles for children are not printed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998103</commentid>
    <comment_count>3</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2014-04-07 01:20:19 -0700</bug_when>
    <thetext>Another 3 more tests

platform/gtk/accessibility/entry-and-password.html
platform/gtk/accessibility/media-emits-object-replacement.html
platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998581</commentid>
    <comment_count>4</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-08 08:48:31 -0700</bug_when>
    <thetext>Curiously enough, I can only reproduce this with WebKit2 and WKTR. With WebKit1 and DRT everything is fine.

I&apos;m taking a look to this right now</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998586</commentid>
    <comment_count>5</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-04-08 09:05:57 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Curiously enough, I can only reproduce this with WebKit2 and WKTR. With WebKit1 and DRT everything is fine.
&gt; 
&gt; I&apos;m taking a look to this right now

Great. And FWIW, WebKit1 is toast soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998595</commentid>
    <comment_count>6</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-08 09:19:37 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; Curiously enough, I can only reproduce this with WebKit2 and WKTR. With WebKit1 and DRT everything is fine.
&gt; &gt; 
&gt; &gt; I&apos;m taking a look to this right now
&gt; 
&gt; Great. And FWIW, WebKit1 is toast soon.

I know. Just mentioned it because I found the difference in behaviour quite interesting, as it could mean the problem is not in WebKit itself, but in the testing tools</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998627</commentid>
    <comment_count>7</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2014-04-08 10:18:31 -0700</bug_when>
    <thetext>Two more tests are also failing:

* accessibility/children-changed-sends-notification.html
* accessibility/notification-listeners.html


The diffs are the following:

--- /stuff/webkit/webkit/layout-test-results/accessibility/children-changed-sends-notification-expected.txt
+++ /stuff/webkit/webkit/layout-test-results/accessibility/children-changed-sends-notification-actual.txt
@@ -6,12 +6,8 @@
 Plain text paragraph 
 
 End of test
-PARAGRAPH notification: AXChildrenRemoved
-GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph
-PARAGRAPH notification: AXChildrenAdded
-GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
 PASS paragraphNotificationCount is globalNotificationCount
-PASS globalNotificationCount is 2
+FAIL globalNotificationCount should be 2. Was 0.
 PASS successfullyParsed is true
 
 TEST COMPLETE

--- /stuff/webkit/webkit/layout-test-results/accessibility/notification-listeners-expected.txt
+++ /stuff/webkit/webkit/layout-test-results/accessibility/notification-listeners-actual.txt
@@ -7,11 +7,13 @@
 Slider
 SELECT AXInvalidStatusChanged
 GLOBAL AXInvalidStatusChanged on element with role AXRole: AXComboBox
+SLIDER AXChildrenAdded
+GLOBAL AXChildrenAdded on element with role AXRole: AXSlider
 SLIDER AXValueChanged
 GLOBAL AXValueChanged on element with role AXRole: AXSlider
 PASS selectNotificationCount is 1
-PASS sliderNotificationCount is 1
-PASS globalNotificationCount is 2
+FAIL sliderNotificationCount should be 1. Was 2.
+FAIL globalNotificationCount should be 2. Was 3.
 PASS successfullyParsed is true
 
 TEST COMPLETE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998667</commentid>
    <comment_count>8</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2014-04-08 11:21:17 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Two more tests are also failing:
&gt; 
&gt; * accessibility/children-changed-sends-notification.html
&gt; * accessibility/notification-listeners.html

I didn&apos;t include them because there seem to be different types of failures. The differences in the output with the expected results are not the same.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>998698</commentid>
    <comment_count>9</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2014-04-08 12:19:11 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #7)
&gt; &gt; Two more tests are also failing:
&gt; &gt; 
&gt; &gt; * accessibility/children-changed-sends-notification.html
&gt; &gt; * accessibility/notification-listeners.html
&gt; 
&gt; I didn&apos;t include them because there seem to be different types of failures. The differences in the output with the expected results are not the same.

Ok. Reported it on bug #131380</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>999134</commentid>
    <comment_count>10</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-09 02:25:29 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; accessibility/lists.html

Quick thing: this test is not failing due to the same issue, but due to an &lt;hr&gt; being removed in http://trac.webkit.org/changeset/166175, which just needs rebaselining.

I&apos;ll land a gardening patch related to that independently</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>999141</commentid>
    <comment_count>11</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-09 03:41:23 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; (In reply to comment #0)
&gt; &gt; accessibility/lists.html
&gt; 
&gt; Quick thing: this test is not failing due to the same issue, but due to an &lt;hr&gt; being removed in http://trac.webkit.org/changeset/166175, which just needs rebaselining.
&gt; 
&gt; I&apos;ll land a gardening patch related to that independently

http://trac.webkit.org/changeset/167009</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>999142</commentid>
    <comment_count>12</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-09 03:47:24 -0700</bug_when>
    <thetext>The problem is caused by http://trac.webkit.org/changeset/166194 because, as per my own recommendation, the call to updateRoleAfterChildrenCreation() is happening now in AccessibilityObject::updateBackingStore(), which unveiled a problem in the way we determined which ATK interfaces to implement in the ATK wrapper.

Because of this issue, all these tests were printing a lot of text when called the stringValue() function of AccessibilityUIElement through WKTR, since the ATK object for the WebArea would be recognized as implementing AtkText. Therefore, calling atk_text_get_text() over it would return a textual representation of the whole web page (internally using WebCore&apos;s TextIterator), which resulted in all that text being shown in the output.

And of course, the javascript code in buildAccessibilityTree() would not keep digging into the subtree for the WebArea because, due to the WebArea already returning a lot of text through the AtkText interface, and due to that text already including the &apos;End of test&apos; string (used as condition to stop digging more in the tree).

So, we need to make sure we never, ever, implement AtkText for objects with the WebArea role. Patch coming soon</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>999143</commentid>
    <comment_count>13</comment_count>
      <attachid>228953</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-09 03:49:47 -0700</bug_when>
    <thetext>Created attachment 228953
Patch proposal

See the patch proposal attached. Notice that this patch not only prevents the WebArea object from implementing AtkText but also AtkHypertext, which I believe is correct because that other interface will be implemented anyway by the real containers of the different blocks of content in the web page.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>999149</commentid>
    <comment_count>14</comment_count>
      <attachid>228956</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-09 05:18:30 -0700</bug_when>
    <thetext>Created attachment 228956
Patch proposal

Forgot the parenthesis in the previous patch. Adding them now to make EFL happy (well, and because I think it&apos;s clearer this way too)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>999171</commentid>
    <comment_count>15</comment_count>
      <attachid>228956</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2014-04-09 07:36:59 -0700</bug_when>
    <thetext>Comment on attachment 228956
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=228956&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        Do not implement Hypetext or AtkText for the WebArea. Those

Small typo: Hypetext -&gt; Hypertext</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>999183</commentid>
    <comment_count>16</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-09 08:02:33 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (From update of attachment 228956 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=228956&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/ChangeLog:8
&gt; &gt; +        Do not implement Hypetext or AtkText for the WebArea. Those
&gt; 
&gt; Small typo: Hypetext -&gt; Hypertext

Oops! Thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>999184</commentid>
    <comment_count>17</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2014-04-09 08:06:31 -0700</bug_when>
    <thetext>Committed r167011: &lt;http://trac.webkit.org/changeset/167011&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>228953</attachid>
            <date>2014-04-09 03:49:47 -0700</date>
            <delta_ts>2014-04-09 05:18:30 -0700</delta_ts>
            <desc>Patch proposal</desc>
            <filename>0001-2014-04-09-Mario-Sanchez-Prada-mario.prada-samsung.c.patch</filename>
            <type>text/plain</type>
            <size>6838</size>
            <attacher name="Mario Sanchez Prada">mario</attacher>
            
              <data encoding="base64">RnJvbSA2ZmViNjVhMWZhYTAzZTRjOTNkMDU0NDRjNGI2MzcxNDUwMTM1YzUxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z
dW5nLmNvbT4KRGF0ZTogV2VkLCA5IEFwciAyMDE0IDExOjM2OjU1ICswMTAwClN1YmplY3Q6IFtQ
QVRDSF0gMjAxNC0wNC0wOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1
bmcuY29tPgoKICAgICAgICBbQVhdW0dUS10gTm8gbmV3IGxpbmVzIGluIHNvbWUgQVggdGVzdHMg
b3V0cHV0CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz
MTI5NAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgRG8gbm90
IGltcGxlbWVudCBIeXBldGV4dCBvciBBdGtUZXh0IGZvciB0aGUgV2ViQXJlYS4gVGhvc2UKICAg
ICAgICBpbnRlcmZhY2VzIHdpbGwgYmUgaW1wbGVtZW50ZWQgYnkgdGhlIGNvbnRhaW5lcnMgKGF1
dG9tYXRpY2FsbHkKICAgICAgICBnZW5lcmF0ZWQgb3Igbm90KSBmb3IgdGhlIGRpZmZlcmVudCBw
YXJ0cyBvZiB0aGUgRE9NIGFuZCB0aGUKICAgICAgICByZW5kZXIgc3VidHJlZSB1bmRlciB0aGlz
IGVsZW1lbnQgYW55d2F5LgoKICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vz
c2libGVXcmFwcGVyQXRrLmNwcDoKICAgICAgICAoZ2V0SW50ZXJmYWNlTWFza0Zyb21PYmplY3Qp
OiBNYWtlIHN1cmUgd2UgZG9uJ3QgYXBwbHkKICAgICAgICBXQUlIeXBlcnRleHQgbm9yIFdBSVRl
eHQgdG8gb2JqZWN0cyB3aXRoIHJvbGUgV2ViQXJlYVJvbGUuCgoyMDE0LTA0LTA5ICBNYXJpbyBT
YW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CgogICAgICAgIFtBWF1bR1RL
XSBObyBuZXcgbGluZXMgaW4gc29tZSBBWCB0ZXN0cyBvdXRwdXQKICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMjk0CgogICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBSZW1vdmVkIGZhaWx1cmUgZXhwZWN0YXRpb25zIGZv
ciB0ZXN0cyBub3cgcGFzc2luZy4KCiAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0
aW9uczogVXBkYXRlZC4KLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgMTEgKysrKysrCiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVz
dEV4cGVjdGF0aW9ucyAgICAgICAgICB8ICAgIDggLS0tLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysKIC4uLi9hdGsv
V2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwICAgICAgICAgICAgIHwgICAzOCArKysrKysr
KysrLS0tLS0tLS0tLQogNCBmaWxlcyBjaGFuZ2VkLCA0NSBpbnNlcnRpb25zKCspLCAyOCBkZWxl
dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKaW5kZXggNmJlNzMxYWIuLmE1YTkxYTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBA
QAogMjAxNC0wNC0wOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcu
Y29tPgogCisgICAgICAgIFtBWF1bR1RLXSBObyBuZXcgbGluZXMgaW4gc29tZSBBWCB0ZXN0cyBv
dXRwdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz
MTI5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl
bW92ZWQgZmFpbHVyZSBleHBlY3RhdGlvbnMgZm9yIHRlc3RzIG5vdyBwYXNzaW5nLgorCisgICAg
ICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFVwZGF0ZWQuCisKKzIwMTQtMDQt
MDkgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KKwogICAg
ICAgICBVbnJldmlld2VkIGdhcmRlbmluZyBmb3IgR1RLLgogCiAgICAgICAgIFVwZGF0ZWQgdGVz
dCBleHBlY3RhdGlvbnMgYWZ0ZXIgcjE2NjE3NSwgd2hpY2ggcmVtb3ZlZCBhbiA8aHI+CmRpZmYg
LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91
dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGE1ZGU3OTguLjk2YjZm
YzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z
CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMDU1
LDE0ICsxMDU1LDYgQEAgQnVnKEdUSykgZWRpdGluZy9zcGVsbGluZy9zcGVsbGluZy1saW5lYnJl
YWsuaHRtbCBbIFNraXAgXQogd2Via2l0Lm9yZy9iLzEyMDQwMSBmYXN0L2V2ZW50cyBbIFNraXAg
XQogd2Via2l0Lm9yZy9iLzEyMDQwMSBlZGl0aW5nL3NlbGVjdGlvbiBbIFNraXAgXQogCi0jIEFY
IHRlc3RzIGZhaWxpbmcKLXdlYmtpdC5vcmcvYi8xMzEyOTQgYWNjZXNzaWJpbGl0eS9hZGphY2Vu
dC1jb250aW51YXRpb25zLWNhdXNlLWFzc2VydGlvbi1mYWlsdXJlLmh0bWwgWyBGYWlsdXJlIF0K
LXdlYmtpdC5vcmcvYi8xMzEyOTQgYWNjZXNzaWJpbGl0eS9kZWxldGluZy1pZnJhbWUtZGVzdHJv
eXMtYXhjYWNoZS5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTMxMjk0IGFjY2Vzc2li
aWxpdHkvZGl2LXdpdGhpbi1hbmNob3JzLWNhdXNlcy1jcmFzaC5odG1sIFsgRmFpbHVyZSBdCi13
ZWJraXQub3JnL2IvMTMxMjk0IHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2VudHJ5LWFuZC1w
YXNzd29yZC5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTMxMjk0IHBsYXRmb3JtL2d0
ay9hY2Nlc3NpYmlsaXR5L21lZGlhLWVtaXRzLW9iamVjdC1yZXBsYWNlbWVudC5odG1sIFsgRmFp
bHVyZSBdCi13ZWJraXQub3JnL2IvMTMxMjk0IHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3Jl
cGxhY2VkLW9iamVjdHMtaW4tYW5vbnltb3VzLWJsb2Nrcy5odG1sIFsgRmFpbHVyZSBdCi0KIHdl
YmtpdC5vcmcvYi8xMDYzNDAgYWNjZXNzaWJpbGl0eS9pbWctZmFsbHNiYWNrLXRvLXRpdGxlLmh0
bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzEzMTM4MCBhY2Nlc3NpYmlsaXR5L2NoaWxk
cmVuLWNoYW5nZWQtc2VuZHMtbm90aWZpY2F0aW9uLmh0bWwgWyBGYWlsdXJlIF0KZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp
bmRleCBiMTAwNzNiLi43YjY4YWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM
b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQt
MDQtMDkgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KKwor
ICAgICAgICBbQVhdW0dUS10gTm8gbmV3IGxpbmVzIGluIHNvbWUgQVggdGVzdHMgb3V0cHV0Cisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEyOTQKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgaW1w
bGVtZW50IEh5cGV0ZXh0IG9yIEF0a1RleHQgZm9yIHRoZSBXZWJBcmVhLiBUaG9zZQorICAgICAg
ICBpbnRlcmZhY2VzIHdpbGwgYmUgaW1wbGVtZW50ZWQgYnkgdGhlIGNvbnRhaW5lcnMgKGF1dG9t
YXRpY2FsbHkKKyAgICAgICAgZ2VuZXJhdGVkIG9yIG5vdCkgZm9yIHRoZSBkaWZmZXJlbnQgcGFy
dHMgb2YgdGhlIERPTSBhbmQgdGhlCisgICAgICAgIHJlbmRlciBzdWJ0cmVlIHVuZGVyIHRoaXMg
ZWxlbWVudCBhbnl3YXkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nl
c3NpYmxlV3JhcHBlckF0ay5jcHA6CisgICAgICAgIChnZXRJbnRlcmZhY2VNYXNrRnJvbU9iamVj
dCk6IE1ha2Ugc3VyZSB3ZSBkb24ndCBhcHBseQorICAgICAgICBXQUlIeXBlcnRleHQgbm9yIFdB
SVRleHQgdG8gb2JqZWN0cyB3aXRoIHJvbGUgV2ViQXJlYVJvbGUuCisKIDIwMTQtMDQtMDggIENv
bnJhZCBTaHVsdHogIDxjb25yYWRfc2h1bHR6QGFwcGxlLmNvbT4KIAogICAgICAgICBuaWwgc2hv
dWxkIG9ubHkgYmUgdXNlZCBmb3Igb2JqZWN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
YWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwIGIvU291cmNl
L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3Bw
CmluZGV4IDIxNGIzNDIuLjE0M2I1YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz
c2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAK
QEAgLTExNTUsMjkgKzExNTUsMjcgQEAgc3RhdGljIGd1aW50MTYgZ2V0SW50ZXJmYWNlTWFza0Zy
b21PYmplY3QoQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCkKICAgICBpZiAoY29yZU9i
amVjdC0+aXNMaW5rKCkgfHwgKHJlbmRlcmVyICYmIHJlbmRlcmVyLT5pc1JlcGxhY2VkKCkpKQog
ICAgICAgICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJSHlwZXJsaW5rOwogCi0gICAgLy8gVGV4
dCAmIEVkaXRhYmxlIFRleHQKKyAgICAvLyBUZXh0LCBFZGl0YWJsZSBUZXh0ICYgSHlwZXJ0ZXh0
CiAgICAgaWYgKHJvbGUgPT0gU3RhdGljVGV4dFJvbGUgfHwgY29yZU9iamVjdC0+aXNNZW51TGlz
dE9wdGlvbigpKQogICAgICAgICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJVGV4dDsKLSAgICBl
bHNlIHsKLSAgICAgICAgaWYgKGNvcmVPYmplY3QtPmlzVGV4dENvbnRyb2woKSkgewotICAgICAg
ICAgICAgaW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSVRleHQ7Ci0gICAgICAgICAgICBpZiAoIWNv
cmVPYmplY3QtPmlzUmVhZE9ubHkoKSkKLSAgICAgICAgICAgICAgICBpbnRlcmZhY2VNYXNrIHw9
IDEgPDwgV0FJRWRpdGFibGVUZXh0OwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgaWYg
KHJvbGUgIT0gVGFibGVSb2xlKSB7Ci0gICAgICAgICAgICAgICAgaW50ZXJmYWNlTWFzayB8PSAx
IDw8IFdBSUh5cGVydGV4dDsKLSAgICAgICAgICAgICAgICBpZiAoKHJlbmRlcmVyICYmIHJlbmRl
cmVyLT5jaGlsZHJlbklubGluZSgpKSB8fCByb2xlSXNUZXh0VHlwZShyb2xlKSkKLSAgICAgICAg
ICAgICAgICAgICAgaW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSVRleHQ7Ci0gICAgICAgICAgICB9
CisgICAgZWxzZSBpZiAoY29yZU9iamVjdC0+aXNUZXh0Q29udHJvbCgpKSB7CisgICAgICAgIGlu
dGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlUZXh0OworICAgICAgICBpZiAoIWNvcmVPYmplY3QtPmlz
UmVhZE9ubHkoKSkKKyAgICAgICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlFZGl0YWJs
ZVRleHQ7CisgICAgfSBlbHNlIGlmICghY29yZU9iamVjdC0+aXNXZWJBcmVhKCkpIHsKKyAgICAg
ICAgaWYgKHJvbGUgIT0gVGFibGVSb2xlKSB7CisgICAgICAgICAgICBpbnRlcmZhY2VNYXNrIHw9
IDEgPDwgV0FJSHlwZXJ0ZXh0OworICAgICAgICAgICAgaWYgKHJlbmRlcmVyICYmIHJlbmRlcmVy
LT5jaGlsZHJlbklubGluZSgpIHx8IHJvbGVJc1RleHRUeXBlKHJvbGUpKQorICAgICAgICAgICAg
ICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlUZXh0OworICAgICAgICB9CiAKLSAgICAgICAg
ICAgIC8vIEFkZCB0aGUgVEVYVCBpbnRlcmZhY2UgZm9yIGxpc3QgaXRlbXMgd2hvc2UKLSAgICAg
ICAgICAgIC8vIGZpcnN0IGFjY2Vzc2libGUgY2hpbGQgaGFzIGEgdGV4dCByZW5kZXJlcgotICAg
ICAgICAgICAgaWYgKHJvbGUgPT0gTGlzdEl0ZW1Sb2xlKSB7Ci0gICAgICAgICAgICAgICAgY29u
c3QgQWNjZXNzaWJpbGl0eU9iamVjdDo6QWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdG9yJiBjaGls
ZHJlbiA9IGNvcmVPYmplY3QtPmNoaWxkcmVuKCk7Ci0gICAgICAgICAgICAgICAgaWYgKGNoaWxk
cmVuLnNpemUoKSkgewotICAgICAgICAgICAgICAgICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBh
eFJlbmRlckNoaWxkID0gY2hpbGRyZW4uYXQoMCkuZ2V0KCk7Ci0gICAgICAgICAgICAgICAgICAg
IGludGVyZmFjZU1hc2sgfD0gZ2V0SW50ZXJmYWNlTWFza0Zyb21PYmplY3QoYXhSZW5kZXJDaGls
ZCk7Ci0gICAgICAgICAgICAgICAgfQorICAgICAgICAvLyBBZGQgdGhlIFRFWFQgaW50ZXJmYWNl
IGZvciBsaXN0IGl0ZW1zIHdob3NlCisgICAgICAgIC8vIGZpcnN0IGFjY2Vzc2libGUgY2hpbGQg
aGFzIGEgdGV4dCByZW5kZXJlcgorICAgICAgICBpZiAocm9sZSA9PSBMaXN0SXRlbVJvbGUpIHsK
KyAgICAgICAgICAgIGNvbnN0IEFjY2Vzc2liaWxpdHlPYmplY3Q6OkFjY2Vzc2liaWxpdHlDaGls
ZHJlblZlY3RvciYgY2hpbGRyZW4gPSBjb3JlT2JqZWN0LT5jaGlsZHJlbigpOworICAgICAgICAg
ICAgaWYgKGNoaWxkcmVuLnNpemUoKSkgeworICAgICAgICAgICAgICAgIEFjY2Vzc2liaWxpdHlP
YmplY3QqIGF4UmVuZGVyQ2hpbGQgPSBjaGlsZHJlbi5hdCgwKS5nZXQoKTsKKyAgICAgICAgICAg
ICAgICBpbnRlcmZhY2VNYXNrIHw9IGdldEludGVyZmFjZU1hc2tGcm9tT2JqZWN0KGF4UmVuZGVy
Q2hpbGQpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQotLSAKMS43LjEwLjQKCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>228956</attachid>
            <date>2014-04-09 05:18:30 -0700</date>
            <delta_ts>2014-04-09 07:36:59 -0700</delta_ts>
            <desc>Patch proposal</desc>
            <filename>0001-2014-04-09-Mario-Sanchez-Prada-mario.prada-samsung.c.patch</filename>
            <type>text/plain</type>
            <size>6840</size>
            <attacher name="Mario Sanchez Prada">mario</attacher>
            
              <data encoding="base64">RnJvbSBhN2UyNTM1MmIwNGM1OWYzZGMxYzY5MWNjMzkxYjAyZmQyMzc4NmM1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z
dW5nLmNvbT4KRGF0ZTogV2VkLCA5IEFwciAyMDE0IDExOjM2OjU1ICswMTAwClN1YmplY3Q6IFtQ
QVRDSF0gMjAxNC0wNC0wOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1
bmcuY29tPgoKICAgICAgICBbQVhdW0dUS10gTm8gbmV3IGxpbmVzIGluIHNvbWUgQVggdGVzdHMg
b3V0cHV0CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz
MTI5NAoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgRG8gbm90
IGltcGxlbWVudCBIeXBldGV4dCBvciBBdGtUZXh0IGZvciB0aGUgV2ViQXJlYS4gVGhvc2UKICAg
ICAgICBpbnRlcmZhY2VzIHdpbGwgYmUgaW1wbGVtZW50ZWQgYnkgdGhlIGNvbnRhaW5lcnMgKGF1
dG9tYXRpY2FsbHkKICAgICAgICBnZW5lcmF0ZWQgb3Igbm90KSBmb3IgdGhlIGRpZmZlcmVudCBw
YXJ0cyBvZiB0aGUgRE9NIGFuZCB0aGUKICAgICAgICByZW5kZXIgc3VidHJlZSB1bmRlciB0aGlz
IGVsZW1lbnQgYW55d2F5LgoKICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vz
c2libGVXcmFwcGVyQXRrLmNwcDoKICAgICAgICAoZ2V0SW50ZXJmYWNlTWFza0Zyb21PYmplY3Qp
OiBNYWtlIHN1cmUgd2UgZG9uJ3QgYXBwbHkKICAgICAgICBXQUlIeXBlcnRleHQgbm9yIFdBSVRl
eHQgdG8gb2JqZWN0cyB3aXRoIHJvbGUgV2ViQXJlYVJvbGUuCgoyMDE0LTA0LTA5ICBNYXJpbyBT
YW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CgogICAgICAgIFtBWF1bR1RL
XSBObyBuZXcgbGluZXMgaW4gc29tZSBBWCB0ZXN0cyBvdXRwdXQKICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMjk0CgogICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBSZW1vdmVkIGZhaWx1cmUgZXhwZWN0YXRpb25zIGZv
ciB0ZXN0cyBub3cgcGFzc2luZy4KCiAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0
aW9uczogVXBkYXRlZC4KLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgMTEgKysrKysrCiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVz
dEV4cGVjdGF0aW9ucyAgICAgICAgICB8ICAgIDggLS0tLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysKIC4uLi9hdGsv
V2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwICAgICAgICAgICAgIHwgICAzOCArKysrKysr
KysrLS0tLS0tLS0tLQogNCBmaWxlcyBjaGFuZ2VkLCA0NSBpbnNlcnRpb25zKCspLCAyOCBkZWxl
dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKaW5kZXggNmJlNzMxYWIuLmE1YTkxYTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBA
QAogMjAxNC0wNC0wOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1bmcu
Y29tPgogCisgICAgICAgIFtBWF1bR1RLXSBObyBuZXcgbGluZXMgaW4gc29tZSBBWCB0ZXN0cyBv
dXRwdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz
MTI5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl
bW92ZWQgZmFpbHVyZSBleHBlY3RhdGlvbnMgZm9yIHRlc3RzIG5vdyBwYXNzaW5nLgorCisgICAg
ICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6IFVwZGF0ZWQuCisKKzIwMTQtMDQt
MDkgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KKwogICAg
ICAgICBVbnJldmlld2VkIGdhcmRlbmluZyBmb3IgR1RLLgogCiAgICAgICAgIFVwZGF0ZWQgdGVz
dCBleHBlY3RhdGlvbnMgYWZ0ZXIgcjE2NjE3NSwgd2hpY2ggcmVtb3ZlZCBhbiA8aHI+CmRpZmYg
LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91
dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGE1ZGU3OTguLjk2YjZm
YzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z
CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMDU1
LDE0ICsxMDU1LDYgQEAgQnVnKEdUSykgZWRpdGluZy9zcGVsbGluZy9zcGVsbGluZy1saW5lYnJl
YWsuaHRtbCBbIFNraXAgXQogd2Via2l0Lm9yZy9iLzEyMDQwMSBmYXN0L2V2ZW50cyBbIFNraXAg
XQogd2Via2l0Lm9yZy9iLzEyMDQwMSBlZGl0aW5nL3NlbGVjdGlvbiBbIFNraXAgXQogCi0jIEFY
IHRlc3RzIGZhaWxpbmcKLXdlYmtpdC5vcmcvYi8xMzEyOTQgYWNjZXNzaWJpbGl0eS9hZGphY2Vu
dC1jb250aW51YXRpb25zLWNhdXNlLWFzc2VydGlvbi1mYWlsdXJlLmh0bWwgWyBGYWlsdXJlIF0K
LXdlYmtpdC5vcmcvYi8xMzEyOTQgYWNjZXNzaWJpbGl0eS9kZWxldGluZy1pZnJhbWUtZGVzdHJv
eXMtYXhjYWNoZS5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTMxMjk0IGFjY2Vzc2li
aWxpdHkvZGl2LXdpdGhpbi1hbmNob3JzLWNhdXNlcy1jcmFzaC5odG1sIFsgRmFpbHVyZSBdCi13
ZWJraXQub3JnL2IvMTMxMjk0IHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L2VudHJ5LWFuZC1w
YXNzd29yZC5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTMxMjk0IHBsYXRmb3JtL2d0
ay9hY2Nlc3NpYmlsaXR5L21lZGlhLWVtaXRzLW9iamVjdC1yZXBsYWNlbWVudC5odG1sIFsgRmFp
bHVyZSBdCi13ZWJraXQub3JnL2IvMTMxMjk0IHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3Jl
cGxhY2VkLW9iamVjdHMtaW4tYW5vbnltb3VzLWJsb2Nrcy5odG1sIFsgRmFpbHVyZSBdCi0KIHdl
YmtpdC5vcmcvYi8xMDYzNDAgYWNjZXNzaWJpbGl0eS9pbWctZmFsbHNiYWNrLXRvLXRpdGxlLmh0
bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzEzMTM4MCBhY2Nlc3NpYmlsaXR5L2NoaWxk
cmVuLWNoYW5nZWQtc2VuZHMtbm90aWZpY2F0aW9uLmh0bWwgWyBGYWlsdXJlIF0KZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp
bmRleCBiMTAwNzNiLi43YjY4YWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM
b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQt
MDQtMDkgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KKwor
ICAgICAgICBbQVhdW0dUS10gTm8gbmV3IGxpbmVzIGluIHNvbWUgQVggdGVzdHMgb3V0cHV0Cisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEyOTQKKwor
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgaW1w
bGVtZW50IEh5cGV0ZXh0IG9yIEF0a1RleHQgZm9yIHRoZSBXZWJBcmVhLiBUaG9zZQorICAgICAg
ICBpbnRlcmZhY2VzIHdpbGwgYmUgaW1wbGVtZW50ZWQgYnkgdGhlIGNvbnRhaW5lcnMgKGF1dG9t
YXRpY2FsbHkKKyAgICAgICAgZ2VuZXJhdGVkIG9yIG5vdCkgZm9yIHRoZSBkaWZmZXJlbnQgcGFy
dHMgb2YgdGhlIERPTSBhbmQgdGhlCisgICAgICAgIHJlbmRlciBzdWJ0cmVlIHVuZGVyIHRoaXMg
ZWxlbWVudCBhbnl3YXkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nl
c3NpYmxlV3JhcHBlckF0ay5jcHA6CisgICAgICAgIChnZXRJbnRlcmZhY2VNYXNrRnJvbU9iamVj
dCk6IE1ha2Ugc3VyZSB3ZSBkb24ndCBhcHBseQorICAgICAgICBXQUlIeXBlcnRleHQgbm9yIFdB
SVRleHQgdG8gb2JqZWN0cyB3aXRoIHJvbGUgV2ViQXJlYVJvbGUuCisKIDIwMTQtMDQtMDggIENv
bnJhZCBTaHVsdHogIDxjb25yYWRfc2h1bHR6QGFwcGxlLmNvbT4KIAogICAgICAgICBuaWwgc2hv
dWxkIG9ubHkgYmUgdXNlZCBmb3Igb2JqZWN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv
YWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwIGIvU291cmNl
L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3Bw
CmluZGV4IDIxNGIzNDIuLmZkNmM2MzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz
c2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAK
QEAgLTExNTUsMjkgKzExNTUsMjcgQEAgc3RhdGljIGd1aW50MTYgZ2V0SW50ZXJmYWNlTWFza0Zy
b21PYmplY3QoQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCkKICAgICBpZiAoY29yZU9i
amVjdC0+aXNMaW5rKCkgfHwgKHJlbmRlcmVyICYmIHJlbmRlcmVyLT5pc1JlcGxhY2VkKCkpKQog
ICAgICAgICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJSHlwZXJsaW5rOwogCi0gICAgLy8gVGV4
dCAmIEVkaXRhYmxlIFRleHQKKyAgICAvLyBUZXh0LCBFZGl0YWJsZSBUZXh0ICYgSHlwZXJ0ZXh0
CiAgICAgaWYgKHJvbGUgPT0gU3RhdGljVGV4dFJvbGUgfHwgY29yZU9iamVjdC0+aXNNZW51TGlz
dE9wdGlvbigpKQogICAgICAgICBpbnRlcmZhY2VNYXNrIHw9IDEgPDwgV0FJVGV4dDsKLSAgICBl
bHNlIHsKLSAgICAgICAgaWYgKGNvcmVPYmplY3QtPmlzVGV4dENvbnRyb2woKSkgewotICAgICAg
ICAgICAgaW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSVRleHQ7Ci0gICAgICAgICAgICBpZiAoIWNv
cmVPYmplY3QtPmlzUmVhZE9ubHkoKSkKLSAgICAgICAgICAgICAgICBpbnRlcmZhY2VNYXNrIHw9
IDEgPDwgV0FJRWRpdGFibGVUZXh0OwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgaWYg
KHJvbGUgIT0gVGFibGVSb2xlKSB7Ci0gICAgICAgICAgICAgICAgaW50ZXJmYWNlTWFzayB8PSAx
IDw8IFdBSUh5cGVydGV4dDsKLSAgICAgICAgICAgICAgICBpZiAoKHJlbmRlcmVyICYmIHJlbmRl
cmVyLT5jaGlsZHJlbklubGluZSgpKSB8fCByb2xlSXNUZXh0VHlwZShyb2xlKSkKLSAgICAgICAg
ICAgICAgICAgICAgaW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSVRleHQ7Ci0gICAgICAgICAgICB9
CisgICAgZWxzZSBpZiAoY29yZU9iamVjdC0+aXNUZXh0Q29udHJvbCgpKSB7CisgICAgICAgIGlu
dGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlUZXh0OworICAgICAgICBpZiAoIWNvcmVPYmplY3QtPmlz
UmVhZE9ubHkoKSkKKyAgICAgICAgICAgIGludGVyZmFjZU1hc2sgfD0gMSA8PCBXQUlFZGl0YWJs
ZVRleHQ7CisgICAgfSBlbHNlIGlmICghY29yZU9iamVjdC0+aXNXZWJBcmVhKCkpIHsKKyAgICAg
ICAgaWYgKHJvbGUgIT0gVGFibGVSb2xlKSB7CisgICAgICAgICAgICBpbnRlcmZhY2VNYXNrIHw9
IDEgPDwgV0FJSHlwZXJ0ZXh0OworICAgICAgICAgICAgaWYgKChyZW5kZXJlciAmJiByZW5kZXJl
ci0+Y2hpbGRyZW5JbmxpbmUoKSkgfHwgcm9sZUlzVGV4dFR5cGUocm9sZSkpCisgICAgICAgICAg
ICAgICAgaW50ZXJmYWNlTWFzayB8PSAxIDw8IFdBSVRleHQ7CisgICAgICAgIH0KIAotICAgICAg
ICAgICAgLy8gQWRkIHRoZSBURVhUIGludGVyZmFjZSBmb3IgbGlzdCBpdGVtcyB3aG9zZQotICAg
ICAgICAgICAgLy8gZmlyc3QgYWNjZXNzaWJsZSBjaGlsZCBoYXMgYSB0ZXh0IHJlbmRlcmVyCi0g
ICAgICAgICAgICBpZiAocm9sZSA9PSBMaXN0SXRlbVJvbGUpIHsKLSAgICAgICAgICAgICAgICBj
b25zdCBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIGNo
aWxkcmVuID0gY29yZU9iamVjdC0+Y2hpbGRyZW4oKTsKLSAgICAgICAgICAgICAgICBpZiAoY2hp
bGRyZW4uc2l6ZSgpKSB7Ci0gICAgICAgICAgICAgICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3Qq
IGF4UmVuZGVyQ2hpbGQgPSBjaGlsZHJlbi5hdCgwKS5nZXQoKTsKLSAgICAgICAgICAgICAgICAg
ICAgaW50ZXJmYWNlTWFzayB8PSBnZXRJbnRlcmZhY2VNYXNrRnJvbU9iamVjdChheFJlbmRlckNo
aWxkKTsKLSAgICAgICAgICAgICAgICB9CisgICAgICAgIC8vIEFkZCB0aGUgVEVYVCBpbnRlcmZh
Y2UgZm9yIGxpc3QgaXRlbXMgd2hvc2UKKyAgICAgICAgLy8gZmlyc3QgYWNjZXNzaWJsZSBjaGls
ZCBoYXMgYSB0ZXh0IHJlbmRlcmVyCisgICAgICAgIGlmIChyb2xlID09IExpc3RJdGVtUm9sZSkg
eworICAgICAgICAgICAgY29uc3QgQWNjZXNzaWJpbGl0eU9iamVjdDo6QWNjZXNzaWJpbGl0eUNo
aWxkcmVuVmVjdG9yJiBjaGlsZHJlbiA9IGNvcmVPYmplY3QtPmNoaWxkcmVuKCk7CisgICAgICAg
ICAgICBpZiAoY2hpbGRyZW4uc2l6ZSgpKSB7CisgICAgICAgICAgICAgICAgQWNjZXNzaWJpbGl0
eU9iamVjdCogYXhSZW5kZXJDaGlsZCA9IGNoaWxkcmVuLmF0KDApLmdldCgpOworICAgICAgICAg
ICAgICAgIGludGVyZmFjZU1hc2sgfD0gZ2V0SW50ZXJmYWNlTWFza0Zyb21PYmplY3QoYXhSZW5k
ZXJDaGlsZCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9Ci0tIAoxLjcuMTAuNAoK
</data>
<flag name="review"
          id="253304"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>