131263 2014-04-04 23:27:20 -0700 REGRESSION (r163914): Application cache cannot be used in main frame 2014-04-18 12:33:14 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 128557 1 ap ap andersca beidson commit-queue japhet jeffrey+webkit oldest_to_newest 997841 0 ap 2014-04-04 23:27:20 -0700 We can't look at main frame URL when loading in main frame, because it comes from an unrelated previous page. And when loading into a new page, it's just empty. <rdar://problem/16532063> 997842 1 ap 2014-04-04 23:27:50 -0700 Regression tests didn't detect this, because they all test appcache in subframes. 997843 2 228660 ap 2014-04-04 23:32:29 -0700 Created attachment 228660 proposed fix 997845 3 228661 ap 2014-04-04 23:37:00 -0700 Created attachment 228661 with release build fix 997948 4 228661 sam 2014-04-05 16:21:29 -0700 Comment on attachment 228661 with release build fix Can we add a regression test so this is caught in the future? 997957 5 228661 ap 2014-04-05 17:19:32 -0700 Comment on attachment 228661 with release build fix I couldn't make a test quickly enough, it would have to be somewhat tricky. 997964 6 228661 commit-queue 2014-04-05 17:48:30 -0700 Comment on attachment 228661 with release build fix Clearing flags on attachment: 228661 Committed r166844: <http://trac.webkit.org/changeset/166844> 997965 7 commit-queue 2014-04-05 17:48:33 -0700 All reviewed patches have been landed. Closing bug. 228660 2014-04-04 23:32:29 -0700 2014-04-04 23:37:00 -0700 proposed fix Bad3rdPartyCheck.txt text/plain 2924 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjgyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTA0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNjM5 MTQpOiBBcHBsaWNhdGlvbiBjYWNoZSBjYW5ub3QgYmUgdXNlZCBpbiBtYWluIGZyYW1lCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEyNjMKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE2NTMyMDYzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVI b3N0LmNwcDogKFdlYkNvcmU6OkFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojppc0FwcGxpY2F0aW9uQ2Fj aGVCbG9ja2VkRm9yUmVxdWVzdCk6CisgICAgICAgIERvbid0IGNoZWNrIG1haW4gZnJhbWUgb3Jp Z2luIHdoZW4gbG9hZGluZyBpbnRvIG1haW4gZnJhbWUsIGl0J3Mgbm90IGEgM3JkIHBhcnR5Cisg ICAgICAgIHN1YmZyYW1lLCBhbmQgdGhlIFVSTCBpcyB1bnJlbGF0ZWQgdG8gdGhlIHBhZ2Ugd2Ug YXJlIGxvYWRpbmcgbm93LgorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9u Q2FjaGVHcm91cC5jcHA6IChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlR3JvdXA6OmNhY2hlRm9y TWFpblJlcXVlc3QpOgorICAgICAgICBSZW1vdmVkIHRoZSBzYW1lIGluY29ycmVjdCBjaGVjayB0 aGF0IHdhcyBkdXBsaWNhdGVkIGhlcmUuIFRoZSBvbmx5IGNhbGxlciBhbHJlYWR5CisgICAgICAg IGNoZWNrcyBpc0FwcGxpY2F0aW9uQ2FjaGVCbG9ja2VkRm9yUmVxdWVzdCgpLgorCiAyMDE0LTA0 LTAzICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBob29rIHVwIHByb2JlIHNhbXBsZXMgdG8gVGltZWxpbmVBZ2VudCdzIHJl Y29yZHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNh Y2hlR3JvdXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNo ZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuY3BwCShyZXZpc2lvbiAxNjY4MjEpCisrKyBTb3VyY2Uv V2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTAzLDcgKzEwMyw3IEBAIEFwcGxpY2F0aW9uQ2FjaGUqIEFwcGxpY2F0aW9u Q2FjaGVHcm91cDoKICAgICBpZiAodXJsLmhhc0ZyYWdtZW50SWRlbnRpZmllcigpKQogICAgICAg ICB1cmwucmVtb3ZlRnJhZ21lbnRJZGVudGlmaWVyKCk7CiAKLSAgICBpZiAoZG9jdW1lbnRMb2Fk ZXItPmZyYW1lKCkgJiYgKGRvY3VtZW50TG9hZGVyLT5mcmFtZSgpLT5wYWdlKCktPnVzZXNFcGhl bWVyYWxTZXNzaW9uKCkgfHwgIWRvY3VtZW50TG9hZGVyLT5mcmFtZSgpLT5kb2N1bWVudCgpLT5z ZWN1cml0eU9yaWdpbigpLT5jYW5BY2Nlc3NBcHBsaWNhdGlvbkNhY2hlKGRvY3VtZW50TG9hZGVy LT5mcmFtZSgpLT50cmVlKCkudG9wKCkuZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKSkpKQor ICAgIGlmIChkb2N1bWVudExvYWRlci0+ZnJhbWUoKSAmJiBkb2N1bWVudExvYWRlci0+ZnJhbWUo KS0+cGFnZSgpLT51c2VzRXBoZW1lcmFsU2Vzc2lvbigpKQogICAgICAgICByZXR1cm4gMDsKIAog ICAgIGlmIChBcHBsaWNhdGlvbkNhY2hlR3JvdXAqIGdyb3VwID0gY2FjaGVTdG9yYWdlKCkuY2Fj aGVHcm91cEZvclVSTCh1cmwpKSB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2Fj aGUvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAJKHJldmlzaW9uIDE2Njgy MSkKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9z dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4MSw4ICs0ODEsMTUgQEAgYm9vbCBBcHBsaWNhdGlv bkNhY2hlSG9zdDo6aXNBcHBsaWNhdGlvbgogCiBib29sIEFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojpp c0FwcGxpY2F0aW9uQ2FjaGVCbG9ja2VkRm9yUmVxdWVzdChjb25zdCBSZXNvdXJjZVJlcXVlc3Qm IHJlcXVlc3QpCiB7CisgICAgRnJhbWUqIGZyYW1lID0gbV9kb2N1bWVudExvYWRlci0+ZnJhbWUo KTsKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoZnJh bWUtPmlzTWFpbkZyYW1lKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIFJlZlB0cjxT ZWN1cml0eU9yaWdpbj4gb3JpZ2luID0gU2VjdXJpdHlPcmlnaW46OmNyZWF0ZShyZXF1ZXN0LnVy bCgpKTsKLSAgICByZXR1cm4gbV9kb2N1bWVudExvYWRlci0+ZnJhbWUoKSAmJiAhb3JpZ2luLT5j YW5BY2Nlc3NBcHBsaWNhdGlvbkNhY2hlKG1fZG9jdW1lbnRMb2FkZXItPmZyYW1lKCktPmRvY3Vt ZW50KCktPnRvcE9yaWdpbigpKTsKKyAgICByZXR1cm4gIW9yaWdpbi0+Y2FuQWNjZXNzQXBwbGlj YXRpb25DYWNoZShmcmFtZS0+ZG9jdW1lbnQoKS0+dG9wT3JpZ2luKCkpOwogfQogCiB9ICAvLyBu YW1lc3BhY2UgV2ViQ29yZQo= 228661 2014-04-04 23:37:00 -0700 2014-04-05 17:48:30 -0700 with release build fix Bad3rdPartyCheck.txt text/plain 3149 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjgyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA0LTA0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNjM5 MTQpOiBBcHBsaWNhdGlvbiBjYWNoZSBjYW5ub3QgYmUgdXNlZCBpbiBtYWluIGZyYW1lCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEyNjMKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE2NTMyMDYzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVI b3N0LmNwcDogKFdlYkNvcmU6OkFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojppc0FwcGxpY2F0aW9uQ2Fj aGVCbG9ja2VkRm9yUmVxdWVzdCk6CisgICAgICAgIERvbid0IGNoZWNrIG1haW4gZnJhbWUgb3Jp Z2luIHdoZW4gbG9hZGluZyBpbnRvIG1haW4gZnJhbWUsIGl0J3Mgbm90IGEgM3JkIHBhcnR5Cisg ICAgICAgIHN1YmZyYW1lLCBhbmQgdGhlIFVSTCBpcyB1bnJlbGF0ZWQgdG8gdGhlIHBhZ2Ugd2Ug YXJlIGxvYWRpbmcgbm93LgorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9u Q2FjaGVHcm91cC5jcHA6IChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlR3JvdXA6OmNhY2hlRm9y TWFpblJlcXVlc3QpOgorICAgICAgICBSZW1vdmVkIHRoZSBzYW1lIGluY29ycmVjdCBjaGVjayB0 aGF0IHdhcyBkdXBsaWNhdGVkIGhlcmUuIFRoZSBvbmx5IGNhbGxlciBhbHJlYWR5CisgICAgICAg IGNoZWNrcyBpc0FwcGxpY2F0aW9uQ2FjaGVCbG9ja2VkRm9yUmVxdWVzdCgpLgorCiAyMDE0LTA0 LTAzICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBob29rIHVwIHByb2JlIHNhbXBsZXMgdG8gVGltZWxpbmVBZ2VudCdzIHJl Y29yZHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNh Y2hlR3JvdXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNo ZS9BcHBsaWNhdGlvbkNhY2hlR3JvdXAuY3BwCShyZXZpc2lvbiAxNjY4MjEpCisrKyBTb3VyY2Uv V2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUdyb3VwLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTAzLDcgKzEwMyw3IEBAIEFwcGxpY2F0aW9uQ2FjaGUqIEFwcGxpY2F0aW9u Q2FjaGVHcm91cDoKICAgICBpZiAodXJsLmhhc0ZyYWdtZW50SWRlbnRpZmllcigpKQogICAgICAg ICB1cmwucmVtb3ZlRnJhZ21lbnRJZGVudGlmaWVyKCk7CiAKLSAgICBpZiAoZG9jdW1lbnRMb2Fk ZXItPmZyYW1lKCkgJiYgKGRvY3VtZW50TG9hZGVyLT5mcmFtZSgpLT5wYWdlKCktPnVzZXNFcGhl bWVyYWxTZXNzaW9uKCkgfHwgIWRvY3VtZW50TG9hZGVyLT5mcmFtZSgpLT5kb2N1bWVudCgpLT5z ZWN1cml0eU9yaWdpbigpLT5jYW5BY2Nlc3NBcHBsaWNhdGlvbkNhY2hlKGRvY3VtZW50TG9hZGVy LT5mcmFtZSgpLT50cmVlKCkudG9wKCkuZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKSkpKQor ICAgIGlmIChkb2N1bWVudExvYWRlci0+ZnJhbWUoKSAmJiBkb2N1bWVudExvYWRlci0+ZnJhbWUo KS0+cGFnZSgpLT51c2VzRXBoZW1lcmFsU2Vzc2lvbigpKQogICAgICAgICByZXR1cm4gMDsKIAog ICAgIGlmIChBcHBsaWNhdGlvbkNhY2hlR3JvdXAqIGdyb3VwID0gY2FjaGVTdG9yYWdlKCkuY2Fj aGVHcm91cEZvclVSTCh1cmwpKSB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2Fj aGUvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAJKHJldmlzaW9uIDE2Njgy MSkKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9z dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKICNpbmNsdWRlICJGcmFtZUxv YWRlci5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50LmgiCiAjaW5jbHVkZSAiSW5zcGVj dG9ySW5zdHJ1bWVudGF0aW9uLmgiCisjaW5jbHVkZSAiTWFpbkZyYW1lLmgiCiAjaW5jbHVkZSAi UHJvZ3Jlc3NFdmVudC5oIgogI2luY2x1ZGUgIlJlc291cmNlSGFuZGxlLmgiCiAjaW5jbHVkZSAi UmVzb3VyY2VMb2FkZXIuaCIKQEAgLTQ4MSw4ICs0ODIsMTUgQEAgYm9vbCBBcHBsaWNhdGlvbkNh Y2hlSG9zdDo6aXNBcHBsaWNhdGlvbgogCiBib29sIEFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojppc0Fw cGxpY2F0aW9uQ2FjaGVCbG9ja2VkRm9yUmVxdWVzdChjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJl cXVlc3QpCiB7CisgICAgRnJhbWUqIGZyYW1lID0gbV9kb2N1bWVudExvYWRlci0+ZnJhbWUoKTsK KyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoZnJhbWUt PmlzTWFpbkZyYW1lKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIFJlZlB0cjxTZWN1 cml0eU9yaWdpbj4gb3JpZ2luID0gU2VjdXJpdHlPcmlnaW46OmNyZWF0ZShyZXF1ZXN0LnVybCgp KTsKLSAgICByZXR1cm4gbV9kb2N1bWVudExvYWRlci0+ZnJhbWUoKSAmJiAhb3JpZ2luLT5jYW5B Y2Nlc3NBcHBsaWNhdGlvbkNhY2hlKG1fZG9jdW1lbnRMb2FkZXItPmZyYW1lKCktPmRvY3VtZW50 KCktPnRvcE9yaWdpbigpKTsKKyAgICByZXR1cm4gIW9yaWdpbi0+Y2FuQWNjZXNzQXBwbGljYXRp b25DYWNoZShmcmFtZS0+ZG9jdW1lbnQoKS0+dG9wT3JpZ2luKCkpOwogfQogCiB9ICAvLyBuYW1l c3BhY2UgV2ViQ29yZQo=