131258 2014-04-04 21:15:06 -0700 Honor System-Level User Preferences for Captions Display 2014-04-07 20:52:00 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 131344 1 bfulgham bfulgham bfulgham calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble jonlee philipj sergio oldest_to_newest 997820 0 bfulgham 2014-04-04 21:15:06 -0700 WebKit doesn't properly honor the global user preferences for caption display in a few cases: 1. When a video starts playing, it should show captions if the user's preferences indicate a preference for caption display. 2. While a video is playing, captions should turn on/off as the user changes preferences. 3. Regardless of the user's preferences, if the user manually selects captions they should be displayed. In all cases, the result of the following JavaScript should reflect what's going on in the video playback: document.querySelector("video").webkitClosedCaptionsVisible 997821 1 bfulgham 2014-04-04 21:15:55 -0700 <rdar://problem/15745400> <rdar://problem/15745452> 997825 2 228653 bfulgham 2014-04-04 21:24:30 -0700 Created attachment 228653 Patch 997826 3 228653 bfulgham 2014-04-04 21:27:35 -0700 Comment on attachment 228653 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228653&action=review > Source/WebCore/html/HTMLMediaElement.cpp:-3713 > - m_captionDisplayMode = displayMode; I needed to do this so that the "ForceOn" state was properly seen by system. 997830 4 bfulgham 2014-04-04 22:20:17 -0700 All tests (including uncommitted region tests) pass with this change. 997937 5 jonlee 2014-04-05 14:22:45 -0700 (In reply to comment #4) > All tests (including uncommitted region tests) pass with this change. Additional test case, then? 997978 6 bfulgham 2014-04-05 20:04:36 -0700 (In reply to comment #5) > (In reply to comment #4) > > All tests (including uncommitted region tests) pass with this change. > > Additional test case, then? after looking at it, I realize it's just a local copy of one of the Opera tests. I'm trying to get the whole set of them turned on in an upcoming patch. 998038 7 bfulgham 2014-04-06 16:22:15 -0700 Committed r166858: <http://trac.webkit.org/changeset/166858> 228653 2014-04-04 21:24:30 -0700 2014-04-04 22:28:42 -0700 Patch bug-131258-20140404212410.patch text/plain 3136 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjgyNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA0LTA0ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEhvbm9yIFN5c3RlbS1MZXZl bCBVc2VyIFByZWZlcmVuY2VzIGZvciBDYXB0aW9uIERpc3BsYXkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTI1OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnNldFNlbGVjdGVkVGV4dFRy YWNrKTogQWxsb3cgcHJlZmVyZW5jZWQgY2hhbmdlIHRvIGZ1bGx5IGRpc3BhdGNoCisgICAgICAg IHNvIHdlIGNhbiBwcm9wZXJseSBkZWFsIHdpdGggY2FwdGlvbnMgYmVpbmcgdHVybmVkIG9mZi4K KyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNhcHRpb25QcmVmZXJlbmNlc0No YW5nZWQpOiBVc2UgJ3dlYmtpdCcgdmFyaWFudCBvZiB0aGUKKyAgICAgICAgc2V0V2ViS2l0Q2xv c2VkQ2FwdGlvbnNWaXNpYmxlIG1ldGhvZCBzbyB3ZSBwcm9wZXJseSBhZGp1c3Qgc2V0dGluZ3Mg bmVlZGVkIGZvciB0aGUgSlMgQVBJIGNhbGwuCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFD b250cm9sRWxlbWVudHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sVGV4dFRy YWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlRGlzcGxheSk6IFdoZW4gY2FwdGlvbnMgYXJlIHR1 cm5lZCBvZmYsIGUuZy4KKyAgICAgICAgYmVjYXVzZSB0aGUgdXNlciB0dXJuZWQgb2ZmIHRoZSBw cmVmZXJlbmNlLCBkb24ndCBpbmFkdmVydGVudGx5IHR1cm4gdGhlbSBiYWNrIG9uIGp1c3QgYmFj YXVzZSB0aGVyZQorICAgICAgICB3YXMgYW4gZXhpc3RpbmcgdHJhY2sgdGhhdCB3YXMgbm90IGlu IGEgJ2hpZGRlbicgc3RhdGUuCisKIDIwMTQtMDQtMDQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdA YXBwbGUuY29tPgogCiAgICAgICAgIFN0cmVhbWxpbmUgY2FjaGVkIHdyYXBwZXIgbG9va3VwIGZv ciBOb2RlcyBpbiB0aGUgbm9ybWFsIHdvcmxkLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNjY3OTEpCisrKyBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzA4LDkgKzM3MDgs NiBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldFNlbGVjdGVkVGV4dFRyCiAgICAgICAgIGRp c3BsYXlNb2RlID0gQ2FwdGlvblVzZXJQcmVmZXJlbmNlczo6QWx3YXlzT247CiAgICAgICAgIGlm ICh0cmFja1RvU2VsZWN0LT5sYW5ndWFnZSgpLmxlbmd0aCgpKQogICAgICAgICAgICAgY2FwdGlv blByZWZlcmVuY2VzLT5zZXRQcmVmZXJyZWRMYW5ndWFnZSh0cmFja1RvU2VsZWN0LT5sYW5ndWFn ZSgpKTsKLSAgICAgICAgCi0gICAgICAgIC8vIFNldCBtX2NhcHRpb25EaXNwbGF5TW9kZSBoZXJl IHNvIHdlIGRvbid0IHJlY29uZmlndXJlIGFnYWluIHdoZW4gdGhlIHByZWZlcmVuY2UgY2hhbmdl ZCBub3RpZmljYXRpb24gY29tZXMgdGhyb3VnaC4KLSAgICAgICAgbV9jYXB0aW9uRGlzcGxheU1v ZGUgPSBkaXNwbGF5TW9kZTsKICAgICB9CiAKICAgICBjYXB0aW9uUHJlZmVyZW5jZXMtPnNldENh cHRpb25EaXNwbGF5TW9kZShkaXNwbGF5TW9kZSk7CkBAIC01NDIwLDcgKzU0MTcsNyBAQCB2b2lk IEhUTUxNZWRpYUVsZW1lbnQ6OmNhcHRpb25QcmVmZXJlbmNlCiAgICAgICAgIHJldHVybjsKIAog ICAgIG1fY2FwdGlvbkRpc3BsYXlNb2RlID0gZGlzcGxheU1vZGU7Ci0gICAgc2V0Q2xvc2VkQ2Fw dGlvbnNWaXNpYmxlKG1fY2FwdGlvbkRpc3BsYXlNb2RlID09IENhcHRpb25Vc2VyUHJlZmVyZW5j ZXM6OkFsd2F5c09uKTsKKyAgICBzZXRXZWJraXRDbG9zZWRDYXB0aW9uc1Zpc2libGUobV9jYXB0 aW9uRGlzcGxheU1vZGUgPT0gQ2FwdGlvblVzZXJQcmVmZXJlbmNlczo6QWx3YXlzT24pOwogfQog CiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6Om1hcmtDYXB0aW9uQW5kU3VidGl0bGVUcmFja3NBc1Vu Y29uZmlndXJlZChSZWNvbmZpZ3VyZU1vZGUgbW9kZSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0 bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAJKHJldmlzaW9uIDE2 Njc5MSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRz LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMxMCw2ICsxMzEwLDkgQEAgdm9pZCBNZWRpYUNvbnRy b2xUZXh0VHJhY2tDb250YWluZXJFbGVtZQogICAgIC8vIGNvcnJlc3BvbmRpbmcgQ1NTIGJveGVz IGFkZGVkIHRvIG91dHB1dCwgaW4gdGV4dCB0cmFjayBjdWUgb3JkZXIsIHJ1biB0aGUKICAgICAv LyBmb2xsb3dpbmcgc3Vic3RlcHM6CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBhY3RpdmVD dWVzLnNpemUoKTsgKytpKSB7CisgICAgICAgIGlmICghbWVkaWFDb250cm9sbGVyKCktPmNsb3Nl ZENhcHRpb25zVmlzaWJsZSgpKQorICAgICAgICAgICAgY29udGludWU7CisKICAgICAgICAgVGV4 dFRyYWNrQ3VlKiB0ZXh0VHJhY2tDdWUgPSBhY3RpdmVDdWVzW2ldLmRhdGEoKTsKICAgICAgICAg aWYgKCF0ZXh0VHJhY2tDdWUtPmlzUmVuZGVyYWJsZSgpKQogICAgICAgICAgICAgY29udGludWU7 Cg==