131253 2014-04-04 19:03:20 -0700 Web Inspector: JSContext inspection Resource search throws exception 2014-04-04 20:54:33 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 997789 0 joepeck 2014-04-04 19:03:20 -0700 Fix the exception, and we should make resource search work. Making it work is tracked by: <https://webkit.org/b/131252> Web Inspector: JSContext inspection Resource search does not work 997792 1 228646 joepeck 2014-04-04 19:06:28 -0700 Created attachment 228646 [PATCH] Proposed Fix 997816 2 228646 commit-queue 2014-04-04 20:54:30 -0700 Comment on attachment 228646 [PATCH] Proposed Fix Clearing flags on attachment: 228646 Committed r166825: <http://trac.webkit.org/changeset/166825> 997817 3 commit-queue 2014-04-04 20:54:33 -0700 All reviewed patches have been landed. Closing bug. 228646 2014-04-04 19:06:28 -0700 2014-04-04 20:54:30 -0700 [PATCH] Proposed Fix search.patch text/plain 2760 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZjOGE3ODEuLmY4OWQ1MjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTA0LTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSlNDb250 ZXh0IGluc3BlY3Rpb24gUmVzb3VyY2Ugc2VhcmNoIHRocm93cyBleGNlcHRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTI1MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZhaWwgZ3JhY2VmdWxseSB3 aGVuIG5vbmUgb2YgdGhlIHN1cHBvcnRlZCBzZWFyY2ggYmFja2VuZHMgYXJlIGF2YWlsYWJsZS4K KyAgICAgICAgSW4gSlNDb250ZXh0IGluc3BlY3Rpb24gdGhlIERPTSBhbmQgUGFnZSBhZ2VudHMg YXJlIHVuYXZhaWxhYmxlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJj ZVNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZVNpZGViYXJQ YW5lbC5wcm90b3R5cGUucGVyZm9ybVNlYXJjaCk6CisKKzIwMTQtMDQtMDQgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBKU0Nv bnRleHQgaW5zcGVjdGlvbiAtIFR5cGVFcnJvcjogbnVsbCBpcyBub3QgYW4gb2JqZWN0IChldmFs dWF0aW5nICdjb250ZW50Vmlldy5zaG93U291cmNlQ29kZScpCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4NTcKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFyUGFuZWwu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVNp ZGViYXJQYW5lbC5qcwppbmRleCA2MTBkZjRhLi44MWRhNzlkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVNpZGViYXJQYW5lbC5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJj ZVNpZGViYXJQYW5lbC5qcwpAQCAtNDUxLDE3ICs0NTEsMjYgQEAgV2ViSW5zcGVjdG9yLlJlc291 cmNlU2lkZWJhclBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIERPTUFnZW50LmdldFNl YXJjaFJlc3VsdHMoc2VhcmNoSWQsIDAsIHJlc3VsdHNDb3VudCwgZG9tU2VhcmNoUmVzdWx0cy5i aW5kKHRoaXMpKTsKICAgICAgICAgfQogCi0gICAgICAgIFdlYkluc3BlY3Rvci5kb21UcmVlTWFu YWdlci5yZXF1ZXN0RG9jdW1lbnQoKTsKKyAgICAgICAgaWYgKHdpbmRvdy5ET01BZ2VudCkKKyAg ICAgICAgICAgIFdlYkluc3BlY3Rvci5kb21UcmVlTWFuYWdlci5yZXF1ZXN0RG9jdW1lbnQoKTsK IAogICAgICAgICAvLyBGSVhNRTogU2hvdWxkIHdlIGJlIHNlYXJjaGluZyBmb3IgcmVnZXhlcyBv ciBqdXN0IHBsYWluIHRleHQ/Ci0gICAgICAgIFBhZ2VBZ2VudC5zZWFyY2hJblJlc291cmNlcyhz ZWFyY2hUZXJtLCBmYWxzZSwgZmFsc2UsIHJlc291cmNlc0NhbGxiYWNrLmJpbmQodGhpcykpOwor ICAgICAgICBpZiAod2luZG93LlBhZ2VBZ2VudCkKKyAgICAgICAgICAgIFBhZ2VBZ2VudC5zZWFy Y2hJblJlc291cmNlcyhzZWFyY2hUZXJtLCBmYWxzZSwgZmFsc2UsIHJlc291cmNlc0NhbGxiYWNr LmJpbmQodGhpcykpOwogCi0gICAgICAgIGlmICgiX2RvbVNlYXJjaElkZW50aWZpZXIiIGluIHRo aXMpIHsKLSAgICAgICAgICAgIERPTUFnZW50LmRpc2NhcmRTZWFyY2hSZXN1bHRzKHRoaXMuX2Rv bVNlYXJjaElkZW50aWZpZXIpOwotICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2RvbVNlYXJjaElk ZW50aWZpZXI7CisgICAgICAgIGlmICh3aW5kb3cuRE9NQWdlbnQpIHsKKyAgICAgICAgICAgIGlm ICgiX2RvbVNlYXJjaElkZW50aWZpZXIiIGluIHRoaXMpIHsKKyAgICAgICAgICAgICAgICBET01B Z2VudC5kaXNjYXJkU2VhcmNoUmVzdWx0cyh0aGlzLl9kb21TZWFyY2hJZGVudGlmaWVyKTsKKyAg ICAgICAgICAgICAgICBkZWxldGUgdGhpcy5fZG9tU2VhcmNoSWRlbnRpZmllcjsKKyAgICAgICAg ICAgIH0KKworICAgICAgICAgICAgRE9NQWdlbnQucGVyZm9ybVNlYXJjaChzZWFyY2hUZXJtLCBk b21DYWxsYmFjay5iaW5kKHRoaXMpKTsKICAgICAgICAgfQogCi0gICAgICAgIERPTUFnZW50LnBl cmZvcm1TZWFyY2goc2VhcmNoVGVybSwgZG9tQ2FsbGJhY2suYmluZCh0aGlzKSk7CisgICAgICAg IC8vIEZJWE1FOiBSZXNvdXJjZSBzZWFyY2ggc2hvdWxkIHdvcmsgaW4gSlNDb250ZXh0IGluc3Bl Y3Rpb24uCisgICAgICAgIC8vIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzEyNTI+IFdlYiBJbnNw ZWN0b3I6IEpTQ29udGV4dCBpbnNwZWN0aW9uIFJlc291cmNlIHNlYXJjaCBkb2VzIG5vdCB3b3Jr CisgICAgICAgIGlmICghd2luZG93LkRPTUFnZW50ICYmICF3aW5kb3cuUGFnZUFnZW50KQorICAg ICAgICAgICAgdXBkYXRlRW1wdHlDb250ZW50UGxhY2Vob2xkZXJTb29uLmNhbGwodGhpcyk7CiAg ICAgfSwKIAogICAgIC8vIFByaXZhdGUK