131251 2014-04-04 18:34:17 -0700 Remove bogus ASSERT in -JSVirtualMachine scanObjectGraph 2014-04-05 12:54:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 997783 0 mhahnenberg 2014-04-04 18:34:17 -0700 ... 997809 1 228650 mhahnenberg 2014-04-04 20:27:19 -0700 Created attachment 228650 Patch 997818 2 228650 fpizlo 2014-04-04 20:54:56 -0700 Comment on attachment 228650 Patch Why was it bogus? 997824 3 mhahnenberg 2014-04-04 21:20:26 -0700 (In reply to comment #2) > (From update of attachment 228650 [details]) > Why was it bogus? If you look at the other code in JSVirtualMachine, it's all written in such a way where having duplicate entries between an owner and an owned object is ok (e.g. addManagedReference:withOwner:). I think I added this ASSERT before I made it okay to do that and just forgot to remove the ASSERT. 997900 4 228650 ggaren 2014-04-05 10:41:35 -0700 Comment on attachment 228650 Patch r=me 997906 5 mhahnenberg 2014-04-05 12:26:32 -0700 <rdar://problem/16520725> 997912 6 228650 commit-queue 2014-04-05 12:54:45 -0700 Comment on attachment 228650 Patch Clearing flags on attachment: 228650 Committed r166835: <http://trac.webkit.org/changeset/166835> 997913 7 commit-queue 2014-04-05 12:54:47 -0700 All reviewed patches have been landed. Closing bug. 228650 2014-04-04 20:27:19 -0700 2014-04-05 12:54:44 -0700 Patch bug-131251-20140404202658.patch text/plain 2711 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2ODIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTA0LTA0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIGJvZ3VzIEFTU0VSVCBpbiAtSlNWaXJ0dWFsTWFjaGluZSBzY2FuT2Jq ZWN0R3JhcGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzMTI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQVBJL0pTVmlydHVhbE1hY2hpbmUubW06CisgICAgICAgIChzY2FuRXh0ZXJuYWxPYmplY3RH cmFwaCk6CisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkubW06CisKIDIwMTQtMDQtMDQgIENv bW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIxNjY4MjAuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTVmlydHVhbE1hY2hpbmUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS9KU1ZpcnR1YWxNYWNoaW5lLm1tCShyZXZpc2lvbiAxNjY4MTkpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0JKHdvcmtpbmcgY29weSkKQEAgLTI1 NSwxMCArMjU1LDggQEAgdm9pZCBzY2FuRXh0ZXJuYWxPYmplY3RHcmFwaChKU0M6OlZNJiB2bQog ICAgICAgICAgICAgTlNNYXBUYWJsZSAqb3duZWRPYmplY3RzID0gW2V4dGVybmFsT2JqZWN0R3Jh cGggb2JqZWN0Rm9yS2V5OnN0YXRpY19jYXN0PGlkPihuZXh0Um9vdCldOwogICAgICAgICAgICAg aWQgb3duZWRPYmplY3Q7CiAgICAgICAgICAgICBOU0VudW1lcmF0b3IgKmVudW1lcmF0b3IgPSBb b3duZWRPYmplY3RzIGtleUVudW1lcmF0b3JdOwotICAgICAgICAgICAgd2hpbGUgKChvd25lZE9i amVjdCA9IFtlbnVtZXJhdG9yIG5leHRPYmplY3RdKSkgewotICAgICAgICAgICAgICAgIEFTU0VS VChyZWludGVycHJldF9jYXN0PHNpemVfdD4oTlNNYXBHZXQob3duZWRPYmplY3RzLCBvd25lZE9i amVjdCkpID09IDEpOworICAgICAgICAgICAgd2hpbGUgKChvd25lZE9iamVjdCA9IFtlbnVtZXJh dG9yIG5leHRPYmplY3RdKSkKICAgICAgICAgICAgICAgICBzdGFjay5hcHBlbmQoc3RhdGljX2Nh c3Q8dm9pZCo+KG93bmVkT2JqZWN0KSk7Ci0gICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9 CiB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tCShy ZXZpc2lvbiAxNjY4MTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3Rh cGkubW0JKHdvcmtpbmcgY29weSkKQEAgLTExMzksNiArMTEzOSwxOSBAQCB2b2lkIHRlc3RPYmpl Y3RpdmVDQVBJKCkKIAogICAgIEBhdXRvcmVsZWFzZXBvb2wgewogICAgICAgICBKU0NvbnRleHQg KmNvbnRleHQgPSBbW0pTQ29udGV4dCBhbGxvY10gaW5pdF07CisgICAgICAgIFRlc3RPYmplY3Qg KnRlc3RPYmplY3QgPSBbVGVzdE9iamVjdCB0ZXN0T2JqZWN0XTsKKyAgICAgICAgY29udGV4dFtA InRlc3RPYmplY3QiXSA9IHRlc3RPYmplY3Q7CisgICAgICAgIEpTTWFuYWdlZFZhbHVlICptYW5h Z2VkVmFsdWUgPSBuaWw7CisgICAgICAgIEBhdXRvcmVsZWFzZXBvb2wgeworICAgICAgICAgICAg SlNWYWx1ZSAqb2JqZWN0ID0gW0pTVmFsdWUgdmFsdWVXaXRoTmV3T2JqZWN0SW5Db250ZXh0OmNv bnRleHRdOworICAgICAgICAgICAgbWFuYWdlZFZhbHVlID0gW0pTTWFuYWdlZFZhbHVlIG1hbmFn ZWRWYWx1ZVdpdGhWYWx1ZTpvYmplY3QgYW5kT3duZXI6dGVzdE9iamVjdF07CisgICAgICAgICAg ICBbY29udGV4dC52aXJ0dWFsTWFjaGluZSBhZGRNYW5hZ2VkUmVmZXJlbmNlOm1hbmFnZWRWYWx1 ZSB3aXRoT3duZXI6dGVzdE9iamVjdF07CisgICAgICAgIH0KKyAgICAgICAgSlNTeW5jaHJvbm91 c0dhcmJhZ2VDb2xsZWN0Rm9yRGVidWdnaW5nKFtjb250ZXh0IEpTR2xvYmFsQ29udGV4dFJlZl0p OworICAgIH0KKworICAgIEBhdXRvcmVsZWFzZXBvb2wgeworICAgICAgICBKU0NvbnRleHQgKmNv bnRleHQgPSBbW0pTQ29udGV4dCBhbGxvY10gaW5pdF07CiAgICAgICAgIGNvbnRleHRbQCJNeUNs YXNzIl0gPSBeewogICAgICAgICAgICAgSlNWYWx1ZSAqbmV3VGhpcyA9IFtKU1ZhbHVlIHZhbHVl V2l0aE5ld09iamVjdEluQ29udGV4dDpbSlNDb250ZXh0IGN1cnJlbnRDb250ZXh0XV07CiAgICAg ICAgICAgICBKU0dsb2JhbENvbnRleHRSZWYgY29udGV4dFJlZiA9IFtbSlNDb250ZXh0IGN1cnJl bnRDb250ZXh0XSBKU0dsb2JhbENvbnRleHRSZWZdOwo=