131241 2014-04-04 15:20:36 -0700 Web Inspector: Log JS Exceptions to System Console if JavaScriptCoreOutputConsoleMessagesToSystemConsole enabled 2014-04-04 16:55:28 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 997699 0 joepeck 2014-04-04 15:20:36 -0700 We do this in WebCore when enabling the system console logging. We should do this for exceptions as well. I did not include the backtrace of the exception, but we could add that if we want to. 997700 1 webkit-bug-importer 2014-04-04 15:21:10 -0700 <rdar://problem/16529729> 997701 2 228620 joepeck 2014-04-04 15:21:55 -0700 Created attachment 228620 [PATCH] Proposed Fix 997743 3 228620 timothy 2014-04-04 16:24:35 -0700 Comment on attachment 228620 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=228620&action=review > Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:162 > + ConsoleClient::printConsoleMessage(MessageSource::JS, MessageType::Log, MessageLevel::Error, errorMessage, callFrame.sourceURL(), callFrame.lineNumber(), callFrame.columnNumber()); Would be good to print the whole stack by passing in callStack and treating it like a console.trace. 997755 4 228620 commit-queue 2014-04-04 16:55:25 -0700 Comment on attachment 228620 [PATCH] Proposed Fix Clearing flags on attachment: 228620 Committed r166816: <http://trac.webkit.org/changeset/166816> 997756 5 commit-queue 2014-04-04 16:55:28 -0700 All reviewed patches have been landed. Closing bug. 228620 2014-04-04 15:21:55 -0700 2014-04-04 16:55:25 -0700 [PATCH] Proposed Fix exception.patch text/plain 2072 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk0MjQ2NjMuLjAzMjIzMzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA0LTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTG9nIEpT IEV4Y2VwdGlvbnMgdG8gU3lzdGVtIENvbnNvbGUgaWYgSmF2YVNjcmlwdENvcmVPdXRwdXRDb25z b2xlTWVzc2FnZXNUb1N5c3RlbUNvbnNvbGUgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNw ZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6SlNHbG9iYWxPYmplY3RJ bnNwZWN0b3JDb250cm9sbGVyOjpyZXBvcnRBUElFeGNlcHRpb24pOgorICAgICAgICBMb2cgdGhl IGV4Y2VwdGlvbiB0byB0aGUgc3lzdGVtIGNvbnNvbGUgaWYgc3lzdGVtIGNvbnNvbGUgb3V0cHV0 IGlzIGVuYWJsZWQuCisKIDIwMTQtMDQtMDMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBKU0NvbnRleHQgaW5zcGVjdGlvbiBw cm92aWRlIGEgd2F5IHRvIG9wdC1vdXQgb2YgaW5jbHVkaW5nIE5hdGl2ZSBDYWxsIFN0YWNrcyBp biBFeGNlcHRpb24gdHJhY2VzIHJlcG9ydGVkIHRvIFdlYiBJbnNwZWN0b3IKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JD b250cm9sbGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxP YmplY3RJbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCA3MTM5MDhhLi45ZTljN2ZiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5z cGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC0xNTYsNiArMTU2LDE0 IEBAIHZvaWQgSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyOjpyZXBvcnRBUElFeGNl cHRpb24oRXhlY1N0YXRlKiBleGVjLCBKU1ZhCiAgICAgU3RyaW5nIGVycm9yTWVzc2FnZSA9IGV4 Y2VwdGlvbi50b1N0cmluZyhleGVjKS0+dmFsdWUoZXhlYyk7CiAgICAgZXhlYy0+Y2xlYXJFeGNl cHRpb24oKTsKIAorICAgIGlmIChKU0NvbnNvbGVDbGllbnQ6OmxvZ1RvU3lzdGVtQ29uc29sZSgp KSB7CisgICAgICAgIGlmIChjYWxsU3RhY2stPnNpemUoKSkgeworICAgICAgICAgICAgY29uc3Qg U2NyaXB0Q2FsbEZyYW1lJiBjYWxsRnJhbWUgPSBjYWxsU3RhY2stPmF0KDApOworICAgICAgICAg ICAgQ29uc29sZUNsaWVudDo6cHJpbnRDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlOjpKUywg TWVzc2FnZVR5cGU6OkxvZywgTWVzc2FnZUxldmVsOjpFcnJvciwgZXJyb3JNZXNzYWdlLCBjYWxs RnJhbWUuc291cmNlVVJMKCksIGNhbGxGcmFtZS5saW5lTnVtYmVyKCksIGNhbGxGcmFtZS5jb2x1 bW5OdW1iZXIoKSk7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgQ29uc29sZUNsaWVudDo6 cHJpbnRDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlOjpKUywgTWVzc2FnZVR5cGU6OkxvZywg TWVzc2FnZUxldmVsOjpFcnJvciwgZXJyb3JNZXNzYWdlLCBTdHJpbmcoKSwgMCwgMCk7CisgICAg fQorCiAgICAgbV9jb25zb2xlQWdlbnQtPmFkZE1lc3NhZ2VUb0NvbnNvbGUoTWVzc2FnZVNvdXJj ZTo6SlMsIE1lc3NhZ2VUeXBlOjpMb2csIE1lc3NhZ2VMZXZlbDo6RXJyb3IsIGVycm9yTWVzc2Fn ZSwgY2FsbFN0YWNrKTsKIH0KIAo=