131236 2014-04-04 12:11:15 -0700 Implement audio track selection in fullscreen. 2015-02-06 16:40:03 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk bfulgham bfulgham jonlee webkit-bug-importer oldest_to_newest 997660 0 jeremyj-wk 2014-04-04 12:11:15 -0700 WebVideoFullscreenModelMediaElement::selectAudioMediaOption needs an implementation. WebVideoFullscreenModelMediaElement also needs to push the media media selection options when they change. 998610 1 webkit-bug-importer 2014-04-08 09:39:44 -0700 <rdar://problem/16552632> 1067448 2 246185 bfulgham 2015-02-06 16:01:00 -0800 Created attachment 246185 Patch 1067458 3 bfulgham 2015-02-06 16:40:03 -0800 Committed r179768: <http://trac.webkit.org/changeset/179768> 246185 2015-02-06 16:01:00 -0800 2015-02-06 16:36:49 -0800 Patch bug-131236-20150206160058.patch text/plain 4362 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTc2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTA2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEltcGxlbWVudCBh dWRpbyB0cmFjayBzZWxlY3Rpb24gaW4gZnVsbHNjcmVlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTIzNgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTY1NTI2MzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxWaWRlb0VsZW1lbnQu aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxWaWRlb0Vs ZW1lbnQubW06CisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbFZpZGVvRWxlbWVudDo6 c2VsZWN0QXVkaW9NZWRpYU9wdGlvbik6IFByb3ZpZGUgaW1wbGVtZW50YXRpb24uCisgICAgICAg IChXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbFZpZGVvRWxlbWVudDo6dXBkYXRlTGVnaWJsZU9wdGlv bnMpOiBBZGQgYXVkaW8gdHJhY2sgaW5mb3JtYXRpb24KKyAgICAgICAgdG8gbWVudSBkaXNwbGF5 ZWQgdG8gdXNlci4KKwogMjAxNS0wMi0wNiAgQmFydGxvbWllaiBHYWpkYSAgPGIuZ2FqZGFAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW01TRV0gSW1wbGVtZW50IEFwcGVuZCBFcnJvciBhbGdvcml0 aG0uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVu TW9kZWxWaWRlb0VsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxWaWRlb0VsZW1lbnQuaAkocmV2aXNpb24gMTc5 NzQ3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbk1v ZGVsVmlkZW9FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgzLDcgQEAgcHJpdmF0 ZToKICAgICBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2UqIG1fdmlkZW9GdWxsc2NyZWVuSW50 ZXJmYWNlOwogICAgIEZsb2F0UmVjdCBtX3ZpZGVvRnJhbWU7CiAgICAgVmVjdG9yPFJlZlB0cjxU ZXh0VHJhY2s+PiBtX2xlZ2libGVUcmFja3NGb3JNZW51OworICAgIFZlY3RvcjxSZWZQdHI8QXVk aW9UcmFjaz4+IG1fYXVkaW9UcmFja3NGb3JNZW51OwogCiAgICAgdm9pZCB1cGRhdGVMZWdpYmxl T3B0aW9ucygpOwogfTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRl b0Z1bGxzY3JlZW5Nb2RlbFZpZGVvRWxlbWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxWaWRlb0VsZW1lbnQubW0J KHJldmlzaW9uIDE3OTc0NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRl b0Z1bGxzY3JlZW5Nb2RlbFZpZGVvRWxlbWVudC5tbQkod29ya2luZyBjb3B5KQpAQCAtMzAyLDkg KzMwMiwxOCBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbk1vZGVsVmlkZW9FbGVtZW50CiAgICAg bV92aWRlb0VsZW1lbnQtPnNldFZpZGVvRnVsbHNjcmVlbkdyYXZpdHkodmlkZW9HcmF2aXR5KTsK IH0KIAotdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbFZpZGVvRWxlbWVudDo6c2VsZWN0QXVk aW9NZWRpYU9wdGlvbih1aW50NjRfdCkKK3ZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxWaWRl b0VsZW1lbnQ6OnNlbGVjdEF1ZGlvTWVkaWFPcHRpb24odWludDY0X3Qgc2VsZWN0ZWRBdWRpb0lu ZGV4KQogewotICAgIC8vIEZJWE1FOiAxMzEyMzYgSW1wbGVtZW50IGF1ZGlvIHRyYWNrIHNlbGVj dGlvbi4KKyAgICBBdWRpb1RyYWNrKiBzZWxlY3RlZEF1ZGlvVHJhY2sgPSBudWxscHRyOworCisg ICAgZm9yIChzaXplX3QgaW5kZXggPSAwOyBpbmRleCA8IG1fYXVkaW9UcmFja3NGb3JNZW51LnNp emUoKTsgKytpbmRleCkgeworICAgICAgICBhdXRvJiBhdWRpb1RyYWNrID0gbV9hdWRpb1RyYWNr c0Zvck1lbnVbaW5kZXhdOworICAgICAgICBhdWRpb1RyYWNrLT5zZXRFbmFibGVkKGluZGV4ID09 IHN0YXRpY19jYXN0PHNpemVfdD4oc2VsZWN0ZWRBdWRpb0luZGV4KSk7CisgICAgICAgIGlmIChh dWRpb1RyYWNrLT5lbmFibGVkKCkpCisgICAgICAgICAgICBzZWxlY3RlZEF1ZGlvVHJhY2sgPSBh dWRpb1RyYWNrLmdldCgpOworICAgIH0KKworICAgIG1fdmlkZW9FbGVtZW50LT5hdWRpb1RyYWNr RW5hYmxlZENoYW5nZWQoc2VsZWN0ZWRBdWRpb1RyYWNrKTsKIH0KIAogdm9pZCBXZWJWaWRlb0Z1 bGxzY3JlZW5Nb2RlbFZpZGVvRWxlbWVudDo6c2VsZWN0TGVnaWJsZU1lZGlhT3B0aW9uKHVpbnQ2 NF90IGluZGV4KQpAQCAtMzE5LDggKzMyOCwxMCBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbk1v ZGVsVmlkZW9FbGVtZW50CiAKIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuTW9kZWxWaWRlb0VsZW1l bnQ6OnVwZGF0ZUxlZ2libGVPcHRpb25zKCkKIHsKKyAgICBBdWRpb1RyYWNrTGlzdCogYXVkaW9U cmFja0xpc3QgPSBtX3ZpZGVvRWxlbWVudC0+YXVkaW9UcmFja3MoKTsKICAgICBUZXh0VHJhY2tM aXN0KiB0cmFja0xpc3QgPSBtX3ZpZGVvRWxlbWVudC0+dGV4dFRyYWNrcygpOwotICAgIGlmICgh dHJhY2tMaXN0IHx8ICFtX3ZpZGVvRWxlbWVudC0+ZG9jdW1lbnQoKS5wYWdlKCkgfHwgIW1fdmlk ZW9FbGVtZW50LT5tZWRpYUNvbnRyb2xzSG9zdCgpKQorCisgICAgaWYgKCghdHJhY2tMaXN0ICYm ICFhdWRpb1RyYWNrTGlzdCkgfHwgIW1fdmlkZW9FbGVtZW50LT5kb2N1bWVudCgpLnBhZ2UoKSB8 fCAhbV92aWRlb0VsZW1lbnQtPm1lZGlhQ29udHJvbHNIb3N0KCkpCiAgICAgICAgIHJldHVybjsK ICAgICAKICAgICBXVEY6OkF0b21pY1N0cmluZyBkaXNwbGF5TW9kZSA9IG1fdmlkZW9FbGVtZW50 LT5tZWRpYUNvbnRyb2xzSG9zdCgpLT5jYXB0aW9uRGlzcGxheU1vZGUoKTsKQEAgLTMyOCw2ICsz MzksMjIgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbFZpZGVvRWxlbWVudAogICAgIFRl eHRUcmFjayogYXV0b21hdGljSXRlbSA9IG1fdmlkZW9FbGVtZW50LT5tZWRpYUNvbnRyb2xzSG9z dCgpLT5jYXB0aW9uTWVudUF1dG9tYXRpY0l0ZW0oKTsKICAgICBDYXB0aW9uVXNlclByZWZlcmVu Y2VzJiBjYXB0aW9uUHJlZmVyZW5jZXMgPSAqbV92aWRlb0VsZW1lbnQtPmRvY3VtZW50KCkucGFn ZSgpLT5ncm91cCgpLmNhcHRpb25QcmVmZXJlbmNlcygpOwogICAgIG1fbGVnaWJsZVRyYWNrc0Zv ck1lbnUgPSBjYXB0aW9uUHJlZmVyZW5jZXMuc29ydGVkVHJhY2tMaXN0Rm9yTWVudSh0cmFja0xp c3QpOworCisgICAgbV9hdWRpb1RyYWNrc0Zvck1lbnUgPSBjYXB0aW9uUHJlZmVyZW5jZXMuc29y dGVkVHJhY2tMaXN0Rm9yTWVudShhdWRpb1RyYWNrTGlzdCk7CisgICAgCisgICAgVmVjdG9yPFN0 cmluZz4gYXVkaW9UcmFja0Rpc3BsYXlOYW1lczsKKyAgICB1aW50NjRfdCBzZWxlY3RlZEF1ZGlv SW5kZXggPSAwOworICAgIAorICAgIGZvciAoc2l6ZV90IGluZGV4ID0gMDsgaW5kZXggPCBtX2F1 ZGlvVHJhY2tzRm9yTWVudS5zaXplKCk7ICsraW5kZXgpIHsKKyAgICAgICAgYXV0byYgdHJhY2sg PSBtX2F1ZGlvVHJhY2tzRm9yTWVudVtpbmRleF07CisgICAgICAgIGF1ZGlvVHJhY2tEaXNwbGF5 TmFtZXMuYXBwZW5kKGNhcHRpb25QcmVmZXJlbmNlcy5kaXNwbGF5TmFtZUZvclRyYWNrKHRyYWNr LmdldCgpKSk7CisgICAgICAgIAorICAgICAgICBpZiAodHJhY2stPmVuYWJsZWQoKSkKKyAgICAg ICAgICAgIHNlbGVjdGVkQXVkaW9JbmRleCA9IGluZGV4OworICAgIH0KKyAgICAKKyAgICBtX3Zp ZGVvRnVsbHNjcmVlbkludGVyZmFjZS0+c2V0QXVkaW9NZWRpYVNlbGVjdGlvbk9wdGlvbnMoYXVk aW9UcmFja0Rpc3BsYXlOYW1lcywgc2VsZWN0ZWRBdWRpb0luZGV4KTsKKwogICAgIFZlY3RvcjxT dHJpbmc+IHRyYWNrRGlzcGxheU5hbWVzOwogICAgIHVpbnQ2NF90IHNlbGVjdGVkSW5kZXggPSAw OwogICAgIHVpbnQ2NF90IG9mZkluZGV4ID0gMDsK