131230 2014-04-04 09:44:51 -0700 Use JSCell::indexingType instead of Structure::indexingType wherever possible 2014-04-04 10:56:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 997601 0 mhahnenberg 2014-04-04 09:44:51 -0700 Avoid the indirection through the Structure. 997605 1 228599 mhahnenberg 2014-04-04 09:58:42 -0700 Created attachment 228599 Patch 997607 2 228599 mark.lam 2014-04-04 10:08:55 -0700 Comment on attachment 228599 Patch r=me 997632 3 228599 commit-queue 2014-04-04 10:56:48 -0700 Comment on attachment 228599 Patch Clearing flags on attachment: 228599 Committed r166792: <http://trac.webkit.org/changeset/166792> 997633 4 commit-queue 2014-04-04 10:56:50 -0700 All reviewed patches have been landed. Closing bug. 228599 2014-04-04 09:58:42 -0700 2014-04-04 10:56:48 -0700 Patch bug-131230-20140404095817.patch text/plain 6321 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2Nzg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE0LTA0LTA0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgVXNlIEpTQ2VsbDo6aW5kZXhpbmdUeXBlIGluc3RlYWQgb2YgU3RydWN0dXJlOjpp bmRleGluZ1R5cGUgd2hlcmV2ZXIgcG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTIzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIHRoZSBpbmRpcmVjdGlvbiB0aHJvdWdoIHRoZSBT dHJ1Y3R1cmUuCisKKyAgICAgICAgKiBieXRlY29kZS9BcnJheUFsbG9jYXRpb25Qcm9maWxlLmNw cDoKKyAgICAgICAgKEpTQzo6QXJyYXlBbGxvY2F0aW9uUHJvZmlsZTo6dXBkYXRlSW5kZXhpbmdU eXBlKToKKyAgICAgICAgKiBieXRlY29kZS9BcnJheUFsbG9jYXRpb25Qcm9maWxlLmg6CisgICAg ICAgIChKU0M6OkFycmF5QWxsb2NhdGlvblByb2ZpbGU6OnNlbGVjdEluZGV4aW5nVHlwZSk6Cisg ICAgICAgICogaGVhcC9IZWFwU3RhdGlzdGljcy5jcHA6CisgICAgICAgIChKU0M6OlN0b3JhZ2VT dGF0aXN0aWNzOjpvcGVyYXRvcigpKToKKyAgICAgICAgKiBydW50aW1lL0FycmF5UHJvdG90eXBl LmNwcDoKKyAgICAgICAgKEpTQzo6YXR0ZW1wdEZhc3RTb3J0KToKKyAgICAgICAgKiBydW50aW1l L0pTR2xvYmFsT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxPYmplY3Q6Om9iamVj dFByb3RvdHlwZUlzU2FuZSk6CisgICAgICAgIChKU0M6OkpTR2xvYmFsT2JqZWN0OjphcnJheVBy b3RvdHlwZUNoYWluSXNTYW5lKToKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxPYmplY3Q6OnN0cmlu Z1Byb3RvdHlwZUNoYWluSXNTYW5lKToKKyAgICAgICAgKiBydW50aW1lL0pTUHJvcGVydHlOYW1l SXRlcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yOjpjcmVh dGUpOgorCiAyMDE0LTA0LTAzICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAog ICAgICAgICBGYXN0LXBhdGggZm9yIGNhc3RpbmcgSlMgd3JhcHBlcnMgdG8gSlNOb2RlLgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0FycmF5QWxsb2NhdGlvblByb2ZpbGUu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9BcnJheUFs bG9jYXRpb25Qcm9maWxlLmNwcAkocmV2aXNpb24gMTY2NzgxKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0FycmF5QWxsb2NhdGlvblByb2ZpbGUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00OSw3ICs0OSw3IEBAIHZvaWQgQXJyYXlBbGxvY2F0aW9uUHJvZmlsZTo6dXBkYXRlSW5k ZXgKICAgICBKU0FycmF5KiBsYXN0QXJyYXkgPSBtX2xhc3RBcnJheTsKICAgICBpZiAoIWxhc3RB cnJheSkKICAgICAgICAgcmV0dXJuOwotICAgIG1fY3VycmVudEluZGV4aW5nVHlwZSA9IGxlYXN0 VXBwZXJCb3VuZE9mSW5kZXhpbmdUeXBlcyhtX2N1cnJlbnRJbmRleGluZ1R5cGUsIGxhc3RBcnJh eS0+c3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpKTsKKyAgICBtX2N1cnJlbnRJbmRleGluZ1R5 cGUgPSBsZWFzdFVwcGVyQm91bmRPZkluZGV4aW5nVHlwZXMobV9jdXJyZW50SW5kZXhpbmdUeXBl LCBsYXN0QXJyYXktPmluZGV4aW5nVHlwZSgpKTsKICAgICBtX2xhc3RBcnJheSA9IDA7CiB9CiAK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9BcnJheUFsbG9jYXRpb25Qcm9m aWxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0FycmF5 QWxsb2NhdGlvblByb2ZpbGUuaAkocmV2aXNpb24gMTY2NzgxKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0FycmF5QWxsb2NhdGlvblByb2ZpbGUuaAkod29ya2luZyBjb3B5KQpA QCAtNDIsNyArNDIsNyBAQCBwdWJsaWM6CiAgICAgSW5kZXhpbmdUeXBlIHNlbGVjdEluZGV4aW5n VHlwZSgpCiAgICAgewogICAgICAgICBKU0FycmF5KiBsYXN0QXJyYXkgPSBtX2xhc3RBcnJheTsK LSAgICAgICAgaWYgKGxhc3RBcnJheSAmJiBVTkxJS0VMWShsYXN0QXJyYXktPnN0cnVjdHVyZSgp LT5pbmRleGluZ1R5cGUoKSAhPSBtX2N1cnJlbnRJbmRleGluZ1R5cGUpKQorICAgICAgICBpZiAo bGFzdEFycmF5ICYmIFVOTElLRUxZKGxhc3RBcnJheS0+aW5kZXhpbmdUeXBlKCkgIT0gbV9jdXJy ZW50SW5kZXhpbmdUeXBlKSkKICAgICAgICAgICAgIHVwZGF0ZUluZGV4aW5nVHlwZSgpOwogICAg ICAgICByZXR1cm4gbV9jdXJyZW50SW5kZXhpbmdUeXBlOwogICAgIH0KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBTdGF0aXN0aWNzLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwU3RhdGlzdGljcy5jcHAJKHJldmlzaW9uIDE2Njc4 MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBTdGF0aXN0aWNzLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTk1LDcgKzE5NSw3IEBAIGlubGluZSB2b2lkIFN0b3JhZ2VTdGF0aXN0 aWNzOjpvcGVyYXRvcigKICAgICAgICAgcmV0dXJuOwogCiAgICAgSlNPYmplY3QqIG9iamVjdCA9 IGpzQ2FzdDxKU09iamVjdCo+KGNlbGwpOwotICAgIGlmIChoYXNJbmRleGVkUHJvcGVydGllcyhv YmplY3QtPnN0cnVjdHVyZSgpLT5pbmRleGluZ1R5cGUoKSkpCisgICAgaWYgKGhhc0luZGV4ZWRQ cm9wZXJ0aWVzKG9iamVjdC0+aW5kZXhpbmdUeXBlKCkpKQogICAgICAgICByZXR1cm47CiAKICAg ICBpZiAob2JqZWN0LT5zdHJ1Y3R1cmUoKS0+aXNVbmNhY2hlYWJsZURpY3Rpb25hcnkoKSkKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5j cHAJKHJldmlzaW9uIDE2Njc4MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Fy cmF5UHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjA3LDcgKzYwNyw3IEBAIHN0YXRp YyBib29sIGF0dGVtcHRGYXN0U29ydChFeGVjU3RhdGUqIGUKIHsKICAgICBpZiAodGhpc09iai0+ Y2xhc3NJbmZvKCkgIT0gSlNBcnJheTo6aW5mbygpCiAgICAgICAgIHx8IGFzQXJyYXkodGhpc09i aiktPmhhc1NwYXJzZU1hcCgpCi0gICAgICAgIHx8IHNob3VsZFVzZVNsb3dQdXQodGhpc09iai0+ c3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpKSkKKyAgICAgICAgfHwgc2hvdWxkVXNlU2xvd1B1 dCh0aGlzT2JqLT5pbmRleGluZ1R5cGUoKSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAK ICAgICBpZiAoaXNOdW1lcmljQ29tcGFyZUZ1bmN0aW9uKGV4ZWMsIGZ1bmN0aW9uLCBjYWxsVHlw ZSwgY2FsbERhdGEpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9i YWxPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTR2xvYmFsT2JqZWN0LmNwcAkocmV2aXNpb24gMTY2NzgxKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDcs NyArNTA3LDcgQEAgT2JqZWN0c1dpdGhCcm9rZW5JbmRleGluZ0ZpbmRlcjo6T2JqZWN0cwogaW5s aW5lIGJvb2wgaGFzQnJva2VuSW5kZXhpbmcoSlNPYmplY3QqIG9iamVjdCkKIHsKICAgICAvLyBU aGlzIHdpbGwgY2hhbmdlIGlmIHdlIGhhdmUgbW9yZSBpbmRleGluZyB0eXBlcy4KLSAgICBJbmRl eGluZ1R5cGUgdHlwZSA9IG9iamVjdC0+c3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpOworICAg IEluZGV4aW5nVHlwZSB0eXBlID0gb2JqZWN0LT5pbmRleGluZ1R5cGUoKTsKICAgICAvLyBUaGlz IGNvdWxkIGJlIG1hZGUgb2J2aW91c2x5IG1vcmUgZWZmaWNpZW50LCBidXQgaXNuJ3QgbWFkZSBz byByaWdodCBub3csIGJlY2F1c2UKICAgICAvLyB3ZSBleHBlY3QgdGhpcyB0byBiZSBhbiB1bmxp a2VseSBzbG93IHBhdGggYW55d2F5LgogICAgIHJldHVybiBoYXNVbmRlY2lkZWQodHlwZSkgfHwg aGFzSW50MzIodHlwZSkgfHwgaGFzRG91YmxlKHR5cGUpIHx8IGhhc0NvbnRpZ3VvdXModHlwZSkg fHwgaGFzQXJyYXlTdG9yYWdlKHR5cGUpOwpAQCAtNTgzLDIwICs1ODMsMjAgQEAgdm9pZCBKU0ds b2JhbE9iamVjdDo6aGF2ZUFCYWRUaW1lKFZNJiB2bQogCiBib29sIEpTR2xvYmFsT2JqZWN0Ojpv YmplY3RQcm90b3R5cGVJc1NhbmUoKQogewotICAgIHJldHVybiAhaGFzSW5kZXhlZFByb3BlcnRp ZXMobV9vYmplY3RQcm90b3R5cGUtPnN0cnVjdHVyZSgpLT5pbmRleGluZ1R5cGUoKSkKKyAgICBy ZXR1cm4gIWhhc0luZGV4ZWRQcm9wZXJ0aWVzKG1fb2JqZWN0UHJvdG90eXBlLT5pbmRleGluZ1R5 cGUoKSkKICAgICAgICAgJiYgbV9vYmplY3RQcm90b3R5cGUtPnByb3RvdHlwZSgpLmlzTnVsbCgp OwogfQogCiBib29sIEpTR2xvYmFsT2JqZWN0OjphcnJheVByb3RvdHlwZUNoYWluSXNTYW5lKCkK IHsKLSAgICByZXR1cm4gIWhhc0luZGV4ZWRQcm9wZXJ0aWVzKG1fYXJyYXlQcm90b3R5cGUtPnN0 cnVjdHVyZSgpLT5pbmRleGluZ1R5cGUoKSkKKyAgICByZXR1cm4gIWhhc0luZGV4ZWRQcm9wZXJ0 aWVzKG1fYXJyYXlQcm90b3R5cGUtPmluZGV4aW5nVHlwZSgpKQogICAgICAgICAmJiBtX2FycmF5 UHJvdG90eXBlLT5wcm90b3R5cGUoKSA9PSBtX29iamVjdFByb3RvdHlwZS5nZXQoKQogICAgICAg ICAmJiBvYmplY3RQcm90b3R5cGVJc1NhbmUoKTsKIH0KIAogYm9vbCBKU0dsb2JhbE9iamVjdDo6 c3RyaW5nUHJvdG90eXBlQ2hhaW5Jc1NhbmUoKQogewotICAgIHJldHVybiAhaGFzSW5kZXhlZFBy b3BlcnRpZXMobV9zdHJpbmdQcm90b3R5cGUtPnN0cnVjdHVyZSgpLT5pbmRleGluZ1R5cGUoKSkK KyAgICByZXR1cm4gIWhhc0luZGV4ZWRQcm9wZXJ0aWVzKG1fc3RyaW5nUHJvdG90eXBlLT5pbmRl eGluZ1R5cGUoKSkKICAgICAgICAgJiYgbV9zdHJpbmdQcm90b3R5cGUtPnByb3RvdHlwZSgpID09 IG1fb2JqZWN0UHJvdG90eXBlLmdldCgpCiAgICAgICAgICYmIG9iamVjdFByb3RvdHlwZUlzU2Fu ZSgpOwogfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNQcm9wZXJ0eU5h bWVJdGVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNQcm9wZXJ0eU5hbWVJdGVyYXRvci5jcHAJKHJldmlzaW9uIDE2Njc4MSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTUHJvcGVydHlOYW1lSXRlcmF0b3IuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02OSw3ICs2OSw3IEBAIEpTUHJvcGVydHlOYW1lSXRlcmF0b3IqIEpTUHJv cGVydHlOYW1lSXQKICAgICBpZiAoby0+c3RydWN0dXJlKCktPnR5cGVJbmZvKCkub3ZlcnJpZGVz R2V0UHJvcGVydHlOYW1lcygpKQogICAgICAgICByZXR1cm4ganNQcm9wZXJ0eU5hbWVJdGVyYXRv cjsKICAgICAKLSAgICBpZiAoaGFzSW5kZXhlZFByb3BlcnRpZXMoby0+c3RydWN0dXJlKCktPmlu ZGV4aW5nVHlwZSgpKSkKKyAgICBpZiAoaGFzSW5kZXhlZFByb3BlcnRpZXMoby0+aW5kZXhpbmdU eXBlKCkpKQogICAgICAgICByZXR1cm4ganNQcm9wZXJ0eU5hbWVJdGVyYXRvcjsKICAgICAKICAg ICBzaXplX3QgY291bnQgPSBub3JtYWxpemVQcm90b3R5cGVDaGFpbihleGVjLCBvKTsK