131228 2014-04-04 08:33:55 -0700 [GTK][CMAKE] build-webkit's parameter --no-webkit1 is not honored 2014-04-09 05:54:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 vjaquez vjaquez bunhere cgarcia commit-queue gyuyoung.kim mrobinson rakuco sergio oldest_to_newest 997573 0 vjaquez 2014-04-04 08:33:55 -0700 When building webkit with $ build-webkit --gtk --no-webkit1 GtkLaunch and the webkit1 libraries are built. 997616 1 228602 vjaquez 2014-04-04 10:34:23 -0700 Created attachment 228602 Patch 997631 2 228602 mrobinson 2014-04-04 10:55:36 -0700 Comment on attachment 228602 Patch WebKit1 supports GTK3, so I'm not sure I understand the patch. We are going to remove WebKit1 soon, so perhaps we can just close this bug and wait for it to go away? 997642 3 vjaquez 2014-04-04 11:14:31 -0700 (In reply to comment #2) > (From update of attachment 228602 [details]) > WebKit1 supports GTK3, so I'm not sure I understand the patch. We are going to remove WebKit1 soon, so perhaps we can just close this bug and wait for it to go away? This patch removes the unconditional compilation of WebKit1 when compiling for GTK3. Sure, we can close this bug and wait, or commit it and then removes its logic. Just I wanted to spot the issue. 998929 4 mrobinson 2014-04-08 17:47:37 -0700 WebKit1GTK+ has been removed. 228602 2014-04-04 10:34:23 -0700 2014-04-09 05:54:57 -0700 Patch bug-131228-20140404173402.patch text/plain 1431 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGU1M2Rl ZWRjZTc2OTJiYTE4NjkxOGMzNGM0ZmMzZDUzMjM1NGI4OWMuLjc4MTM4ZDQxYTk3Y2UyZDBlNmE1 YThjMTlmYzkyZTVmNzY4ZTU1ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC05Myw3ICs5Myw2 IEBAIFdFQktJVF9PUFRJT05fRU5EKCkKIAogc2V0KEVOQUJMRV9XRUJDT1JFIE9OKQogc2V0KEVO QUJMRV9JTlNQRUNUT1IgT04pCi1zZXQoRU5BQkxFX1dFQktJVCBPTikKIGlmIChOT1QgVVNFX0dU SzIpCiAgICAgc2V0KFdFQktJVEdUS19BUElfVkVSU0lPTiAzLjApCiAgICAgc2V0KEdUS19BUElf VkVSU0lPTiAzLjApCkBAIC0xMDUsNiArMTA0LDcgQEAgZWxzZSAoKQogICAgIHNldChHVEtfQVBJ X1ZFUlNJT04gMi4wKQogICAgIHNldChFTkFCTEVfUExVR0lOX1BST0NFU1MgT0ZGKQogICAgIHNl dChFTkFCTEVfV0VCS0lUMiBPRkYpCisgICAgc2V0KEVOQUJMRV9XRUJLSVQgT04pCiBlbmRpZiAo KQogCiAjIFRoZXNlIGFyZSB1c2VkIHRvIGdlbmVyYXRlIHRoZSBwa2ctY29uZmlnIGZpbGVzLgpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDYwMDAzMGRmZmNjMzVhYWUy NmU5OGE0ODUxODdlMTA5YzQ5ODU4MDguLjc3Y2M1NzY4MGYzZTBiYWY4MDBkZDkwYTRhNjEzMzk2 MmJmNGFhMzAgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxNC0wNC0wNCAgVsOtY3RvciBNYW51ZWwgSsOhcXVleiBMZWFsICA8dmphcXVl ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW0NNQUtFXSBidWlsZC13ZWJraXQncyBwYXJh bWV0ZXIgLS1uby13ZWJraXQxIGlzIG5vdCBob25vcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEyMjgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIb25vdXIgdGhlIHBhcmFtZXRlciAtLW5vLXdlYmtp dDEuIFByZXZpb3VzbHkgV2ViS2l0MSB3YXMgYnVpbHQKKyAgICAgICAgdW5jb25kaXRpb25hbGx5 LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IGVuYWJsZSB3ZWJr aXQxIG9ubHkgd2hlbiBidWlsZGluZworICAgICAgICB3aXRoIEdUSzIuCisKIDIwMTQtMDQtMDIg IFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+ CiAKICAgICAgICAgW0dUS11bQ01ha2VdIExvb2sgZm9yIGdseC5oIGluIE9QRU5HTF9JTkNMVURF X0RJUi4K