131220 2014-04-04 02:55:00 -0700 [WK2][GTK] ASSERTION FAILED: m_status == Scheduled in GMainLoopSource 2014-05-29 02:39:04 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 130081 1 svillar webkit-unassigned benjamin cgarcia cmarcelo commit-queue oldest_to_newest 997519 0 svillar 2014-04-04 02:55:00 -0700 Tests crashing: * inspector-protocol/dom/remove-multiple-nodes.html STDERR: ASSERTION FAILED: m_status == Scheduled STDERR: ../../Source/WTF/wtf/gobject/GMainLoopSource.cpp(206) : bool WTF::GMainLoopSource::boolCallback() STDERR: 1 0x7f72ab55ee2d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-3.0.so.0(WTFCrash+0x1e) [0x7f72ab55ee2d] STDERR: 2 0x7f72ab5a16c9 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-3.0.so.0(_ZN3WTF15GMainLoopSource12boolCallbackEv+0x95) [0x7f72ab5a16c9] STDERR: 3 0x7f72ab5a1966 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-3.0.so.0(_ZN3WTF15GMainLoopSource18boolSourceCallbackEPS0_+0x18) [0x7f72ab5a1966] STDERR: 4 0x7f729fee9fcb /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0(+0x54fcb) [0x7f729fee9fcb] STDERR: 5 0x7f729fee8295 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0(+0x53295) [0x7f729fee8295] STDERR: 6 0x7f729fee8fec /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x33) [0x7f729fee8fec] STDERR: 7 0x7f729fee91de /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0(+0x541de) [0x7f729fee91de] STDERR: 8 0x7f729fee9607 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0(g_main_loop_run+0x1d9) [0x7f729fee9607] STDERR: 9 0x7f72a569d9b8 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-3.0.so.25(_ZN3WTF7RunLoop3runEv+0x42) [0x7f72a569d9b8] STDERR: 10 0x7f72a55e520a /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-3.0.so.25(WebProcessMainGtk+0xed) [0x7f72a55e520a] STDERR: 11 0x400b4d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/bin/WebKitWebProcess(main+0x20) [0x400b4d] STDERR: 12 0x7f729c97b995 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f729c97b995] STDERR: 13 0x400a69 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/bin/WebKitWebProcess() [0x400a69] STDERR: LEAK: 1 WebPageProxy STDERR: LEAK: 1 WebContext 1012375 1 cgarcia 2014-05-29 01:03:14 -0700 Yes, this assert is wrong for repeating sources, the first time is correct, the status is scheduled, but then it's dispatched and it can be dispatched more than once. So we should check the status is either scheduled or dispatched. 1012376 2 232238 cgarcia 2014-05-29 01:08:05 -0700 Created attachment 232238 Patch 1012378 3 cgarcia 2014-05-29 01:27:54 -0700 Forgot to unskip the test, I'll do it before landing. 1012384 4 cgarcia 2014-05-29 02:39:04 -0700 Committed r169443: <http://trac.webkit.org/changeset/169443> 232238 2014-05-29 01:08:05 -0700 2014-05-29 01:22:21 -0700 Patch wtf-main-loop-source-assert.diff text/plain 1717 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNWM3ODg0Yy4uZTZiMmM3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNC0wNS0yOSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dL Ml1bR1RLXSBBU1NFUlRJT04gRkFJTEVEOiBtX3N0YXR1cyA9PSBTY2hlZHVsZWQgaW4gR01haW5M b29wU291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzEyMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgYXNzZXJ0IGlzIHdyb25nIGZvciByZXBlYXRpbmcgc291cmNlcywgdGhlIGZpcnN0IHRp bWUgaXMKKyAgICAgICAgY29ycmVjdCwgdGhlIHN0YXR1cyBpcyBzY2hlZHVsZWQsIGJ1dCB0aGVu IGl0J3MgZGlzcGF0Y2hlZCBhbmQgaXQKKyAgICAgICAgY2FuIGJlIGRpc3BhdGNoZWQgbW9yZSB0 aGFuIG9uY2UuIFNvIHdlIHNob3VsZCBjaGVjayB0aGUgc3RhdHVzIGlzCisgICAgICAgIGVpdGhl ciBzY2hlZHVsZWQgb3IgZGlzcGF0Y2hlZC4KKworICAgICAgICAqIHd0Zi9nb2JqZWN0L0dNYWlu TG9vcFNvdXJjZS5jcHA6CisgICAgICAgIChXVEY6OkdNYWluTG9vcFNvdXJjZTo6Ym9vbENhbGxi YWNrKToKKyAgICAgICAgKFdURjo6R01haW5Mb29wU291cmNlOjpzb2NrZXRDYWxsYmFjayk6CisK IDIwMTQtMDUtMjcgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0 ZSBFTkFCTEUoTUVESUFfU09VUkNFKSBvbiBNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L2dvYmplY3QvR01haW5Mb29wU291cmNlLmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dvYmplY3QvR01h aW5Mb29wU291cmNlLmNwcAppbmRleCBlMzc1NjlmLi5mMWFmODhjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL3d0Zi9nb2JqZWN0L0dNYWluTG9vcFNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dURi93 dGYvZ29iamVjdC9HTWFpbkxvb3BTb3VyY2UuY3BwCkBAIC0yMDMsNyArMjAzLDcgQEAgYm9vbCBH TWFpbkxvb3BTb3VyY2U6OmJvb2xDYWxsYmFjaygpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAog ICAgIEFTU0VSVChtX2Jvb2xDYWxsYmFjayk7Ci0gICAgQVNTRVJUKG1fc3RhdHVzID09IFNjaGVk dWxlZCk7CisgICAgQVNTRVJUKG1fc3RhdHVzID09IFNjaGVkdWxlZCB8fCBtX3N0YXR1cyA9PSBE aXNwYXRjaGVkKTsKICAgICBtX3N0YXR1cyA9IERpc3BhdGNoZWQ7CiAKICAgICBHU291cmNlKiBz b3VyY2UgPSBtX3NvdXJjZS5nZXQoKTsKQEAgLTIyMCw3ICsyMjAsNyBAQCBib29sIEdNYWluTG9v cFNvdXJjZTo6c29ja2V0Q2FsbGJhY2soR0lPQ29uZGl0aW9uIGNvbmRpdGlvbikKICAgICAgICAg cmV0dXJuIGZhbHNlOwogCiAgICAgQVNTRVJUKG1fc29ja2V0Q2FsbGJhY2spOwotICAgIEFTU0VS VChtX3N0YXR1cyA9PSBTY2hlZHVsZWQpOworICAgIEFTU0VSVChtX3N0YXR1cyA9PSBTY2hlZHVs ZWQgfHwgbV9zdGF0dXMgPT0gRGlzcGF0Y2hlZCk7CiAgICAgbV9zdGF0dXMgPSBEaXNwYXRjaGVk OwogCiAgICAgaWYgKGdfY2FuY2VsbGFibGVfaXNfY2FuY2VsbGVkKG1fY2FuY2VsbGFibGUuZ2V0 KCkpKSB7Cg==