<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>13122</bug_id>
          
          <creation_ts>2007-03-19 15:56:16 -0700</creation_ts>
          <short_desc>No history added for a window.open followed by refresh</short_desc>
          <delta_ts>2007-04-19 05:32:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>History</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>All</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>3546</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>GoogleBug</keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dex Deacon">occupant4</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fishd</cc>
    
    <cc>mitz</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>18299</commentid>
    <comment_count>0</comment_count>
    <who name="Dex Deacon">occupant4</who>
    <bug_when>2007-03-19 15:56:16 -0700</bug_when>
    <thetext>Repro steps:
1. Navigate to the attached test case.
2. Click the button to open a new window.
3. Navigate somewhere in the new window.  Notice that you can&apos;t go back to the original page that opened the window.

Firefox creates a history entry for the new page opened, Safari does not.  I observed this in both Safari 2.0.4 and Safari running with WebKit r20325.

From stepping through the code, it looks like the problem is in FrameLoader::updateHistoryForStandardLoad().  For the initial window.open(), the URL is empty, so history is not updated.  Then the redirect occurs, and this function is called again, but this time it&apos;s rejected from history because it&apos;s a redirect.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>18300</commentid>
    <comment_count>1</comment_count>
      <attachid>13707</attachid>
    <who name="Dex Deacon">occupant4</who>
    <bug_when>2007-03-19 15:57:21 -0700</bug_when>
    <thetext>Created attachment 13707
reduced test case</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>14190</commentid>
    <comment_count>2</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2007-04-18 15:40:16 -0700</bug_when>
    <thetext>The problem here is that no session history entry is created for either &quot;about:blank&quot; navigations or &quot;client redirect&quot; navigations.  The &lt;meta refresh&gt; appears to be treated as a client redirect.

I see this bug when I click a link in Gmail.  IMO, this is a pretty major bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>14191</commentid>
    <comment_count>3</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2007-04-18 15:45:22 -0700</bug_when>
    <thetext>I *think* this is a dupe of http://bugs.webkit.org/show_bug.cgi?id=3546 which was fixed very recently</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>14192</commentid>
    <comment_count>4</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2007-04-18 15:48:56 -0700</bug_when>
    <thetext>Yep, its a dupe - this works on ToT.  Closing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>14123</commentid>
    <comment_count>5</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-04-19 05:32:40 -0700</bug_when>
    <thetext>Reopening to mark as duplicate.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>14124</commentid>
    <comment_count>6</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-04-19 05:32:54 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of 3546 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>13707</attachid>
            <date>2007-03-19 15:57:21 -0700</date>
            <delta_ts>2007-03-19 15:57:21 -0700</delta_ts>
            <desc>reduced test case</desc>
            <filename>history.html</filename>
            <type>text/html</type>
            <size>254</size>
            <attacher name="Dex Deacon">occupant4</attacher>
            
              <data encoding="base64">PGh0bWw+Cjxib2R5Pgo8c2NyaXB0PgpmdW5jdGlvbiBvcGVuTmV3V2luZG93KCkgewogIHZhciB3
ID0gd2luZG93Lm9wZW4oKTsKICB3LmRvY3VtZW50LndyaXRlKCc8bWV0YSBodHRwLWVxdWl2PSJy
ZWZyZXNoIiBjb250ZW50PSIwOyBoaXN0b3J5Lmh0bWwiPicpOwogIHcuZG9jdW1lbnQuY2xvc2Uo
KTsKfQo8L3NjcmlwdD4KPGJ1dHRvbiBvbmNsaWNrPSJvcGVuTmV3V2luZG93KCkiPmNsaWNrIG1l
PC9idXR0b24+CjwvYm9keT4KPC9odG1sPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>