131208 2014-04-03 20:08:38 -0700 Regression: AX: image labels no longer exposed to AX API in SVG test case 2014-04-08 00:59:58 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED http://www.webkit.org/blog-files/aria1.0/africa_large.svg InRadar P2 Normal --- 1 jcraig cfleizach aboxhall apinheiro cfleizach commit-queue dmazzoni jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 997449 0 jcraig 2014-04-03 20:08:38 -0700 Regression: AX: image labels no longer exposed to AX API in SVG test case. I believe this is a recent regression. http://www.webkit.org/blog-files/aria1.0/africa_large.svg 997450 1 webkit-bug-importer 2014-04-03 20:09:00 -0700 <rdar://problem/16520975> 998434 2 228805 cfleizach 2014-04-07 22:35:10 -0700 Created attachment 228805 patch 998451 3 228805 dbates 2014-04-07 23:20:41 -0700 Comment on attachment 228805 patch View in context: https://bugs.webkit.org/attachment.cgi?id=228805&action=review This patch looks straightforward to me. > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1849 > static String accessibleNameForNode(Node* node) Nit: We should change the parameter type from Node* to Node& since this function assumes node is a non-null pointer. Otherwise, we should check/assert that node is non-null. > LayoutTests/accessibility/svg-labelledby.html:6 > +<body id="body"> The HTML attribute id is unnecessary as we never reference this element by id in this document. Moreover, it's sufficient it use document.body to obtain a reference to the HTML Body element instead of assigning an id to it. > LayoutTests/accessibility/svg-labelledby.html:13 > + </path> Nit: This closing tag has a different amount of indentation that its opening tag (line 11). 998456 4 cfleizach 2014-04-07 23:31:41 -0700 (In reply to comment #3) > (From update of attachment 228805 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228805&action=review > > This patch looks straightforward to me. > > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1849 > > static String accessibleNameForNode(Node* node) > > Nit: We should change the parameter type from Node* to Node& since this function assumes node is a non-null pointer. Otherwise, we should check/assert that node is non-null. > > > LayoutTests/accessibility/svg-labelledby.html:6 > > +<body id="body"> > > The HTML attribute id is unnecessary as we never reference this element by id in this document. Moreover, it's sufficient it use document.body to obtain a reference to the HTML Body element instead of assigning an id to it. > > > LayoutTests/accessibility/svg-labelledby.html:13 > > + </path> > > Nit: This closing tag has a different amount of indentation that its opening tag (line 11). Thanks, I'll take care of all of these 998488 5 cfleizach 2014-04-08 00:59:58 -0700 http://trac.webkit.org/changeset/166917 228805 2014-04-07 22:35:10 -0700 2014-04-07 23:20:41 -0700 patch patch text/plain 4832 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NjkxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA0LTA3ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbjogQVg6 IGltYWdlIGxhYmVscyBubyBsb25nZXIgZXhwb3NlZCB0byBBWCBBUEkgaW4gU1ZHIHRlc3QgY2Fz ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMjA4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYWNjZXNz aWJsZU5hbWVGb3JOb2RlIHNob3VsZCB3b3JrIG9uIGFueSBFbGVtZW50LCBub3QganVzdCBIVE1M IGVsZW1lbnRzLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvc3ZnLWxhYmVsbGVkYnku aHRtbAorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjphY2Nlc3NpYmxlTmFtZUZvck5vZGUpOgorCiAyMDE0LTA0 LTA3ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDU1Mg U2hhcGVzXSBTaW1wbGlmeSB0aGUgcGFyc2luZyBvZiB3aWR0aCBhcmd1bWVudHMgZm9yIEluc2V0 IHNoYXBlcwpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 Tm9kZU9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAJKHJldmlzaW9uIDE2Njg5MCkKKysrIFNvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xODQ4LDEwICsxODQ4LDEwIEBACiAvLyBBUklBIEltcGxlbWVudGVyJ3Mg R3VpZGUuICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKIHN0YXRpYyBTdHJpbmcg YWNjZXNzaWJsZU5hbWVGb3JOb2RlKE5vZGUqIG5vZGUpCiB7Ci0gICAgaWYgKCFub2RlLT5pc0hU TUxFbGVtZW50KCkpCisgICAgaWYgKCFub2RlLT5pc0VsZW1lbnROb2RlKCkpCiAgICAgICAgIHJl dHVybiBTdHJpbmcoKTsKICAgICAKLSAgICBIVE1MRWxlbWVudCogZWxlbWVudCA9IHRvSFRNTEVs ZW1lbnQobm9kZSk7CisgICAgRWxlbWVudCogZWxlbWVudCA9IHRvRWxlbWVudChub2RlKTsKICAg ICAKICAgICBjb25zdCBBdG9taWNTdHJpbmcmIGFyaWFMYWJlbCA9IGVsZW1lbnQtPmZhc3RHZXRB dHRyaWJ1dGUoYXJpYV9sYWJlbEF0dHIpOwogICAgIGlmICghYXJpYUxhYmVsLmlzRW1wdHkoKSkK QEAgLTE4NzAsOCArMTg3MCw4IEBACiAgICAgU3RyaW5nIHRleHQ7CiAgICAgaWYgKGF4T2JqZWN0 KQogICAgICAgICB0ZXh0ID0gYXhPYmplY3QtPnRleHRVbmRlckVsZW1lbnQoKTsKLSAgICBlbHNl IGlmIChub2RlLT5pc0VsZW1lbnROb2RlKCkpCi0gICAgICAgIHRleHQgPSB0b0VsZW1lbnQobm9k ZSktPmlubmVyVGV4dCgpOworICAgIGVsc2UKKyAgICAgICAgdGV4dCA9IGVsZW1lbnQtPmlubmVy VGV4dCgpOwogICAgIAogICAgIGlmICghdGV4dC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiB0 ZXh0OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2OTEwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDQtMDcgIENocmlzIEZsZWl6 YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uOiBBWDogaW1h Z2UgbGFiZWxzIG5vIGxvbmdlciBleHBvc2VkIHRvIEFYIEFQSSBpbiBTVkcgdGVzdCBjYXNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEyMDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2li aWxpdHkvc3ZnLWxhYmVsbGVkYnktZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBhY2Nl c3NpYmlsaXR5L3N2Zy1sYWJlbGxlZGJ5Lmh0bWw6IEFkZGVkLgorCiAyMDE0LTA0LTA3ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBmYXN0L2NzczMt dGV4dC9jc3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0LWRlY29yYXRpb24tdGhpY2tuZXNzLmh0bWwg ZmFpbHMgb24gR1RLCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3N2Zy1sYWJlbGxl ZGJ5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L3N2Zy1sYWJlbGxlZGJ5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2FjY2Vzc2liaWxpdHkvc3ZnLWxhYmVsbGVkYnktZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkBAIC0wLDAgKzEsMTEgQEAKKworVGhpcyB0ZXN0cyB0aGF0IGFyaWEtbGFiZWxsZWRieSB3b3Jr cyBvbiBTVkcgZWxlbWVudHMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBv ZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitTVkcg RWxlbWVudDogQVhEZXNjcmlwdGlvbjogU3VkYW4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L3N2Zy1sYWJlbGxlZGJ5Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9zdmctbGFiZWxsZWRieS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvYWNj ZXNzaWJpbGl0eS9zdmctbGFiZWxsZWRieS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MzggQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxo dG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPHN2ZyB4bWxucz0iaHR0cDov L3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5 L3hsaW5rIj4KKworPGc+Cis8cGF0aCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmci IHJvbGU9ImltZyIgYXJpYS1sYWJlbGxlZGJ5PSJsYWJlbF9TdWRhbiIgaWQ9IlN1ZGFuIiBjbGFz cz0ibGFuZCBzZCIgZD0iTTQ2My45OTk2LDI2Mi41NDc0IEM0NjQuNjA2OCwyNjEuMDggNDY0Ljg0 NTYsMjU5Ljg0ODggNDY2LjIwMDQsMjU4Ljg5MjQgQzQ2Ny40Njg4LDI1Ny45OTcyIDQ2OC40OTg0 LDI1Ny4zNDE4IDQ2Ny42NzI4LDI1NS43ODY2IEM0NjUuNTA0NCwyNTEuNzAxOCA0NjcuNDU2OCwy NTAuODgxIDQ3MC40Nzk2LDI0OC40NjMgQzQ2OS42NjQ4LDI0Ny42ODMyIDQ2OC4zMDc2LDI0NC4z ODkyIDQ2OS42MzQ4LDI0My42ODYgQzQ3MS43NDMyLDI0Mi41NjY0IDQ3Mi4wMDI0LDI0MC41NTAy IDQ3My40NTgsMjM4LjY5NzQgQzQ3NS4yNzM2LDIzNi4zODM4IDQ3Mi4yMTM2LDIzNC4yMDcyIDQ3 NS4xMTg4LDIzMi43Njk2Ij4KKyAgIDxzZXQgYXR0cmlidXRlTmFtZT0ib3BhY2l0eSIgZnJvbT0i MSIgdG89IjAuNSIgYmVnaW49Im1vdXNlb3ZlciIgZW5kPSJtb3VzZW91dCIvPgorICA8L3BhdGg+ Cis8L2c+CisKKzx0ZXh0IHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgaWQ9Imxh YmVsX1N1ZGFuIiB4PSI4MCIgeT0iNzkwIiBmb250LXNpemU9IjI0IiB2aXNpYmlsaXR5PSJoaWRk ZW4iPgorICAgU3VkYW4KKyAgIDxzZXQgYXR0cmlidXRlTmFtZT0idmlzaWJpbGl0eSIgZnJvbT0i aGlkZGVuIiB0bz0idmlzaWJsZSIgYmVnaW49IlN1ZGFuLm1vdXNlb3ZlciIgZW5kPSJTdWRhbi5t b3VzZW91dCIvPgorICA8L3RleHQ+Cis8L3N2Zz4KKworPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKworICAgIGRlc2NyaXB0aW9u KCJUaGlzIHRlc3RzIHRoYXQgYXJpYS1sYWJlbGxlZGJ5IHdvcmtzIG9uIFNWRyBlbGVtZW50cy4i KTsKKworICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAgICAg dmFyIGltYWdlID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlk KCJTdWRhbiIpOworICAgICAgICBkZWJ1ZygiU1ZHIEVsZW1lbnQ6ICIgKyBpbWFnZS5kZXNjcmlw dGlvbik7CisgICAgfQorCis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=