131206 2014-04-03 19:41:42 -0700 [Cocoa] Add additional WKWebView SPI for clients that interact with PDFs 2014-04-04 00:32:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes mitz webkit-bug-importer oldest_to_newest 997445 0 aestes 2014-04-03 19:41:42 -0700 [Cocoa] Add additional WKWebView SPI for clients that interact with PDFs 997446 1 228575 aestes 2014-04-03 19:48:16 -0700 Created attachment 228575 Patch 997452 2 228575 mitz 2014-04-03 20:24:21 -0700 Comment on attachment 228575 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228575&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1240 > + return [reinterpret_cast<WKPDFView *>(_customContentView.get()) documentData]; We normally use C-style casts between Objective-C classes. > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1247 > + return [reinterpret_cast<WKPDFView *>(_customContentView.get()) suggestedFilename]; Ditto. > Source/WebKit2/UIProcess/ios/WKPDFView.mm:71 > + _suggestedFilename = filename; Please copy and adopt, since NSString has a mutable subclass. 997471 3 aestes 2014-04-03 22:24:40 -0700 Committed r166767: <http://trac.webkit.org/changeset/166767> 997493 4 webkit-bug-importer 2014-04-04 00:32:13 -0700 <rdar://problem/16522127> 228575 2014-04-03 19:48:16 -0700 2014-04-03 20:24:20 -0700 Patch bug-131206-20140403194756.patch text/plain 6446 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTQ5MWQ5NmQ3YTM0ZTgz YzNjZDA5Y2E0MTEzMDM0ZGJkMjhiMWEzNy4uMTA1YzFhN2M3NDdkZTAzM2NjNjU2ZjgzYjdhYTkx MDJlMzk5MTk0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE0LTA0LTAzICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIEFkZCBhZGRpdGlv bmFsIFdLV2ViVmlldyBTUEkgZm9yIGNsaWVudHMgdGhhdCBpbnRlcmFjdCB3aXRoIFBERnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTIwNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBfZGF0YUZv ckRpc3BsYXllZFBERiBhbmQgX3N1Z2dlc3RlZEZpbGVuYW1lRm9yRGlzcGxheWVkUERGIHRvCisg ICAgICAgIHN1cHBvcnQgY2xpZW50cyB0aGF0IHdpc2ggdG8gc2F2ZSBhIGNvcHkgb2YgdGhlIGN1 cnJlbnRseSBkaXNwbGF5ZWQgUERGCisgICAgICAgIHRvIGRpc2suIFVsdGltYXRlbHkgd2Ugc2hv dWxkIHN1cHBvcnQgdGhpcyB1c2UgY2FzZSBieSBleHBvc2luZyBzb21ldGhpbmcKKyAgICAgICAg bGlrZSBXS1dlYlZpZXdDb250ZW50UHJvdmlkZXIsIGJ1dCBmb3Igbm93IGxldCdzIGRvIHNvbWV0 aGluZyBzaW1wbGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t bToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9kaWRGaW5pc2hMb2FkaW5nRGF0YUZvckN1c3RvbUNv bnRlbnRQcm92aWRlcldpdGhTdWdnZXN0ZWRGaWxlbmFtZTpkYXRhOl0pOgorICAgICAgICAoLVtX S1dlYlZpZXcgX2RhdGFGb3JEaXNwbGF5ZWRQREZdKToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9z dWdnZXN0ZWRGaWxlbmFtZUZvckRpc3BsYXllZFBERl0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9X S1dlYlZpZXdDb250ZW50UHJvdmlkZXIuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLUERG Vmlldy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tOgorICAgICAgICAo LVtXS1BERlZpZXcgZG9jdW1lbnREYXRhXSk6CisgICAgICAgICgtW1dLUERGVmlldyBzdWdnZXN0 ZWRGaWxlbmFtZV0pOgorICAgICAgICAoLVtXS1BERlZpZXcgd2ViX3NldENvbnRlbnRQcm92aWRl ckRhdGE6c3VnZ2VzdGVkRmlsZW5hbWU6XSk6CisKIDIwMTQtMDQtMDMgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAoQXN5bmMgdGV4dCBp bnB1dCk6IENvbnRyb2xzIGJlY29tZSB1bnJlc3BvbnNpdmUgdG8gbW91c2UgZXZlbnRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IGM1 YjA2MWZhODI2N2Q0ZWRjMDU5NjZlNzk3YmRlODMyYzUwOGQ5YWUuLjM0YWMyZTdiNWVlOTA3N2Iy ODFjZGU1ZmNhODRkMzZkZjI0OWI5NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0zOTcsNyArMzk3LDcgQEAgLSAodm9pZClfc2V0 SGFzQ3VzdG9tQ29udGVudFZpZXc6KEJPT0wpcGFnZUhhc0N1c3RvbUNvbnRlbnRWaWV3IGxvYWRl ZE1JTUVUeXBlOigKIC0gKHZvaWQpX2RpZEZpbmlzaExvYWRpbmdEYXRhRm9yQ3VzdG9tQ29udGVu dFByb3ZpZGVyV2l0aFN1Z2dlc3RlZEZpbGVuYW1lOihjb25zdCBTdHJpbmcmKXN1Z2dlc3RlZEZp bGVuYW1lIGRhdGE6KE5TRGF0YSAqKWRhdGEKIHsKICAgICBBU1NFUlQoX2N1c3RvbUNvbnRlbnRW aWV3KTsKLSAgICBbX2N1c3RvbUNvbnRlbnRWaWV3IHdlYl9zZXRDb250ZW50UHJvdmlkZXJEYXRh OmRhdGFdOworICAgIFtfY3VzdG9tQ29udGVudFZpZXcgd2ViX3NldENvbnRlbnRQcm92aWRlckRh dGE6ZGF0YSBzdWdnZXN0ZWRGaWxlbmFtZTpzdWdnZXN0ZWRGaWxlbmFtZV07CiB9CiAKIC0gKHZv aWQpX2RpZENvbW1pdExvYWRGb3JNYWluRnJhbWUKQEAgLTEyMzMsNiArMTIzMywyMCBAQCAtIChC T09MKV9pc0Rpc3BsYXlpbmdQREYKICAgICByZXR1cm4gW19jdXN0b21Db250ZW50VmlldyBpc0tp bmRPZkNsYXNzOltXS1BERlZpZXcgY2xhc3NdXTsKIH0KIAorLSAoTlNEYXRhICopX2RhdGFGb3JE aXNwbGF5ZWRQREYKK3sKKyAgICBpZiAoIVtzZWxmIF9pc0Rpc3BsYXlpbmdQREZdKQorICAgICAg ICByZXR1cm4gbmlsOworICAgIHJldHVybiBbcmVpbnRlcnByZXRfY2FzdDxXS1BERlZpZXcgKj4o X2N1c3RvbUNvbnRlbnRWaWV3LmdldCgpKSBkb2N1bWVudERhdGFdOworfQorCistIChOU1N0cmlu ZyAqKV9zdWdnZXN0ZWRGaWxlbmFtZUZvckRpc3BsYXllZFBERgoreworICAgIGlmICghW3NlbGYg X2lzRGlzcGxheWluZ1BERl0pCisgICAgICAgIHJldHVybiBuaWw7CisgICAgcmV0dXJuIFtyZWlu dGVycHJldF9jYXN0PFdLUERGVmlldyAqPihfY3VzdG9tQ29udGVudFZpZXcuZ2V0KCkpIHN1Z2dl c3RlZEZpbGVuYW1lXTsKK30KKwogLy8gRklYTUU6IFJlbW92ZSB0aGlzIG9uY2Ugbm9ib2R5IHVz ZXMgaXQuCiAtIChOU1VSTCAqKWFjdGl2ZVVSTAogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAppbmRleCA1ZTMwNjA3NWJh NzdkMjdhNzlmMjdiY2ZhMmViZmY2YjRhZGQyODA2Li5iMTkzMTVlN2U3YWVjM2Y5MjczYTQxYTRk NWE2OTQ3NzNhMTNhNTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaApAQCAtOTksNyArOTksMTEgQEAgdHlwZWRlZiBO U19PUFRJT05TKE5TVUludGVnZXIsIF9XS0ZpbmRPcHRpb25zKSB7CiAKIEBwcm9wZXJ0eSAobm9u YXRvbWljLCBzZXR0ZXI9X3NldEJhY2tncm91bmRFeHRlbmRzQmV5b25kUGFnZTopIEJPT0wgX2Jh Y2tncm91bmRFeHRlbmRzQmV5b25kUGFnZTsKIAorLy8gRklYTUU6IFJlbW92ZSB0aGVzZSB0aHJl ZSBwcm9wZXJ0aWVzIG9uY2Ugd2UgZXhwb3NlIFdLV2ViVmlld0NvbnRlbnRQcm92aWRlciBhcyBB UEkuCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGdldHRlcj1faXNEaXNwbGF5aW5n UERGKSBCT09MIF9kaXNwbGF5aW5nUERGOworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5 KSBOU0RhdGEgKl9kYXRhRm9yRGlzcGxheWVkUERGOworLy8gRklYTUU6IFRoaXMgY2FuIGJlIHJl bW92ZWQgb25jZSBXS05hdmlnYXRpb24ncyByZXNwb25zZSBwcm9wZXJ0eSBpcyBpbXBsZW1lbnRl ZC4KK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgTlNTdHJpbmcgKl9zdWdnZXN0ZWRG aWxlbmFtZUZvckRpc3BsYXllZFBERjsKIAogLSAodm9pZClfYmVnaW5JbnRlcmFjdGl2ZU9ic2N1 cmVkSW5zZXRzQ2hhbmdlOwogLSAodm9pZClfZW5kSW50ZXJhY3RpdmVPYnNjdXJlZEluc2V0c0No YW5nZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XS1dlYlZp ZXdDb250ZW50UHJvdmlkZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XS1dl YlZpZXdDb250ZW50UHJvdmlkZXIuaAppbmRleCA5NzdiMTU0NWY4MTUwZTAxMWNmMzJkNjRmMDM3 MzI5NWJkNjkxNDRlLi4xZTM1ZGJlOTUxYjA3YTRhZDgwYmFhZGRjNWRjODg4M2YzMmEyNDU3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvV0tXZWJWaWV3Q29udGVu dFByb3ZpZGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dLV2ViVmll d0NvbnRlbnRQcm92aWRlci5oCkBAIC0zNyw3ICszNyw3IEBAIHN0cnVjdCBDR1NpemU7CiAvLyBG SVhNRTogVGhpcyBzaG91bGQgYmUgQVBJLgogQHByb3RvY29sIFdLV2ViVmlld0NvbnRlbnRQcm92 aWRlciA8TlNPYmplY3Q+CiAKLS0gKHZvaWQpd2ViX3NldENvbnRlbnRQcm92aWRlckRhdGE6KE5T RGF0YSAqKWRhdGE7CistICh2b2lkKXdlYl9zZXRDb250ZW50UHJvdmlkZXJEYXRhOihOU0RhdGEg KilkYXRhIHN1Z2dlc3RlZEZpbGVuYW1lOihOU1N0cmluZyAqKWZpbGVuYW1lOwogLSAodm9pZCl3 ZWJfc2V0TWluaW11bVNpemU6KENHU2l6ZSlzaXplOwogLSAodm9pZCl3ZWJfc2V0U2Nyb2xsVmll dzooVUlTY3JvbGxWaWV3ICopc2Nyb2xsVmlldzsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9p b3MvV0tQREZWaWV3LmgKaW5kZXggZjQ5ZTEyMzgwODY0NzkwMWFjNjA0MWUxNGYyZTMzYmZmY2Fk ZDE1Zi4uOTMwZDU2MDM3NmRmMDVlYTJmNThmNDJmYjZhYjU2OGZhNTgwM2RkZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5oCkBAIC0zMCw2ICszMCw5IEBACiAKIEBp bnRlcmZhY2UgV0tQREZWaWV3IDogVUlWaWV3IDxXS1dlYlZpZXdDb250ZW50UHJvdmlkZXI+CiAK K0Bwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgTlNEYXRhICpkb2N1bWVudERhdGE7CitA cHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5TU3RyaW5nICpzdWdnZXN0ZWRGaWxlbmFt ZTsKKwogQGVuZAogCiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLUERGVmlldy5tbQppbmRleCBhMzU5MWQ0YjllYmZhYTVhYWUxNzgwZDAzN2Fk MTI2MDYzZjY1MWY5Li4zODgwNTc0M2Q2NTcwY2FhMDNhYjQyZGQyZTQxZWYzYjg3NmY0ZWM1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5tbQpAQCAtMjgsNiArMjgs NyBAQAogCiAjaWYgUExBVEZPUk0oSU9TKQogCisjaW1wb3J0IDxDb3JlR3JhcGhpY3MvQ0dQREZE b2N1bWVudFByaXZhdGUuaD4KICNpbXBvcnQgPENvcmVQREYvVUlQREZEb2N1bWVudC5oPgogI2lt cG9ydCA8Q29yZVBERi9VSVBERlBhZ2VWaWV3Lmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+ CkBAIC0zOSw2ICs0MCw3IEBAIGNvbnN0IENHRmxvYXQgcGRmTWF4aW11bVpvb21TY2FsZSA9IDU7 CiAKIEBpbXBsZW1lbnRhdGlvbiBXS1BERlZpZXcgewogICAgIFJldGFpblB0cjxVSVBERkRvY3Vt ZW50PiBfcGRmRG9jdW1lbnQ7CisgICAgUmV0YWluUHRyPE5TU3RyaW5nPiBfc3VnZ2VzdGVkRmls ZW5hbWU7CiAgICAgVmVjdG9yPFVJUERGUGFnZVZpZXcqPiBfcGFnZVZpZXdzOwogICAgIENHU2l6 ZSBfbWluaW11bVNpemU7CiAgICAgVUlTY3JvbGxWaWV3ICpfc2Nyb2xsVmlldzsKQEAgLTU0LDgg KzU2LDIwIEBAIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUKICAg ICByZXR1cm4gc2VsZjsKIH0KIAotLSAodm9pZCl3ZWJfc2V0Q29udGVudFByb3ZpZGVyRGF0YToo TlNEYXRhICopZGF0YQorLSAoTlNEYXRhICopZG9jdW1lbnREYXRhCit7ICAgIAorICAgIHJldHVy biBbKE5TRGF0YSAqKUNHRGF0YVByb3ZpZGVyQ29weURhdGEoQ0dQREZEb2N1bWVudEdldERhdGFQ cm92aWRlcihbX3BkZkRvY3VtZW50IENHRG9jdW1lbnRdKSkgYXV0b3JlbGVhc2VdOworfQorCist IChOU1N0cmluZyAqKXN1Z2dlc3RlZEZpbGVuYW1lCit7CisgICAgcmV0dXJuIF9zdWdnZXN0ZWRG aWxlbmFtZS5nZXQoKTsKK30KKworLSAodm9pZCl3ZWJfc2V0Q29udGVudFByb3ZpZGVyRGF0YToo TlNEYXRhICopZGF0YSBzdWdnZXN0ZWRGaWxlbmFtZTooTlNTdHJpbmcgKilmaWxlbmFtZQogewor ICAgIF9zdWdnZXN0ZWRGaWxlbmFtZSA9IGZpbGVuYW1lOworCiAgICAgZm9yIChhdXRvJiBwYWdl VmlldyA6IF9wYWdlVmlld3MpCiAgICAgICAgIFtwYWdlVmlldyByZW1vdmVGcm9tU3VwZXJ2aWV3 XTsKIAo=