131200 2014-04-03 18:12:57 -0700 check-webkit-style: Improve warnings on Objective-C @property syntax 2014-04-03 18:57:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue dbates glenn mitz oldest_to_newest 997408 0 joepeck 2014-04-03 18:12:57 -0700 It was complaining about space around the '=' operator in: @property (setter=_setFoo) NSString *_foo; It should not. And while we are here, we can encourage: @property (attr) Over: @property(attr) 997412 1 228569 joepeck 2014-04-03 18:14:47 -0700 Created attachment 228569 [PATCH] Proposed Fix 997435 2 228569 commit-queue 2014-04-03 18:57:14 -0700 Comment on attachment 228569 [PATCH] Proposed Fix Clearing flags on attachment: 228569 Committed r166758: <http://trac.webkit.org/changeset/166758> 997436 3 commit-queue 2014-04-03 18:57:17 -0700 All reviewed patches have been landed. Closing bug. 228569 2014-04-03 18:14:47 -0700 2014-04-03 18:57:13 -0700 [PATCH] Proposed Fix objc.patch text/plain 4006 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhODNh OWVmLi40MjllMDQ0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDQtMDMgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6IEltcHJvdmUg d2FybmluZ3Mgb24gT2JqZWN0aXZlLUMgQHByb3BlcnR5IHN5bnRheAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMjAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3NwYWNpbmcpOgorICAgICAgICAoQ3Bw Q2hlY2tlcik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHk6CisgICAgICAgIChDcHBTdHlsZVRlc3QudGVzdF9zcGFjaW5nX2luX29iamVj dGl2ZV9jX3Byb3BlcnRpZXMpOgorCiAyMDE0LTA0LTAxICBCcmVudCBGdWxnaGFtICA8YmZ1bGdo YW1AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IDMwMjY0NzIu LmVjODU3ZDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5CkBAIC0xODM2LDEzICsxODM2LDI1IEBAIGRlZiBjaGVja19zcGFjaW5nKGZpbGVfZXh0ZW5z aW9uLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKIAogICAgIGxpbmUgPSBjbGVh bl9saW5lcy5lbGlkZWRbbGluZV9udW1iZXJdICAjIGdldCByaWQgb2YgY29tbWVudHMgYW5kIHN0 cmluZ3MKIAorICAgICMgT2JqZWN0aXZlLUMgQHByb3BlcnR5IGxpbmVzLgorICAgIGlzX29iamVj dGl2ZV9jX3Byb3BlcnR5ID0gc2VhcmNoKHInXkBwcm9wZXJ0eScsIGxpbmUpCisgICAgaWYgaXNf b2JqZWN0aXZlX2NfcHJvcGVydHk6CisgICAgICAgICMgIkBwcm9wZXJ0eSAoYXR0cikiIG5vdCAi QHByb3BlcnR5KGF0dHIpIgorICAgICAgICBpZiBzZWFyY2gocideQHByb3BlcnR5XCgnLCBsaW5l KToKKyAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9wcm9wZXJ0eScs IDQsCisgICAgICAgICAgICAgICAgICAnU2hvdWxkIGhhdmUgc3BhY2UgYmV0d2VlbiBAcHJvcGVy dHkgYW5kIGF0dHJpYnV0ZXMuJykKKyAgICAgICAgIyAiKGdldHRlcj1mb28pIiBub3QgIihnZXR0 ZXIgPSBmb28pIgorICAgICAgICBpZiBzZWFyY2gocicoXHMrPXw9XHMrKScsIGxpbmUpOgorICAg ICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL3Byb3BlcnR5JywgNCwKKyAg ICAgICAgICAgICAgICAgICdTaG91bGQgbm90IGhhdmUgc3BhY2VzIGFyb3VuZCA9IGluIHByb3Bl cnR5IGF0dHJpYnV0ZXMuJykKKwogICAgICMgRG9uJ3QgdHJ5IHRvIGRvIHNwYWNpbmcgY2hlY2tz IGZvciBvcGVyYXRvciBtZXRob2RzCiAgICAgbGluZSA9IHN1YihyJ29wZXJhdG9yKD09fCE9fDx8 PDx8PD18Pj18Pj58PnxcKz18LT18XCo9fC89fCU9fCY9fFx8PXxePXw8PD18Pj49fC8pXCgnLCAn b3BlcmF0b3JcKCcsIGxpbmUpCiAgICAgIyBEb24ndCB0cnkgdG8gZG8gc3BhY2luZyBjaGVja3Mg Zm9yICNpbmNsdWRlLCAjaW1wb3J0LCBvciAjaWYgc3RhdGVtZW50cyBhdAogICAgICMgbWluaW11 bSBiZWNhdXNlIGl0IG1lc3NlcyB1cCBjaGVja3MgZm9yIHNwYWNpbmcgYXJvdW5kIC8KICAgICBp ZiBtYXRjaChyJ1xzKiNccyooPzppbmNsdWRlfGltcG9ydHxpZiknLCBsaW5lKToKICAgICAgICAg cmV0dXJuCi0gICAgaWYgc2VhcmNoKHInW1x3Ll09W1x3Ll0nLCBsaW5lKToKKyAgICBpZiBub3Qg aXNfb2JqZWN0aXZlX2NfcHJvcGVydHkgYW5kIHNlYXJjaChyJ1tcdy5dPVtcdy5dJywgbGluZSk6 CiAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9vcGVyYXRvcnMnLCA0LAog ICAgICAgICAgICAgICAnTWlzc2luZyBzcGFjZXMgYXJvdW5kID0nKQogCkBAIC0zNzY4LDYgKzM3 ODAsNyBAQCBjbGFzcyBDcHBDaGVja2VyKG9iamVjdCk6CiAgICAgICAgICd3aGl0ZXNwYWNlL2xp bmVfbGVuZ3RoJywKICAgICAgICAgJ3doaXRlc3BhY2UvbmV3bGluZScsCiAgICAgICAgICd3aGl0 ZXNwYWNlL29wZXJhdG9ycycsCisgICAgICAgICd3aGl0ZXNwYWNlL3Byb3BlcnR5JywKICAgICAg ICAgJ3doaXRlc3BhY2UvcGFyZW5zJywKICAgICAgICAgJ3doaXRlc3BhY2Uvc2VtaWNvbG9uJywK ICAgICAgICAgJ3doaXRlc3BhY2UvdGFiJywKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggNGMzMjg3Ni4uNjFiNjg3 MiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHBfdW5pdHRlc3QucHkKQEAgLTE3ODMsNiArMTc4MywxNyBAQCBjbGFzcyBDcHBTdHlsZVRlc3Qo Q3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ1N0cmluZyYgb3Bl cmF0b3J8PShjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmKTsnLCAnJykKICAgICAgICAgc2Vs Zi5hc3NlcnRfbGludCgnU3RyaW5nJiBvcGVyYXRvcl49KGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0 cmluZyYpOycsICcnKQogCisgICAgZGVmIHRlc3Rfc3BhY2luZ19pbl9vYmplY3RpdmVfY19wcm9w ZXJ0aWVzKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdAcHJvcGVydHkgKHJlYWRv bmx5KSBCT09MIHBhc3M7JywgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ0Bwcm9wZXJ0 eSAoZ2V0dGVyPWlzUGFzc2luZykgQk9PTCBwYXNzaW5nOycsICcnKQorICAgICAgICBzZWxmLmFz c2VydF9saW50KCdAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5TU3RyaW5nKiB0aXRs ZTsnLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnQHByb3BlcnR5KHJlYWRvbmx5KSBC T09MIGZhaWw7JywKKyAgICAgICAgICAgICAgICAgICAgICAgICAnU2hvdWxkIGhhdmUgc3BhY2Ug YmV0d2VlbiBAcHJvcGVydHkgYW5kIGF0dHJpYnV0ZXMuICBbd2hpdGVzcGFjZS9wcm9wZXJ0eV0g WzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnQHByb3BlcnR5IChnZXR0ZXIgPSBpc0Zh aWxpbmcpIEJPT0wgZmFpbGluZzsnLAorICAgICAgICAgICAgICAgICAgICAgICAgICdTaG91bGQg bm90IGhhdmUgc3BhY2VzIGFyb3VuZCA9IGluIHByb3BlcnR5IGF0dHJpYnV0ZXMuICBbd2hpdGVz cGFjZS9wcm9wZXJ0eV0gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnQHByb3BlcnR5 IChub25hdG9taWMscmVhZG9ubHkpIE5TU3RyaW5nKiB0aXRsZTsnLAorICAgICAgICAgICAgICAg ICAgICAgICAgICdNaXNzaW5nIHNwYWNlIGFmdGVyICwgIFt3aGl0ZXNwYWNlL2NvbW1hXSBbM10n KQorCiAgICAgZGVmIHRlc3Rfc3BhY2luZ19iZWZvcmVfbGFzdF9zZW1pY29sb24oc2VsZik6CiAg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2NhbGxfZnVuY3Rpb24oKSA7JywKICAgICAgICAgICAg ICAgICAgICAgICAgICAnRXh0cmEgc3BhY2UgYmVmb3JlIGxhc3Qgc2VtaWNvbG9uLiBJZiB0aGlz IHNob3VsZCBiZSBhbiAnCg==