131197 2014-04-03 17:46:18 -0700 All Heap::writeBarriers should be inline 2014-04-29 15:30:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121074 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 997397 0 mhahnenberg 2014-04-03 17:46:18 -0700 One is in a JSCellInlines.h, another is in Heap.cpp. These are all critical enough and small enough to belong in HeapInlines.h 997398 1 228565 mhahnenberg 2014-04-03 17:48:20 -0700 Created attachment 228565 Patch 997404 2 228565 mark.lam 2014-04-03 17:59:29 -0700 Comment on attachment 228565 Patch r=me 997441 3 228565 commit-queue 2014-04-03 19:24:55 -0700 Comment on attachment 228565 Patch Clearing flags on attachment: 228565 Committed r166759: <http://trac.webkit.org/changeset/166759> 997442 4 commit-queue 2014-04-03 19:24:57 -0700 All reviewed patches have been landed. Closing bug. 228565 2014-04-03 17:48:20 -0700 2014-04-03 19:24:54 -0700 Patch bug-131197-20140403174631.patch text/plain 4670 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2NzU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE0LTA0LTAzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQWxsIEhlYXA6OndyaXRlQmFycmllcnMgc2hvdWxkIGJlIGlubGluZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMTk3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25lIGlzIGluIGEgSlND ZWxsSW5saW5lcy5oLCBhbm90aGVyIGlzIGluIEhlYXAuY3BwLiBUaGVzZSBhcmUgYWxsIGNyaXRp Y2FsIAorICAgICAgICBlbm91Z2ggYW5kIHNtYWxsIGVub3VnaCB0byBiZWxvbmcgaW4gSGVhcElu bGluZXMuaC4gQWxzbyBhZGRlZCB0aGUgcHJvcGVyIAorICAgICAgICBFTkFCTEUoR0dDKSBpZmRl ZnMgdG8gbWluaW1pemUgdGhlIGNvc3Qgb2YgQysrIGJhcnJpZXJzIGZvciAhRU5BQkxFKEdHQykg YnVpbGRzLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6 d3JpdGVCYXJyaWVyKTogRGVsZXRlZC4KKyAgICAgICAgKiBoZWFwL0hlYXAuaDoKKyAgICAgICAg KiBoZWFwL0hlYXBJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkhlYXA6OndyaXRlQmFycmllcik6 CisgICAgICAgICogcnVudGltZS9KU0NlbGxJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkhlYXA6 OndyaXRlQmFycmllcik6IERlbGV0ZWQuCisKIDIwMTQtMDQtMDMgIE1hcmsgTGFtICA8bWFyay5s YW1AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBiaXQgcm90IGluIEFSTXY3IEpJVCBwcm9iZSBt ZWNoYW5pc20uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkocmV2aXNpb24g MTY2NzQzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTEyOTYsMjEgKzEyOTYsNiBAQCB2b2lkIEhlYXA6OnpvbWJpZnlEZWFkT2JqZWN0 cygpCiAgICAgbV9vYmplY3RTcGFjZS5mb3JFYWNoRGVhZENlbGw8Wm9tYmlmeT4oaXRlcmF0aW9u U2NvcGUpOwogfQogCi12b2lkIEhlYXA6OndyaXRlQmFycmllcihjb25zdCBKU0NlbGwqIGZyb20p Ci17Ci0jaWYgRU5BQkxFKEdHQykKLSAgICBBU1NFUlRfR0NfT0JKRUNUX0xPT0tTX1ZBTElEKGNv bnN0X2Nhc3Q8SlNDZWxsKj4oZnJvbSkpOwotICAgIGlmICghZnJvbSB8fCAhZnJvbS0+aXNNYXJr ZWQoKSkgewotICAgICAgICBBU1NFUlQoIWZyb20gfHwgIWlzTWFya2VkKGZyb20pKTsKLSAgICAg ICAgcmV0dXJuOwotICAgIH0KLSAgICBBU1NFUlQoaXNNYXJrZWQoZnJvbSkpOwotICAgIGFkZFRv UmVtZW1iZXJlZFNldChmcm9tKTsKLSNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKGZyb20pOwotI2Vu ZGlmCi19Ci0KIHZvaWQgSGVhcDo6Zmx1c2hXcml0ZUJhcnJpZXJCdWZmZXIoSlNDZWxsKiBjZWxs KQogewogI2lmIEVOQUJMRShHR0MpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9I ZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCShy ZXZpc2lvbiAxNjY3NDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgJKHdv cmtpbmcgY29weSkKQEAgLTEwMCw3ICsxMDAsNyBAQCBwdWJsaWM6CiAKICAgICBKU19FWFBPUlRf UFJJVkFURSB2b2lkIGFkZFRvUmVtZW1iZXJlZFNldChjb25zdCBKU0NlbGwqKTsKICAgICBzdGF0 aWMgYm9vbCBpc1dyaXRlQmFycmllckVuYWJsZWQoKTsKLSAgICBKU19FWFBPUlRfUFJJVkFURSB2 b2lkIHdyaXRlQmFycmllcihjb25zdCBKU0NlbGwqKTsKKyAgICB2b2lkIHdyaXRlQmFycmllcihj b25zdCBKU0NlbGwqKTsKICAgICB2b2lkIHdyaXRlQmFycmllcihjb25zdCBKU0NlbGwqLCBKU1Zh bHVlKTsKICAgICB2b2lkIHdyaXRlQmFycmllcihjb25zdCBKU0NlbGwqLCBKU0NlbGwqKTsKIApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcElubGluZXMuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwSW5saW5lcy5oCShyZXZpc2lvbiAx NjY3NDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwSW5saW5lcy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpbmNsdWRlICJIZWFwLmgiCiAjaW5jbHVk ZSAiSlNDZWxsLmgiCisjaW5jbHVkZSAiU3RydWN0dXJlLmgiCiAKIG5hbWVzcGFjZSBKU0Mgewog CkBAIC0xMDUsOSArMTA2LDUwIEBAIGlubGluZSB2b2lkIEhlYXA6OndyaXRlQmFycmllcihjb25z dCBKU0MKICNpZiBFTkFCTEUoV1JJVEVfQkFSUklFUl9QUk9GSUxJTkcpCiAgICAgV3JpdGVCYXJy aWVyQ291bnRlcnM6OmNvdW50V3JpdGVCYXJyaWVyKCk7CiAjZW5kaWYKKyNpZiBFTkFCTEUoR0dD KQogICAgIGlmICghdG8uaXNDZWxsKCkpCiAgICAgICAgIHJldHVybjsKICAgICB3cml0ZUJhcnJp ZXIoZnJvbSwgdG8uYXNDZWxsKCkpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZnJvbSk7Cisg ICAgVU5VU0VEX1BBUkFNKHRvKTsKKyNlbmRpZgorfQorCitpbmxpbmUgdm9pZCBIZWFwOjp3cml0 ZUJhcnJpZXIoY29uc3QgSlNDZWxsKiBmcm9tLCBKU0NlbGwqIHRvKQoreworI2lmIEVOQUJMRShX UklURV9CQVJSSUVSX1BST0ZJTElORykKKyAgICBXcml0ZUJhcnJpZXJDb3VudGVyczo6Y291bnRX cml0ZUJhcnJpZXIoKTsKKyNlbmRpZgorI2lmIEVOQUJMRShHR0MpCisgICAgaWYgKCFmcm9tIHx8 ICFmcm9tLT5pc01hcmtlZCgpKSB7CisgICAgICAgIEFTU0VSVCghZnJvbSB8fCAhaXNNYXJrZWQo ZnJvbSkpOworICAgICAgICByZXR1cm47CisgICAgfQorICAgIGlmICghdG8gfHwgdG8tPmlzTWFy a2VkKCkpIHsKKyAgICAgICAgQVNTRVJUKCF0byB8fCBpc01hcmtlZCh0bykpOworICAgICAgICBy ZXR1cm47CisgICAgfQorICAgIGFkZFRvUmVtZW1iZXJlZFNldChmcm9tKTsKKyNlbHNlCisgICAg VU5VU0VEX1BBUkFNKGZyb20pOworICAgIFVOVVNFRF9QQVJBTSh0byk7CisjZW5kaWYKK30KKwor aW5saW5lIHZvaWQgSGVhcDo6d3JpdGVCYXJyaWVyKGNvbnN0IEpTQ2VsbCogZnJvbSkKK3sKKyNp ZiBFTkFCTEUoR0dDKQorICAgIEFTU0VSVF9HQ19PQkpFQ1RfTE9PS1NfVkFMSUQoY29uc3RfY2Fz dDxKU0NlbGwqPihmcm9tKSk7CisgICAgaWYgKCFmcm9tIHx8ICFmcm9tLT5pc01hcmtlZCgpKSB7 CisgICAgICAgIEFTU0VSVCghZnJvbSB8fCAhaXNNYXJrZWQoZnJvbSkpOworICAgICAgICByZXR1 cm47CisgICAgfQorICAgIEFTU0VSVChpc01hcmtlZChmcm9tKSk7CisgICAgYWRkVG9SZW1lbWJl cmVkU2V0KGZyb20pOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZnJvbSk7CisjZW5kaWYKIH0K IAogaW5saW5lIHZvaWQgSGVhcDo6cmVwb3J0RXh0cmFNZW1vcnlDb3N0KHNpemVfdCBjb3N0KQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsSW5saW5lcy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbElubGluZXMuaAko cmV2aXNpb24gMTY2NzQzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxs SW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDIsMjIgKzI0Miw2IEBAIGlubGluZSBUcmlT dGF0ZSBKU0NlbGw6OnB1cmVUb0Jvb2xlYW4oKSAKICAgICByZXR1cm4gTWl4ZWRUcmlTdGF0ZTsK IH0KIAotaW5saW5lIHZvaWQgSGVhcDo6d3JpdGVCYXJyaWVyKGNvbnN0IEpTQ2VsbCogZnJvbSwg SlNDZWxsKiB0bykKLXsKLSNpZiBFTkFCTEUoV1JJVEVfQkFSUklFUl9QUk9GSUxJTkcpCi0gICAg V3JpdGVCYXJyaWVyQ291bnRlcnM6OmNvdW50V3JpdGVCYXJyaWVyKCk7Ci0jZW5kaWYKLSAgICBp ZiAoIWZyb20gfHwgIWZyb20tPmlzTWFya2VkKCkpIHsKLSAgICAgICAgQVNTRVJUKCFmcm9tIHx8 ICFpc01hcmtlZChmcm9tKSk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0gICAgaWYgKCF0byB8 fCB0by0+aXNNYXJrZWQoKSkgewotICAgICAgICBBU1NFUlQoIXRvIHx8IGlzTWFya2VkKHRvKSk7 Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0gICAgYWRkVG9SZW1lbWJlcmVkU2V0KGZyb20pOwot fQotCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAogI2VuZGlmIC8vIEpTQ2VsbElubGluZXNfaAo=