131178 2014-04-03 12:08:56 -0700 [GTK] Fails to build documentation when output is redirected 2014-04-22 11:13:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gustavo gustavo pnormand oldest_to_newest 997258 0 gustavo 2014-04-03 12:08:56 -0700 [GTK] Fails to build documentation when output is redirected 997261 1 228529 gustavo 2014-04-03 12:10:06 -0700 Created attachment 228529 Patch 997262 2 gustavo 2014-04-03 12:11:40 -0700 I found this while building webkit-clutter which also uses those scripts: Traceback (most recent call last): File "../Tools/gtk/generate-gtkdoc", line 296, in <module> saw_webkit1_warnings = generate_doc(generator) File "../Tools/gtk/generate-gtkdoc", line 233, in generate_doc generator.generate(html='--skip-html' not in sys.argv) File "/usr/src/packages/BUILD/webkit-clutter-2.3.5+20140313+c798d3a/Tools/gtk/gtkdoc.py", line 147, in generate self._run_gtkdoc_fixxref() File "/usr/src/packages/BUILD/webkit-clutter-2.3.5+20140313+c798d3a/Tools/gtk/gtkdoc.py", line 369, in _run_gtkdoc_fixxref self._run_command(args, cwd=self.output_dir, ignore_warnings=True) File "/usr/src/packages/BUILD/webkit-clutter-2.3.5+20140313+c798d3a/Tools/gtk/gtkdoc.py", line 194, in _run_command sys.stdout.write(stdout) UnicodeEncodeError: 'ascii' codec can't encode character u'\u201c' in position 3856: ordinal not in range(128) make[3]: *** [docs-build.stamp] Error 1 999151 3 pnormand 2014-04-09 05:52:47 -0700 Seems like another option would be: export PYTHONIOENCODING=utf-8 999155 4 gustavo 2014-04-09 06:46:58 -0700 I think relying on setting something on the environment is not that great =/ 999168 5 228529 mrobinson 2014-04-09 07:33:54 -0700 Comment on attachment 228529 Patch This approach seems fine to me, but can we move this to generate-gtkdoc? 1000833 6 gustavo 2014-04-15 05:28:35 -0700 I did before I uploaded the patch, following our discussion on IRC =) 1000835 7 228529 mrobinson 2014-04-15 05:42:59 -0700 Comment on attachment 228529 Patch Sorry! I was going too fast. 1002998 8 gustavo 2014-04-22 11:13:28 -0700 Committed r167669: <http://trac.webkit.org/changeset/167669> 228529 2014-04-03 12:10:06 -0700 2014-04-15 05:42:59 -0700 Patch bug-131178-20140403160944.patch text/plain 1442 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NzE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjNhMGY0ZDMyZDY5MDQwNTY5NGJkMGJiZDgzZmUwOTVl ZmY5Mjg2YS4uOWI2MjlkYzcwNTQ5NWMzNGVkNzQyZThiYWFiZDYxMjRlODY4Y2RiNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA0LTAzICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgor CisgICAgICAgIFtHVEtdIEZhaWxzIHRvIGJ1aWxkIGRvY3VtZW50YXRpb24gd2hlbiBvdXRwdXQg aXMgcmVkaXJlY3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTMxMTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBndGsvZ2VuZXJhdGUtZ3RrZG9jOiBzZXQgdGhlIG91dHB1dCBmb3Igc3Rkb3V0IGFu ZCBzdGRlcnIgdG8gVVRGLTgKKyAgICAgICAgZXhwbGljaXRseSB0byBhdm9pZCBlbmNvZGluZyBp c3N1ZXMgd2hlbiB0aGV5IGFyZSByZWRpcmVjdGVkLgorCiAyMDE0LTA0LTAzICBNYW51ZWwgUmVn byBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFt3ZWJraXRweV0gcGVy ZiBwcm9maWxlciBkb2VzIG5vdCB1bmRlcnN0YW5kIC0tY2FsbC1ncmFwaCBhcmd1bWVudApkaWZm IC0tZ2l0IGEvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYyBiL1Rvb2xzL2d0ay9nZW5lcmF0ZS1n dGtkb2MKaW5kZXggM2U3ZjAwOGNlNWFkMzA4NDIwYzUyNmYyZWQ2ZjYyM2JmMWE3ZjBiZi4uNWFm ZTFiMzc3NjFlN2EzNTJlMTlmNTA0MjM5YzAxZTk3YzdkZDVhYiAxMDA3NTUKLS0tIGEvVG9vbHMv Z3RrL2dlbmVyYXRlLWd0a2RvYworKysgYi9Ub29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jCkBAIC0x OSw2ICsxOSw3IEBAIGZyb20gX19mdXR1cmVfXyBpbXBvcnQgcHJpbnRfZnVuY3Rpb24KIGZyb20g Q29uZmlnUGFyc2VyIGltcG9ydCBTYWZlQ29uZmlnUGFyc2VyCiAKIGltcG9ydCBhcmdwYXJzZQor aW1wb3J0IGNvZGVjcwogaW1wb3J0IGNvbW1vbgogaW1wb3J0IGdsb2IKIGltcG9ydCBndGtkb2MK QEAgLTI3LDYgKzI4LDkgQEAgaW1wb3J0IG9zLnBhdGgKIGltcG9ydCBzeXMKIGltcG9ydCB3ZWJr aXRkb20KIAorc3lzLnN0ZG91dCA9IGNvZGVjcy5nZXR3cml0ZXIoInV0Zi04Iikoc3lzLnN0ZG91 dCkKK3N5cy5zdGRlcnIgPSBjb2RlY3MuZ2V0d3JpdGVyKCJ1dGYtOCIpKHN5cy5zdGRlcnIpCisK IGRlZiBjb25maWd1cmVfbG9nZ2luZyh2ZXJib3NlKToKICAgICBsZXZlbCA9IGxvZ2dpbmcuREVC VUcgaWYgdmVyYm9zZSBlbHNlIGxvZ2dpbmcuSU5GTwogICAgIGxvZ2dlciA9IGxvZ2dpbmcuZ2V0 TG9nZ2VyKCdndGtkb2MnKQo=