13117 2007-03-19 06:30:29 -0700 REGRESSION (r14658): Flickering text fields when updating via javascript 2007-03-19 12:46:33 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://bestbefore.tv/flickr.html InRadar, Regression P1 Normal --- 1 jon mitz mitz mrowe oldest_to_newest 18271 0 jon 2007-03-19 06:30:29 -0700 Text fields often flicker when their value is set with javascript. That is, when their value is changed, the field is cleared to white for a split second, then the actual value is drawn. This is most obvious when they're rapidly updated (see the sample page) but can happen even for a single update. The flicker seems to have been introduced between r14652:14663 18272 1 mitz 2007-03-19 07:38:27 -0700 I think I know what to do! 18273 2 13704 mitz 2007-03-19 08:35:19 -0700 Created attachment 13704 Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout The flickering was caused by painting without updating layout first, as a result of -[WebCoreFrameBridge needsLayout] returning NO because the required layout was for a subtree only. 18274 3 13705 mitz 2007-03-19 08:36:37 -0700 Created attachment 13705 Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout Moved a *. 18283 4 mjs 2007-03-19 11:52:26 -0700 <rdar://problem/5072352> 18288 5 13705 hyatt 2007-03-19 12:41:29 -0700 Comment on attachment 13705 Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout r=me 18290 6 adele 2007-03-19 12:46:33 -0700 Committed revision 20324. 13704 2007-03-19 08:35:19 -0700 2007-03-19 08:36:37 -0700 Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout 13117_r1.patch text/plain 2987 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDMyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDctMDMtMTkgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTE3CisgICAgICAgIFJF R1JFU1NJT04gKHIxNDY1OCk6IEZsaWNrZXJpbmcgdGV4dCBmaWVsZHMgd2hlbiB1cGRhdGluZyB2 aWEgamF2YXNjcmlwdAorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZTo6Zm9yY2VMYXlvdXQpOiBBZGRlZCBhIGZsYWcgdG8gYWxsb3cgcGFydGlhbCBy ZWxheW91dC4KKyAgICAgICAgKiBwYWdlL0ZyYW1lLmg6CisgICAgICAgICogcGFnZS9tYWMvV2Vi Q29yZUZyYW1lQnJpZGdlLm1tOgorICAgICAgICAoLVtXZWJDb3JlRnJhbWVCcmlkZ2UgZm9yY2VM YXlvdXRBZGp1c3RpbmdWaWV3U2l6ZTpdKTogQWxsb3cgcGFydGlhbCByZWxheW91dAorICAgICAg ICBpZiBub3QgYWRqdXN0aW5nIHZpZXcgc2l6ZS4KKyAgICAgICAgKC1bV2ViQ29yZUZyYW1lQnJp ZGdlIG5lZWRzTGF5b3V0XSk6IENoYW5nZWQgdG8gY2hlY2sgZm9yIHBlbmRpbmcgc3VidHJlZQor ICAgICAgICBsYXlvdXQgaW5zdGVhZCBvZiBqdXN0IHdoZXRoZXIgdGhlIHJvb3QgbmVlZHMgbGF5 b3V0LgorCiAyMDA3LTAzLTE5ICBNaXR6IFBldHRlbCAgPG1pdHpAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBUaW0gSGF0Y2hlci4KSW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkocmV2aXNpb24gMjAzMjAp CisrKyBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMwLDExICsx MzMwLDExIEBAIEZyYW1lKiBGcmFtZTo6ZnJhbWVGb3JXaWRnZXQoY29uc3QgV2lkZ2UKICAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8Y29uc3QgRnJhbWVWaWV3Kj4od2lkZ2V0KS0+ZnJhbWUoKTsKIH0K IAotdm9pZCBGcmFtZTo6Zm9yY2VMYXlvdXQoKQordm9pZCBGcmFtZTo6Zm9yY2VMYXlvdXQoYm9v bCBhbGxvd1N1YnRyZWUpCiB7CiAgICAgRnJhbWVWaWV3ICp2ID0gZC0+bV92aWV3LmdldCgpOwog ICAgIGlmICh2KSB7Ci0gICAgICAgIHYtPmxheW91dChmYWxzZSk7CisgICAgICAgIHYtPmxheW91 dChhbGxvd1N1YnRyZWUpOwogICAgICAgICAvLyBXZSBjYW5ub3QgdW5zY2hlZHVsZSBhIHBlbmRp bmcgcmVsYXlvdXQsIHNpbmNlIHRoZSBmb3JjZSBjYW4gYmUgY2FsbGVkIHdpdGgKICAgICAgICAg Ly8gYSB0aW55IHJlY3RhbmdsZSBmcm9tIGEgZHJhd1JlY3QgdXBkYXRlLiAgQnkgdW5zY2hlZHVs aW5nIHdlIGluIGVmZmVjdAogICAgICAgICAvLyAidmFsaWRhdGUiIGFuZCBzdG9wIHRoZSBuZWNl c3NhcnkgZnVsbCByZXBhaW50IGZyb20gb2NjdXJyaW5nLiAgQmFzaWNhbGx5IGFueSBiYXNpYwpJ bmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0Zy YW1lLmgJKHJldmlzaW9uIDIwMzIwKQorKysgV2ViQ29yZS9wYWdlL0ZyYW1lLmgJKHdvcmtpbmcg Y29weSkKQEAgLTIxNyw3ICsyMTcsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFkanVzdFBhZ2VI ZWlnaHQoZmxvYXQqIG5ld0JvdHRvbSwgZmxvYXQgb2xkVG9wLCBmbG9hdCBvbGRCb3R0b20sIGZs b2F0IGJvdHRvbUxpbWl0KTsKIAotICAgIHZvaWQgZm9yY2VMYXlvdXQoKTsKKyAgICB2b2lkIGZv cmNlTGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlID0gZmFsc2UpOwogICAgIHZvaWQgZm9yY2VMYXlv dXRXaXRoUGFnZVdpZHRoUmFuZ2UoZmxvYXQgbWluUGFnZVdpZHRoLCBmbG9hdCBtYXhQYWdlV2lk dGgpOwogCiAgICAgdm9pZCBzZW5kUmVzaXplRXZlbnQoKTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9t YWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9tYWMv V2ViQ29yZUZyYW1lQnJpZGdlLm1tCShyZXZpc2lvbiAyMDMyMCkKKysrIFdlYkNvcmUvcGFnZS9t YWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zODQsNyArMzg0LDcg QEAgc3RhdGljIGlubGluZSBXZWJDb3JlRnJhbWVCcmlkZ2UgKmJyaWRnZQogCiAtICh2b2lkKWZv cmNlTGF5b3V0QWRqdXN0aW5nVmlld1NpemU6KEJPT0wpZmxhZwogewotICAgIG1fZnJhbWUtPmZv cmNlTGF5b3V0KCk7CisgICAgbV9mcmFtZS0+Zm9yY2VMYXlvdXQoIWZsYWcpOwogICAgIGlmIChm bGFnKQogICAgICAgICBtX2ZyYW1lLT52aWV3KCktPmFkanVzdFZpZXdTaXplKCk7CiB9CkBAIC03 NjksOCArNzY5LDggQEAgc3RhdGljIEhUTUxGb3JtRWxlbWVudCAqZm9ybUVsZW1lbnRGcm9tRAog CiAtIChCT09MKW5lZWRzTGF5b3V0CiB7Ci0gICAgUmVuZGVyT2JqZWN0ICpyZW5kZXJlciA9IG1f ZnJhbWUtPnJlbmRlcmVyKCk7Ci0gICAgcmV0dXJuIHJlbmRlcmVyID8gcmVuZGVyZXItPm5lZWRz TGF5b3V0KCkgOiBmYWxzZTsKKyAgICBGcmFtZVZpZXcgKnZpZXcgPSBtX2ZyYW1lLT52aWV3KCk7 CisgICAgcmV0dXJuIHZpZXcgPyB2aWV3LT5sYXlvdXRQZW5kaW5nKCkgOiBmYWxzZTsKIH0KIAog LSAodm9pZClzZXROZWVkc0xheW91dAo= 13705 2007-03-19 08:36:37 -0700 2007-03-19 12:41:29 -0700 Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout 13117_r1.patch text/plain 2987 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDMyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDctMDMtMTkgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTE3CisgICAgICAgIFJF R1JFU1NJT04gKHIxNDY1OCk6IEZsaWNrZXJpbmcgdGV4dCBmaWVsZHMgd2hlbiB1cGRhdGluZyB2 aWEgamF2YXNjcmlwdAorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZTo6Zm9yY2VMYXlvdXQpOiBBZGRlZCBhIGZsYWcgdG8gYWxsb3cgcGFydGlhbCBy ZWxheW91dC4KKyAgICAgICAgKiBwYWdlL0ZyYW1lLmg6CisgICAgICAgICogcGFnZS9tYWMvV2Vi Q29yZUZyYW1lQnJpZGdlLm1tOgorICAgICAgICAoLVtXZWJDb3JlRnJhbWVCcmlkZ2UgZm9yY2VM YXlvdXRBZGp1c3RpbmdWaWV3U2l6ZTpdKTogQWxsb3cgcGFydGlhbCByZWxheW91dAorICAgICAg ICBpZiBub3QgYWRqdXN0aW5nIHZpZXcgc2l6ZS4KKyAgICAgICAgKC1bV2ViQ29yZUZyYW1lQnJp ZGdlIG5lZWRzTGF5b3V0XSk6IENoYW5nZWQgdG8gY2hlY2sgZm9yIHBlbmRpbmcgc3VidHJlZQor ICAgICAgICBsYXlvdXQgaW5zdGVhZCBvZiBqdXN0IHdoZXRoZXIgdGhlIHJvb3QgbmVlZHMgbGF5 b3V0LgorCiAyMDA3LTAzLTE5ICBNaXR6IFBldHRlbCAgPG1pdHpAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBUaW0gSGF0Y2hlci4KSW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkocmV2aXNpb24gMjAzMjAp CisrKyBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMwLDExICsx MzMwLDExIEBAIEZyYW1lKiBGcmFtZTo6ZnJhbWVGb3JXaWRnZXQoY29uc3QgV2lkZ2UKICAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8Y29uc3QgRnJhbWVWaWV3Kj4od2lkZ2V0KS0+ZnJhbWUoKTsKIH0K IAotdm9pZCBGcmFtZTo6Zm9yY2VMYXlvdXQoKQordm9pZCBGcmFtZTo6Zm9yY2VMYXlvdXQoYm9v bCBhbGxvd1N1YnRyZWUpCiB7CiAgICAgRnJhbWVWaWV3ICp2ID0gZC0+bV92aWV3LmdldCgpOwog ICAgIGlmICh2KSB7Ci0gICAgICAgIHYtPmxheW91dChmYWxzZSk7CisgICAgICAgIHYtPmxheW91 dChhbGxvd1N1YnRyZWUpOwogICAgICAgICAvLyBXZSBjYW5ub3QgdW5zY2hlZHVsZSBhIHBlbmRp bmcgcmVsYXlvdXQsIHNpbmNlIHRoZSBmb3JjZSBjYW4gYmUgY2FsbGVkIHdpdGgKICAgICAgICAg Ly8gYSB0aW55IHJlY3RhbmdsZSBmcm9tIGEgZHJhd1JlY3QgdXBkYXRlLiAgQnkgdW5zY2hlZHVs aW5nIHdlIGluIGVmZmVjdAogICAgICAgICAvLyAidmFsaWRhdGUiIGFuZCBzdG9wIHRoZSBuZWNl c3NhcnkgZnVsbCByZXBhaW50IGZyb20gb2NjdXJyaW5nLiAgQmFzaWNhbGx5IGFueSBiYXNpYwpJ bmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0Zy YW1lLmgJKHJldmlzaW9uIDIwMzIwKQorKysgV2ViQ29yZS9wYWdlL0ZyYW1lLmgJKHdvcmtpbmcg Y29weSkKQEAgLTIxNyw3ICsyMTcsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGFkanVzdFBhZ2VI ZWlnaHQoZmxvYXQqIG5ld0JvdHRvbSwgZmxvYXQgb2xkVG9wLCBmbG9hdCBvbGRCb3R0b20sIGZs b2F0IGJvdHRvbUxpbWl0KTsKIAotICAgIHZvaWQgZm9yY2VMYXlvdXQoKTsKKyAgICB2b2lkIGZv cmNlTGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlID0gZmFsc2UpOwogICAgIHZvaWQgZm9yY2VMYXlv dXRXaXRoUGFnZVdpZHRoUmFuZ2UoZmxvYXQgbWluUGFnZVdpZHRoLCBmbG9hdCBtYXhQYWdlV2lk dGgpOwogCiAgICAgdm9pZCBzZW5kUmVzaXplRXZlbnQoKTsKSW5kZXg6IFdlYkNvcmUvcGFnZS9t YWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9tYWMv V2ViQ29yZUZyYW1lQnJpZGdlLm1tCShyZXZpc2lvbiAyMDMyMCkKKysrIFdlYkNvcmUvcGFnZS9t YWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zODQsNyArMzg0LDcg QEAgc3RhdGljIGlubGluZSBXZWJDb3JlRnJhbWVCcmlkZ2UgKmJyaWRnZQogCiAtICh2b2lkKWZv cmNlTGF5b3V0QWRqdXN0aW5nVmlld1NpemU6KEJPT0wpZmxhZwogewotICAgIG1fZnJhbWUtPmZv cmNlTGF5b3V0KCk7CisgICAgbV9mcmFtZS0+Zm9yY2VMYXlvdXQoIWZsYWcpOwogICAgIGlmIChm bGFnKQogICAgICAgICBtX2ZyYW1lLT52aWV3KCktPmFkanVzdFZpZXdTaXplKCk7CiB9CkBAIC03 NjksOCArNzY5LDggQEAgc3RhdGljIEhUTUxGb3JtRWxlbWVudCAqZm9ybUVsZW1lbnRGcm9tRAog CiAtIChCT09MKW5lZWRzTGF5b3V0CiB7Ci0gICAgUmVuZGVyT2JqZWN0ICpyZW5kZXJlciA9IG1f ZnJhbWUtPnJlbmRlcmVyKCk7Ci0gICAgcmV0dXJuIHJlbmRlcmVyID8gcmVuZGVyZXItPm5lZWRz TGF5b3V0KCkgOiBmYWxzZTsKKyAgICBGcmFtZVZpZXcqIHZpZXcgPSBtX2ZyYW1lLT52aWV3KCk7 CisgICAgcmV0dXJuIHZpZXcgPyB2aWV3LT5sYXlvdXRQZW5kaW5nKCkgOiBmYWxzZTsKIH0KIAog LSAodm9pZClzZXROZWVkc0xheW91dAo=