131167 2014-04-03 10:09:44 -0700 Fix bit rot in ARMv7 JIT probe mechanism 2014-04-03 11:25:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo ggaren mhahnenberg mmirman msaboff oliver oldest_to_newest 997213 0 mark.lam 2014-04-03 10:09:44 -0700 This is just to get the ARMv7 JIT probe mechanism working again. The needed changes: 1. The macro assembler does not support pushing the SP register. Worked around this by pushing the LR register as a placeholder, and then writing the original SP value to that slot. 2. The CPUState field in the ProbeContext needs to be aligned on a 4 byte boundary, not an 8 byte boundary. 997214 1 228514 mark.lam 2014-04-03 10:13:53 -0700 Created attachment 228514 the patch 997228 2 228514 ggaren 2014-04-03 10:54:41 -0700 Comment on attachment 228514 the patch r=me 997246 3 228514 commit-queue 2014-04-03 11:25:52 -0700 Comment on attachment 228514 the patch Clearing flags on attachment: 228514 Committed r166732: <http://trac.webkit.org/changeset/166732> 997247 4 commit-queue 2014-04-03 11:25:55 -0700 All reviewed patches have been landed. Closing bug. 228514 2014-04-03 10:13:53 -0700 2014-04-03 11:25:52 -0700 the patch bug-131167.patch text/plain 2339 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2NzI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTA0LTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggYml0IHJvdCBpbiBBUk12NyBKSVQgcHJvYmUgbWVjaGFuaXNtLgorICAgICAgICA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMTMxMTY3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIDEuIFRoZSBtYWNybyBhc3NlbWJsZXIgZG9lcyBub3Qgc3VwcG9ydCBw dXNoaW5nIHRoZSBTUCByZWdpc3Rlci4gIFdvcmtlZAorICAgICAgICAgICBhcm91bmQgdGhpcyBi eSBwdXNoaW5nIHRoZSBMUiByZWdpc3RlciBhcyBhIHBsYWNlaG9sZGVyLCBhbmQgdGhlbgorICAg ICAgICAgICB3cml0aW5nIHRoZSBvcmlnaW5hbCBTUCB2YWx1ZSB0byB0aGF0IHNsb3QuCisgICAg ICAgIDIuIFRoZSBDUFVTdGF0ZSBmaWVsZCBpbiB0aGUgUHJvYmVDb250ZXh0IG5lZWRzIHRvIGJl IGFsaWduZWQgb24gYSA0CisgICAgICAgICAgIGJ5dGUgYm91bmRhcnksIG5vdCBhbiA4IGJ5dGUg Ym91bmRhcnkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5jcHA6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNdjc6OnByb2JlKToKKyAgICAgICAgKiBq aXQvSklUU3R1YnNBUk12Ny5oOgorCiAyMDE0LTA0LTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBBUk12NyBjb21wYXJlMzIoKSBzaG91bGQgbm90IHVzZSBUU1Qg dG8gZG8gQ01QJ3Mgam9iLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTXY3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuY3BwCShyZXZpc2lvbiAxNjY3MTUpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC04Miw4ICs4MiwxMCBAQCBleHRlcm4gIkMiIHZvaWQgY3RpTWFz bVByb2JlVHJhbXBvbGluZSgpCiAKIHZvaWQgTWFjcm9Bc3NlbWJsZXJBUk12Nzo6cHJvYmUoTWFj cm9Bc3NlbWJsZXJBUk12Nzo6UHJvYmVGdW5jdGlvbiBmdW5jdGlvbiwgdm9pZCogYXJnMSwgdm9p ZCogYXJnMikKIHsKLSAgICBwdXNoKFJlZ2lzdGVySUQ6OnNwKTsKICAgICBwdXNoKFJlZ2lzdGVy SUQ6OmxyKTsKKyAgICBwdXNoKFJlZ2lzdGVySUQ6OmxyKTsKKyAgICBhZGQzMihUcnVzdGVkSW1t MzIoOCksIFJlZ2lzdGVySUQ6OnNwLCBSZWdpc3RlcklEOjpscik7CisgICAgc3RvcmUzMihSZWdp c3RlcklEOjpsciwgQXJtQWRkcmVzcyhSZWdpc3RlcklEOjpzcCwgNCkpOwogICAgIHB1c2goUmVn aXN0ZXJJRDo6aXApOwogICAgIHB1c2goUmVnaXN0ZXJJRDo6cjApOwogICAgIC8vIFRoZSBmb2xs b3dpbmcgdXNlcyBSZWdpc3RlcklEOjppcC4gU28sIHRoZXkgbXVzdCBjb21lIGFmdGVyIHdlIHB1 c2ggaXAgYWJvdmUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzQVJN djcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzQVJN djcuaAkocmV2aXNpb24gMTY2NzE1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRT dHVic0FSTXY3LmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDcgKzUyLDcgQEAgbmFtZXNwYWNlIEpT QyB7CiAjZGVmaW5lIFBST0JFX0FSRzFfT0ZGU0VUICgxICogUFRSX1NJWkUpCiAjZGVmaW5lIFBS T0JFX0FSRzJfT0ZGU0VUICgyICogUFRSX1NJWkUpCiAKLSNkZWZpbmUgUFJPQkVfRklSU1RfR1BS RUdfT0ZGU0VUICg0ICogUFRSX1NJWkUpCisjZGVmaW5lIFBST0JFX0ZJUlNUX0dQUkVHX09GRlNF VCAoMyAqIFBUUl9TSVpFKQogCiAjZGVmaW5lIEdQUkVHX1NJWkUgNAogI2RlZmluZSBQUk9CRV9D UFVfUjBfT0ZGU0VUIChQUk9CRV9GSVJTVF9HUFJFR19PRkZTRVQgKyAoMCAqIEdQUkVHX1NJWkUp KQo=