131164 2014-04-03 08:41:27 -0700 [WK2] Fix !ENABLE(BLOB) build 2014-04-04 06:13:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhodovan.u-szeged webkit-unassigned ap beidson commit-queue darin kling oldest_to_newest 997177 0 mhodovan.u-szeged 2014-04-03 08:41:27 -0700 [WK2] Fix !ENABLE(BLOB) build 997178 1 228510 mhodovan.u-szeged 2014-04-03 08:46:06 -0700 Created attachment 228510 Proposed patch 997188 2 228510 ap 2014-04-03 09:25:59 -0700 Comment on attachment 228510 Proposed patch r=me What is the purpose of not enabling BLOB, though? Should we just enable it unconditionally everywhere? 997210 3 228510 commit-queue 2014-04-03 09:56:12 -0700 Comment on attachment 228510 Proposed patch Clearing flags on attachment: 228510 Committed r166728: <http://trac.webkit.org/changeset/166728> 997211 4 commit-queue 2014-04-03 09:56:15 -0700 All reviewed patches have been landed. Closing bug. 997550 5 mhodovan.u-szeged 2014-04-04 06:13:29 -0700 (In reply to comment #2) > (From update of attachment 228510 [details]) > What is the purpose of not enabling BLOB, though? Should we just enable it unconditionally everywhere? The --minimal build is used for checking whether the guards are at the right places, and this patch was necessary to make it work properly. If no one is interested to build without BLOB, then probably we should remove the guards. 228510 2014-04-03 08:46:06 -0700 2014-04-03 09:56:12 -0700 Proposed patch 0001-enable-blob-build.patch text/plain 4238 mhodovan.u-szeged RnJvbSBhODM3MWM2NTI2ODljNWUxNzdmNTI1ZjhjYWFlOGU0MjczMmVkODRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXJ0aW4gPG1ob2RvdmFuLnUtc3plZ2VkQHBhcnRuZXIuc2Ft c3VuZy5jb20+CkRhdGU6IFRodSwgMyBBcHIgMjAxNCAxNzo0NDowNyArMDIwMApTdWJqZWN0OiBb UEFUQ0hdIGVuYWJsZSBibG9iIGJ1aWxkCgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEyICsrKysrKysrKysrKwogLi4u L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuY3Bw IHwgIDQgKysrKwogLi4uL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25U b1dlYlByb2Nlc3MuaCAgIHwgIDIgKysKIC4uLi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVj dGlvblRvV2ViUHJvY2Vzcy5tZXNzYWdlcy5pbiB8ICAyICsrCiA0IGZpbGVzIGNoYW5nZWQsIDIw IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmE5MDBjOS4uYTk1M2UxMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTAzICBNYXJ0aW4gSG9kb3ZhbiAgPG1ob2RvdmFu QGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBbV0syXSBGaXggIUVOQUJMRShCTE9CKSBidWls ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMTY0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHA6CisgICAgICAgIChX ZWJLaXQ6Ok5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpkaWRDbG9zZSk6CisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuaDoKKyAgICAg ICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5tZXNzYWdl cy5pbjoKKwogMjAxNC0wMy0wOSAgSmVvbmcgWW9uZy11ayAgPHlvbmdAY29tcGFueTEwMC5jb20+ CiAKICAgICAgICAgVXBkYXRlIGNvbW1lbnQgaW4gTmV0d29ya1Jlc291cmNlTG9hZGVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRv V2ViUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29u bmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKaW5kZXggZGNjNjJlOS4uNWUyODQ5OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlBy b2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25u ZWN0aW9uVG9XZWJQcm9jZXNzLmNwcApAQCAtMTAxLDcgKzEwMSw5IEBAIHZvaWQgTmV0d29ya0Nv bm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmRpZENsb3NlKElQQzo6Q29ubmVjdGlvbiopCiAgICAgZm9y IChIYXNoTWFwPFJlc291cmNlTG9hZElkZW50aWZpZXIsIFJlZlB0cjxOZXR3b3JrUmVzb3VyY2VM b2FkZXI+Pjo6aXRlcmF0b3IgaSA9IG1fbmV0d29ya1Jlc291cmNlTG9hZGVycy5iZWdpbigpOyBp ICE9IGVuZDsgKytpKQogICAgICAgICBpLT52YWx1ZS0+YWJvcnQoKTsKIAorI2lmIEVOQUJMRShC TE9CKQogICAgIE5ldHdvcmtCbG9iUmVnaXN0cnk6OnNoYXJlZCgpLmNvbm5lY3Rpb25Ub1dlYlBy b2Nlc3NEaWRDbG9zZSh0aGlzKTsKKyNlbmRpZgogCiAgICAgbV9uZXR3b3JrUmVzb3VyY2VMb2Fk ZXJzLmNsZWFyKCk7CiAgICAgCkBAIC0yMTQsNiArMjE2LDcgQEAgdm9pZCBOZXR3b3JrQ29ubmVj dGlvblRvV2ViUHJvY2Vzczo6ZGVsZXRlQ29va2llKFNlc3Npb25JRCBzZXNzaW9uSUQsIGNvbnN0 IFVSTCYKICAgICBXZWJDb3JlOjpkZWxldGVDb29raWUoc3RvcmFnZVNlc3Npb24oc2Vzc2lvbklE KSwgdXJsLCBjb29raWVOYW1lKTsKIH0KIAorI2lmIEVOQUJMRShCTE9CKQogdm9pZCBOZXR3b3Jr Q29ubmVjdGlvblRvV2ViUHJvY2Vzczo6cmVnaXN0ZXJCbG9iVVJMKGNvbnN0IFVSTCYgdXJsLCBj b25zdCBCbG9iUmVnaXN0cmF0aW9uRGF0YSYgZGF0YSkKIHsKICAgICBWZWN0b3I8UmVmUHRyPFNh bmRib3hFeHRlbnNpb24+PiBleHRlbnNpb25zOwpAQCAtMjM0LDYgKzIzNyw3IEBAIHZvaWQgTmV0 d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnVucmVnaXN0ZXJCbG9iVVJMKGNvbnN0IFVSTCYg dXJsKQogewogICAgIE5ldHdvcmtCbG9iUmVnaXN0cnk6OnNoYXJlZCgpLnVucmVnaXN0ZXJCbG9i VVJMKHRoaXMsIHVybCk7CiB9CisjZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9u VG9XZWJQcm9jZXNzLmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29u bmVjdGlvblRvV2ViUHJvY2Vzcy5oCmluZGV4IGZhOTk3OTUuLjgxNWYxMGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9j ZXNzLmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rp b25Ub1dlYlByb2Nlc3MuaApAQCAtODYsOSArODYsMTEgQEAgcHJpdmF0ZToKICAgICB2b2lkIGdl dFJhd0Nvb2tpZXMoV2ViQ29yZTo6U2Vzc2lvbklELCBjb25zdCBXZWJDb3JlOjpVUkwmIGZpcnN0 UGFydHksIGNvbnN0IFdlYkNvcmU6OlVSTCYsIFZlY3RvcjxXZWJDb3JlOjpDb29raWU+Jik7CiAg ICAgdm9pZCBkZWxldGVDb29raWUoV2ViQ29yZTo6U2Vzc2lvbklELCBjb25zdCBXZWJDb3JlOjpV UkwmLCBjb25zdCBTdHJpbmcmIGNvb2tpZU5hbWUpOwogCisjaWYgRU5BQkxFKEJMT0IpCiAgICAg dm9pZCByZWdpc3RlckJsb2JVUkwoY29uc3QgV2ViQ29yZTo6VVJMJiwgY29uc3QgQmxvYlJlZ2lz dHJhdGlvbkRhdGEmKTsKICAgICB2b2lkIHJlZ2lzdGVyQmxvYlVSTEZyb21VUkwoY29uc3QgV2Vi Q29yZTo6VVJMJiwgY29uc3QgV2ViQ29yZTo6VVJMJiBzcmNVUkwpOwogICAgIHZvaWQgdW5yZWdp c3RlckJsb2JVUkwoY29uc3QgV2ViQ29yZTo6VVJMJik7CisjZW5kaWYKIAogICAgIFJlZlB0cjxJ UEM6OkNvbm5lY3Rpb24+IG1fY29ubmVjdGlvbjsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MubWVzc2FnZXMu aW4gYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2Vi UHJvY2Vzcy5tZXNzYWdlcy5pbgppbmRleCBhZjFlODVkLi5lOWJjOGIyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vz cy5tZXNzYWdlcy5pbgorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr Q29ubmVjdGlvblRvV2ViUHJvY2Vzcy5tZXNzYWdlcy5pbgpAQCAtNDIsOSArNDIsMTEgQEAgbWVz c2FnZXMgLT4gTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MgTGVnYWN5UmVjZWl2ZXIgewog ICAgIEdldFJhd0Nvb2tpZXMoV2ViQ29yZTo6U2Vzc2lvbklEIHNlc3Npb25JRCwgV2ViQ29yZTo6 VVJMIGZpcnN0UGFydHksIFdlYkNvcmU6OlVSTCB1cmwpIC0+IChWZWN0b3I8V2ViQ29yZTo6Q29v a2llPiBjb29raWVzKQogICAgIERlbGV0ZUNvb2tpZShXZWJDb3JlOjpTZXNzaW9uSUQgc2Vzc2lv bklELCBXZWJDb3JlOjpVUkwgdXJsLCBTdHJpbmcgY29va2llTmFtZSkKIAorI2lmIEVOQUJMRShC TE9CKQogICAgIFJlZ2lzdGVyQmxvYlVSTChXZWJDb3JlOjpVUkwgdXJsLCBXZWJLaXQ6OkJsb2JS ZWdpc3RyYXRpb25EYXRhIGRhdGEpCiAgICAgUmVnaXN0ZXJCbG9iVVJMRnJvbVVSTChXZWJDb3Jl OjpVUkwgdXJsLCBXZWJDb3JlOjpVUkwgc3JjVVJMKQogICAgIFVucmVnaXN0ZXJCbG9iVVJMKFdl YkNvcmU6OlVSTCB1cmwpCisjZW5kaWYKIH0KIAogI2VuZGlmIC8vIEVOQUJMRShORVRXT1JLX1BS T0NFU1MpCi0tIAoxLjguMS4yCgo=