131157 2014-04-03 00:50:13 -0700 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests 2014-04-03 09:39:43 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa benjamin commit-queue kling koivisto slewis zoltan oldest_to_newest 997067 0 rniwa 2014-04-03 00:50:13 -0700 Right now, adding "all metrics" would result in adding all metrics of the suite as well as all subtests of the suite. We should split these two notions so that we can add, for example, all PLT metrics without having to add times for all pages. 997068 1 228485 rniwa 2014-04-03 00:57:53 -0700 Created attachment 228485 Patch 997200 2 228485 commit-queue 2014-04-03 09:39:40 -0700 Comment on attachment 228485 Patch Clearing flags on attachment: 228485 Committed r166724: <http://trac.webkit.org/changeset/166724> 997201 3 commit-queue 2014-04-03 09:39:43 -0700 All reviewed patches have been landed. Closing bug. 228485 2014-04-03 00:57:53 -0700 2014-04-03 09:39:40 -0700 Patch bug-131157-20140403165730.patch text/plain 4958 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2Njk5CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBmMDA3NGI5Mjc3NzkyNzI3MDAxYjA1M2Q1MjQzMWNhODU4YmUzZTkwLi4yNDNmM2ExNzgy MDYxMzYzNjMwMjM5ZmIwMTE1MTNlODIwYWVjMzFmIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxNC0wNC0wMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAorICAgICAgICBXZWJLaXRQZXJmTW9uaXRvcjogVGhlcmUgc2hvdWxkIGJl IGEgd2F5IHRvIGFkZCBhbGwgbWV0cmljcyBvZiBhIHN1aXRlIHdpdGhvdXQgYWxzbyBhZGRpbmcg c3VidGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzMTE1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFNwbGl0ICJhbGwgbWV0cmljcyIgaW50byBhbGwgbWV0cmljcyBvZiBhIHRlc3Qgc3VpdGUgYW5k IGFsbCBzdWJ0ZXN0cyBvZiB0aGUgc3VpdGUuCisgICAgICAgIFRoaXMgYWxsb3dzLCBmb3IgZXhh bXBsZSwgYWRkaW5nIGFsbCBtZXRyaWNzIHN1Y2ggYXMgQXJpdGhtZXRpYyBhbmQgR2VvbWV0cmlj IGZvcgorICAgICAgICBhIGdpdmVuIHRlc3Qgc3VpdGUgd2l0aG91dCBhbHNvIGFkZGluZyBpdHMg c3VidGVzdHMuCisKKyAgICAgICAgKiBwdWJsaWMvaW5kZXguaHRtbDoKKyAgICAgICAgKGluaXQu c2hvd0NoYXJ0cyk6CisgICAgICAgIChpbml0KToKKworMjAxNC0wNC0wMyAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KKwogICAgICAgICBXZWJLaXRQZXJmTW9uaXRvcjogVG9vbHRp cHMgY2Fubm90IGJlIHBpbm5lZCBhZnRlciB1c2luZyBicm93c2VyJ3MgYmFjayBidXR0b24KICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMTE1NQogCmRp ZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luZGV4Lmh0bWwgYi9X ZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luZGV4Lmh0bWwKaW5kZXggZjY0MmUxYmVk ZGU4MzliYmY0YmM2YjE5MTE0M2UzNTZjNTY2NzFlMy4uOTk2MDM0YTU3ZDFmOTlhYTA2YjkyZmVh YzZiNWMzMzc2MzEwOTM0MSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1 YmxpYy9pbmRleC5odG1sCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5k ZXguaHRtbApAQCAtODk5LDE1ICs4OTksMzMgQEAgZnVuY3Rpb24gaW5pdCgpIHsKICAgICAgICAg ICAgIHdoaWxlIChtZXRyaWNMaXN0LmZpcnN0Q2hpbGQpCiAgICAgICAgICAgICAgICAgbWV0cmlj TGlzdC5yZW1vdmVDaGlsZChtZXRyaWNMaXN0LmZpcnN0Q2hpbGQpOwogCi0gICAgICAgICAgICBh ZGRPcHRpb24obWV0cmljTGlzdCwgJ0FsbCBtZXRyaWNzJywgT1BUSU9OX1ZBTFVFX0ZPUl9BTEwp OworICAgICAgICAgICAgdmFyIG1ldHJpY3NHcm91cCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J29wdGdyb3VwJyk7CisgICAgICAgICAgICBtZXRyaWNzR3JvdXAubGFiZWwgPSAnTWV0cmljcyc7 CisgICAgICAgICAgICBtZXRyaWNMaXN0LmFwcGVuZENoaWxkKG1ldHJpY3NHcm91cCk7CisgICAg ICAgICAgICBhZGRPcHRpb24obWV0cmljc0dyb3VwLCAnQWxsIG1ldHJpY3MnLCBPUFRJT05fVkFM VUVfRk9SX0FMTCk7CiAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRlc3RzLmxlbmd0 aDsgKytpKSB7Ci0gICAgICAgICAgICAgICAgaWYgKHRlc3RzW2ldLmlkICE9IHRlc3RMaXN0LnZh bHVlICYmICghdGVzdHNbaV0ucGFyZW50VGVzdCB8fCB0ZXN0c1tpXS5wYXJlbnRUZXN0LmlkICE9 IHRlc3RMaXN0LnZhbHVlKSkKKyAgICAgICAgICAgICAgICBpZiAodGVzdHNbaV0uaWQgPT0gdGVz dExpc3QudmFsdWUpIHsKKyAgICAgICAgICAgICAgICAgICAgdmFyIHNlbGVjdGVkVGVzdCA9IHRl c3RzW2ldOworICAgICAgICAgICAgICAgICAgICBmb3IgKHZhciBqID0gMDsgaiA8IHNlbGVjdGVk VGVzdC5tZXRyaWNzLmxlbmd0aDsgKytqKSB7CisgICAgICAgICAgICAgICAgICAgICAgICB2YXIg ZnVsbE5hbWUgPSBzZWxlY3RlZFRlc3QubWV0cmljc1tqXS5mdWxsTmFtZTsKKyAgICAgICAgICAg ICAgICAgICAgICAgIHZhciByZWxhdGl2ZU5hbWUgPSBmdWxsTmFtZS5yZXBsYWNlKHNlbGVjdGVk VGVzdC5mdWxsTmFtZSwgJycpLnJlcGxhY2UoL15bOi9dLywgJycpOworICAgICAgICAgICAgICAg ICAgICAgICAgYWRkT3B0aW9uKG1ldHJpY3NHcm91cCwgcmVsYXRpdmVOYW1lLCBmdWxsTmFtZSk7 CisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9 CisgICAgICAgICAgICB2YXIgc3VidGVzdHNHcm91cCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J29wdGdyb3VwJyk7CisgICAgICAgICAgICBzdWJ0ZXN0c0dyb3VwLmxhYmVsID0gJ1Rlc3RzJzsK KyAgICAgICAgICAgIG1ldHJpY0xpc3QuYXBwZW5kQ2hpbGQoc3VidGVzdHNHcm91cCk7CisgICAg ICAgICAgICBhZGRPcHRpb24oc3VidGVzdHNHcm91cCwgJ0FsbCBzdWJ0ZXN0cycsIE9QVElPTl9W QUxVRV9GT1JfQUxMKTsKKyAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGVzdHMubGVu Z3RoOyArK2kpIHsKKyAgICAgICAgICAgICAgICBpZiAoIXRlc3RzW2ldLnBhcmVudFRlc3QgfHwg dGVzdHNbaV0ucGFyZW50VGVzdC5pZCAhPSB0ZXN0TGlzdC52YWx1ZSkKICAgICAgICAgICAgICAg ICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAgdmFyIHNlbGVjdGVkVGVzdCA9IHRlc3Rz W2ldLmlkID09IHRlc3RMaXN0LnZhbHVlID8gdGVzdHNbaV0gOiB0ZXN0c1tpXS5wYXJlbnRUZXN0 OwotICAgICAgICAgICAgICAgIGZvciAodmFyIGogPSAwOyBqIDwgdGVzdHNbaV0ubWV0cmljcy5s ZW5ndGg7ICsraikgewotICAgICAgICAgICAgICAgICAgICB2YXIgZnVsbE5hbWUgPSB0ZXN0c1tp XS5tZXRyaWNzW2pdLmZ1bGxOYW1lOworICAgICAgICAgICAgICAgIHZhciBzdWJ0ZXN0ID0gdGVz dHNbaV07CisgICAgICAgICAgICAgICAgdmFyIHNlbGVjdGVkVGVzdCA9IHN1YnRlc3QucGFyZW50 VGVzdDsKKyAgICAgICAgICAgICAgICBmb3IgKHZhciBqID0gMDsgaiA8IHN1YnRlc3QubWV0cmlj cy5sZW5ndGg7ICsraikgeworICAgICAgICAgICAgICAgICAgICB2YXIgZnVsbE5hbWUgPSBzdWJ0 ZXN0Lm1ldHJpY3Nbal0uZnVsbE5hbWU7CiAgICAgICAgICAgICAgICAgICAgIHZhciByZWxhdGl2 ZU5hbWUgPSBmdWxsTmFtZS5yZXBsYWNlKHNlbGVjdGVkVGVzdC5mdWxsTmFtZSwgJycpLnJlcGxh Y2UoL15bOi9dLywgJycpOwotICAgICAgICAgICAgICAgICAgICBhZGRPcHRpb24obWV0cmljTGlz dCwgcmVsYXRpdmVOYW1lLCBmdWxsTmFtZSk7CisgICAgICAgICAgICAgICAgICAgIGFkZE9wdGlv bihzdWJ0ZXN0c0dyb3VwLCByZWxhdGl2ZU5hbWUsIGZ1bGxOYW1lKTsKICAgICAgICAgICAgICAg ICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KQEAgLTk2MywxMyArOTgxLDE0IEBAIGZ1bmN0 aW9uIGluaXQoKSB7CiAgICAgICAgICAgICAgICAgICAgIG5ld0NoYXJ0TGlzdC5wdXNoKFthbGxQ bGF0Zm9ybXNbaV0ubmFtZSwgbWV0cmljTGlzdC52YWx1ZV0pOwogICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIH0gZWxzZSBpZiAobWV0cmljTGlzdC52YWx1ZSA9PT0gT1BUSU9OX1ZBTFVF X0ZPUl9BTEwpIHsKLSAgICAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRlc3RzLmxl bmd0aDsgKytpKSB7Ci0gICAgICAgICAgICAgICAgICAgIGlmICh0ZXN0c1tpXS5pZCAhPSB0ZXN0 TGlzdC52YWx1ZSAmJiAoIXRlc3RzW2ldLnBhcmVudFRlc3QgfHwgdGVzdHNbaV0ucGFyZW50VGVz dC5pZCAhPSB0ZXN0TGlzdC52YWx1ZSkpCisgICAgICAgICAgICAgICAgdmFyIGdyb3VwID0gbWV0 cmljTGlzdC5zZWxlY3RlZE9wdGlvbnNbMF0ucGFyZW50Tm9kZTsKKyAgICAgICAgICAgICAgICB2 YXIgbWV0cmljc1RvQWRkID0gW107CisgICAgICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkg PCBncm91cC5jaGlsZHJlbi5sZW5ndGg7IGkrKykgeworICAgICAgICAgICAgICAgICAgICB2YXIg bWV0cmljID0gZ3JvdXAuY2hpbGRyZW5baV0udmFsdWU7CisgICAgICAgICAgICAgICAgICAgIGlm IChtZXRyaWMgPT0gT1BUSU9OX1ZBTFVFX0ZPUl9BTEwpCiAgICAgICAgICAgICAgICAgICAgICAg ICBjb250aW51ZTsKLSAgICAgICAgICAgICAgICAgICAgZm9yICh2YXIgaiA9IDA7IGogPCB0ZXN0 c1tpXS5tZXRyaWNzLmxlbmd0aDsgKytqKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBjcmVh dGVDaGFydEZyb21MaXN0UGFpcihwbGF0Zm9ybUxpc3QudmFsdWUsIHRlc3RzW2ldLm1ldHJpY3Nb al0uZnVsbE5hbWUpOwotICAgICAgICAgICAgICAgICAgICAgICAgbmV3Q2hhcnRMaXN0LnB1c2go W3BsYXRmb3JtTGlzdC52YWx1ZSwgdGVzdHNbaV0ubWV0cmljc1tqXS5mdWxsTmFtZV0pOwotICAg ICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgICAgIGNyZWF0ZUNoYXJ0RnJvbUxp c3RQYWlyKHBsYXRmb3JtTGlzdC52YWx1ZSwgbWV0cmljKTsKKyAgICAgICAgICAgICAgICAgICAg bmV3Q2hhcnRMaXN0LnB1c2goW3BsYXRmb3JtTGlzdC52YWx1ZSwgbWV0cmljXSk7CiAgICAgICAg ICAgICAgICAgfQogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBjcmVhdGVD aGFydEZyb21MaXN0UGFpcihwbGF0Zm9ybUxpc3QudmFsdWUsIG1ldHJpY0xpc3QudmFsdWUpOwo=