131152 2014-04-02 23:34:02 -0700 [WK2][EFL] Use template method in creating NativeWebMouseEvent 2014-04-03 21:12:28 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song bunhere cdumez commit-queue enmi.lee gyuyoung.kim lucas.de.marchi rakuco sergio oldest_to_newest 997025 0 jinwoo7.song 2014-04-02 23:34:02 -0700 There are three EFL mouse events, such as Evas_Event_Mouse_Down, Evas_Event_Mouse_Up, and Evas_Event_Mouse_Move. They can be defined as a template method. 997027 1 228471 jinwoo7.song 2014-04-02 23:36:13 -0700 Created attachment 228471 Patch 997050 2 enmi.lee 2014-04-03 00:24:51 -0700 LGTM. I like this patch :) 997459 3 228471 commit-queue 2014-04-03 21:12:23 -0700 Comment on attachment 228471 Patch Clearing flags on attachment: 228471 Committed r166763: <http://trac.webkit.org/changeset/166763> 997460 4 commit-queue 2014-04-03 21:12:28 -0700 All reviewed patches have been landed. Closing bug. 228471 2014-04-02 23:36:13 -0700 2014-04-03 21:12:22 -0700 Patch bug-131152-20140403153539.patch text/plain 5920 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTljMjg1YmI0YTQ2NTI2 YTQ2MjI4NTk0MjdhMjViMDIyZDFhZTg5Yy4uODUzM2Y2ODcxZTUxZWU5MWMzODQzNTE1ZjliYjE4 YTllNGYwNmY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA0LTAyICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXVtFRkxd IFVzZSB0ZW1wbGF0ZSBtZXRob2QgaW4gY3JlYXRpbmcgTmF0aXZlV2ViTW91c2VFdmVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMTUyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIHRo cmVlIEVGTCBtb3VzZSBldmVudHMsIHN1Y2ggYXMgRXZhc19FdmVudF9Nb3VzZV9Eb3duLCBFdmFz X0V2ZW50X01vdXNlX1VwLAorICAgICAgICBhbmQgRXZhc19FdmVudF9Nb3VzZV9Nb3ZlLiBUaGV5 IGNhbiBiZSBkZWZpbmVkIGFzIGEgdGVtcGxhdGUgbWV0aG9kLgorCisgICAgICAgICogUGxhdGZv cm1FZmwuY21ha2U6IFJlbW92ZSBOYXRpdmVXZWJNb3VzZUV2ZW50RWZsLmNwcAorICAgICAgICAq IFNoYXJlZC9OYXRpdmVXZWJNb3VzZUV2ZW50Lmg6CisgICAgICAgIChXZWJLaXQ6Ok5hdGl2ZVdl Yk1vdXNlRXZlbnQ6Ok5hdGl2ZVdlYk1vdXNlRXZlbnQpOiBBZGQgYSB0ZW1wbGF0ZSBtZXRob2Qu CisgICAgICAgICogU2hhcmVkL2VmbC9OYXRpdmVXZWJNb3VzZUV2ZW50RWZsLmNwcDogUmVtb3Zl ZC4KKwogMjAxNC0wNC0wMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgYSBGSVhNRSB0aGF0IGhhcHBlbmVkLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVm bC5jbWFrZQppbmRleCAwMGY1YzFiYWU4YzJlZjFlMTlmYTdjYzIzNjk1OTc3YTExMDhiOGM4Li5m MGRlOWJiYTVkNjI4OTIzZDFjNjY2MDQyYzcyYjNkYWE2ODFhYTZlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bUVmbC5jbWFrZQpAQCAtMzYsNyArMzYsNiBAQCBsaXN0KEFQUEVORCBXZWJLaXQyX1NPVVJDRVMK IAogICAgIFNoYXJlZC9lZmwvTGF5ZXJUcmVlQ29udGV4dEVmbC5jcHAKICAgICBTaGFyZWQvZWZs L05hdGl2ZVdlYktleWJvYXJkRXZlbnRFZmwuY3BwCi0gICAgU2hhcmVkL2VmbC9OYXRpdmVXZWJN b3VzZUV2ZW50RWZsLmNwcAogICAgIFNoYXJlZC9lZmwvTmF0aXZlV2ViVG91Y2hFdmVudEVmbC5j cHAKICAgICBTaGFyZWQvZWZsL05hdGl2ZVdlYldoZWVsRXZlbnRFZmwuY3BwCiAgICAgU2hhcmVk L2VmbC9Qcm9jZXNzRXhlY3V0YWJsZVBhdGhFZmwuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvTmF0aXZlV2ViTW91c2VFdmVudC5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVk L05hdGl2ZVdlYk1vdXNlRXZlbnQuaAppbmRleCAyMzFiMDNmYzMzNjkyZGZhZDZiMWFkZDRhNzdh MzcwYzY4NTcwNzUzLi43ZWVjODA0ODU2MmMwMjQyN2Q4MTQxNWFlZWJmOGRmMjFjNmE0ZGUyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvTmF0aXZlV2ViTW91c2VFdmVudC5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9OYXRpdmVXZWJNb3VzZUV2ZW50LmgKQEAgLTM0LDYg KzM0LDcgQEAgT0JKQ19DTEFTUyBOU1ZpZXc7CiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKEVGTCkK KyNpbmNsdWRlICJXZWJFdmVudEZhY3RvcnkuaCIKICNpbmNsdWRlIDxFdmFzLmg+CiAjaW5jbHVk ZSA8V2ViQ29yZS9BZmZpbmVUcmFuc2Zvcm0uaD4KICNlbmRpZgpAQCAtNTMsOSArNTQsOCBAQCBw dWJsaWM6CiAgICAgTmF0aXZlV2ViTW91c2VFdmVudChjb25zdCBOYXRpdmVXZWJNb3VzZUV2ZW50 Jik7CiAgICAgTmF0aXZlV2ViTW91c2VFdmVudChHZGtFdmVudCosIGludCk7CiAjZWxpZiBQTEFU Rk9STShFRkwpCi0gICAgTmF0aXZlV2ViTW91c2VFdmVudChjb25zdCBFdmFzX0V2ZW50X01vdXNl X0Rvd24qLCBjb25zdCBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zvcm0mLCBjb25zdCBXZWJDb3JlOjpB ZmZpbmVUcmFuc2Zvcm0mKTsKLSAgICBOYXRpdmVXZWJNb3VzZUV2ZW50KGNvbnN0IEV2YXNfRXZl bnRfTW91c2VfVXAqLCBjb25zdCBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zvcm0mLCBjb25zdCBXZWJD b3JlOjpBZmZpbmVUcmFuc2Zvcm0mKTsKLSAgICBOYXRpdmVXZWJNb3VzZUV2ZW50KGNvbnN0IEV2 YXNfRXZlbnRfTW91c2VfTW92ZSosIGNvbnN0IFdlYkNvcmU6OkFmZmluZVRyYW5zZm9ybSYsIGNv bnN0IFdlYkNvcmU6OkFmZmluZVRyYW5zZm9ybSYpOworICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBF dmFzRXZlbnRNb3VzZT4KKyAgICBOYXRpdmVXZWJNb3VzZUV2ZW50KGNvbnN0IEV2YXNFdmVudE1v dXNlKiwgY29uc3QgV2ViQ29yZTo6QWZmaW5lVHJhbnNmb3JtJiwgY29uc3QgV2ViQ29yZTo6QWZm aW5lVHJhbnNmb3JtJik7CiAjZW5kaWYKIAogI2lmIFVTRShBUFBLSVQpCkBAIC03OCw2ICs3OCwx NSBAQCBwcml2YXRlOgogI2VuZGlmCiB9OwogCisjaWYgUExBVEZPUk0oRUZMKQordGVtcGxhdGUg PHR5cGVuYW1lIEV2YXNFdmVudE1vdXNlPgorTmF0aXZlV2ViTW91c2VFdmVudDo6TmF0aXZlV2Vi TW91c2VFdmVudChjb25zdCBFdmFzRXZlbnRNb3VzZSogZXZlbnQsIGNvbnN0IFdlYkNvcmU6OkFm ZmluZVRyYW5zZm9ybSYgdG9XZWJDb250ZW50LCBjb25zdCBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zv cm0mIHRvRGV2aWNlU2NyZWVuKQorICAgIDogV2ViTW91c2VFdmVudChXZWJFdmVudEZhY3Rvcnk6 OmNyZWF0ZVdlYk1vdXNlRXZlbnQoZXZlbnQsIHRvV2ViQ29udGVudCwgdG9EZXZpY2VTY3JlZW4p KQorICAgICwgbV9uYXRpdmVFdmVudChldmVudCkKK3sKK30KKyNlbmRpZgorCiB9IC8vIG5hbWVz cGFjZSBXZWJLaXQKIAogI2VuZGlmIC8vIE5hdGl2ZVdlYk1vdXNlRXZlbnRfaApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9OYXRpdmVXZWJNb3VzZUV2ZW50RWZsLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvTmF0aXZlV2ViTW91c2VFdmVudEVmbC5jcHAKZGVs ZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDBiYTQ0YmZhMDU2NDliZTBiN2YzZTk4MDU2NTkw NjE2ZjgyNWNmODIuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0t IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9OYXRpdmVXZWJNb3VzZUV2ZW50RWZsLmNwcAor KysgL2Rldi9udWxsCkBAIC0xLDUxICswLDAgQEAKLS8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTEg U2Ftc3VuZyBFbGVjdHJvbmljcwotICoKLSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBh cmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCi0gKiBh cmUgbWV0OgotICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWlu IHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KLSAqIDIuIFJlZGlzdHJpYnV0aW9ucyBp biBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIgaW4gdGhlCi0gKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJv dmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJP VklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycKLSAqIEFO RCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBM SU1JVEVEIFRPLAotICogVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkg QU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgotICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4g SU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTCi0gKiBCRSBM SUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVN UExBUlksIE9SCi0gKiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBM SU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRgotICogU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNF UzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTCi0gKiBJTlRFUlJV UFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hF VEhFUiBJTgotICogQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQgKElOQ0xVRElO RyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkKLSAqIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0Yg VEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YKLSAqIFRIRSBQT1NT SUJJTElUWSBPRiBTVUNIIERBTUFHRS4KLSAqLwotCi0jaW5jbHVkZSAiY29uZmlnLmgiCi0jaW5j bHVkZSAiTmF0aXZlV2ViTW91c2VFdmVudC5oIgotCi0jaW5jbHVkZSAiV2ViRXZlbnRGYWN0b3J5 LmgiCi0KLW5hbWVzcGFjZSBXZWJLaXQgewotCi1OYXRpdmVXZWJNb3VzZUV2ZW50OjpOYXRpdmVX ZWJNb3VzZUV2ZW50KGNvbnN0IEV2YXNfRXZlbnRfTW91c2VfRG93biogZXZlbnQsIGNvbnN0IFdl YkNvcmU6OkFmZmluZVRyYW5zZm9ybSYgdG9XZWJDb250ZW50LCBjb25zdCBXZWJDb3JlOjpBZmZp bmVUcmFuc2Zvcm0mIHRvRGV2aWNlU2NyZWVuKQotICAgIDogV2ViTW91c2VFdmVudChXZWJFdmVu dEZhY3Rvcnk6OmNyZWF0ZVdlYk1vdXNlRXZlbnQoZXZlbnQsIHRvV2ViQ29udGVudCwgdG9EZXZp Y2VTY3JlZW4pKQotICAgICwgbV9uYXRpdmVFdmVudChldmVudCkKLXsKLX0KLQotTmF0aXZlV2Vi TW91c2VFdmVudDo6TmF0aXZlV2ViTW91c2VFdmVudChjb25zdCBFdmFzX0V2ZW50X01vdXNlX1Vw KiBldmVudCwgY29uc3QgV2ViQ29yZTo6QWZmaW5lVHJhbnNmb3JtJiB0b1dlYkNvbnRlbnQsIGNv bnN0IFdlYkNvcmU6OkFmZmluZVRyYW5zZm9ybSYgdG9EZXZpY2VTY3JlZW4pCi0gICAgOiBXZWJN b3VzZUV2ZW50KFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViTW91c2VFdmVudChldmVudCwgdG9X ZWJDb250ZW50LCB0b0RldmljZVNjcmVlbikpCi0gICAgLCBtX25hdGl2ZUV2ZW50KGV2ZW50KQot ewotfQotCi1OYXRpdmVXZWJNb3VzZUV2ZW50OjpOYXRpdmVXZWJNb3VzZUV2ZW50KGNvbnN0IEV2 YXNfRXZlbnRfTW91c2VfTW92ZSogZXZlbnQsIGNvbnN0IFdlYkNvcmU6OkFmZmluZVRyYW5zZm9y bSYgdG9XZWJDb250ZW50LCBjb25zdCBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zvcm0mIHRvRGV2aWNl U2NyZWVuKQotICAgIDogV2ViTW91c2VFdmVudChXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYk1v dXNlRXZlbnQoZXZlbnQsIHRvV2ViQ29udGVudCwgdG9EZXZpY2VTY3JlZW4pKQotICAgICwgbV9u YXRpdmVFdmVudChldmVudCkKLXsKLX0KLQotfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==