131151 2014-04-02 22:29:25 -0700 [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type 2014-04-02 23:16:23 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi bunhere cdumez commit-queue enmi.lee gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 997000 0 ryuan.choi 2014-04-02 22:29:25 -0700 Instead of using webkit specific type, we'd better to use EFL type. 997001 1 228465 ryuan.choi 2014-04-02 22:35:09 -0700 Created attachment 228465 Patch 997008 2 228465 gyuyoung.kim 2014-04-02 22:58:30 -0700 Comment on attachment 228465 Patch LGTM 997017 3 228465 commit-queue 2014-04-02 23:16:17 -0700 Comment on attachment 228465 Patch Clearing flags on attachment: 228465 Committed r166698: <http://trac.webkit.org/changeset/166698> 997018 4 commit-queue 2014-04-02 23:16:23 -0700 All reviewed patches have been landed. Closing bug. 228465 2014-04-02 22:35:09 -0700 2014-04-02 23:16:17 -0700 Patch bug-131151-20140403143448.patch text/plain 7187 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggOTM4Y2ZiYTFk MGI2MDcxYzI4OGE1ZmUzN2RhMDUwZmJkNzU3NWM5NS4uOGMxYmVlMDkyMWNjMDNlYmUxNGRjYWE5 OTRmMDMzMGE3ODE5ZWYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0 LTA0LTAyICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXVtXSzFdIFVzZSBFdmFzX1RvdWNoX1BvaW50X1N0YXRlIGluc3RlYWQgb2YgRXdrX1RvdWNo X1BvaW50X1R5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzMTE1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIExpa2UgZXdlYmtpdDIsIHdlJ2QgYmV0ZXIgdG8gdXNlIEVGTCB0eXBlIGluc3RlYWQgb2Yg V2ViS2l0IHNwZWNpZmljIHR5cGUKKyAgICAgICAgSW4gYWRkaXRpb24sIGNoYW5nZWQgdHlwZSBv ZiBpZCBhcyBpbnQgdG8gbWF0Y2ggd2l0aCBld2Via2l0Mi4KKworICAgICAgICAqIGV3ay9ld2tf ZnJhbWUuaDogUmVwbGFjZSBFd2tfVG91Y2hfUG9pbnRfVHlwZSB0byBFdmFzX1RvdWNoX1BvaW50 X1N0YXRlLgorICAgICAgICAqIGV3ay9ld2tfdG91Y2hfZXZlbnQuY3BwOgorICAgICAgICAodG9Q bGF0Zm9ybVRvdWNoUG9pbnRTdGF0ZSk6CisKIDIwMTQtMDQtMDIgIE1hcnRpbiBIb2NrICA8bWhv Y2tAYXBwbGUuY29tPgogCiAgICAgICAgIFVuaWZ5IHByaXZhdGUgYnJvd3Npbmcgd2l0aCBzZXNz aW9ucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuaCBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuaAppbmRleCBmZDA2MWNkZmJlZjZiNTgwMmUy NjEwYmNiZGJmYmVjMDcyNjY1OWVhLi5lOTA3ODRkYTJiMDJiOTAxZDE1ODNhNzIwYjc4ZDU4Njc0 YmM2ZDBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmgKKysr IGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5oCkBAIC0yMzMsMjQgKzIzMywxNCBA QCB0eXBlZGVmIGVudW0gewogICAgIEVXS19UT1VDSF9DQU5DRUwKIH0gRXdrX1RvdWNoX0V2ZW50 X1R5cGU7CiAKLS8vLyBSZXByZXNlbnRzIHN0YXRlcyBvZiB0b3VjaCBldmVudHMuCi10eXBlZGVm IGVudW0gewotICAgIEVXS19UT1VDSF9QT0lOVF9SRUxFQVNFRCwKLSAgICBFV0tfVE9VQ0hfUE9J TlRfUFJFU1NFRCwKLSAgICBFV0tfVE9VQ0hfUE9JTlRfTU9WRUQsCi0gICAgRVdLX1RPVUNIX1BP SU5UX1NUQVRJT05BUlksCi0gICAgRVdLX1RPVUNIX1BPSU5UX0NBTkNFTExFRCwKLSAgICBFV0tf VE9VQ0hfUE9JTlRfRU5ECi19IEV3a19Ub3VjaF9Qb2ludF9UeXBlOwotCiAvLy8gQ3JlYXRlcyBh IHR5cGUgbmFtZSBmb3IgX0V3a19Ub3VjaF9Qb2ludC4KIHR5cGVkZWYgc3RydWN0IF9Fd2tfVG91 Y2hfUG9pbnQgRXdrX1RvdWNoX1BvaW50OwogLy8vIFJlcHJlc2VudHMgYSB0b3VjaCBwb2ludC4K IHN0cnVjdCBfRXdrX1RvdWNoX1BvaW50IHsKLSAgICB1bnNpZ25lZCBpbnQgaWQ7IC8qKjwgaWRl bnRpZmllciBvZiB0aGUgdG91Y2ggZXZlbnQgKi8KKyAgICBpbnQgaWQ7IC8qKjwgaWRlbnRpZmll ciBvZiB0aGUgdG91Y2ggZXZlbnQgKi8KICAgICBpbnQgeDsgLyoqPCB0aGUgaG9yaXpvbnRhbCBw b3NpdGlvbiBvZiB0aGUgdG91Y2ggZXZlbnQgKi8KICAgICBpbnQgeTsgLyoqPCB0aGUgaG9yaXpv bnRhbCBwb3NpdGlvbiBvZiB0aGUgdG91Y2ggZXZlbnQgKi8KLSAgICBFd2tfVG91Y2hfUG9pbnRf VHlwZSBzdGF0ZTsgLyoqPCBzdGF0ZSBvZiB0aGUgdG91Y2ggZXZlbnQgKi8KKyAgICBFdmFzX1Rv dWNoX1BvaW50X1N0YXRlIHN0YXRlOyAvKio8IHN0YXRlIG9mIHRoZSB0b3VjaCBldmVudCAqLwog fTsKIAogdHlwZWRlZiBlbnVtIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdG91Y2hfZXZlbnQuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190b3VjaF9ldmVu dC5jcHAKaW5kZXggMjY2ZDE3OTY5YTFkYzllOWY0ZWJlYTM0NzU4ZjZiODhiNGYzOTMxZS4uNWVi MWQzOWJhYWY4Y2JmMDNkYzAxODRjZWM3OTk5ZTUxOTI4ZTQyMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a190b3VjaF9ldmVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a190b3VjaF9ldmVudC5jcHAKQEAgLTQzLDIxICs0MywxOSBAQCBwdWJsaWM6CiAg ICAgfQogfTsKIAotaW5saW5lIHN0YXRpYyBXZWJDb3JlOjpQbGF0Zm9ybVRvdWNoUG9pbnQ6OlN0 YXRlIHRvUGxhdGZvcm1Ub3VjaFBvaW50U3RhdGUoRXdrX1RvdWNoX1BvaW50X1R5cGUgdHlwZSkK K2lubGluZSBzdGF0aWMgV2ViQ29yZTo6UGxhdGZvcm1Ub3VjaFBvaW50OjpTdGF0ZSB0b1BsYXRm b3JtVG91Y2hQb2ludFN0YXRlKEV2YXNfVG91Y2hfUG9pbnRfU3RhdGUgdHlwZSkKIHsKICAgICBz d2l0Y2ggKHR5cGUpIHsKLSAgICBjYXNlIEVXS19UT1VDSF9QT0lOVF9SRUxFQVNFRDoKKyAgICBj YXNlIEVWQVNfVE9VQ0hfUE9JTlRfVVA6CiAgICAgICAgIHJldHVybiBXZWJDb3JlOjpQbGF0Zm9y bVRvdWNoUG9pbnQ6OlRvdWNoUmVsZWFzZWQ7Ci0gICAgY2FzZSBFV0tfVE9VQ0hfUE9JTlRfUFJF U1NFRDoKKyAgICBjYXNlIEVWQVNfVE9VQ0hfUE9JTlRfRE9XTjoKICAgICAgICAgcmV0dXJuIFdl YkNvcmU6OlBsYXRmb3JtVG91Y2hQb2ludDo6VG91Y2hQcmVzc2VkOwotICAgIGNhc2UgRVdLX1RP VUNIX1BPSU5UX01PVkVEOgorICAgIGNhc2UgRVZBU19UT1VDSF9QT0lOVF9NT1ZFOgogICAgICAg ICByZXR1cm4gV2ViQ29yZTo6UGxhdGZvcm1Ub3VjaFBvaW50OjpUb3VjaE1vdmVkOwotICAgIGNh c2UgRVdLX1RPVUNIX1BPSU5UX1NUQVRJT05BUlk6CisgICAgY2FzZSBFVkFTX1RPVUNIX1BPSU5U X1NUSUxMOgogICAgICAgICByZXR1cm4gV2ViQ29yZTo6UGxhdGZvcm1Ub3VjaFBvaW50OjpUb3Vj aFN0YXRpb25hcnk7Ci0gICAgY2FzZSBFV0tfVE9VQ0hfUE9JTlRfQ0FOQ0VMTEVEOgorICAgIGNh c2UgRVZBU19UT1VDSF9QT0lOVF9DQU5DRUw6CiAgICAgICAgIHJldHVybiBXZWJDb3JlOjpQbGF0 Zm9ybVRvdWNoUG9pbnQ6OlRvdWNoQ2FuY2VsbGVkOwotICAgIGNhc2UgRVdLX1RPVUNIX1BPSU5U X0VORDoKLSAgICAgICAgcmV0dXJuIFdlYkNvcmU6OlBsYXRmb3JtVG91Y2hQb2ludDo6VG91Y2hT dGF0ZUVuZDsKICAgICB9CiAKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NWFjMmI3NDIzYjA3MTgz ODQwMzlmMzIyYzEyYmFiZDYwYmM1Y2FiLi4wYmRjODY3NmYxNjQxMmM2NjM1ODg4MzVlZTJjNGEy YmM2YWJhZDBlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDQtMDIgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9p QHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMV0gVXNlIEV2YXNfVG91Y2hfUG9pbnRf U3RhdGUgaW5zdGVhZCBvZiBFd2tfVG91Y2hfUG9pbnRfVHlwZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMTUxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRXZlbnRT ZW5kZXIuY3BwOiBSZXBsYWNlIEV3a19Ub3VjaF9Qb2ludF9UeXBlIHRvIEV2YXNfVG91Y2hfUG9p bnRfU3RhdGUuCisgICAgICAgIChUb3VjaEV2ZW50SW5mbzo6VG91Y2hFdmVudEluZm8pOgorICAg ICAgICAoc2VuZFRvdWNoRXZlbnQpOgorICAgICAgICAoYWRkVG91Y2hQb2ludENhbGxiYWNrKToK KyAgICAgICAgKHVwZGF0ZVRvdWNoUG9pbnRDYWxsYmFjayk6CisgICAgICAgIChjYW5jZWxUb3Vj aFBvaW50Q2FsbGJhY2spOgorICAgICAgICAocmVsZWFzZVRvdWNoUG9pbnRDYWxsYmFjayk6CisK IDIwMTQtMDQtMDIgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBmaWx0ZXItYnVpbGQtd2Via2l0OiBJZ25vcmUgeGNvZGVidWlsZCB3YXJuaW5ncyB3aGVuIGNv bXBpbGluZyB3aXRoIG5ld2VyIGJ1aWxkcyBvZiBjbGFuZwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvZWZsL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Vm bC9FdmVudFNlbmRlci5jcHAKaW5kZXggOTYyODhhNTUwZTQwOWJhZDczNGU4ZDU1ZDJkMWNjM2M2 NGFkZDNjMC4uNTkzNzNlZDJjYmFhMjBlZGRjM2RjZGI5MjcyY2IyNGZkOGY2ZDQ0NCAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0V2ZW50U2VuZGVyLmNwcAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9lZmwvRXZlbnRTZW5kZXIuY3BwCkBAIC0xNTMsMTUgKzE1MywxNSBA QCBzdHJ1Y3QgRGVsYXllZEV2ZW50IHsKIH07CiAKIHN0cnVjdCBUb3VjaEV2ZW50SW5mbyB7Ci0g ICAgVG91Y2hFdmVudEluZm8odW5zaWduZWQgaWQsIEV3a19Ub3VjaF9Qb2ludF9UeXBlIHN0YXRl LCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgcG9pbnQpCisgICAgVG91Y2hFdmVudEluZm8oaW50 IGlkLCBFdmFzX1RvdWNoX1BvaW50X1N0YXRlIHN0YXRlLCBjb25zdCBXZWJDb3JlOjpJbnRQb2lu dCYgcG9pbnQpCiAgICAgICAgIDogc3RhdGUoc3RhdGUpCiAgICAgICAgICwgcG9pbnQocG9pbnQp CiAgICAgICAgICwgaWQoaWQpCiAgICAgewogICAgIH0KIAotICAgIHVuc2lnbmVkIGlkOwotICAg IEV3a19Ub3VjaF9Qb2ludF9UeXBlIHN0YXRlOworICAgIGludCBpZDsKKyAgICBFdmFzX1RvdWNo X1BvaW50X1N0YXRlIHN0YXRlOwogICAgIFdlYkNvcmU6OkludFBvaW50IHBvaW50OwogfTsKIApA QCAtNzY0LDEwICs3NjQsMTAgQEAgc3RhdGljIHZvaWQgc2VuZFRvdWNoRXZlbnQoRXdrX1RvdWNo X0V2ZW50X1R5cGUgdHlwZSkKICAgICB9CiAKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwg dG91Y2hQb2ludExpc3QoKS5zaXplKCk7ICkgewotICAgICAgICBpZiAodG91Y2hQb2ludExpc3Qo KS5hdChpKS5zdGF0ZSA9PSBFV0tfVE9VQ0hfUE9JTlRfUkVMRUFTRUQpCisgICAgICAgIGlmICh0 b3VjaFBvaW50TGlzdCgpLmF0KGkpLnN0YXRlID09IEVWQVNfVE9VQ0hfUE9JTlRfVVApCiAgICAg ICAgICAgICB0b3VjaFBvaW50TGlzdCgpLnJlbW92ZShpKTsKICAgICAgICAgZWxzZSB7Ci0gICAg ICAgICAgICB0b3VjaFBvaW50TGlzdCgpLmF0KGkpLnN0YXRlID0gRVdLX1RPVUNIX1BPSU5UX1NU QVRJT05BUlk7CisgICAgICAgICAgICB0b3VjaFBvaW50TGlzdCgpLmF0KGkpLnN0YXRlID0gRVZB U19UT1VDSF9QT0lOVF9TVElMTDsKICAgICAgICAgICAgICsraTsKICAgICAgICAgfQogICAgIH0K QEAgLTc4NSw3ICs3ODUsNyBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBhZGRUb3VjaFBvaW50Q2FsbGJh Y2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aQogCiAgICAgY29uc3Qg V2ViQ29yZTo6SW50UG9pbnQgcG9pbnQoeCwgeSk7CiAgICAgY29uc3QgdW5zaWduZWQgaWQgPSB0 b3VjaFBvaW50TGlzdCgpLmlzRW1wdHkoKSA/IDAgOiB0b3VjaFBvaW50TGlzdCgpLmxhc3QoKS5p ZCArIDE7Ci0gICAgVG91Y2hFdmVudEluZm8gZXZlbnRJbmZvKGlkLCBFV0tfVE9VQ0hfUE9JTlRf UFJFU1NFRCwgcG9pbnQpOworICAgIFRvdWNoRXZlbnRJbmZvIGV2ZW50SW5mbyhpZCwgRVZBU19U T1VDSF9QT0lOVF9ET1dOLCBwb2ludCk7CiAgICAgdG91Y2hQb2ludExpc3QoKS5hcHBlbmQoZXZl bnRJbmZvKTsKIAogICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKQEAg LTgxNSw3ICs4MTUsNyBAQCBzdGF0aWMgSlNWYWx1ZVJlZiB1cGRhdGVUb3VjaFBvaW50Q2FsbGJh Y2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bgogICAgIFdlYkNvcmU6Oklu dFBvaW50JiBwb2ludCA9IHRvdWNoUG9pbnRMaXN0KCkuYXQoaW5kZXgpLnBvaW50OwogICAgIHBv aW50LnNldFgoeCk7CiAgICAgcG9pbnQuc2V0WSh5KTsKLSAgICB0b3VjaFBvaW50TGlzdCgpLmF0 KGluZGV4KS5zdGF0ZSA9IEVXS19UT1VDSF9QT0lOVF9NT1ZFRDsKKyAgICB0b3VjaFBvaW50TGlz dCgpLmF0KGluZGV4KS5zdGF0ZSA9IEVWQVNfVE9VQ0hfUE9JTlRfTU9WRTsKIAogICAgIHJldHVy biBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsKIH0KQEAgLTgzNiw3ICs4MzYsNyBAQCBz dGF0aWMgSlNWYWx1ZVJlZiBjYW5jZWxUb3VjaFBvaW50Q2FsbGJhY2soSlNDb250ZXh0UmVmIGNv bnRleHQsIEpTT2JqZWN0UmVmIGZ1bgogICAgIGlmIChpbmRleCA8IDAgfHwgaW5kZXggPj0gdG91 Y2hQb2ludExpc3QoKS5zaXplKCkpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5l ZChjb250ZXh0KTsKIAotICAgIHRvdWNoUG9pbnRMaXN0KCkuYXQoaW5kZXgpLnN0YXRlID0gRVdL X1RPVUNIX1BPSU5UX0NBTkNFTExFRDsKKyAgICB0b3VjaFBvaW50TGlzdCgpLmF0KGluZGV4KS5z dGF0ZSA9IEVWQVNfVE9VQ0hfUE9JTlRfQ0FOQ0VMOwogICAgIHJldHVybiBKU1ZhbHVlTWFrZVVu ZGVmaW5lZChjb250ZXh0KTsKIH0KIApAQCAtODU2LDcgKzg1Niw3IEBAIHN0YXRpYyBKU1ZhbHVl UmVmIHJlbGVhc2VUb3VjaFBvaW50Q2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2Jq ZWN0UmVmIGZ1CiAgICAgaWYgKGluZGV4IDwgMCB8fCBpbmRleCA+PSB0b3VjaFBvaW50TGlzdCgp LnNpemUoKSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOwog Ci0gICAgdG91Y2hQb2ludExpc3QoKS5hdChpbmRleCkuc3RhdGUgPSBFV0tfVE9VQ0hfUE9JTlRf UkVMRUFTRUQ7CisgICAgdG91Y2hQb2ludExpc3QoKS5hdChpbmRleCkuc3RhdGUgPSBFVkFTX1RP VUNIX1BPSU5UX1VQOwogICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KTsK IH0KIAo=