131147 2014-04-02 21:01:32 -0700 [Win] Turn on ENABLE_CSS_GRID_LAYOUT 2014-04-03 15:50:35 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 996975 0 bfulgham 2014-04-02 21:01:32 -0700 A few tests are failing on Windows because they expect ENABLE_CSS_GRID_LAYOUT to be activated. It seems to be activated for everyone else, let's turn it on! 996976 1 228458 bfulgham 2014-04-02 21:03:08 -0700 Created attachment 228458 Patch 997044 2 bfulgham 2014-04-03 00:09:42 -0700 Looks like a missing implementation file! Fixing... 997331 3 bfulgham 2014-04-03 15:31:21 -0700 This change allows Windows to pass the following tests: fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style.html 997339 4 228551 bfulgham 2014-04-03 15:37:51 -0700 Created attachment 228551 Patch 997345 5 bfulgham 2014-04-03 15:50:35 -0700 Committed r166749: <http://trac.webkit.org/changeset/166749> 228458 2014-04-02 21:03:08 -0700 2014-04-03 15:37:49 -0700 Patch bug-131147-20140402210246.patch text/plain 2113 bfulgham SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2NjkxKQorKysgV2ViS2l0TGlicmFyaWVzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA0LTAyICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIEVuYWJsZSB0 aGUgQ1NTX0dSSURfTEFZT1VUIGZlYXR1cmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzExNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBKdXN0IGxpa2UgdGhlIENBTlZBU19QQVRIIGZlYXR1cmUsIHRo aXMgc2VlbXMgdG8gaGF2ZSBiZWVuCisgICAgICAgIG92ZXJsb29rZWQgd2hlbiBpdCB3YXMgdHVy bmVkIG9uIGZvciBvdGhlciBwb3J0cy4KKworICAgICAgICAqIHdpbi90b29scy92c3Byb3BzL0Zl YXR1cmVEZWZpbmVzLnByb3BzOgorICAgICAgICAqIHdpbi90b29scy92c3Byb3BzL0ZlYXR1cmVE ZWZpbmVzQ2Fpcm8ucHJvcHM6CisKIDIwMTQtMDQtMDIgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBw bGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBXS1NJLgpJbmRleDogV2ViS2l0TGlicmFyaWVzL3dp bi90b29scy92c3Byb3BzL0ZlYXR1cmVEZWZpbmVzLnByb3BzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lcy5wcm9wcwkocmV2aXNp b24gMTY2NjkxKQorKysgV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL0ZlYXR1cmVE ZWZpbmVzLnByb3BzCSh3b3JraW5nIGNvcHkpCkBAIC0xNSw3ICsxNSw3IEBACiAgICAgPEVOQUJM RV9DU1NfQ09NUE9TSVRJTkcgLz4KICAgICA8RU5BQkxFX0NTU19FWENMVVNJT05TIC8+CiAgICAg PEVOQUJMRV9DU1NfRklMVEVSUz5FTkFCTEVfQ1NTX0ZJTFRFUlM8L0VOQUJMRV9DU1NfRklMVEVS Uz4KLSAgICA8RU5BQkxFX0NTU19HUklEX0xBWU9VVCAvPgorICAgIDxFTkFCTEVfQ1NTX0dSSURf TEFZT1VUPkVOQUJMRV9DU1NfR1JJRF9MQVlPVVQ8L0VOQUJMRV9DU1NfR1JJRF9MQVlPVVQ+CiAg ICAgPEVOQUJMRV9DU1NfSU1BR0VfU0VUPkVOQUJMRV9DU1NfSU1BR0VfU0VUPC9FTkFCTEVfQ1NT X0lNQUdFX1NFVD4KICAgICA8RU5BQkxFX0NTU19SRUdJT05TPkVOQUJMRV9DU1NfUkVHSU9OUzwv RU5BQkxFX0NTU19SRUdJT05TPgogICAgIDxFTkFCTEVfQ1NTX1NIQURFUlMgLz4KSW5kZXg6IFdl YktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lc0NhaXJvLnByb3Bz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJl RGVmaW5lc0NhaXJvLnByb3BzCShyZXZpc2lvbiAxNjY2OTEpCisrKyBXZWJLaXRMaWJyYXJpZXMv d2luL3Rvb2xzL3ZzcHJvcHMvRmVhdHVyZURlZmluZXNDYWlyby5wcm9wcwkod29ya2luZyBjb3B5 KQpAQCAtMTUsNyArMTUsNyBAQAogICAgIDxFTkFCTEVfQ1NTX0NPTVBPU0lUSU5HIC8+CiAgICAg PEVOQUJMRV9DU1NfRVhDTFVTSU9OUyAvPgogICAgIDxFTkFCTEVfQ1NTX0ZJTFRFUlM+PC9FTkFC TEVfQ1NTX0ZJTFRFUlM+Ci0gICAgPEVOQUJMRV9DU1NfR1JJRF9MQVlPVVQgLz4KKyAgICA8RU5B QkxFX0NTU19HUklEX0xBWU9VVD5FTkFCTEVfQ1NTX0dSSURfTEFZT1VUPC9FTkFCTEVfQ1NTX0dS SURfTEFZT1VUPgogICAgIDxFTkFCTEVfQ1NTX0lNQUdFX1NFVD5FTkFCTEVfQ1NTX0lNQUdFX1NF VDwvRU5BQkxFX0NTU19JTUFHRV9TRVQ+CiAgICAgPEVOQUJMRV9DU1NfUkVHSU9OUz5FTkFCTEVf Q1NTX1JFR0lPTlM8L0VOQUJMRV9DU1NfUkVHSU9OUz4KICAgICA8RU5BQkxFX0NTU19TSEFERVJT IC8+Cg== 228551 2014-04-03 15:37:51 -0700 2014-04-03 15:39:59 -0700 Patch bug-131147-20140403153731.patch text/plain 3337 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Njc0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA0LTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFR1cm4gb24gRU5B QkxFX0NTU19HUklEX0xBWU9VVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTMxMTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyBmYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxl IHRlc3RzLgorCisgICAgICAgICogY3NzL0NTU0FsbEluT25lLmNwcDogQWRkIENTU0dyaWRMaW5l TmFtZXNWYWx1ZS5jcHAgd2hlbiBidWlsZGluZworICAgICAgICB3aXRoIEVOQUJMRShDU1NfR1JJ RF9MQVlPVVQpCisKIDIwMTQtMDQtMDMgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4K IAogICAgICAgICBbQ0ddIENhbnZhcyBsaW5lRGFzaE9mZnNldCBkb2VzIG5vdCBoYW5kbGUgbmVn YXRpdmUgbnVtYmVycyBjb3JyZWN0bHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NBbGxJ bk9uZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU0FsbEluT25lLmNw cAkocmV2aXNpb24gMTY2NzM4KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU0FsbEluT25lLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDMsNiArNDMsOSBAQAogI2luY2x1ZGUgIkNTU0ZvbnRTZWxl Y3Rvci5jcHAiCiAjaW5jbHVkZSAiQ1NTRnVuY3Rpb25WYWx1ZS5jcHAiCiAjaW5jbHVkZSAiQ1NT R3JhZGllbnRWYWx1ZS5jcHAiCisjaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKKyNpbmNsdWRl ICJDU1NHcmlkTGluZU5hbWVzVmFsdWUuY3BwIgorI2VuZGlmCiAjaW5jbHVkZSAiQ1NTR3JvdXBp bmdSdWxlLmNwcCIKICNpbmNsdWRlICJDU1NJbWFnZUdlbmVyYXRvclZhbHVlLmNwcCIKICNpbmNs dWRlICJDU1NJbWFnZVNldFZhbHVlLmNwcCIKSW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTY2 NzM4KQorKysgV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE0LTA0LTAzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIEVuYWJsZSB0aGUgQ1NTX0dSSURfTEFZT1VUIGZlYXR1cmUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzExNDcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKdXN0IGxpa2Ug dGhlIENBTlZBU19QQVRIIGZlYXR1cmUsIHRoaXMgc2VlbXMgdG8gaGF2ZSBiZWVuCisgICAgICAg IG92ZXJsb29rZWQgd2hlbiBpdCB3YXMgdHVybmVkIG9uIGZvciBvdGhlciBwb3J0cy4KKworICAg ICAgICAqIHdpbi90b29scy92c3Byb3BzL0ZlYXR1cmVEZWZpbmVzLnByb3BzOgorICAgICAgICAq IHdpbi90b29scy92c3Byb3BzL0ZlYXR1cmVEZWZpbmVzQ2Fpcm8ucHJvcHM6CisKIDIwMTQtMDQt MDIgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBXS1NJ LgpJbmRleDogV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL0ZlYXR1cmVEZWZpbmVz LnByb3BzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9G ZWF0dXJlRGVmaW5lcy5wcm9wcwkocmV2aXNpb24gMTY2NzM4KQorKysgV2ViS2l0TGlicmFyaWVz L3dpbi90b29scy92c3Byb3BzL0ZlYXR1cmVEZWZpbmVzLnByb3BzCSh3b3JraW5nIGNvcHkpCkBA IC0xNSw3ICsxNSw3IEBACiAgICAgPEVOQUJMRV9DU1NfQ09NUE9TSVRJTkcgLz4KICAgICA8RU5B QkxFX0NTU19FWENMVVNJT05TIC8+CiAgICAgPEVOQUJMRV9DU1NfRklMVEVSUz5FTkFCTEVfQ1NT X0ZJTFRFUlM8L0VOQUJMRV9DU1NfRklMVEVSUz4KLSAgICA8RU5BQkxFX0NTU19HUklEX0xBWU9V VCAvPgorICAgIDxFTkFCTEVfQ1NTX0dSSURfTEFZT1VUPkVOQUJMRV9DU1NfR1JJRF9MQVlPVVQ8 L0VOQUJMRV9DU1NfR1JJRF9MQVlPVVQ+CiAgICAgPEVOQUJMRV9DU1NfSU1BR0VfU0VUPkVOQUJM RV9DU1NfSU1BR0VfU0VUPC9FTkFCTEVfQ1NTX0lNQUdFX1NFVD4KICAgICA8RU5BQkxFX0NTU19S RUdJT05TPkVOQUJMRV9DU1NfUkVHSU9OUzwvRU5BQkxFX0NTU19SRUdJT05TPgogICAgIDxFTkFC TEVfQ1NTX1NIQURFUlMgLz4KSW5kZXg6IFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9w cy9GZWF0dXJlRGVmaW5lc0NhaXJvLnByb3BzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdExpYnJhcmll cy93aW4vdG9vbHMvdnNwcm9wcy9GZWF0dXJlRGVmaW5lc0NhaXJvLnByb3BzCShyZXZpc2lvbiAx NjY3MzgpCisrKyBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvRmVhdHVyZURlZmlu ZXNDYWlyby5wcm9wcwkod29ya2luZyBjb3B5KQpAQCAtMTUsNyArMTUsNyBAQAogICAgIDxFTkFC TEVfQ1NTX0NPTVBPU0lUSU5HIC8+CiAgICAgPEVOQUJMRV9DU1NfRVhDTFVTSU9OUyAvPgogICAg IDxFTkFCTEVfQ1NTX0ZJTFRFUlM+PC9FTkFCTEVfQ1NTX0ZJTFRFUlM+Ci0gICAgPEVOQUJMRV9D U1NfR1JJRF9MQVlPVVQgLz4KKyAgICA8RU5BQkxFX0NTU19HUklEX0xBWU9VVD5FTkFCTEVfQ1NT X0dSSURfTEFZT1VUPC9FTkFCTEVfQ1NTX0dSSURfTEFZT1VUPgogICAgIDxFTkFCTEVfQ1NTX0lN QUdFX1NFVD5FTkFCTEVfQ1NTX0lNQUdFX1NFVDwvRU5BQkxFX0NTU19JTUFHRV9TRVQ+CiAgICAg PEVOQUJMRV9DU1NfUkVHSU9OUz5FTkFCTEVfQ1NTX1JFR0lPTlM8L0VOQUJMRV9DU1NfUkVHSU9O Uz4KICAgICA8RU5BQkxFX0NTU19TSEFERVJTIC8+Cg==