131139 2014-04-02 16:46:03 -0700 Fix over-retain in SharedBufferCF's createCFData(). 2014-04-03 15:57:15 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling kling oldest_to_newest 996911 0 kling 2014-04-02 16:46:03 -0700 Fix over-retain in SharedBufferCF's createCFData(). 996912 1 228445 kling 2014-04-02 16:46:27 -0700 Created attachment 228445 Patch 996913 2 228445 andersca 2014-04-02 16:47:53 -0700 Comment on attachment 228445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228445&action=review > Source/WebCore/platform/cf/SharedBufferCF.cpp:58 > return m_cfData.get(); Can you just return m_cfData here? 997348 3 kling 2014-04-03 15:57:15 -0700 Committed r166751: <http://trac.webkit.org/changeset/166751> 228445 2014-04-02 16:46:27 -0700 2014-04-02 16:47:53 -0700 Patch bug-131139.diff text/plain 1327 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMzNkZmJlLi41MDk2ZGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDQtMDIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEZpeCBvdmVyLXJldGFpbiBpbiBTaGFyZWRCdWZmZXJDRidzIGNyZWF0ZUNGRGF0YSgpLgor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTMxMTM5PgorCisgICAgICAgIENvbnN0cnVj dGluZyB0aGUgcmV0dXJuIHR5cGUgKFJldGFpblB0cjxDRkRhdGFSZWY+KSB3aWxsIGFsc28gcmV0 YWluCisgICAgICAgIHRoZSBwb2ludGVlLCBzbyB0aGlzIHdvdWxkIGVuZCB1cCBsZWFraW5nLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vY2YvU2hhcmVkQnVmZmVyQ0YuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkQnVmZmVy OjpjcmVhdGVDRkRhdGEpOgorCiAyMDE0LTA0LTAyICBNYXJ0aW4gSG9jayAgPG1ob2NrQGFwcGxl LmNvbT4KIAogICAgICAgICBVbmlmeSBwcml2YXRlIGJyb3dzaW5nIHdpdGggc2Vzc2lvbnMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9TaGFyZWRCdWZmZXJDRi5jcHAKaW5kZXggZDI1 OGNhOC4uMmFiOWU1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvU2hh cmVkQnVmZmVyQ0YuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NmL1NoYXJlZEJ1 ZmZlckNGLmNwcApAQCAtNTQsMTAgKzU0LDggQEAgU2hhcmVkQnVmZmVyOjpTaGFyZWRCdWZmZXIo Q0ZEYXRhUmVmIGNmRGF0YSkKICNpZiAhVVNFKEZPVU5EQVRJT04pCiBSZXRhaW5QdHI8Q0ZEYXRh UmVmPiBTaGFyZWRCdWZmZXI6OmNyZWF0ZUNGRGF0YSgpCiB7Ci0gICAgaWYgKG1fY2ZEYXRhKSB7 Ci0gICAgICAgIENGUmV0YWluKG1fY2ZEYXRhLmdldCgpKTsKKyAgICBpZiAobV9jZkRhdGEpCiAg ICAgICAgIHJldHVybiBtX2NmRGF0YS5nZXQoKTsKLSAgICB9CiAKICAgICAvLyBJbnRlcm5hbCBk YXRhIGluIFNoYXJlZEJ1ZmZlciBjYW4gYmUgc2VnbWVudGVkLiBXZSBuZWVkIHRvIGdldCB0aGUg Y29udGlndW91cyBidWZmZXIuCiAgICAgY29uc3QgVmVjdG9yPGNoYXI+JiBjb250aWd1b3VzQnVm ZmVyID0gYnVmZmVyKCk7Cg==