<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>131138</bug_id>
          
          <creation_ts>2014-04-02 16:18:36 -0700</creation_ts>
          <short_desc>Document WKNavigationAction and WKNavigationResponse</short_desc>
          <delta_ts>2014-04-03 11:07:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Anders Carlsson">andersca</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>996899</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-04-02 16:18:36 -0700</bug_when>
    <thetext>Document WKNavigationAction and WKNavigationResponse</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>996900</commentid>
    <comment_count>1</comment_count>
      <attachid>228441</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-04-02 16:18:46 -0700</bug_when>
    <thetext>Created attachment 228441
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>997233</commentid>
    <comment_count>2</comment_count>
      <attachid>228441</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2014-04-03 10:58:43 -0700</bug_when>
    <thetext>Comment on attachment 228441
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228441&amp;action=review

&gt; Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.h:38
&gt; +/*! @abstractÂ Whether the frame is the main frame or a subframe

Needs a period.

&gt; Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.h:40
&gt; + @constant WebNavigationTypeOther           Navigation is taking place for some other reason.

WebNavigationTypeOther -&gt; WKNavigationTypeOther</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>997237</commentid>
    <comment_count>3</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-04-03 11:07:17 -0700</bug_when>
    <thetext>Committed r166731: &lt;http://trac.webkit.org/changeset/166731&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>228441</attachid>
            <date>2014-04-02 16:18:46 -0700</date>
            <delta_ts>2014-04-03 10:58:42 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-131138-20140402161826.patch</filename>
            <type>text/plain</type>
            <size>4672</size>
            <attacher name="Anders Carlsson">andersca</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2ZkZjMwZWVlYjg5ZTA2
M2Y3MTFlZWQ0YTk4MzFhOGU3YzUxYWQxYS4uZDMyNzU0YmFjMmQ2ZTc1YTkxNTcwYzUwZTYzODIz
OTQzOGQ1M2YxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE0LTA0LTAyICBBbmRl
cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgRG9jdW1lbnQgV0tO
YXZpZ2F0aW9uQWN0aW9uIGFuZCBXS05hdmlnYXRpb25SZXNwb25zZQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMxMTM4CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dL
RnJhbWVJbmZvLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRpb25B
Y3Rpb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLTmF2aWdhdGlvblJlc3Bv
bnNlLmg6CisKKzIwMTQtMDQtMDIgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv
bT4KKwogICAgICAgICBEb2N1bWVudCBXS0JhY2tGb3J3YXJkTGlzdCwgV0tCYWNrRm9yd2FyZExp
c3RJdGVtIGFuZCBXS1dlYlZpZXdDb25maWd1cmF0aW9uCiAgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzExMzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0ZyYW1lSW5mby5oIGIvU291cmNlL1dlYktpdDIv
VUlQcm9jZXNzL0FQSS9Db2NvYS9XS0ZyYW1lSW5mby5oCmluZGV4IDcwYTM5MGRhMGFkZjM4MzE0
ZDEyNGUzOTQ4ZGRkZDVjNjJhNzg3MzEuLjU1NTQ0NzA5M2VkMzEyNzJmMDMzNmQyZDdmYjlmNGJi
NGUwNWFmZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev
V0tGcmFtZUluZm8uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL
RnJhbWVJbmZvLmgKQEAgLTI4LDEwICsyOCwxOSBAQAogCiAjaWYgV0tfQVBJX0VOQUJMRUQKIAor
LyohIEEgQGxpbmsgV0tGcmFtZUluZm8gQC9saW5rIG9iamVjdCBjb250YWlucyBpbmZvcm1hdGlv
biBhYm91dCBhIGZyYW1lIG9uIGEgd2ViIHBhZ2UuCisgQGRpc2N1c3Npb24gV0tGcmFtZUluZm8g
b2JqZWN0cyBhcmUgdHJhbnNpZW50IGRhdGEgb25seSBvYmplY3RzLCB0aGV5IGNhbiBub3QgYmUg
dXNlZCB0byB1bmlxdWVseSAKKyBpZGVudGlmeSBhIGZyYW1lIGFjcm9zcyBtdWx0aXBsZSBkZWxl
Z2F0ZSBtZXRob2QgY2FsbHMuCisgKi8KIFdLX0FQSV9DTEFTUwogQGludGVyZmFjZSBXS0ZyYW1l
SW5mbyA6IE5TT2JqZWN0CiAKKy8qISBAYWJzdHJhY3TCoFdoZXRoZXIgdGhlIGZyYW1lIGlzIHRo
ZSBtYWluIGZyYW1lIG9yIGEgc3ViZnJhbWUKKyAqLwogQHByb3BlcnR5IChub25hdG9taWMsIHJl
YWRvbmx5LCBnZXR0ZXI9aXNNYWluRnJhbWUpIEJPT0wgbWFpbkZyYW1lOworCisvKiEgQGFic3Ry
YWN0IFRoZSBjdXJyZW50IE5TVVJMUmVxdWVzdCBvZiB0aGlzIGZyYW1lLgorICovCiBAcHJvcGVy
dHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIE5TVVJMUmVxdWVzdCAqcmVxdWVzdDsKIAogQGVuZApk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRp
b25BY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tOYXZpZ2F0
aW9uQWN0aW9uLmgKaW5kZXggZTZlZmVjNDA4Nzk5MDRjMTc2ZjNkZmQ2NmIyNTIyZWJkMWFiMDYx
NS4uYTRhZmViNDk5ZjNlNzgxYjdiZjJiMTliZjI3ZWQ0Y2IxZWFiZjRjNyAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRpb25BY3Rpb24uaAor
KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLTmF2aWdhdGlvbkFjdGlv
bi5oCkBAIC0zMCw2ICszMCwxNSBAQAogCiBAY2xhc3MgV0tGcmFtZUluZm87CiAKKy8qISBAZW51
bSBXS05hdmlnYXRpb25UeXBlCisgQGFic3RyYWN0IHRoZSB0eXBlIG9mIGFjdGlvbiB0aGF0IHRy
aWdnZXJlZCBhIHBvc3NpYmxlIG5hdmlnYXRpb24uCisgQGNvbnN0YW50IFdLTmF2aWdhdGlvblR5
cGVMaW5rQWN0aXZhdGVkICAgIEEgbGluayB3aXRoIGFuIGhyZWYgYWN0aXZhdGVkIGJ5IHRoZSB1
c2VyLgorIEBjb25zdGFudCBXS05hdmlnYXRpb25UeXBlRm9ybVN1Ym1pdHRlZCAgICBBIGZvcm0g
d2FzIHN1Ym1pdHRlZC4KKyBAY29uc3RhbnQgV0tOYXZpZ2F0aW9uVHlwZUJhY2tGb3J3YXJkICAg
ICAgVGhlIHVzZXIgcmVxdWVzdGVkIGFuIGl0ZW0gZnJvbSB0aGUgYmFjayBmb3J3YXJkIGxpc3Qu
CisgQGNvbnN0YW50IFdLTmF2aWdhdGlvblR5cGVSZWxvYWQgICAgICAgICAgIFRoZSB1c2VyIHJl
bG9hZGVkIGEgcGFnZS4KKyBAY29uc3RhbnQgV0tOYXZpZ2F0aW9uVHlwZUZvcm1SZXN1Ym1pdHRl
ZCAgQSBmb3JtIGFzIHJlc3VibWl0dGVkIChmb3IgZXhhbXBsZSBieSBnb2luZyBiYWNrLCBmb3J3
YXJkIG9yIHJlbG9hZGluZykuCisgQGNvbnN0YW50IFdlYk5hdmlnYXRpb25UeXBlT3RoZXIgICAg
ICAgICAgIE5hdmlnYXRpb24gaXMgdGFraW5nIHBsYWNlIGZvciBzb21lIG90aGVyIHJlYXNvbi4K
KyAqLwogdHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwgV0tOYXZpZ2F0aW9uVHlwZSkgewogICAg
IFdLTmF2aWdhdGlvblR5cGVMaW5rQWN0aXZhdGVkLAogICAgIFdLTmF2aWdhdGlvblR5cGVGb3Jt
U3VibWl0dGVkLApAQCAtMzksMTMgKzQ4LDI2IEBAIHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIs
IFdLTmF2aWdhdGlvblR5cGUpIHsKICAgICBXS05hdmlnYXRpb25UeXBlT3RoZXIgPSAtMSwKIH07
CiAKKworLyohIENvbnRhaW5zIGluZm9ybWF0aW9uIGFib3V0IGFuIGFjdGlvbiB0aGF0IGNhbiBj
YXVzZSBhIHBvc3NpYmxlIG5hdmlnYXRpb24sIHVzZWQgZm9yIG1ha2luZyBwb2xpY3kgZGVjaXNp
b25zLgorICovCiBXS19BUElfQ0xBU1MKIEBpbnRlcmZhY2UgV0tOYXZpZ2F0aW9uQWN0aW9uIDog
TlNPYmplY3QKIAorLyohIEBhYnN0cmFjdCBSZXByZXNlbnRzIHRoZSBmcmFtZSB0aGF0IGlzIHJl
cXVlc3RpbmcgdGhlIG5hdmlnYXRpb24uCisgKi8KIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFk
b25seSkgV0tGcmFtZUluZm8gKnNvdXJjZUZyYW1lOworCisvKiEgQGFic3RyYWN0IFJlcHJlc2Vu
dHMgdGhlIHRhcmdldCBmcmFtZS4gSWYgdGhpcyBpcyBhIG5ldyB3aW5kb3cgbmF2aWdhdGlvbiwg
dGFyZ2V0RnJhbWUgd2lsbCBiZSBuaWwuCisgKi8KIEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFk
b25seSkgV0tGcmFtZUluZm8gKnRhcmdldEZyYW1lOwogCisvKiEgQGFic3RyYWN0IFRoZSB0eXBl
IG9mIHRoZSBuYXZpZ2F0aW9uLgorICovCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkp
IFdLTmF2aWdhdGlvblR5cGUgbmF2aWdhdGlvblR5cGU7CisKKy8qISBAYWJzdHJhY3QgVGhlIE5T
VVJMUmVxdWVzdCBvZiB0aGUgbmF2aWdhdGlvbi4KKyAqLwogQHByb3BlcnR5IChub25hdG9taWMs
IHJlYWRvbmx5KSBOU1VSTFJlcXVlc3QgKnJlcXVlc3Q7CiAKIEBlbmQKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tOYXZpZ2F0aW9uUmVzcG9uc2UuaCBi
L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tOYXZpZ2F0aW9uUmVzcG9uc2Uu
aAppbmRleCA3ZGZjNzU1ZTQ3OWI2Njk1ZDFkM2M1ODZjY2Y0MDZiMzZlZmM5OTQ4Li5lODdkYjEz
ZTMyZDZjZGRlMDc0YjY4NmNkNjhlYTkxYTlhNDliN2UwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLTmF2aWdhdGlvblJlc3BvbnNlLmgKKysrIGIvU291
cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRpb25SZXNwb25zZS5oCkBA
IC0zMCwxMSArMzAsMjEgQEAKIAogQGNsYXNzIFdLRnJhbWVJbmZvOwogCisvKiEgQ29udGFpbnMg
aW5mb3JtYXRpb24gYWJvdXQgYSBuYXZpZ2F0aW9uIHJlc3BvbnNlLCB1c2VkIGZvciBtYWtpbmcg
cG9saWN5IGRlY2lzaW9ucy4KKyAqLwogV0tfQVBJX0NMQVNTCiBAaW50ZXJmYWNlIFdLTmF2aWdh
dGlvblJlc3BvbnNlIDogTlNPYmplY3QKIAorLyohIEBhYnN0cmFjdCBSZXByZXNlbnRzIHRoZSBm
cmFtZSB0aGF0IGlzIGJlaW5nIG5hdmlnYXRlZC4KKyAqLwogQHByb3BlcnR5IChub25hdG9taWMs
IHJlYWRvbmx5KSBXS0ZyYW1lSW5mbyAqZnJhbWU7CisKKy8qISBAYWJzdHJhY3QgVGhlIE5TVVJM
UmVzcG9uc2Ugb2YgdGhlIGZyYW1lLgorICovCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9u
bHkpIE5TVVJMUmVzcG9uc2UgKnJlc3BvbnNlOworCisvKiEgQGFic3RyYWN0IFdoZXRoZXIgV2Vi
S2l0IGNhbiBzaG93IHRoZSBNSU1FIHR5cGUgbmF0aXZlbHkgb3Igbm90LgorICovCiBAcHJvcGVy
dHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIEJPT0wgY2FuU2hvd01JTUVUeXBlOwogCiBAZW5kCg==
</data>
<flag name="review"
          id="252731"
          type_id="1"
          status="+"
          setter="sam"
    />
          </attachment>
      

    </bug>

</bugzilla>