131136 2014-04-02 16:13:29 -0700 Remove FrameLoadRequest's m_lockHistory member since it's always false 2014-04-02 17:56:38 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrowe mrowe commit-queue japhet oldest_to_newest 996893 0 mrowe 2014-04-02 16:13:29 -0700 FrameLoadRequest initialize m_lockHistory to false. Nothing ever calls setLockHistory to alter the value. The one call site that checks for the value being true can be removed. 996894 1 228438 mrowe 2014-04-02 16:15:42 -0700 Created attachment 228438 Patch 996931 2 228438 kling 2014-04-02 17:15:27 -0700 Comment on attachment 228438 Patch r=me 996944 3 228438 commit-queue 2014-04-02 17:56:36 -0700 Comment on attachment 228438 Patch Clearing flags on attachment: 228438 Committed r166685: <http://trac.webkit.org/changeset/166685> 996945 4 commit-queue 2014-04-02 17:56:38 -0700 All reviewed patches have been landed. Closing bug. 228438 2014-04-02 16:15:42 -0700 2014-04-02 17:56:35 -0700 Patch bug-131136-20140402161522.patch text/plain 4489 mrowe U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWZmNjE1Y2EzM2Q4OTM3 MTU5MDBlNTBmYWUyNDFiYzBmZWNmM2Q4Yi4uMjQ0MDYwMWE2OGNmZDVhZmNmMTI0MTMwZjgxZGUx MWU4OGM4ZjBlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE0LTA0LTAyICBNYXJr IFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9i LzEzMTEzNj4gUmVtb3ZlIEZyYW1lTG9hZFJlcXVlc3QncyBtX2xvY2tIaXN0b3J5IG1lbWJlciBz aW5jZSBpdCdzIGFsd2F5cyBmYWxzZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRSZXF1ZXN0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lTG9hZFJlcXVlc3Q6OkZyYW1lTG9hZFJlcXVlc3QpOgorICAgICAgICAq IGxvYWRlci9GcmFtZUxvYWRSZXF1ZXN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRS ZXF1ZXN0OjpGcmFtZUxvYWRSZXF1ZXN0KToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZFJl cXVlc3Q6OmxvY2tIaXN0b3J5KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9h ZFJlcXVlc3Q6OnNldExvY2tIaXN0b3J5KTogRGVsZXRlZC4KKyAgICAgICAgKiBsb2FkZXIvRnJh bWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmxvYWQpOiBSZW1v dmUgYW4gaWYgd2hvc2UgYm9keSB3YXMgbmV2ZXIgZXhlY3V0ZWQuCisKKzIwMTQtMDQtMDIgIE1h cmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KKwogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn L2IvMTMxMTM1PiBJbnRyb2R1Y2UgTG9ja0hpc3RvcnkgYW5kIExvY2tCYWNrRm9yd2FyZExpc3Qg ZW51bXMgdG8gdXNlIGluIHBsYWNlIG9mIGJvb2xzLgogCiAgICAgICAgIFRoZXNlIGFyZ3VtZW50 cyBhcmUgb2Z0ZW4gcGFzc2VkIHVzaW5nIGxpdGVyYWxzIGF0IHRoZSBjYWxsIHNpdGUsIHdoZXJl IHRoZSB1c2Ugb2YgYm9vbHMgc2V2ZXJlbHkgaGluZGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZFJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZFJlcXVlc3QuY3BwCmluZGV4IDAxNDY3ODgyM2ViZTUzYzQ3M2M3NDQ1NmRlNWFh NDg0NjM4MDIyMTguLjY3MzljZmYzYTdlZWYwYTM3N2ZkZTQ5MTVkNjM1ODZkZGEyMTU2NGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRSZXF1ZXN0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkUmVxdWVzdC5jcHAKQEAgLTM5LDcgKzM5 LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogRnJhbWVMb2FkUmVxdWVzdDo6RnJhbWVMb2FkUmVx dWVzdChGcmFtZSogZnJhbWUsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVzb3VyY2VSZXF1ZXN0 LCBjb25zdCBTdWJzdGl0dXRlRGF0YSYgc3Vic3RpdHV0ZURhdGEpCiAgICAgOiBtX3JlcXVlc3Rl cihmcmFtZS0+ZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKSkKICAgICAsIG1fcmVzb3VyY2VS ZXF1ZXN0KHJlc291cmNlUmVxdWVzdCkKLSAgICAsIG1fbG9ja0hpc3RvcnkoZmFsc2UpCiAgICAg LCBtX3Nob3VsZENoZWNrTmV3V2luZG93UG9saWN5KGZhbHNlKQogICAgICwgbV9zdWJzdGl0dXRl RGF0YShzdWJzdGl0dXRlRGF0YSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkUmVx dWVzdC5oCmluZGV4IDM5OGYzM2YyMjE5MmJiNmNiNTZiMjk2NWJhZTc3YmFmOWY2YTY1MDYuLjFh MmJiZjg0OTNiZjg5ZDhhNzA4ZDhlMTUyMjIyYzFmOGU0YmI4YTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRSZXF1ZXN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL0ZyYW1lTG9hZFJlcXVlc3QuaApAQCAtMzcsNyArMzcsNiBAQCBzdHJ1Y3QgRnJhbWVM b2FkUmVxdWVzdCB7CiBwdWJsaWM6CiAgICAgZXhwbGljaXQgRnJhbWVMb2FkUmVxdWVzdChTZWN1 cml0eU9yaWdpbiogcmVxdWVzdGVyKQogICAgICAgICA6IG1fcmVxdWVzdGVyKHJlcXVlc3RlcikK LSAgICAgICAgLCBtX2xvY2tIaXN0b3J5KGZhbHNlKQogICAgICAgICAsIG1fc2hvdWxkQ2hlY2tO ZXdXaW5kb3dQb2xpY3koZmFsc2UpCiAgICAgewogICAgIH0KQEAgLTQ1LDcgKzQ0LDYgQEAgcHVi bGljOgogICAgIEZyYW1lTG9hZFJlcXVlc3QoU2VjdXJpdHlPcmlnaW4qIHJlcXVlc3RlciwgY29u c3QgUmVzb3VyY2VSZXF1ZXN0JiByZXNvdXJjZVJlcXVlc3QpCiAgICAgICAgIDogbV9yZXF1ZXN0 ZXIocmVxdWVzdGVyKQogICAgICAgICAsIG1fcmVzb3VyY2VSZXF1ZXN0KHJlc291cmNlUmVxdWVz dCkKLSAgICAgICAgLCBtX2xvY2tIaXN0b3J5KGZhbHNlKQogICAgICAgICAsIG1fc2hvdWxkQ2hl Y2tOZXdXaW5kb3dQb2xpY3koZmFsc2UpCiAgICAgewogICAgIH0KQEAgLTU0LDcgKzUyLDYgQEAg cHVibGljOgogICAgICAgICA6IG1fcmVxdWVzdGVyKHJlcXVlc3RlcikKICAgICAgICAgLCBtX3Jl c291cmNlUmVxdWVzdChyZXNvdXJjZVJlcXVlc3QpCiAgICAgICAgICwgbV9mcmFtZU5hbWUoZnJh bWVOYW1lKQotICAgICAgICAsIG1fbG9ja0hpc3RvcnkoZmFsc2UpCiAgICAgICAgICwgbV9zaG91 bGRDaGVja05ld1dpbmRvd1BvbGljeShmYWxzZSkKICAgICB7CiAgICAgfQpAQCAtNzEsOSArNjgs NiBAQCBwdWJsaWM6CiAgICAgY29uc3QgU3RyaW5nJiBmcmFtZU5hbWUoKSBjb25zdCB7IHJldHVy biBtX2ZyYW1lTmFtZTsgfQogICAgIHZvaWQgc2V0RnJhbWVOYW1lKGNvbnN0IFN0cmluZyYgZnJh bWVOYW1lKSB7IG1fZnJhbWVOYW1lID0gZnJhbWVOYW1lOyB9CiAKLSAgICB2b2lkIHNldExvY2tI aXN0b3J5KGJvb2wgbG9ja0hpc3RvcnkpIHsgbV9sb2NrSGlzdG9yeSA9IGxvY2tIaXN0b3J5OyB9 Ci0gICAgYm9vbCBsb2NrSGlzdG9yeSgpIGNvbnN0IHsgcmV0dXJuIG1fbG9ja0hpc3Rvcnk7IH0K LQogICAgIHZvaWQgc2V0U2hvdWxkQ2hlY2tOZXdXaW5kb3dQb2xpY3koYm9vbCBjaGVja1BvbGlj eSkgeyBtX3Nob3VsZENoZWNrTmV3V2luZG93UG9saWN5ID0gY2hlY2tQb2xpY3k7IH0KICAgICBi b29sIHNob3VsZENoZWNrTmV3V2luZG93UG9saWN5KCkgY29uc3QgeyByZXR1cm4gbV9zaG91bGRD aGVja05ld1dpbmRvd1BvbGljeTsgfQogCkBAIC04NSw3ICs3OSw2IEBAIHByaXZhdGU6CiAgICAg UmVmUHRyPFNlY3VyaXR5T3JpZ2luPiBtX3JlcXVlc3RlcjsKICAgICBSZXNvdXJjZVJlcXVlc3Qg bV9yZXNvdXJjZVJlcXVlc3Q7CiAgICAgU3RyaW5nIG1fZnJhbWVOYW1lOwotICAgIGJvb2wgbV9s b2NrSGlzdG9yeTsKICAgICBib29sIG1fc2hvdWxkQ2hlY2tOZXdXaW5kb3dQb2xpY3k7CiAgICAg U3Vic3RpdHV0ZURhdGEgbV9zdWJzdGl0dXRlRGF0YTsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyLmNwcAppbmRleCBhY2VmNzMwYjc0MGY1MDMwZTUxODQxNWViNmI0ZWUwNTI3OWZi MTdkLi4zNmQ2NWE0YmQ2YTQ0ZmQ3MjA2MmM2ZjkxN2VjOWIxMTFhMThiN2YzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKQEAgLTEzNTcsOCArMTM1Nyw2IEBAIHZvaWQgRnJh bWVMb2FkZXI6OmxvYWQoY29uc3QgRnJhbWVMb2FkUmVxdWVzdCYgcGFzc2VkUmVxdWVzdCkKICAg ICAgICAgcmVxdWVzdC5zZXRTdWJzdGl0dXRlRGF0YShkZWZhdWx0U3Vic3RpdHV0ZURhdGFGb3JV UkwocmVxdWVzdC5yZXNvdXJjZVJlcXVlc3QoKS51cmwoKSkpOwogCiAgICAgUmVmUHRyPERvY3Vt ZW50TG9hZGVyPiBsb2FkZXIgPSBtX2NsaWVudC5jcmVhdGVEb2N1bWVudExvYWRlcihyZXF1ZXN0 LnJlc291cmNlUmVxdWVzdCgpLCByZXF1ZXN0LnN1YnN0aXR1dGVEYXRhKCkpOwotICAgIGlmIChy ZXF1ZXN0LmxvY2tIaXN0b3J5KCkgJiYgbV9kb2N1bWVudExvYWRlcikKLSAgICAgICAgbG9hZGVy LT5zZXRDbGllbnRSZWRpcmVjdFNvdXJjZUZvckhpc3RvcnkobV9kb2N1bWVudExvYWRlci0+ZGlk Q3JlYXRlR2xvYmFsSGlzdG9yeUVudHJ5KCkgPyBtX2RvY3VtZW50TG9hZGVyLT51cmxGb3JIaXN0 b3J5KCkuc3RyaW5nKCkgOiBtX2RvY3VtZW50TG9hZGVyLT5jbGllbnRSZWRpcmVjdFNvdXJjZUZv ckhpc3RvcnkoKSk7CiAgICAgbG9hZChsb2FkZXIuZ2V0KCkpOwogfQogCg==